From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E247A052A for ; Tue, 26 Jan 2021 10:03:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 60A901412CF; Tue, 26 Jan 2021 10:03:26 +0100 (CET) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by mails.dpdk.org (Postfix) with ESMTP id 11D4F1412BE; Tue, 26 Jan 2021 10:03:21 +0100 (CET) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 26 Jan 2021 01:03:21 -0800 Received: from HQMAIL107.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Tue, 26 Jan 2021 01:03:21 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 26 Jan 2021 01:03:21 -0800 Received: from HQMAIL101.nvidia.com (172.20.187.10) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 26 Jan 2021 09:03:20 +0000 Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 26 Jan 2021 09:02:29 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 26 Jan 2021 09:02:29 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jBm0JmFSZ6ACtqh1n3Wo8FiR8J1L3yJ0e/vjoNhyQiBAHUkUo26kn1X9eTs500wGaEZqO1Z/M8hPpyxSVFXQZn/OdzvL9qeWK7FDlce83+TzdfbHI9qFoBjeanySUZxPANKFRzwy00+MRbVBJNBGYAqdmV0174QPBtBYN9ZNKR9vpBDxe7xlToDeMIElLZggIIPECw2nTA5YVcVLRSJlczeN9WjmFbgomK60pvmgcRNY/3Yaib8kP6ceFnx314acPJqVHh6pPeA9zhXxPKoHS+Yd1nNE46Ecjf4xzgA5+39RqImgIYn894dNymb45Vp+l0w3kDNN1YVj00gtu6Pc6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ET9LeaxGa3oIouBiPu2qtTaJzcuLtd4w8EsinUFPlME=; b=KYSIuEETwi8RX7t9i7TbBhSWVeXqC/4E83eX2/eUD2Opvqjtk4cAwbRcIjvi8Yy6sRxwmLsnaM8DpvhsoT8oP/ViicNTiWyWeYnOfiHAi0K327AXOVsmJ8QSukh5iCVxJCpz/vy9FaodBMS8rTr5arm/85b4M7kq1RyyHtKqglyYdYOcUx2EpKXuOsUPVXcvzivYIrMtyIKiKLQWNfBcJnmjXs56vRYUmej4xzjAbwSb73Q3w0gGSk4HUqemiznRdHVMB1FbEBV4nzxk4rnYYMa/OivG/M9Fgb7HGEq4np2BVBxMiPevYvWQMYj+n0EcH3o0HyQpDdZkp6otyqaHZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MWHPR12MB1677.namprd12.prod.outlook.com (2603:10b6:301:11::13) by MWHPR12MB1341.namprd12.prod.outlook.com (2603:10b6:300:11::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.13; Tue, 26 Jan 2021 09:02:28 +0000 Received: from MWHPR12MB1677.namprd12.prod.outlook.com ([fe80::75d6:cd9:3d37:3797]) by MWHPR12MB1677.namprd12.prod.outlook.com ([fe80::75d6:cd9:3d37:3797%11]) with mapi id 15.20.3784.017; Tue, 26 Jan 2021 09:02:28 +0000 From: Wisam Monther To: Ferruh Yigit , Wenzhuo Lu , Xiaoyun Li , Bernard Iremonger , Steve Yang CC: "dev@dpdk.org" , "stable@dpdk.org" , "lance.richardson@broadcom.com" , "oulijun@huawei.com" , "lihuisong@huawei.com" Thread-Topic: [PATCH v5] app/testpmd: fix setting maximum packet length Thread-Index: AQHW80YnJYaCqwZtREKK2sZYKpt/jao5nO8g Date: Tue, 26 Jan 2021 09:02:27 +0000 Message-ID: References: <20210125083202.38267-1-stevex.yang@intel.com> <20210125181548.2713326-1-ferruh.yigit@intel.com> In-Reply-To: <20210125181548.2713326-1-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [37.142.171.133] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 434d28da-5fe8-4296-5cb1-08d8c1d91b2b x-ms-traffictypediagnostic: MWHPR12MB1341: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:252; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cfK1ug6ugmJ5uNB8FqKQSoOkwU/KpX23v5PWImX/fhZe7jgV4Hgtkwq7Dp5Bs9KBC5vD7PCD/XwFw3JeS6bT0poH3w+OYRTQbAMWFI9N9gNgxJEJ+YmwdJJy4OXj7z9EvqTufptnzGknC38ncEEqdCLXQNYJB0uux+rOCDVO8URjZRu34c1l9agAEXhbTghloX/xLfrlam/lIBgbIfeleG+qJx25ku2rS4ZGWqyJ4oaay5Ra5fMsyvlQFwmmXoQabP3GeW3it5vR5/HNFchROkyJcsvzqUz5TcdpL/b3P70+xO++m7tpk3jC5Ix35qzy+bu54JMCRm7s8OLYSSDNgzcU7nfcZ6SLuz+w7BaZGtrmRU3HW3IWpd24ZDNR5u0OMZS9/dLucEzxXqpnBi3/dyUa5jTX5NWkQso3NPL+eOJxwno2jTjaAef0Fp2Q9+fGzHwly8lqYqXd803FGKHPwM1/JHkBo5J5JGMmJc2AsPkYCQ69l2S585nKVfMCRRrjFnZHf4fFLJr3TGeWbVx9jXDyWnS3bt9wjIaQtHShieQFVi7SVaicBp47J6HvXFDXdrsG3e09nqfCrE821Lrw8+1rGu20+V/j9/tbnsaFeLk= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR12MB1677.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(396003)(136003)(366004)(346002)(376002)(7416002)(4326008)(110136005)(53546011)(64756008)(52536014)(966005)(2906002)(83380400001)(5660300002)(54906003)(7696005)(71200400001)(6506007)(86362001)(66556008)(66446008)(478600001)(316002)(76116006)(33656002)(186003)(8936002)(66476007)(66946007)(9686003)(8676002)(26005)(55016002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?kZ1pgnbN102vqPeS0yinay1E+MGjeNAepJm9HUgvFaGt40aD1uy67998CqrD?= =?us-ascii?Q?6UhobC+IbiAGEIko1rS/dtCiRb2Z2viZzu470XD6aZLtGNAcsuzcQJPxTAf+?= =?us-ascii?Q?AbMw/RKfnytHNaAJzi4untM7vleHiTG3VIJJYoKUa2slsPC8VCBESvoqg2la?= =?us-ascii?Q?DHCBDrcqliNnLlrf9jfi4pSg5lRE/jbkIlIQRkZhae14yIzxyapNXzDmwKPT?= =?us-ascii?Q?fSZiNMRw0abkdQu2mG24ppoLRr/IdTmmDg0wwrkdHiO/oH+g/knj2Os1jHTo?= =?us-ascii?Q?BadtYMT5dOIiY/5VOWo+6rA5ZitgB1+Ft91K4ZA0Kh19xw64t0jutkFOitcW?= =?us-ascii?Q?LayumVyCcteQe4RCAFiszpZSe1wWPEXqpSNdockkFexZfkjh61LOg6PAtAlN?= =?us-ascii?Q?Phm3a9Uh0HAuQ4DR+C12QlFggV8ACjpGCYceH/UKnKdkh7AO88AExs9QJIJA?= =?us-ascii?Q?qFisFrXaDppqapjrmEHtDfJbTGu+nMCuGRne8cUe4Mj7WzaAL5+/Qj1UAiMc?= =?us-ascii?Q?HKlIYkfwgYbbxmssokFeycD0nE1FGwoJwICN5gN85xOLgDybYHLLdoaU69BH?= =?us-ascii?Q?7D9Tts2ziorNiUX6g+cfUClWxrI20fAbq09TZTZchdPklIINf3WuMIkNuAyu?= =?us-ascii?Q?kuggU1vJXseWWfKE2anRdO5swKFF77aDo9aN8W3TMPs3vxPjXv7zV/1q3YKY?= =?us-ascii?Q?CfSHtQV+W8P7j7kk74pTocx0FCdFyslI7sS8/rnBejtMZ+fH4NliXIpz5o6t?= =?us-ascii?Q?6Ho45yAPE9Oz6PNZeCH4aUZq/6F3liPB7LsM8GP6bvAXypkQHyuWeLamNMK1?= =?us-ascii?Q?F4dyF802wuMPvT/5VeJHWuDYH/QvItftFYF3SdXnEkq84oSTSvtRww5H+Ca/?= =?us-ascii?Q?gW2yDYmUO0ufzgyiXFXWQ7Xm1o7PI/2ohJ6zynNj/lWzmftzKCIhkO0tb9xM?= =?us-ascii?Q?Toc6PdJ+2qWPtOAYBKq+E0ucqlHM7ecLGYzEfgLB3kyiAjr1+UuKH6paL1xO?= =?us-ascii?Q?jF99SHUSij7GMvEAdsvePXdVRdOXkxjWe7FaoCrABRReRqOOCXXzuufPtdtI?= =?us-ascii?Q?oOcR7gLu?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR12MB1677.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 434d28da-5fe8-4296-5cb1-08d8c1d91b2b X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jan 2021 09:02:27.9696 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sJhkCeG+XnXrs7xU3RAzoquuUPnw6XiL79chw3lieHbbWKpGpxxNpW/MEqvCt+az3Bfj/D4zAymhGaParZhBlg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1341 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1611651801; bh=ET9LeaxGa3oIouBiPu2qtTaJzcuLtd4w8EsinUFPlME=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: x-ms-exchange-transport-forked:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=lfZQf4EehGwwnJs/4wbZD4MQqL2CwC18XIDLxrFDIZOwM218KDNOCW9QQiEEmeysr vITBfV+frOeDMv05HVFlkn1VBSdqBojKvvlfqPAFw45z+BgtspZW0wlLoqFXD3xypV VX0U0procbZz3BgJq1CxYt+gJqKJEJxga+vsIsJPbZ3TckzlpHuT0LgP9Uhy5jjF3Z Nj1hXI9NpS9mSzqhCH3MxIPmPoGQMx+S8VsJhzQ2g2vLzp8dsgKRX/5WhRPNtcA1gB kBk5L7tPwPKM7obOsP0JcgFINGf+HlnCpNcDAIzpVHZGzZ2nAgeqjSbPODvs18vGlh WklP4+dMfqFWA== Subject: Re: [dpdk-stable] [PATCH v5] app/testpmd: fix setting maximum packet length X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: Ferruh Yigit > Sent: Monday, January 25, 2021 8:16 PM > To: Wenzhuo Lu ; Xiaoyun Li > ; Bernard Iremonger > ; Steve Yang > Cc: Ferruh Yigit ; dev@dpdk.org; stable@dpdk.org; > lance.richardson@broadcom.com; oulijun@huawei.com; Wisam Monther > ; lihuisong@huawei.com > Subject: [PATCH v5] app/testpmd: fix setting maximum packet length >=20 > From: Steve Yang >=20 > "port config all max-pkt-len" command fails because it doesn't set the > 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag properly. >=20 > Commit in the fixes line moved the 'DEV_RX_OFFLOAD_JUMBO_FRAME' > offload flag update from 'cmd_config_max_pkt_len_parsed()' to > 'init_config()'. > 'init_config()' function is only called during testpmd startup, but the f= lag > status needs to be calculated whenever 'max_rx_pkt_len' changes. >=20 > The issue can be reproduce as [1], where the 'max-pkt-len' reduced and > 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag should be cleared but it > didn't. >=20 > Adding the 'update_jumbo_frame_offload()' helper function to update > 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag and 'max_rx_pkt_len'. This > function is called both by 'init_config()' and > 'cmd_config_max_pkt_len_parsed()'. >=20 > Default 'max-pkt-len' value set to zero, 'update_jumbo_frame_offload()' > updates it to "RTE_ETHER_MTU + PMD specific Ethernet overhead" when it is > zero. > If '--max-pkt-len=3DN' argument provided, it will be used instead. > And with each "port config all max-pkt-len" command, the > 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag, 'max-pkt-len' and MTU is > updated. >=20 > [1] > -------------------------------------------------------------------------= - > dpdk-testpmd -c 0xf -n 4 -- -i --max-pkt-len=3D9000 --tx-offloads=3D0x800= 0 > --rxq=3D4 --txq=3D4 --disable-rss > testpmd> set verbose 3 > testpmd> port stop all > testpmd> port config all max-pkt-len 1518 port start all >=20 > // Got fail error info without this patch Configuring Port 0 (socket 1) E= thdev > port_id=3D0 rx_queue_id=3D0, new added offloads 0x800 must be within per- > queue offload capabilities 0x0 in rte_eth_rx_queue_setup() Fail to config= ure > port 0 rx queues //<-- Fail error info; > -------------------------------------------------------------------------= - >=20 > Fixes: 761c4d66900f ("app/testpmd: fix max Rx packet length for VLAN > packets") > Cc: stable@dpdk.org >=20 > Signed-off-by: Steve Yang > Signed-off-by: Ferruh Yigit > --- >=20 > v5: > * 'update_jumbo_frame_offload()' helper updated > * check zero 'max-pkt-len' value > * Update how queue offload flags updated > * Update MTU if JUMBO_FRAME flag is not set > * Default testpmd 'max-pkt-len' value set to zero >=20 > Cc: lance.richardson@broadcom.com > Cc: oulijun@huawei.com > Cc: wisamm@mellanox.com > Cc: lihuisong@huawei.com > --- It fixed this bug indeed: https://bugs.dpdk.org/show_bug.cgi?id=3D625 Thanks Acked-by: Wisam Jaddo BRs, Wisam Jaddo