From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77382A04B7 for ; Wed, 14 Oct 2020 12:16:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 59F521DE00; Wed, 14 Oct 2020 12:16:34 +0200 (CEST) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id 5D60B1DDDB; Wed, 14 Oct 2020 12:16:30 +0200 (CEST) Received: from HKMAIL101.nvidia.com (Not Verified[10.18.92.77]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Wed, 14 Oct 2020 18:16:28 +0800 Received: from HKMAIL104.nvidia.com (10.18.16.13) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 14 Oct 2020 10:16:23 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 14 Oct 2020 10:16:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iV8IrdkGM3bCqXZRrt10DLHjdygyMIe7MB64K0vsfClLZWhyzVmjjXiZXYVtqFe1H+JKuP6jrW1gXC7PwfuxfXCkYE0p99Xz8dI+v1eO3HHsUwgEi5fvKRwC/EIHyVn5kUOEUpn/XWQ7glvi6cD6oUF/IOosYszLzO1KCcew9zrAat/VKBbqkbM4bps+CLOusRKR4W0WSEIWbrxp82kJ2zHMuKzTbmID7gUBv33BcxgLpXovp10hABj3g1fwblF2tQhrEDPnhlZW8Z9uK+p47dTIR9HuCATDqFT7dFUDp1m9PBPzqA1lyEK3LnelyHgAIUsBCVnh0YJU56BM9vCjeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=44jwv1GZVjLW8uPwKDSml1Uw3YSKqv6jcGpuouKa0vE=; b=fLD6R+4LZ2RpCvBHbaJw8Wj+CDbXi4F3UyaSKAcXUPYNlfpRBbYI3KZtQtofl7odQd4F6nSswqbsl+vXDu9ySZQPtv/TAuoNJi/ySwMTwLmPqRvQQ/pkF8IhmWCs2bcjN2bzVmdzwWw+xRVkDtq/vkYMSn/L8b7FiJJvaSiaFxvUEQ1zjr6r1t79voAKhvDIcnwC45ASlVAMRSWIVj0V+tF8ZWC4WslyciW2N9oUVUhzxycAxuWq9SWImyUfHLEKurGZI9pMRnhpsiIkrWWJ3PCYoiryX4fkjISnzCUdjBgLFBknDhaEHgTo0XccmSAo1treiFnsOxVqyzOa9HbbYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MWHPR12MB1743.namprd12.prod.outlook.com (2603:10b6:300:113::8) by MW2PR12MB2460.namprd12.prod.outlook.com (2603:10b6:907:9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.27; Wed, 14 Oct 2020 10:16:21 +0000 Received: from MWHPR12MB1743.namprd12.prod.outlook.com ([fe80::59df:5b11:7957:cfc]) by MWHPR12MB1743.namprd12.prod.outlook.com ([fe80::59df:5b11:7957:cfc%6]) with mapi id 15.20.3477.020; Wed, 14 Oct 2020 10:16:21 +0000 From: Suanming Mou To: Junyu Jiang , "dev@dpdk.org" CC: Beilei Xing , Wenzhuo Lu , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: fix flow flush with invalid port Thread-Index: AQHWogn5PFvKYHOSJ0aw28nQSsJwq6mW4SDA Date: Wed, 14 Oct 2020 10:16:21 +0000 Message-ID: References: <20201014083005.64428-1-junyux.jiang@intel.com> In-Reply-To: <20201014083005.64428-1-junyux.jiang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [60.176.163.235] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fc232c5a-22b6-4366-6919-08d8702a329d x-ms-traffictypediagnostic: MW2PR12MB2460: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EqsEYaxnTVpf95eLPYzz8HaSEHrg3wCxYIPCD3/3FMibPbZKF6cmjmhvGzLhFU+wFR2arRY8E0+m8QZEn9BX44upRl71IKXovKXhx6GgGqnuxP5xEjK7EdgaZBJR1J9Q4DYWzjSSxnKwHjxToRRlUokCcQmGuMYTWVZOwRbwhfb3FyEMCKQzHjqiWdOP8/YjtmOEwaehplQrkgPHqg1LMntaEZvDbxtRJmVu0M3IcErcitEHbXaNcLs3P+IkIMFxF19VNQpjRezHjIC3/svzpiDW5H15A4WwGyPyfV0r/Qfu+Ca8Y3IQBlEqhssZlJXtV9heVB01r9M45Yn4TaC9sw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR12MB1743.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(376002)(39860400002)(366004)(136003)(66946007)(110136005)(316002)(64756008)(66446008)(76116006)(66476007)(66556008)(5660300002)(33656002)(52536014)(86362001)(83380400001)(2906002)(478600001)(8936002)(186003)(71200400001)(54906003)(26005)(53546011)(55016002)(7696005)(4326008)(6506007)(9686003)(8676002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: kTDwoWCoyj+6EhnAlsMT679+YjHeYtwBDFozUi7qVHJyNH+NeAuIpPw4Q8sUgSjdO9OlXNjYK9oywfhhy2lBgZfLB/sCtXz1mxeCvZTcSDgAbJm7m+h2V5fhho7K+iwA7lSFaEaFNPapMrWBiYNQOigDJOGjIABSk2mwLxvDbuuQSCQvbshfm6X2Jxli5NBawALaLz5rNNfCGlKl8dPlEYK9A3GSFYMnmIewW5TY5s/FnI8ewfoKHsaH8xZRlwLdqs9OZZF7iPKhwzhtFPb31m57eiWnKUyuE/a5PJWv3DrJj0Y90kFCVPs4++zVhortZf7YDWpi7wkqVdW8+mC129hqluH2rWYX60IwEmf6QfiEeCQjcbc2r8s/kvJotk7guRl6bApzz1wEp6O60KVjJn7lya1qRxGjeviu8wyJUN6/jj0kzLNVEHhImVzXfYtUbOFZIBA6wEC4WR8yJbEspqnCmVtFMNw4Lva+RVU9mrxYyluWop7SBhNPpTjoBLkIxY8syEk2EbUtD0S9fgiTcfdqPfi24HQmpAvyc8GyBlWoBE7746jInjaK9AmymKp1NEhvVLWRJ64BOcaJM4s3XKcaG4+ZmnvrBPag3V4HhotanfNuDNFNwKHXWeM9WkBfByzkASBtPGh1WERqqj+LXQ== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR12MB1743.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc232c5a-22b6-4366-6919-08d8702a329d X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2020 10:16:21.1889 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1BPT+L2eJS2WT/FYCyrrRytS+wF0LMabhFWsbz2AXsS39746/mlp2YMC+xQwY82fPJqbld8p8MD/3gc9Sue8RA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR12MB2460 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1602670588; bh=44jwv1GZVjLW8uPwKDSml1Uw3YSKqv6jcGpuouKa0vE=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: x-ms-exchange-transport-forked:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=Z075TqswspBJRERIlQx9Ghd4L5YfSJVc0AR1SPt5olqWjMTgLg8sE3nMbAG2GJP+B 5iiNZPEAoAYffcqMVgz1IddLy1GV6vq1mLJQsh6vXpfECtPlyZObE9jFDdfPZLCIJ/ rCa+HBvD/O2ZRvMammnobXxLeUM+lKSib/KjMPAM21oV1dO8M2gWH9cMigqcKHBpkk bg4nBfZgTHxMdXbFQEmyCXT9YtQ6LTTpOp9KpTsHJCO5cgecY84ZYPi+s1JYLs2Ka8 r3S8fOQErqPxCYHJzrKKBw9EFRAojFsbdZ0QGUaVa6GmyF9GIm84e1w/W26KYtvv+e Fhcg3sw79csWQ== Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] app/testpmd: fix flow flush with invalid port X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: dev On Behalf Of Junyu Jiang > Sent: Wednesday, October 14, 2020 4:30 PM > To: dev@dpdk.org > Cc: Beilei Xing ; Wenzhuo Lu ; > Junyu Jiang ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] app/testpmd: fix flow flush with invalid port >=20 > There is no error info displayed when running flow flush command with inv= alid > port. This patch fixed the issue. >=20 > Fixes: 2a449871a12d ("app/testpmd: align behaviour of multi-port detach") > Cc: stable@dpdk.org >=20 > Signed-off-by: Junyu Jiang > --- > app/test-pmd/config.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) >=20 > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index > fe31a9d52..cc4527386 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -1775,16 +1775,17 @@ port_flow_flush(portid_t port_id) > struct rte_port *port =3D &ports[port_id]; > int ret =3D 0; >=20 > + if (port_id_is_invalid(port_id, ENABLED_WARN) || > + port_id =3D=3D (portid_t)RTE_PORT_ALL) > + return -EINVAL; > + Also better to move the port initialize after this check to make the code c= lean? Reviewed-by: Suanming Mou > if (port->flow_list =3D=3D NULL) > return ret; >=20 > /* Poisoning to make sure PMDs update it in case of error. */ > memset(&error, 0x44, sizeof(error)); > if (rte_flow_flush(port_id, &error)) { > - ret =3D port_flow_complain(&error); > - if (port_id_is_invalid(port_id, DISABLED_WARN) || > - port_id =3D=3D (portid_t)RTE_PORT_ALL) > - return ret; > + port_flow_complain(&error); > } >=20 > while (port->flow_list) { > -- > 2.17.1