[dpdk-stable] 19.11 - dependencies of 22629f05 "crypto/dpaa_sec: affine the thread portal affinity" not fulfilled

[dpdk-stable] 19.11 - dependencies of 22629f05 "crypto/dpaa_sec: affine the thread portal affinity" not fulfilled

[Christian Ehrhardt]

Hi Hemant,
this commit was targeted for the stable releases:

commit 22629f05f8832358d01872414e0e30c2c81e43d4
Author: Hemant Agrawal <hemant.agrawal@nxp.com>
Date:   Mon May 3 14:09:53 2021 +0530

    crypto/dpaa_sec: affine the thread portal affinity

But prior to 20.08 the following change was not present.

commit e58722218aa9ad6b527423f8b95e788e6c5a15b7
Author: Rohit Raj <rohit.raj@nxp.com>
Date:   Tue Jul 7 14:52:27 2020 +0530

    drivers/dpaa: optimize thread local storage

That leads to compile errors and seems not trivial to backport
as changes to local storage could have various dependencies
and implications that I might miss.

If you want the patch applied to 19.11 I'd ask you to have a look
and provide a backport for it that considers all that and is tested.
Otherwise please feel free to just let me know that 19.11 series
will be fine without 22629f05.

-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd

Re: [dpdk-stable] 19.11 - dependencies of 22629f05 "crypto/dpaa_sec: affine the thread portal affinity" not fulfilled

[Hemant Agrawal]

I will be submitting a patch in next 1-2 days.

- Hemant

> -----Original Message-----
> From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> Sent: Tuesday, June 1, 2021 12:43 PM
> To: Hemant Agrawal <hemant.agrawal@nxp.com>
> Cc: dpdk stable <stable@dpdk.org>
> Subject: 19.11 - dependencies of 22629f05 "crypto/dpaa_sec: affine the
> thread portal affinity" not fulfilled
> 
> Hi Hemant,
> this commit was targeted for the stable releases:
> 
> commit 22629f05f8832358d01872414e0e30c2c81e43d4
> Author: Hemant Agrawal <hemant.agrawal@nxp.com>
> Date:   Mon May 3 14:09:53 2021 +0530
> 
>     crypto/dpaa_sec: affine the thread portal affinity
> 
> But prior to 20.08 the following change was not present.
> 
> commit e58722218aa9ad6b527423f8b95e788e6c5a15b7
> Author: Rohit Raj <rohit.raj@nxp.com>
> Date:   Tue Jul 7 14:52:27 2020 +0530
> 
>     drivers/dpaa: optimize thread local storage
> 
> That leads to compile errors and seems not trivial to backport as changes to
> local storage could have various dependencies and implications that I might
> miss.
> 
> If you want the patch applied to 19.11 I'd ask you to have a look and provide
> a backport for it that considers all that and is tested.
> Otherwise please feel free to just let me know that 19.11 series will be fine
> without 22629f05.
> 
> --
> Christian Ehrhardt
> Staff Engineer, Ubuntu Server
> Canonical Ltd

Re: [dpdk-stable] 19.11 - dependencies of 22629f05 "crypto/dpaa_sec: affine the thread portal affinity" not fulfilled

[Christian Ehrhardt]

On Wed, Jun 2, 2021 at 5:04 PM Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
>
> I will be submitting a patch in next 1-2 days.

Thanks in advance!

I was collecting a few more changes for a 19.11.9-rc2 today, but I do
not want to tag a release candidate every day.
So I'm waiting for your changes to show up (or you telling me that it
won't be backported).
It would be great if those could be available *tomorrow morning to be
able to tag rc2 before this week is over.

* = my tomorrow morning so ~23h from the time I sent this email :-)

> - Hemant
>
> > -----Original Message-----
> > From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> > Sent: Tuesday, June 1, 2021 12:43 PM
> > To: Hemant Agrawal <hemant.agrawal@nxp.com>
> > Cc: dpdk stable <stable@dpdk.org>
> > Subject: 19.11 - dependencies of 22629f05 "crypto/dpaa_sec: affine the
> > thread portal affinity" not fulfilled
> >
> > Hi Hemant,
> > this commit was targeted for the stable releases:
> >
> > commit 22629f05f8832358d01872414e0e30c2c81e43d4
> > Author: Hemant Agrawal <hemant.agrawal@nxp.com>
> > Date:   Mon May 3 14:09:53 2021 +0530
> >
> >     crypto/dpaa_sec: affine the thread portal affinity
> >
> > But prior to 20.08 the following change was not present.
> >
> > commit e58722218aa9ad6b527423f8b95e788e6c5a15b7
> > Author: Rohit Raj <rohit.raj@nxp.com>
> > Date:   Tue Jul 7 14:52:27 2020 +0530
> >
> >     drivers/dpaa: optimize thread local storage
> >
> > That leads to compile errors and seems not trivial to backport as changes to
> > local storage could have various dependencies and implications that I might
> > miss.
> >
> > If you want the patch applied to 19.11 I'd ask you to have a look and provide
> > a backport for it that considers all that and is tested.
> > Otherwise please feel free to just let me know that 19.11 series will be fine
> > without 22629f05.
> >
> > --
> > Christian Ehrhardt
> > Staff Engineer, Ubuntu Server
> > Canonical Ltd



-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd

Re: [dpdk-stable] 19.11 - dependencies of 22629f05 "crypto/dpaa_sec: affine the thread portal affinity" not fulfilled

[Hemant Agrawal]

> On Wed, Jun 2, 2021 at 5:04 PM Hemant Agrawal
> <hemant.agrawal@nxp.com> wrote:
> >
> > I will be submitting a patch in next 1-2 days.
> 
> Thanks in advance!
> 
> I was collecting a few more changes for a 19.11.9-rc2 today, but I do not
> want to tag a release candidate every day.
> So I'm waiting for your changes to show up (or you telling me that it won't be
> backported).
> It would be great if those could be available *tomorrow morning to be able
> to tag rc2 before this week is over.

[Hemant]  done.

> 
> * = my tomorrow morning so ~23h from the time I sent this email :-)
> 
> > - Hemant
> >
> > > -----Original Message-----
> > > From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> > > Sent: Tuesday, June 1, 2021 12:43 PM
> > > To: Hemant Agrawal <hemant.agrawal@nxp.com>
> > > Cc: dpdk stable <stable@dpdk.org>
> > > Subject: 19.11 - dependencies of 22629f05 "crypto/dpaa_sec: affine
> > > the thread portal affinity" not fulfilled
> > >
> > > Hi Hemant,
> > > this commit was targeted for the stable releases:
> > >
> > > commit 22629f05f8832358d01872414e0e30c2c81e43d4
> > > Author: Hemant Agrawal <hemant.agrawal@nxp.com>
> > > Date:   Mon May 3 14:09:53 2021 +0530
> > >
> > >     crypto/dpaa_sec: affine the thread portal affinity
> > >
> > > But prior to 20.08 the following change was not present.
> > >
> > > commit e58722218aa9ad6b527423f8b95e788e6c5a15b7
> > > Author: Rohit Raj <rohit.raj@nxp.com>
> > > Date:   Tue Jul 7 14:52:27 2020 +0530
> > >
> > >     drivers/dpaa: optimize thread local storage
> > >
> > > That leads to compile errors and seems not trivial to backport as
> > > changes to local storage could have various dependencies and
> > > implications that I might miss.
> > >
> > > If you want the patch applied to 19.11 I'd ask you to have a look
> > > and provide a backport for it that considers all that and is tested.
> > > Otherwise please feel free to just let me know that 19.11 series
> > > will be fine without 22629f05.
> > >
> > > --
> > > Christian Ehrhardt
> > > Staff Engineer, Ubuntu Server
> > > Canonical Ltd
> 
> 
> 
> --
> Christian Ehrhardt
> Staff Engineer, Ubuntu Server
> Canonical Ltd

Re: [dpdk-stable] 19.11 - dependencies of 22629f05 "crypto/dpaa_sec: affine the thread portal affinity" not fulfilled

[Christian Ehrhardt]

On Thu, Jun 3, 2021 at 2:20 PM Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
>
> > On Wed, Jun 2, 2021 at 5:04 PM Hemant Agrawal
> > <hemant.agrawal@nxp.com> wrote:
> > >
> > > I will be submitting a patch in next 1-2 days.
> >
> > Thanks in advance!
> >
> > I was collecting a few more changes for a 19.11.9-rc2 today, but I do not
> > want to tag a release candidate every day.
> > So I'm waiting for your changes to show up (or you telling me that it won't be
> > backported).
> > It would be great if those could be available *tomorrow morning to be able
> > to tag rc2 before this week is over.
>
> [Hemant]  done.

Found it, applied it - entering test builds now.
Thank you so much Hemant!

> >
> > * = my tomorrow morning so ~23h from the time I sent this email :-)
> >
> > > - Hemant
> > >
> > > > -----Original Message-----
> > > > From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> > > > Sent: Tuesday, June 1, 2021 12:43 PM
> > > > To: Hemant Agrawal <hemant.agrawal@nxp.com>
> > > > Cc: dpdk stable <stable@dpdk.org>
> > > > Subject: 19.11 - dependencies of 22629f05 "crypto/dpaa_sec: affine
> > > > the thread portal affinity" not fulfilled
> > > >
> > > > Hi Hemant,
> > > > this commit was targeted for the stable releases:
> > > >
> > > > commit 22629f05f8832358d01872414e0e30c2c81e43d4
> > > > Author: Hemant Agrawal <hemant.agrawal@nxp.com>
> > > > Date:   Mon May 3 14:09:53 2021 +0530
> > > >
> > > >     crypto/dpaa_sec: affine the thread portal affinity
> > > >
> > > > But prior to 20.08 the following change was not present.
> > > >
> > > > commit e58722218aa9ad6b527423f8b95e788e6c5a15b7
> > > > Author: Rohit Raj <rohit.raj@nxp.com>
> > > > Date:   Tue Jul 7 14:52:27 2020 +0530
> > > >
> > > >     drivers/dpaa: optimize thread local storage
> > > >
> > > > That leads to compile errors and seems not trivial to backport as
> > > > changes to local storage could have various dependencies and
> > > > implications that I might miss.
> > > >
> > > > If you want the patch applied to 19.11 I'd ask you to have a look
> > > > and provide a backport for it that considers all that and is tested.
> > > > Otherwise please feel free to just let me know that 19.11 series
> > > > will be fine without 22629f05.
> > > >
> > > > --
> > > > Christian Ehrhardt
> > > > Staff Engineer, Ubuntu Server
> > > > Canonical Ltd
> >
> >
> >
> > --
> > Christian Ehrhardt
> > Staff Engineer, Ubuntu Server
> > Canonical Ltd



-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd