From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E66B7A056A for ; Tue, 9 Mar 2021 11:27:38 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D1B3C22A4D8; Tue, 9 Mar 2021 11:27:38 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 40AFC22A443; Tue, 9 Mar 2021 11:27:36 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 129AKS9o019208; Tue, 9 Mar 2021 02:27:30 -0800 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2177.outbound.protection.outlook.com [104.47.55.177]) by mx0b-0016f401.pphosted.com with ESMTP id 374drqy221-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Mar 2021 02:27:30 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KttgAEVZnE9QASb2RrnQyPN2730LYEFM/0UR2BXsYEJTTrPMr6mGMi2pAMs1uOMSiNy7EneB1PJ7iu6J6B/gPEeIks1qw+wAxx92iiC3ilztnwSxY9YxycVC7fEOmmtzE7/dXywCFaLsl7vV8e4aPFLvOfF2XEPIphaeDi3MEa6PsnTqFI1t+bRl0uOofvGPpcZpYYSjFcdF1BLhtdejdfxqUqAz8IJuFyUS5y+9icIAsJzSOSvYshu5KVeIax2jscPYo6LHbYLzFS8vxp75if1rgsYrJ11VU5q8A1gfvVcHYY/2gvId7USx2h0Hm0hUEWVP6vUHgIP4TuMl2/Q0qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n95wn2Xhz7AgAuJSGVIuGrPS0O5kq/wPKg6Zf3wOk6w=; b=AECOzSWzlLLDaPmz/gfSne6FUJTFZc8s79j1hGFFOBjEFibpqYZ/wKaAS63vqgX2VmMXpay93BCLmTb0IQq4C5EZdtUKoTRP8ImY6ZzefTNF9VKcK3P8dvobOX2dVA7KNlgtpD3pODbpEbNJtxhFsuDmHiGvUnCyH7wraQ4lW7N/Wd1WY24RJPDiE9IiMoVhnUSYPL4+zYM8FhdOC7amD5C/tx4a9ML4q8bTjReGPfElvrTrGQW/isJ62511Yd/VNyNQxBC3vcXmaCU4lBUG0aUKvLRYXqRA+3ziU1cQeHOqDMbJkNq8QAwyO6vOWFyjszmXAph2A+oGKU+ZmTJNVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n95wn2Xhz7AgAuJSGVIuGrPS0O5kq/wPKg6Zf3wOk6w=; b=ByOpW8WytsiNCrvoPjJU6k74D+rLN6uuXpMZ/gfxyQHHrz9VlcTn8tgTH+DHb4jOW0iDtkZMWkiIqIDz693GQS8+klxUsXE5B39ZwOUCOe2G0ONzyoiCYu10FShkfU2H2Fur5zTyK9wJ0WPXJuJd/g1ynK8Tn3Cj+1f8WDdwfmM= Received: from PH0PR18MB4086.namprd18.prod.outlook.com (2603:10b6:510:3::9) by PH0PR18MB3877.namprd18.prod.outlook.com (2603:10b6:510:25::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Tue, 9 Mar 2021 10:27:29 +0000 Received: from PH0PR18MB4086.namprd18.prod.outlook.com ([fe80::51dd:b5d6:af81:172d]) by PH0PR18MB4086.namprd18.prod.outlook.com ([fe80::51dd:b5d6:af81:172d%4]) with mapi id 15.20.3912.029; Tue, 9 Mar 2021 10:27:29 +0000 From: Pavan Nikhilesh Bhagavatula To: Feifei Wang , Jerin Jacob Kollanukkaran , Sunil Kumar Kori , David Marchand CC: "dev@dpdk.org" , "nd@arm.com" , "stable@dpdk.org" , Honnappa Nagarahalli , Honnappa Nagarahalli , Ruifeng Wang Thread-Topic: [EXT] [dpdk-dev] [PATCH v2 1/1] app/test: collect perf data after worker threads exit Thread-Index: AQHXC1knkNq1IzCO4UiVccVz5BJ1uap7hsJw Date: Tue, 9 Mar 2021 10:27:29 +0000 Message-ID: References: <20210225093213.2811627-1-feifei.wang2@arm.com> <20210225093213.2811627-2-feifei.wang2@arm.com> In-Reply-To: <20210225093213.2811627-2-feifei.wang2@arm.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [2405:201:d009:304d:884d:7160:99e9:7ca0] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ef4ca608-c89a-4ca0-36bd-08d8e2e5f103 x-ms-traffictypediagnostic: PH0PR18MB3877: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Ivof/rna/ThHOVjWAA3H/CaIoscvlZ81DjJzEp9KSbHmX1wUuCUZNGcJQ/W4it1vZ+joGUGu1aQusXw93DOd6DHKe8xDHaCPKkOvDqOpa3uD/w0Domx2dnb4Ohae1yXkcLSJtFZPff78kKahkhW7uPAuDH2rp5ODeJuT/vGA7wayk0ed0q++emizd7tHneuUFfwRzPqjUQrV3cnQEE5Amyqg0vLr+WNIbVKFkelfq3lv5EjzSmgpSfe8i0W1Q8lMQCjCaD+JCZGjwBpSzo61N9QHgMpFXIAd812xGcYY9jvHne5Q3JPxDl2jpxG7/Na6kKifi9XK9tYru1vt/1JdwdTej2NVTuBwzcg6eVZ8ST0/1y3lrj4vTw0vIHau93GO3sTwg6oY4eueUrBe5V5M1JzFaQDQCWVmIXRNJlKVsf/lev1QHHdP6WuHDWEX5nU2ACjQI2IOd8Xwkx2Mq4XgdZzyBZ5eMaPnKraeQ9Dp1AUs5yrIaGu+HaO5vmwBRhLqQOoovCBb3ulEPHVh/onjkw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4086.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(376002)(366004)(396003)(136003)(346002)(52536014)(71200400001)(8676002)(2906002)(9686003)(55016002)(186003)(6506007)(66946007)(7696005)(66446008)(86362001)(83380400001)(64756008)(76116006)(33656002)(8936002)(5660300002)(316002)(478600001)(4326008)(110136005)(54906003)(66556008)(66476007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?VPkVK7zEMLAgboX9BC4N5MOD+/NwBTDHnWA07w6sJ+8s5IWc0T+t6uE0sTjP?= =?us-ascii?Q?OS6PvUt0yfoAjGiGlqNXHbgPA/iC1xN8FGSMxSc9DjK/QteD5XdZ2TiKl4qM?= =?us-ascii?Q?HH1r107emvkzltQWi7Qpf/7AveQPG2XewHijQfOV+UIMJMjPE/szbZjrrrGx?= =?us-ascii?Q?xy8XR6X4wPcEnZCk7TcYx5fBdLigi/b6YCmugoJhTupYZov9lJbGNrO0ecX5?= =?us-ascii?Q?QntFxAl1c3ZkeA1j9ujluwl1kez0iQ26jzwGwELZ2/bJXtQPbOzsh16r5A/Q?= =?us-ascii?Q?mauYPLRItfHsLUjBh2C/sAFw8RO620jY1DTu56/jsPy/wbEgWNla28GYAqKd?= =?us-ascii?Q?m1m772EMj8SL+OcPBXeiVCDprDX25G7PDGFK9WbnJVWedktdfXDNUMa1jWsc?= =?us-ascii?Q?ywfnMwHmcDxd+sNQ86H3NiUaDzrp2IsjT+vQLOQ1KwXWqJO9A/EAwNXULfRl?= =?us-ascii?Q?Jm5YdxNKigALIyyaNwnJLoV4KCitaXt9HEkMpN38011wwBBjKV2aTrezE7ZB?= =?us-ascii?Q?LHbAkJ6kYceNcPkRCygItumvr6o+7PhG7U3oV1bo6l6VxnZvZ34lGyFKVt7c?= =?us-ascii?Q?V38w9Rx0nrhpA+/se7GVnKoBfZjtQ4YgZkavNONyfi46TFnvc+3sFYVKjRgY?= =?us-ascii?Q?/feesyoHgZHUxYCzYyZdDG19I8Dt4ArFSwqhfBJrtXtybOTQfF/EiespF+n3?= =?us-ascii?Q?WlcpsO/ePqO6eawFh7+PuIrHb+Mqd6eHhAQEoysfPvSDQ9YjlIqE9JVolKDF?= =?us-ascii?Q?+Plqyc/3ffV2q712jBhS9OasITZ+Tptny+HN85GUwKZu/vEruKQA7ZphHkXH?= =?us-ascii?Q?FXHsa+jJF03mw5sY4hRbhgTs/KQeb35p1NCoUoq8f5ruioEd5kPLgNrwpE/u?= =?us-ascii?Q?Ix2LhlzsK6XjLlZBup5Up//OWbC2wccZRv4b+nFClP7pSnceGyzwr/UNrzv+?= =?us-ascii?Q?ZlsfQmxuZUjxHdLT3sXaCRaUHusakbIFGNxt/Xfw1JihqAmemW775CC+KyR9?= =?us-ascii?Q?++8NGf+y9DUtxvL0fVxMNweg497Cv+abmHxge2UCkp9L8DN7XWhlP6UukfBS?= =?us-ascii?Q?u39+zVvB8BDUxesrIBGOV3OHMWyHmFSpGIu830nQxVPqX/GLu4n5j6yPcdum?= =?us-ascii?Q?eCEEIDyaW0H+mrXV8vjEtbD4WMOw6UWiqK3DxO2lewyYNoCpwHwNW0Egd7At?= =?us-ascii?Q?6ZwiWNAkvD+3i6z+qTATdl86kF7iRMx4wnulFk3A99Y38mTmgsPIUeeFaHAx?= =?us-ascii?Q?FbArkECRpcdBPm9ovSaa5iV6qiOoQ2dwAIu1EInuY6LzCh1eJBVsLuQMI5aJ?= =?us-ascii?Q?VsSolg39AztydShjmeVouHRyfWSyaqsHFDNt4HjosOPLQNOm7q0wJJqhKlLn?= =?us-ascii?Q?/ss4b9aMSTI3HFZxMZ3Z1iN/J1hL?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4086.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef4ca608-c89a-4ca0-36bd-08d8e2e5f103 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Mar 2021 10:27:29.0897 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VHhDx7VEJ80fFmcpHOScZItB3Pr6FpVL0tixpNQOYZoftifOtgy2RrAgCy2JqK2EUuC3KZwYC2j3QkfRVPZC2GdREldjs8p/xpRIWJMkG5A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB3877 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-03-09_09:2021-03-08, 2021-03-09 signatures=0 Subject: Re: [dpdk-stable] [EXT] [dpdk-dev] [PATCH v2 1/1] app/test: collect perf data after worker threads exit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" >The measure_perf function should be executed after worker threads >exit >to collect correct perf data. Otherwise, while workers are running, the >main thread may get incomplete data from workers. > >In the meanwhile, remove unnecessary barrier in the test. >For signal variables "ldata.done" and "ldata.start", no operations >should keep the order that being executed after them. So the wmb after >them can be moved. > >Fixes: 16a277a24c9f ("test/trace: add performance test cases") >Cc: jerinj@marvell.com >Cc: stable@dpdk.org > >Suggested-by: Honnappa Nagarahalli > >Signed-off-by: Feifei Wang >Reviewed-by: Honnappa Nagarahalli > >Reviewed-by: Ruifeng Wang Acked-by: Pavan Nikhilesh >--- > app/test/test_trace_perf.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > >diff --git a/app/test/test_trace_perf.c b/app/test/test_trace_perf.c >index e1ad8e6f5..46ae7d807 100644 >--- a/app/test/test_trace_perf.c >+++ b/app/test/test_trace_perf.c >@@ -79,7 +79,6 @@ signal_workers_to_finish(struct test_data *data) > > for (workers =3D 0; workers < data->nb_workers; workers++) { > data->ldata[workers].done =3D 1; >- rte_smp_wmb(); > } > } > >@@ -102,7 +101,6 @@ worker_fn_##func(void *arg) \ > { \ > struct lcore_data *ldata =3D arg; \ > ldata->started =3D 1; \ >- rte_smp_wmb(); \ > __worker_##func(ldata); \ > return 0; \ > } >@@ -137,11 +135,12 @@ run_test(const char *str, lcore_function_t f, >struct test_data *data, size_t sz) > > wait_till_workers_are_ready(data); > rte_delay_ms(100); /* Wait for some time to accumulate the >stats */ >- measure_perf(str, data); > signal_workers_to_finish(data); > > RTE_LCORE_FOREACH_WORKER(id) > rte_eal_wait_lcore(id); >+ >+ measure_perf(str, data); > } > > static int >-- >2.25.1