From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EAA86A00BE for ; Tue, 17 May 2022 04:56:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1DB5342684; Tue, 17 May 2022 04:56:27 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id DD4644068B for ; Tue, 17 May 2022 04:56:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652756184; x=1684292184; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=8tbrmX9V4NsibGqStb2O73A38sVvo3RM067hQwO0Yz0=; b=cdrIm9CLKj6dr8Rj8GpvCp7aHC6+F7GLN+kQrJKT/agNGIZQxr8h0hZg vTYYrnZakxbyjWHztjB1nGTySipupOsq6C2mR2lPVrEOgqjGjJmLHlTdi PZdP/g8IRdoMmnmNawYeTddxe4yhXJMzWx4tNFAZXzOvHeepbQaaDjGfy fw8eOW1rzoLF7uGTYjuGcjx7ZziO38NvVq5xfY/WYAz5fbh9exbCOkIGM MwIaK/brqLCpWcCggDyaLxAJ1AfwcRTgzVK7m39kxGsgqc+MRNlKTL8VL TE0TKic2pdmDbptvryI3lvwFSDEBYEgeEIfLaOhKY8uFoI2q+/VqKz54X w==; X-IronPort-AV: E=McAfee;i="6400,9594,10349"; a="357444213" X-IronPort-AV: E=Sophos;i="5.91,231,1647327600"; d="scan'208";a="357444213" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2022 19:56:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,231,1647327600"; d="scan'208";a="672637362" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga002.fm.intel.com with ESMTP; 16 May 2022 19:56:21 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 16 May 2022 19:56:21 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 16 May 2022 19:56:21 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 16 May 2022 19:56:20 -0700 Received: from PH7PR11MB6006.namprd11.prod.outlook.com (2603:10b6:510:1e1::13) by CY4PR11MB0007.namprd11.prod.outlook.com (2603:10b6:910:79::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.16; Tue, 17 May 2022 02:56:17 +0000 Received: from PH7PR11MB6006.namprd11.prod.outlook.com ([fe80::a414:94ac:532:112e]) by PH7PR11MB6006.namprd11.prod.outlook.com ([fe80::a414:94ac:532:112e%7]) with mapi id 15.20.5250.018; Tue, 17 May 2022 02:56:17 +0000 From: "Ling, WeiX" To: "Ma, WenwuX" , "Li, Xiaoyun" , "Singh, Aman Deep" , "Zhang, Yuying" , "dev@dpdk.org" CC: "Hu, Jiayu" , "Wang, Yinan" , "He, Xingguang" , "Ma, WenwuX" , "stable@dpdk.org" Subject: RE: [PATCH v3] app/testpmd: perform SW IP checksum for GRO/GSO packets Thread-Topic: [PATCH v3] app/testpmd: perform SW IP checksum for GRO/GSO packets Thread-Index: AQHYZZ0xF5VEcwKbgkWDJ3CPzwVXp60iZ/Zg Date: Tue, 17 May 2022 02:56:17 +0000 Message-ID: References: <20220511013705.24602-1-wenwux.ma@intel.com> <20220512010756.29553-1-wenwux.ma@intel.com> In-Reply-To: <20220512010756.29553-1-wenwux.ma@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2b72ef4e-0517-4cb9-9506-08da37b0d020 x-ms-traffictypediagnostic: CY4PR11MB0007:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ueEEUA6VzbpfTGddN2r2lsPySFGUJ0UPViJTZLS1g8gY39MMb5hlTvLSYpqGq2qv1KQ0QvZP9xNMjqZTftOB2nXWakxRTRlghdYfZNq9BTIe9RKOmDnBig3IQezBWxzDsz6wJ6VnSkCmHyCmfs6RPV03l7v8upfCqmgNfKSDfA8RyOdz0QZggHpeqx8KTgl3DzSqzOix2hhP5wBuYc/reGvhUiDTOe6PvLI4mmhNd+RG8VkHJG8YOyAgN7wuGysF0nRCtfzRdQQi6Oa0hWnXmR8F7NO+IiMW3Sx8tOgAv4hRbI7e766hrPZPTFxMTfMzNSHr+r7V2QCHGCVntmtue7zO86tf2YkLOaq37SryPJ8Sl4xq+N+orI3sHurZi8cikwwXR0kH28LxCejIZJZiykS8Nnqj9CtcOrIVs38T60hIixSawO6JZvZWGyKi43rk00EiJxjyGDT96TZ9VzPVaxf3mqdI8DYeQSqnY+e6J6knu/4eI0NpCh+AtTZguAsCAESG0jFkIo3GHBDVmMYwVKJbU7X4sPhVceh1f22AdJ5Qb55UP2U9Zp++06VIkXk7aLwjE+8imIe7FWLefM2K7Ch2F742a3r1i8DO9ZO8l0wPSt25kVjZIUpKjhGpqHkH5VOVZWHfPfnoMgfdksxW6oi3XwHTBbEDB4oEgzNL1PcNIJINa9B3gSPhjCd4fAO35i94KxRddwBRtC/t4ZJzFQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR11MB6006.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(76116006)(450100002)(8676002)(66476007)(6506007)(4326008)(66946007)(53546011)(71200400001)(2906002)(64756008)(66446008)(66556008)(4744005)(7696005)(55016003)(38100700002)(38070700005)(33656002)(5660300002)(122000001)(508600001)(82960400001)(83380400001)(186003)(110136005)(54906003)(86362001)(316002)(26005)(9686003)(52536014)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?o8BF/6NHZJ9aR1qMoEwoic7734OHbhx8T/grPtonc740Mwf/m7mXA+qfRKH6?= =?us-ascii?Q?9tnWNBy0FNdC+hGGMIKNbbPU/FY+76imULPQiIPLwjH+jQc+GyPWf5XVXia1?= =?us-ascii?Q?SlQJmTYHe4MoYrO0hTwbgivIEj71aafQa+HcrnauTmzPB0PAcw3XmK3yHkA5?= =?us-ascii?Q?snlfMWX9bxxPy2nIBKyg4KDtACe9oeahlo8tsYxEcHDE6AP5PYKTO89poBcg?= =?us-ascii?Q?lx8tZfA3ztloW4X+kzAZ+/HDXpC54xBxuFVQpCJYkynVF4mFbu82YpimI3ba?= =?us-ascii?Q?9M0rM8Lhd9Xc2LEinnDbZHJs1Vi8WeUB1stfvBjJbuu6qypseG6J7GA2WyCl?= =?us-ascii?Q?KMd8r/ka18uGuehcE7HnoJQeUrJg7RN1rFZRSlpBDJQKq3+mXzNoisCcvTkG?= =?us-ascii?Q?aTg5Vb0c9f55SSYKEFeymt0dbmh5vO90hSMPyuqwuwKkwYvpBQE61/NZhl9n?= =?us-ascii?Q?rgSYS/wWJ8JkgKAdNWUq/P4utyagAXz7V7w8Ijp6X/3wz14HGuy69+wsUYZS?= =?us-ascii?Q?62hJTmPxiZ8H+aUxSgUKlEBIVvLRExd55SgygIG+/pnRyIRnslW6PUH/Dzi3?= =?us-ascii?Q?1jx9kAZWfZwUkV9CIvAjaTBGNw9Y3J/rljH2errjQNWYmkyZBF0qHhwk5rv6?= =?us-ascii?Q?vaDFFLhpxcr4g3u89mKOKxy28mBGGN27Efo7dBCtO/HYuzbyn0s4ar3l28Qz?= =?us-ascii?Q?d1+WkKCyWk8sJqMhNyinJLiDW8v1PK7fkP26zY6Pmi3iXtONFxvOzwkjD84+?= =?us-ascii?Q?CuQGIFGWIbYtQ6GXZl8Bp6UKKhMlhfOAAraqZD6CsrvMzurOZNuuM2gk5Q8+?= =?us-ascii?Q?8cZQO1fF+Dp/ngOJsr5XdRSgRxc/OgEKLjqvApSXEt8gPKoyPMTfYRmIurOZ?= =?us-ascii?Q?OyTSeGZaJc3mgmGr6rIbBrL1nZAYpzA0vSfULkuj+pwMx1cARKL18kJ8eYu3?= =?us-ascii?Q?sE66Hj6UcTc+MwBwmDL/d+M5pk+7Q2YKIU50jp26+yJQ8WcClGUYjBxTZVlX?= =?us-ascii?Q?8xk5/HvjstxrusfF4QJF2EYN9TyImsJl/ODOpH99AGYrlJ2zL5xTi3FHVXcG?= =?us-ascii?Q?elJ0hqfunwMG7Ip/7hKOA3C38Xwdt81m2DMP3/9kCBXA4mfkELZ9zciAkdN+?= =?us-ascii?Q?2/MPoULtG8itxwlg6Xy+i2U5oqG5E4VespUzaTgBfpqerb5TSzXp1wxl70Mw?= =?us-ascii?Q?Hw3RE0LuCbzlDBtGv7WLJY0JWI/u6v6+1U3mYX3ApCVgf+ydhIYsxkgew5u8?= =?us-ascii?Q?/ZN40hycJXhUbXd7lX4nD3b+Nvve1LF3eFUA8uoqxEQZl97OS7kKtAC0fB/l?= =?us-ascii?Q?d2FTwx/gT/1y0xorXrsxIhyChjILawVtOrqyJF4j3uj8WTQebDcnuFHUflBQ?= =?us-ascii?Q?8vC5alsHj6qN8koyvwC3G9QZC5HjhhrVnabI9iRAIZABUo0y2NVAkdCGbyzb?= =?us-ascii?Q?62qGgtMjt+3Z+sRwq7EUmEdzQRwm/1UE2KWY8lZeE48u69mBA73v6TF0+/Pi?= =?us-ascii?Q?BktqyDrQLsIr7xdko55+slCXk6SSWZIdiHuevTKzRXspHgAMHm3kyQJlbDsc?= =?us-ascii?Q?6I+4pomOO/gZ0moV5gOQsMZCx5ptx6QKaytzAfD+5EDX7kFfefxzJClAKPX4?= =?us-ascii?Q?Zr06mIWEIqz99gvaHipGYrfy1Qs4bsrSzbzMyVHgj8VaI2cgdzTxcDZqWKF9?= =?us-ascii?Q?2viZw+3DKLsJ+gTrL2fvOcuzrnYaZTcYLwC/gC0Xq+GUWbyPOUGAKhVIhMlm?= =?us-ascii?Q?sS8RDqeqkw=3D=3D?= arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QAE1qPvZdQVRFcYsrgdU6BM+Vm1UJBzIta7jAKgRMgz3oOB1debETBQMKOvqQrVEUA83JxikBF3RAf5MCXD9D0hazG0CrJRN7NgC0thOJ0VtCy9qNceNkidFw89Qj9ixhThJu4VH+ttBCNkGZR320oBAMMzUj2pgTUxMvRL2P3J2//abRN8PXJLMo4POgTLhPiBzPhNF1ALnHQgt0HsNXFCaDIZb5gsQ1cOJ12ljLiiLGFsyjlPFBQex6jRflKmG5qoae3Eel22FsJXjtsrBL3djL8sQ5kipO9o4GVCL6cWyeJvpxkhoB7rdm3z/70JknnLM+3yf/yqlKGvV+BFdlA== arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Mo6OiybZMDqhAzB7AO1rs3fXzKWw/owHUSY049Cn9rQ=; b=L8fdCilcfQ6EFzDIxkPrqGAxg+yp/xBQRIPymwcIdcfofPC95CUAX+FVxHza/FqQP6EFoVAp51UTiHaMp2IuCjVkLBLrtyRbTHHcCBNg5MzSaM5mzKViljjXMnTJSnnRDq+vUUQZFrzcOXmglt9cRvww+0MKZfXDl0wlxzHbNy6GBkIOtcJiB40JFTRuhb7kODODzKuB8A1zCdJUs/Pn4qEmMMGhKffSoavs3g8vgYbLCgpfFD6IoSjiWDyNahNAYZ5x1M9PAaS5udZ9e/jOY/uRcIN3A1NZPM78gmugQFUZJiYsgMzlXdGeeMmHtf2Ay5aCnLt+TrnmZGJ79UMOlQ== arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none x-ms-exchange-crosstenant-authas: Internal x-ms-exchange-crosstenant-authsource: PH7PR11MB6006.namprd11.prod.outlook.com x-ms-exchange-crosstenant-network-message-id: 2b72ef4e-0517-4cb9-9506-08da37b0d020 x-ms-exchange-crosstenant-originalarrivaltime: 17 May 2022 02:56:17.1445 (UTC) x-ms-exchange-crosstenant-fromentityheader: Hosted x-ms-exchange-crosstenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d x-ms-exchange-crosstenant-mailboxtype: HOSTED x-ms-exchange-crosstenant-userprincipalname: H/YJ62uMGjLRZs1PhoG6wBlx8GbTrjm8I1e3xzdX7lQhT8w9NiaDAOkJa2bv1lH62uoS76SkmSU30ib2pL+1ng== x-ms-exchange-transport-crosstenantheadersstamped: CY4PR11MB0007 x-originatororg: intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Wenwu Ma > Sent: Thursday, May 12, 2022 9:08 AM > To: Li, Xiaoyun ; Singh, Aman Deep > ; Zhang, Yuying ; > dev@dpdk.org > Cc: Hu, Jiayu ; Wang, Yinan ; > He, Xingguang ; Ma, WenwuX > ; stable@dpdk.org > Subject: [PATCH v3] app/testpmd: perform SW IP checksum for GRO/GSO > packets > > The GRO/GSO library doesn't re-calculate checksums for > merged/fragmented packets. If users want the packets to have correct IP > checksums, they should select HW IP checksum calculation for the port whi= ch > the packets are transmitted to. But if the port doesn't support HW IP > checksum, users may perform a SW IP checksum. This patch add the code > about it. > > Fixes: b7091f1dcfbc ("app/testpmd: enable the heavyweight mode TCP/IPv4 > GRO") > Fixes: 52f38a2055ed ("app/testpmd: enable TCP/IPv4 VxLAN and GRE GSO") > Cc: stable@dpdk.org > > Signed-off-by: Wenwu Ma > --- Tested-by: Wei Ling