From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5ED94A04DD for ; Tue, 26 Nov 2019 17:20:24 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8B0021BE0C; Tue, 26 Nov 2019 17:20:23 +0100 (CET) Received: from APC01-PU1-obe.outbound.protection.outlook.com (mail-eopbgr1320113.outbound.protection.outlook.com [40.107.132.113]) by dpdk.org (Postfix) with ESMTP id B311691; Tue, 26 Nov 2019 04:32:33 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gYlD8rpnMvj1nzXFf3V6kAkx6jSundwLuAKHl8xfe1N4eCxUcpAPx6VyUPAY3JIeA8yT7WoeaijkSRGE2Uif8a6jh+VHm70cUbvVMH2eJF5xlUbsIBWZod0KqEassYeY1nNm+U8qD6bMc+WrnhEjZMLzkKLlZbTlJJ9nZBQJQFEuQibPPWUl9zH+JnsB/2UqUpWTVca2xu2SHhGxamBbKq0AI96St/y9KXX2VnXNWcNcILIJ+ATznUYeiq0+zshqtA0Px2sUskbuEh8bBPfKGXC68MMzIMj5yZb3A4671BdVxeM359tiY7zidZIKapsM/mq2dnbgXtdeLy7kJAL+VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aH6VnQkb6H6uBqn0OITl9TPYs1zyEY39dqmqHe/fsdg=; b=S9dZO4Zqw7/yORTGewPdKLZbjjLTe4cPsY+YqzqC8r7fR4NRrU12QuahD1Y0We8LylPsAecyek9cyez1iIm0ulTGBy32ax9H0EopUe7/QTc40ZRjm/y9GuxpcXnHCISiKY+5C8il7KlxsvGMJtCyxzDle2w6bnCBeC6zjzYUIe+x+TD9UIN7C23Jzn6PlvJtpV3hjO2DJPMV9Ed7Vv8iGnLem6JmpI8WM+8CHYwYO5NTdDygVoklG6zW/mnh+LeTBiuwCt0qAR04xTYYJi9cPIj3lENhBjgg8SJfqDEK4kKcuO2+vp2/BbCABh8GyU2mHPloQvnYqGGXAdvxbhfZKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aH6VnQkb6H6uBqn0OITl9TPYs1zyEY39dqmqHe/fsdg=; b=aau9OGW4eUqC9cHmFx+Coy+fYfGKUlkfBLoYaZ3Ks1APmskQcEpNoiO2BJhqQ24xzTCI74ed7BJ6HNNa66OtBcUEDnSQM8rVKe5zvDCFvhnrFfZ6HvzeKN29xvbmC9mJZLxksmi/Vr/b6kW/aevcuRGwreGN2bH/mTc70Whzv4Y= Received: from PU1P153MB0169.APCP153.PROD.OUTLOOK.COM (10.170.189.13) by PU1P153MB0140.APCP153.PROD.OUTLOOK.COM (10.170.188.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2516.2; Tue, 26 Nov 2019 03:32:31 +0000 Received: from PU1P153MB0169.APCP153.PROD.OUTLOOK.COM ([fe80::704b:f2b6:33d:557a]) by PU1P153MB0169.APCP153.PROD.OUTLOOK.COM ([fe80::704b:f2b6:33d:557a%10]) with mapi id 15.20.2516.003; Tue, 26 Nov 2019 03:32:31 +0000 From: Dexuan Cui To: Stephen Hemminger , "dev@dpdk.org" , "Donald Lee (RD-TW)" CC: "stable@dpdk.org" , Abhishek Marathe Thread-Topic: [PATCH] net/netvsc: disable before changing RSS parameters Thread-Index: AdWkCZCSRBa3Z8IWRAK5fNreHRUkqQAAD9GA Date: Tue, 26 Nov 2019 03:32:30 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=decui@microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2019-11-26T03:28:33.6092091Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=031a46c2-06e0-43e1-b061-7477b96c975c; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic authentication-results: spf=none (sender IP is ) smtp.mailfrom=decui@microsoft.com; x-originating-ip: [2601:600:a280:7f70:d876:5e02:2ddf:79f2] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 7bc9641c-4038-453b-c1fc-08d7722144ee x-ms-traffictypediagnostic: PU1P153MB0140:|PU1P153MB0140:|PU1P153MB0140: x-ms-exchange-transport-forked: True x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-forefront-prvs: 0233768B38 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(346002)(376002)(366004)(136003)(39860400002)(199004)(189003)(71190400001)(478600001)(256004)(14444005)(8990500004)(25786009)(71200400001)(229853002)(10290500003)(86362001)(66446008)(76116006)(11346002)(33656002)(107886003)(55016002)(6436002)(14454004)(4326008)(6246003)(9686003)(66946007)(8676002)(74316002)(81166006)(305945005)(7736002)(81156014)(22452003)(76176011)(7696005)(316002)(5660300002)(8936002)(66476007)(66556008)(46003)(446003)(2940100002)(64756008)(6116002)(6506007)(2501003)(10090500001)(186003)(2906002)(53546011)(99286004)(102836004)(110136005)(54906003)(52536014); DIR:OUT; SFP:1102; SCL:1; SRVR:PU1P153MB0140; H:PU1P153MB0169.APCP153.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dpaW4vgwBvtSN9loU2y7KVzLBUUd+xOgwoEa8msRTUDNWshGYNeDzIf6MDEd07Jhc9zy9LTh5+HJtWOYbHAsAnuQJus/sWTVivR+9AwsEv3LIW2QYRkBUs3oyvXRRkm3vawuJ4S54iEkp5FObwJI+4/z0C/Az/y3ZLA/AgcSNx/fhOQAOuJlZaf3VqeG/1rlU6k2sUWxG+UhPFDp4xEaIqXDwWzXpBA+uLYD/m5AbtwOaxAeR4zpbNjfzgajgRDPx/mtL4gyMdfw6E1dY67duXNb4E2Qulu51ewX7NNsm0IaSMgWU0z7Xx2u0RBqRLnP9M5jJJZp5Lv3oDscuX/cLujowKqYCikbD4DKQSVgxKW1CAWqgIy9wKppR+3c93gh3TTG0kbwhX+bK9dSz5uxpnqwWNf0REq8Qx0rIks1OB5FE36phrWLJQPjiFfyp2ho Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7bc9641c-4038-453b-c1fc-08d7722144ee X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Nov 2019 03:32:30.8022 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4G0Sd4Ed4SgxK0oAf5j+Ta9wGdfdvh1kH485ZPco1fwdBXnKkJZIbF57bHhPML96oiIY22NQsichJuppq7I3Yw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PU1P153MB0140 X-Mailman-Approved-At: Tue, 26 Nov 2019 17:20:22 +0100 Subject: Re: [dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > From: Dexuan Cui > Sent: Monday, November 25, 2019 7:29 PM > To: Stephen Hemminger ; dev@dpdk.org; > Donald_Lee@trendmicro.com > Cc: stable@dpdk.org > Subject: RE: [PATCH] net/netvsc: disable before changing RSS parameters >=20 > > From: Stephen Hemminger > > Sent: Monday, November 25, 2019 9:13 AM > > To: dev@dpdk.org > > Cc: Stephen Hemminger ; > stable@dpdk.org; > > Dexuan Cui > > > > In order to change RSS parameters, the host requires that RSS > > is disable first. > > > > Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters") > > Cc: stable@dpdk.org > > Signed-off-by: Dexuan Cui > > Signed-off-by: Stephen Hemminger > > --- > > drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/drivers/net/netvsc/hn_ethdev.c > b/drivers/net/netvsc/hn_ethdev.c > > index 164e9ad174a7..575780ee5f26 100644 > > --- a/drivers/net/netvsc/hn_ethdev.c > > +++ b/drivers/net/netvsc/hn_ethdev.c > > @@ -291,6 +291,13 @@ static int hn_rss_reta_update(struct rte_eth_dev > > *dev, > > hv->rss_ind[i] =3D reta_conf[idx].reta[shift]; > > } > > > > + err =3D hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE); > > + if (err) { > > + PMD_DRV_LOG(NOTICE, > > + "rss disable failed"); > > + return err; > > + } > > + > > err =3D hn_rndis_conf_rss(hv, 0); > > if (err) { > > PMD_DRV_LOG(NOTICE, > > @@ -578,6 +585,13 @@ static int hn_dev_configure(struct rte_eth_dev > > *dev) > > return err; > > } > > > > + err =3D hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE); > > + if (err) { > > + PMD_DRV_LOG(NOTICE, > > + "rss disable failed"); > > + return err; > > + } > > + > > err =3D hn_rndis_conf_rss(hv, 0); > > if (err) { > > PMD_DRV_LOG(NOTICE, > > -- > > 2.20.1 >=20 > Hi, Stephen, > I think the patch originally came from Donald Lee (I added him to "To"). >=20 > IMO Donald's Signed-off-by should be added. >=20 > And, can you please change my Signed-off-by to Tested-by? >=20 > -- Dexuan Also, please add Tested-by for=20 Abhishek Marathe (Cc'd). Thanks, -- Dexuan