patches for DPDK stable branches
 help / color / mirror / Atom feed
* Re: [dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters
@ 2019-11-26  3:28 Dexuan Cui
  2019-11-26  3:32 ` Dexuan Cui
  2019-12-09 21:29 ` [dpdk-stable] " Dexuan Cui
  0 siblings, 2 replies; 9+ messages in thread
From: Dexuan Cui @ 2019-11-26  3:28 UTC (permalink / raw)
  To: Stephen Hemminger, dev, Donald Lee (RD-TW); +Cc: stable

> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Monday, November 25, 2019 9:13 AM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; stable@dpdk.org;
> Dexuan Cui <decui@microsoft.com>
> 
> In order to change RSS parameters, the host requires that RSS
> is disable first.
> 
> Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
> Cc: stable@dpdk.org
> Signed-off-by: Dexuan Cui <decui@microsoft.com>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
> index 164e9ad174a7..575780ee5f26 100644
> --- a/drivers/net/netvsc/hn_ethdev.c
> +++ b/drivers/net/netvsc/hn_ethdev.c
> @@ -291,6 +291,13 @@ static int hn_rss_reta_update(struct rte_eth_dev
> *dev,
>  			hv->rss_ind[i] = reta_conf[idx].reta[shift];
>  	}
> 
> +	err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
> +	if (err) {
> +		PMD_DRV_LOG(NOTICE,
> +			"rss disable failed");
> +		return err;
> +	}
> +
>  	err = hn_rndis_conf_rss(hv, 0);
>  	if (err) {
>  		PMD_DRV_LOG(NOTICE,
> @@ -578,6 +585,13 @@ static int hn_dev_configure(struct rte_eth_dev
> *dev)
>  			return err;
>  		}
> 
> +		err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
> +		if (err) {
> +			PMD_DRV_LOG(NOTICE,
> +				"rss disable failed");
> +			return err;
> +		}
> +
>  		err = hn_rndis_conf_rss(hv, 0);
>  		if (err) {
>  			PMD_DRV_LOG(NOTICE,
> --
> 2.20.1

Hi, Stephen,
I think the patch originally came from Donald Lee (I added him to "To").

IMO Donald's Signed-off-by should be added.

And, can you please change my Signed-off-by to Tested-by?

Thanks,
-- Dexuan

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters
@ 2019-11-25 17:13 Stephen Hemminger
  2019-11-26 13:52 ` Ferruh Yigit
  0 siblings, 1 reply; 9+ messages in thread
From: Stephen Hemminger @ 2019-11-25 17:13 UTC (permalink / raw)
  To: dev; +Cc: Stephen Hemminger, stable, Dexuan Cui

In order to change RSS parameters, the host requires that RSS
is disable first.

Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
Cc: stable@dpdk.org
Signed-off-by: Dexuan Cui <decui@microsoft.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
index 164e9ad174a7..575780ee5f26 100644
--- a/drivers/net/netvsc/hn_ethdev.c
+++ b/drivers/net/netvsc/hn_ethdev.c
@@ -291,6 +291,13 @@ static int hn_rss_reta_update(struct rte_eth_dev *dev,
 			hv->rss_ind[i] = reta_conf[idx].reta[shift];
 	}
 
+	err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
+	if (err) {
+		PMD_DRV_LOG(NOTICE,
+			"rss disable failed");
+		return err;
+	}
+
 	err = hn_rndis_conf_rss(hv, 0);
 	if (err) {
 		PMD_DRV_LOG(NOTICE,
@@ -578,6 +585,13 @@ static int hn_dev_configure(struct rte_eth_dev *dev)
 			return err;
 		}
 
+		err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
+		if (err) {
+			PMD_DRV_LOG(NOTICE,
+				"rss disable failed");
+			return err;
+		}
+
 		err = hn_rndis_conf_rss(hv, 0);
 		if (err) {
 			PMD_DRV_LOG(NOTICE,
-- 
2.20.1


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2019-12-12  9:57 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-26  3:28 [dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters Dexuan Cui
2019-11-26  3:32 ` Dexuan Cui
2019-11-26 17:02   ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
2019-11-26 17:19     ` Ferruh Yigit
2019-12-09 21:29 ` [dpdk-stable] " Dexuan Cui
2019-12-10  2:31   ` Donald_Lee
2019-12-10  6:59     ` Stephen Hemminger
  -- strict thread matches above, loose matches on Subject: below --
2019-11-25 17:13 Stephen Hemminger
2019-11-26 13:52 ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).