From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB5C0A0561 for ; Wed, 3 Mar 2021 08:42:27 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DD934406B4; Wed, 3 Mar 2021 08:42:27 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 83C934067B; Wed, 3 Mar 2021 08:42:24 +0100 (CET) IronPort-SDR: ty+i7dSfUtCnaVxTPfYVUFNm6cpWDUwKKlFD0o0a6clpJHe3ZKO16dBZ76A8QFMIcqqNp2ELuo HRIeBAc6PG9Q== X-IronPort-AV: E=McAfee;i="6000,8403,9911"; a="186477956" X-IronPort-AV: E=Sophos;i="5.81,219,1610438400"; d="scan'208";a="186477956" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2021 23:42:23 -0800 IronPort-SDR: 82Y2fxYG7ZfsLdfOjX8/P9x2IrtyOrK5zmiBNSJzaQ1wKrIcuEfdoqel4+VvcIOlOq5TDTEJpM /EuvIXDlyH+w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,219,1610438400"; d="scan'208";a="428169752" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga004.fm.intel.com with ESMTP; 02 Mar 2021 23:42:23 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 2 Mar 2021 23:39:27 -0800 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 2 Mar 2021 23:39:27 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 2 Mar 2021 23:39:27 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.176) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 2 Mar 2021 23:39:24 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kvO+5EP9lFzgytJUKsULz3oATUAfX9M71OL40bhE8iSmZrB26WFAq2G0LZws15WcEJCxPrqNwwlVO4D1RhTJRbLMEIUWbO74Gs4GCiTHckG/trOu138TZFWjGSYdtJhmjNGHSC+f3TxpVjGRNqw/+ebPWd1sqKHmwOHrynINMgZOHKzhXLk0A2Na5t+XmFoEG6M1DAT/LXUbke2fw7EjRrOrSq7+zevbKfpU5UFAj7uTr4X1lTVG5lCgBS1tB/PxdUfISfo+uYaXU3TDcEv/wkz1jhM6gSt3Llq1ylg17A5D0bJh2AQXuJVq0N4IMNZhZ2HgmMQ38wmhSN8OIDEFEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ubIlHEW3FWC3KtwkdYcsR/8RTYUw7BkyhStaiLRX+Yg=; b=JRp2GBKOdDobxe7xLeQHlq9OUmvw3d4WdvIk4YYDuSUBDDqmGNmgbnsz1q5GkhJCnzFO1EPPdFbDXDZ0P8W9a3ZYNSJE7Pb21p9xdVrkkBydMsMMei4XJbIGHrrUc8UKHa0hhT7TKmFkZZGP7ujvmu8THSMhLeHHr1iLRaeGVM2aViLHYEcH9OdXNNtwwLgI9FdLExxVAPEYh1hxyG+fTGwWEJLD1RJkl6XyNQoIq2YlPhHQQ8sX+yU09Xksmc+gHumRDtn1AkLZcHtKj+RRr1SjpsobEnk+b840wroXJmTnjhnT8XA3YnoiVJSnPQ8wKWV9YG/dPOWwfWDxFGnQXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ubIlHEW3FWC3KtwkdYcsR/8RTYUw7BkyhStaiLRX+Yg=; b=xPAKqPLc1YPDP1QcjlWpbb0bQ99Sz9IYwvzFWhSjMQGz2fRGAXH1c5kIpwhxZNJ/F5GrIkNGu6vPqTGuuobITbJgXuKd9rwcTVjWtuODl9sZRwCuTKtVmugWyzuiZraJi70Kfspr+5dyeHTasCBjvttz3s4neaVHXQGVrWeSaKk= Received: from SA0PR11MB4575.namprd11.prod.outlook.com (2603:10b6:806:9b::18) by SA2PR11MB4844.namprd11.prod.outlook.com (2603:10b6:806:f9::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.25; Wed, 3 Mar 2021 07:39:21 +0000 Received: from SA0PR11MB4575.namprd11.prod.outlook.com ([fe80::21cb:1548:7a3e:1b71]) by SA0PR11MB4575.namprd11.prod.outlook.com ([fe80::21cb:1548:7a3e:1b71%4]) with mapi id 15.20.3890.030; Wed, 3 Mar 2021 07:39:21 +0000 From: "Wu, Wenjun1" To: "Yang, Qiming" , "dev@dpdk.org" , "Zhang, Qi Z" CC: "stable@dpdk.org" Thread-Topic: [PATCH v1] net/ice: fix wrong RSS hash update Thread-Index: AQHXDydSJ1GdVLokzkiiMNxFy4Pz5qpx06WAgAALBXA= Date: Wed, 3 Mar 2021 07:39:21 +0000 Message-ID: References: <20210302053105.63783-1-wenjun1.wu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.213] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 19be8c02-70b3-4f28-afe6-08d8de17760b x-ms-traffictypediagnostic: SA2PR11MB4844: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8Fqa6QFZJno2J4orFyArrbKQlCUXSXngOleA2lFfIPx0L4e+6c/2N1z6/9uXFnHrnGXZosyW6D8yNM5FrP9MZ65uUGxo6yZI/lwTNm8eqcKaYXarZxB7y5qSF0W6S7/xnD4RJ2LficTksWG/w8MnF52yVQ5to8HzeVs8EMrUYwL+pJFF3YSPOIJyLrBz1S5XXhoWPKXVdD0GGVCGTzBffGkiTM2HUK/Lg7D/GAVAIte5dcCfMeTyFxe0S6t2McGWZHiQQ5mIUcEWQMGAqy7szhDj1btu3PituIkmXUU6Vbl5yTqwu0AZFtrBebfXFxXl0fZRwm02EAN6r+kPMTlK6+uDncivu54nW/EbPyM6bqpVlWLhtWMXJzA9211yANhqCQbWkw/jIGmNztpfjtAun7Me3mKZTzmPPEj6S/bV3VKzfs4sQh3+ad2njvybCHUIS3Ru1os0mKJ5gUDEeuyTZgxuxWp2+glkeWdY5fYxgmVNmEvpFKdWO10QTvzeKNA8bz/duPArViTKkrcZ0bPREA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA0PR11MB4575.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(396003)(366004)(39860400002)(376002)(346002)(52536014)(6506007)(478600001)(5660300002)(7696005)(83380400001)(2906002)(15650500001)(33656002)(66446008)(53546011)(316002)(66476007)(6636002)(8676002)(66946007)(64756008)(66556008)(8936002)(450100002)(4326008)(110136005)(26005)(71200400001)(9686003)(86362001)(186003)(55016002)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?2vS33rnkeXlPPMhbubucOTBEj48b2H9NEPAPBGrzCIIZSeZ40PyI10b1hcpL?= =?us-ascii?Q?vXjz8SLC0OMHVONx4sw6xZIKBmEUJ7G2TaVEswLr6h2ut6JIbfd5d6CCQvSB?= =?us-ascii?Q?+sGjKLL5dby2XXb3nzWyLxWLN67Usv4RkD0+tIHmlqdeKer40U+DYzsjkAbl?= =?us-ascii?Q?WcjFXoYHIpomXOucbSL1nI1kjaYrReNVWot2fUh2lszLMY6ilJI+2dHzw+z9?= =?us-ascii?Q?Lp20vyiWdL+yMRV04z/As/KX0/Uv/98rYlWYVTB0Uw/WpM803jQdutKR3lny?= =?us-ascii?Q?6bJOYaCYHTOtEZqEKP8Qf9LifovpENyvCt64DI2UD9pmsHzD3FAQdaUvx2Fp?= =?us-ascii?Q?2uzesuyD1M77LeqcCFORdsVIXVT3cFgEM2rK+emC4HomZTpF9gDaCY8mOoi+?= =?us-ascii?Q?cAs0nX/x6M5pwS/BxDwTqfWNmKR0SZodrAKBHE7dpQ6cfqhKZnwvdmgSgJKK?= =?us-ascii?Q?oVaeCAt19W87LsnSRr2XqjhAXKF4LjUZOxeoXOo3v7I/r2k8qpk16uRZhqGV?= =?us-ascii?Q?J0GfU5jETKAS3mx4qyIXnXxKeJdspaU0ODSpReMq0YUQAJ+AwoJZwL0oxjAY?= =?us-ascii?Q?vKQloOQ66uOlz2rtlKVuXbR13nun+xq2dUayqey9/5/vR4pwiIy+YuCXFLnu?= =?us-ascii?Q?KK5hvuSbB49sBqWD/i+G8pwylmaq5pQp9yk8lHRgGWKfewF7qkhYelGEdWqV?= =?us-ascii?Q?EwqdCcF3YJpeN8kNnyne8Jh6q7HR1s2wb5FDLCU009QxXTlUf58+6EIA7BOl?= =?us-ascii?Q?yRKfe/xj7KNffxoW85dIlnSyEjxP6y+S15ENvjYjE/A/U8tYHR8pkjMH3uKZ?= =?us-ascii?Q?YZ/OunA6QuV1uKfaAAijFeV2/TCric+vaHIQKUO4VRzbSYC5Yi7WyhunstqT?= =?us-ascii?Q?Rl/5Uhy3H1YevqpY+MUNcU0KlUiOkqxTDuDui/e60HXu0r0xDfBqmq0KhCeR?= =?us-ascii?Q?XxbIVofHAX4JmFeoHkr0AtZ5bvMixuJEw+onQfNGZompC/LejY1ZdeugjQSU?= =?us-ascii?Q?2/sbjooPNuW/1W+sZjqwIilcci+eBQKbeowl2Qzh+fguFt8qQcmnihtmU1Qb?= =?us-ascii?Q?XbnpTJ647ji8Ok2lEipdZjUjc/tic7SNQuEgxe30TIdpNngJZcbdvFWUp2T2?= =?us-ascii?Q?sZQBmHJgYGG+qGGy/sWTY7mMRGgcTnMKp5KcRTWkRfrlp6Ks88K3VrrHTMnC?= =?us-ascii?Q?Zk8bAA9pY3LgtLrmZKBCoKoAqcuYDGVnNIvT2KXo2N7DNW2e2ci6p3OLc+7h?= =?us-ascii?Q?CHy631oIrdcsC8G9k5+7nP9p8iFcNRQ7HqV3kmg56TF/Lm5C2u3TGQZQ14LD?= =?us-ascii?Q?JvLAUsCUlyP6zUvsBr1Vx61A?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA0PR11MB4575.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 19be8c02-70b3-4f28-afe6-08d8de17760b X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2021 07:39:21.7971 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8KKXZzNhMgqh/ixuVtqJNJYwHuWTYU+fNiChUHbGSh+imqakpQQYYHyJWpcZihsZoe5kakqdzbIvt3OVC9pSCA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4844 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH v1] net/ice: fix wrong RSS hash update X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi Qiming,=20 There are two consequences if skipping the state rss_conf->rss_hf =3D=3D 0. 1. The function " port config all rss none" means to disable RSS. When rss_= conf->rss_hf =3D=3D 0, the function will not take affect, which does not co= nform to the description in dpdk doc: The none option is equivalent to the --disable-rss command-line option. 2. Some ptypes are not supported by CVL. When rss_conf->rss_hf =3D=3D 0, us= ers cannot predict the consequences when setting RSS with these unsupported= ptypes. The RSS may be disabled, or with no change, which is not what we w= ant to see. So delete these codes may be better. Regards, Wenjun -----Original Message----- From: Yang, Qiming =20 Sent: Wednesday, March 3, 2021 2:47 PM To: Wu, Wenjun1 ; dev@dpdk.org; Zhang, Qi Z Cc: stable@dpdk.org Subject: RE: [PATCH v1] net/ice: fix wrong RSS hash update > -----Original Message----- > From: Wu, Wenjun1 > Sent: Tuesday, March 2, 2021 13:31 > To: dev@dpdk.org; Yang, Qiming ; Zhang, Qi Z=20 > > Cc: Wu, Wenjun1 ; stable@dpdk.org > Subject: [PATCH v1] net/ice: fix wrong RSS hash update >=20 > This patch removes redundant judgment statements to disable RSS when=20 > RSS hash function configured is not supported. >=20 > Fixes: 4717a12cfaf1 ("net/ice: initialize and update RSS based on user=20 > config") > Cc: stable@dpdk.org >=20 > Signed-off-by: Wenjun Wu > --- > drivers/net/ice/ice_ethdev.c | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/drivers/net/ice/ice_ethdev.c=20 > b/drivers/net/ice/ice_ethdev.c index > f43b2e0b2..a84b3d3c0 100644 > --- a/drivers/net/ice/ice_ethdev.c > +++ b/drivers/net/ice/ice_ethdev.c > @@ -4461,9 +4461,6 @@ ice_rss_hash_update(struct rte_eth_dev *dev, > if (status) > return status; >=20 > - if (rss_conf->rss_hf =3D=3D 0) > - return 0; > - Why need to delete this code? It's a code clean to avoid to do more judgeme= nt in the next funxtion. > /* RSS hash configuration */ > ice_rss_hash_set(pf, rss_conf->rss_hf); >=20 > -- > 2.25.1