From: "Ding, Xuan" <xuan.ding@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v2] net/iavf: fix VIRTHCNL_OP_SET_RSS_HENA handling
Date: Tue, 19 Jan 2021 04:34:38 +0000 [thread overview]
Message-ID: <SJ0PR11MB5216A4ABED7DCF89F3B1A54EE7A30@SJ0PR11MB5216.namprd11.prod.outlook.com> (raw)
In-Reply-To: <f75b7bab1ffe452ba3fefafc5229eb4b@intel.com>
Hi Qi,
> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zhang@intel.com>
> Sent: Tuesday, January 19, 2021 11:45 AM
> To: Ding, Xuan <xuan.ding@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>;
> Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: RE: [PATCH v2] net/iavf: fix VIRTHCNL_OP_SET_RSS_HENA handling
>
>
>
> > -----Original Message-----
> > From: Ding, Xuan <xuan.ding@intel.com>
> > Sent: Monday, January 18, 2021 4:28 PM
> > To: Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>;
> > Xing, Beilei <beilei.xing@intel.com>
> > Cc: dev@dpdk.org; Ding, Xuan <xuan.ding@intel.com>; stable@dpdk.org
> > Subject: [PATCH v2] net/iavf: fix VIRTHCNL_OP_SET_RSS_HENA handling
> >
> > Allow error to be returned for VIRTCHNL_OP_SET_RSS_HENA when set hena =
> 0.
> > Add warning that PF does not support hena = 0 now.
>
> Actually this is not a fix, it’s a workaround to handle some defect in legacy
> kernel driver.
> So changed title and commit log as below:
>
> Title: workaround RSS cleanup failure handling
>
> Allow to ignore error returned from virtual channel command
> VIRTCHNL_OP_SET_RSS_HENA with hena = 0 due to some legacy
> kernel driver does not support this. Add warning message when
> this happen.
>
> >
> > Fixes: 95f2f0e9fc2a6("net/iavf: improve default RSS")
>
> The fix line should be removed.
>
> > Cc: stable@dpdk.org
Since fix line is removed, should CC to stable also be removed?
Thanks for your correction.
Regards,
Xuan
> >
> > Signed-off-by: Xuan Ding <xuan.ding@intel.com>
>
> Acked by: Qi Zhang <qi.z.zhang@intel.com>
>
> Applied to dpdk-next-net-intel.
>
> Thanks
> Qi
next prev parent reply other threads:[~2021-01-19 4:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 8:15 [dpdk-stable] [PATCH] " Xuan Ding
2021-01-18 8:28 ` [dpdk-stable] [PATCH v2] " Xuan Ding
2021-01-19 3:45 ` Zhang, Qi Z
2021-01-19 4:34 ` Ding, Xuan [this message]
2021-01-19 4:41 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR11MB5216A4ABED7DCF89F3B1A54EE7A30@SJ0PR11MB5216.namprd11.prod.outlook.com \
--to=xuan.ding@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).