From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C35F6A0A04 for ; Tue, 19 Jan 2021 05:35:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B321F140E6A; Tue, 19 Jan 2021 05:35:03 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id AB38E140E56; Tue, 19 Jan 2021 05:34:59 +0100 (CET) IronPort-SDR: RlzIXLe/PLS2JCPREwH95RQhG2dkRWNMg5WaSXVqYXF5MFsoer0MwMs9YxkXgDJpGesJa79Goq 9cH9So7XBgSA== X-IronPort-AV: E=McAfee;i="6000,8403,9868"; a="176305309" X-IronPort-AV: E=Sophos;i="5.79,357,1602572400"; d="scan'208";a="176305309" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2021 20:34:48 -0800 IronPort-SDR: 4njxx4iq1FPJLCweNRJTgh2IXNfp2g44agM7ci/xnpvoigU9olJcMlJ+2250C/nJtcn+auMKnZ 5790C9LfsiDw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,357,1602572400"; d="scan'208";a="350384842" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga003.jf.intel.com with ESMTP; 18 Jan 2021 20:34:46 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 18 Jan 2021 20:34:45 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 18 Jan 2021 20:34:45 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 18 Jan 2021 20:34:45 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.42) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 18 Jan 2021 20:34:43 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QQ6TKkD8MoDz7p3pO5hoI8gUZ09K1/dvY1SXhXucfx4rDFseiu3zjn8ANdmMEArf2D2V9cDrm6Ii93rH83ZmcOCisbDRYepqRUK73qHWFvhrN5sKrHe9cxVyav8vnRxRoijYoA08mmNudosNIQzEnrpD4WeP39Z9eaw5xouWpFkLh8cHz9sGb3hwnxhxhvVzSE5CRbnIu422/qXGyXOZRWi/igbzhEObEFvKAoFOtyTmGe8yoPS6B6jBgOdZrdgOliYiaLs1Kzpm+1BbPs5yz307xC+Qn8ipnNdNiUvGiWdsyiHj/Xdmr1TiWDFEWewPC+F7A/FOu8obMbCCILzdDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wJlJRH371ob20v9jP1TTHmk8IlPO315kM8LwZREdCHM=; b=UdZ7/vwunFwZr8iauagoNAltHjzZJloUGDO70I+Olitdx0+tYKRSMSY3PdbUfyXqf3tXSwkzbaLoUiUGqplzTL+JbwzyQRvrudua+c7VZgUhN7+7lvou6w7NlUrs0k8v+aVtNaBpkug9fCcJtxC9rkBnlyknlXrPcCoGZnh/fqkq1nQOs4/dZC7sHHg5Tc590v5KejuhsKxAcmlQMAtCSIBFvIe1LNlqTPsxxypibm4KXn1oNoo2Q+clreIyFa/ymZPPR/KOhk6cjH73b+u1NsEhm+tUz4jr1bKIJZvrZ1IsKL0zqg3NA37YZ0i1O8AxzXC217kLGe3SpzctweVvKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wJlJRH371ob20v9jP1TTHmk8IlPO315kM8LwZREdCHM=; b=Ka1x6DJZam0QoHHuksB46mXcCxnUkKx5RwsrID1v4863A8ldyxf5jeoTss1zetFKWlWSxm5CsdB4tQ1OV7V0da0DkV2149fh65q08fGEq5//5Irznk0D4fOci2feBJfAv6svgomscBrOiPwMmn16hnQCxYXdmhmNl5sUkIV8hLs= Received: from SJ0PR11MB5216.namprd11.prod.outlook.com (2603:10b6:a03:2db::23) by BY5PR11MB4166.namprd11.prod.outlook.com (2603:10b6:a03:191::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.11; Tue, 19 Jan 2021 04:34:38 +0000 Received: from SJ0PR11MB5216.namprd11.prod.outlook.com ([fe80::41c9:9aff:53db:370b]) by SJ0PR11MB5216.namprd11.prod.outlook.com ([fe80::41c9:9aff:53db:370b%6]) with mapi id 15.20.3763.014; Tue, 19 Jan 2021 04:34:38 +0000 From: "Ding, Xuan" To: "Zhang, Qi Z" , "Wu, Jingjing" , "Xing, Beilei" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/iavf: fix VIRTHCNL_OP_SET_RSS_HENA handling Thread-Index: AQHW7XW7t+lLJ3eLVEO1TH8vtbdzu6ouUBgAgAAMr7A= Date: Tue, 19 Jan 2021 04:34:38 +0000 Message-ID: References: <20210118081506.107794-1-xuan.ding@intel.com> <20210118082826.1261-1-xuan.ding@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.46] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 474fd627-6f41-4b93-2561-08d8bc3387e5 x-ms-traffictypediagnostic: BY5PR11MB4166: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:336; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BwbJsV240McOSZ5m8jabhI5G93vM6MrWFEpcl+Ijuy2slgHSKAiCKuKnIebcPshPrKnZxxgryujSP1VLPKDT9I6sV0ByuXFva9wVJ47be/x6Et+qsgUy1Lltd1OL36EJHPMdURplmQiBmspSEYwQX6nQAjR77jSRo4W8Ad4gziLvRNBNZ1GCflLxTQMrGSGG3cG+wBv5ijvTAtVfySF9PNiKEzpLDFQI/3cJZOhcqyHO1dM/DFwO72gAjdOyPHRN7IbZZIoilt7Ort+wTnr2iaotEZW7+mmWKJ+iUkJeDomTntQXiFzX8qyyM10FjqnLDQ18p9JG88epEGHrNKEcTTsZDSPId942hYvSfi0lGDRbsWlmtPdac5wVmVFtYJ7HKZyPG2YhEEYKXYkGo9APJKh1xeXxV3PKEftYWTCiSbsZhBAvbuuQ1J0gZvIQnYLPPXzTdp4UO1zp08IBg/IcmckD03UfThjwkNf14SwAWp0Cbmb8HdAYScAaAeUYxoLDxr6yZLsOqmnDMPxql0bH+Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5216.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(376002)(366004)(39860400002)(136003)(9686003)(33656002)(478600001)(76116006)(55016002)(54906003)(7696005)(66556008)(52536014)(86362001)(66446008)(186003)(5660300002)(66476007)(8676002)(66946007)(71200400001)(64756008)(8936002)(6636002)(450100002)(110136005)(4326008)(316002)(26005)(53546011)(2906002)(6506007)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?Windows-1252?Q?2HqqIccSgVSSRL0H8wxUBjTQfd+dwLu5Ga9hxSkKgCiYBRd6+DW/pokf?= =?Windows-1252?Q?KK6kbHm0vHPUuHEjDFeZ5GzLnsurwdUtowncdzygMk54RFomoPqdYfWC?= =?Windows-1252?Q?fpe737jcBxH56F9VrEoIK35H7bbubXTesAz1dmC2h4fs6vPvUGvFSvFu?= =?Windows-1252?Q?n8ZS7J73A5hwwmDDmVHPVXh+cJEq66g6moHnEoKaQlXLZ2ou2RRBRyk4?= =?Windows-1252?Q?9fA8aCgNkDlrg5jbcTzBMP/KZFe+NhrmPq+HGcRx9M9D35byafDTI7JN?= =?Windows-1252?Q?SgWAM12yW6yKj7KlNGlBRTcJqvmQpyRw6HoOy72arurklUYsaeCb+2t1?= =?Windows-1252?Q?ErYnwOmhot8giIzrZRETJOZQrgXlaY4b8SL52kEegLaz6zP+6QRsVg9w?= =?Windows-1252?Q?z3gX8TFH2F0+oIkJduWMnOqMDlaGPAm5MkZRJdAyY05E5ntlJ3YDmfB1?= =?Windows-1252?Q?ombWUjph6RUByVTT8rCl0O72WR8gne8DgyrV1ytHfRssB2ENNPi5gYL7?= =?Windows-1252?Q?d4XID8C1LQw5j1v34qo6zsZo9FQfPMco5pRjOYpSy+zTFdIxUOMqR9x6?= =?Windows-1252?Q?+U9/5xSyvRSKuc7MQLJe19SGbMYGkVIIodlCCSBjgN/cEfb1HI3Dd7GC?= =?Windows-1252?Q?9IUw5OhYtKWw7QG3gR5JULrha2hh0qMFrmy+bu3wg7VWtfTzqX2C2bhF?= =?Windows-1252?Q?qJy2Ywhyed1HPN5LrxF2nxZXF54A0GGE010fcaKG52MVq1a0G9P6bkb9?= =?Windows-1252?Q?nk1/tmxnYvML+DVQFCr2NXQehsW0RbweQgZuE5kNFVKOD6+r0dCWe3c7?= =?Windows-1252?Q?1Kik4ELtFVCDCA5SHPdLpETCE42a++8KvbfzWLY3gJ9Zqfh7dAab7shG?= =?Windows-1252?Q?Yp+snBGTo+Yy9WTZ/PwmoM2zSX8jUusHXTNxd/cnirwA2XaTnwnBfw3M?= =?Windows-1252?Q?o/sjO1jm1H1Lmk1qQHCN0nxFbrNVU55dTmcN8EMtNCAwA2qpHj5YarPG?= =?Windows-1252?Q?q0uSvVJDW/4iB3Jl89gHuIG8vr1vpHHFG2WpwGkRw4LxrXV9QDI=3D?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5216.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 474fd627-6f41-4b93-2561-08d8bc3387e5 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jan 2021 04:34:38.0697 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pU7TsJZHwk5q9cNz9+tanrj2/doNROZiLLtNi3jJ+aYiK8kBBXLQarNZDTg0+tKXAZb3HJ+bRwSkSp6F46NrOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4166 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH v2] net/iavf: fix VIRTHCNL_OP_SET_RSS_HENA handling X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi Qi, > -----Original Message----- > From: Zhang, Qi Z > Sent: Tuesday, January 19, 2021 11:45 AM > To: Ding, Xuan ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; stable@dpdk.org > Subject: RE: [PATCH v2] net/iavf: fix VIRTHCNL_OP_SET_RSS_HENA handling >=20 >=20 >=20 > > -----Original Message----- > > From: Ding, Xuan > > Sent: Monday, January 18, 2021 4:28 PM > > To: Zhang, Qi Z ; Wu, Jingjing ; > > Xing, Beilei > > Cc: dev@dpdk.org; Ding, Xuan ; stable@dpdk.org > > Subject: [PATCH v2] net/iavf: fix VIRTHCNL_OP_SET_RSS_HENA handling > > > > Allow error to be returned for VIRTCHNL_OP_SET_RSS_HENA when set hena = =3D > 0. > > Add warning that PF does not support hena =3D 0 now. >=20 > Actually this is not a fix, it=92s a workaround to handle some defect in = legacy > kernel driver. > So changed title and commit log as below: >=20 > Title: workaround RSS cleanup failure handling >=20 > Allow to ignore error returned from virtual channel command > VIRTCHNL_OP_SET_RSS_HENA with hena =3D 0 due to some legacy > kernel driver does not support this. Add warning message when > this happen. >=20 > > > > Fixes: 95f2f0e9fc2a6("net/iavf: improve default RSS") >=20 > The fix line should be removed. >=20 > > Cc: stable@dpdk.org Since fix line is removed, should CC to stable also be removed? Thanks for your correction. Regards, Xuan > > > > Signed-off-by: Xuan Ding >=20 > Acked by: Qi Zhang >=20 > Applied to dpdk-next-net-intel. >=20 > Thanks > Qi