[PATCH v2 1/4] app/testpmd: fix the testpmd field string sequence

[PATCH v2 1/4] app/testpmd: fix the testpmd field string sequence

[Rongwei Liu]

The field string should be in the same order as the rte_flow_field_id
enumration definitions

Fixes: bfc007802 ("ethdev: allow modifying IPv6 FL and TC fields")
Cc: michaelba@nvidia.com
Cc: stable@dpdk.org

Signed-off-by: Rongwei Liu <rongweil@nvidia.com>
---
 app/test-pmd/cmdline_flow.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 60ee9337cf..775ce20fc4 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -1002,10 +1002,10 @@ static const char *const flow_field_ids[] = {
 	"hash_result",
 	"geneve_opt_type", "geneve_opt_class", "geneve_opt_data", "mpls",
 	"tcp_data_off", "ipv4_ihl", "ipv4_total_len", "ipv6_payload_len",
-	"random",
 	"ipv4_proto",
-	"esp_spi", "esp_seq_num", "esp_proto",
 	"ipv6_flow_label", "ipv6_traffic_class",
+	"esp_spi", "esp_seq_num", "esp_proto",
+	"random",
 	NULL
 };
 
-- 
2.27.0

Re: [PATCH v2 1/4] app/testpmd: fix the testpmd field string sequence

[rongwei liu]

[-- Attachment #1: Type: text/plain, Size: 1862 bytes --]

Hi
@Dariusz Sosnowski<mailto:dsosnowski@nvidia.com> Can you comment on this patch? Thanks.


BR

Rongwei



________________________________
From: Rongwei Liu <rongweil@nvidia.com>
Sent: Monday, May 27, 2024 10:47
To: dev@dpdk.org <dev@dpdk.org>; Matan Azrad <matan@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>; NBU-Contact-Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>
Cc: Michael Baum <michaelba@nvidia.com>; stable@dpdk.org <stable@dpdk.org>; Aman Singh <aman.deep.singh@intel.com>; Yuying Zhang <yuying.zhang@intel.com>; Ferruh Yigit <ferruh.yigit@amd.com>; Dariusz Sosnowski <dsosnowski@nvidia.com>
Subject: [PATCH v2 1/4] app/testpmd: fix the testpmd field string sequence

External email: Use caution opening links or attachments


The field string should be in the same order as the rte_flow_field_id
enumration definitions

Fixes: bfc007802 ("ethdev: allow modifying IPv6 FL and TC fields")
Cc: michaelba@nvidia.com
Cc: stable@dpdk.org

Signed-off-by: Rongwei Liu <rongweil@nvidia.com>
---
 app/test-pmd/cmdline_flow.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 60ee9337cf..775ce20fc4 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -1002,10 +1002,10 @@ static const char *const flow_field_ids[] = {
        "hash_result",
        "geneve_opt_type", "geneve_opt_class", "geneve_opt_data", "mpls",
        "tcp_data_off", "ipv4_ihl", "ipv4_total_len", "ipv6_payload_len",
-       "random",
        "ipv4_proto",
-       "esp_spi", "esp_seq_num", "esp_proto",
        "ipv6_flow_label", "ipv6_traffic_class",
+       "esp_spi", "esp_seq_num", "esp_proto",
+       "random",
        NULL
 };

--
2.27.0


[-- Attachment #2: Type: text/html, Size: 3898 bytes --]

RE: [PATCH v2 1/4] app/testpmd: fix the testpmd field string sequence

[Dariusz Sosnowski]

> -----Original Message-----
> From: rongwei liu <rongweil@nvidia.com>
> Sent: Monday, May 27, 2024 04:47
> To: dev@dpdk.org; Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; Suanming Mou
> <suanmingm@nvidia.com>; NBU-Contact-Thomas Monjalon (EXTERNAL)
> <thomas@monjalon.net>
> Cc: Michael Baum <michaelba@nvidia.com>; stable@dpdk.org; Aman Singh
> <aman.deep.singh@intel.com>; Yuying Zhang <yuying.zhang@intel.com>;
> Ferruh Yigit <ferruh.yigit@amd.com>; Dariusz Sosnowski
> <dsosnowski@nvidia.com>
> Subject: [PATCH v2 1/4] app/testpmd: fix the testpmd field string sequence
> 
> The field string should be in the same order as the rte_flow_field_id
> enumration definitions
> 
> Fixes: bfc007802 ("ethdev: allow modifying IPv6 FL and TC fields")
> Cc: michaelba@nvidia.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Rongwei Liu <rongweil@nvidia.com>

Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>

Best regards,
Dariusz Sosnowski