From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 05C15A0C42 for ; Tue, 11 May 2021 10:09:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EAD71410E9; Tue, 11 May 2021 10:09:04 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id C920D4003E; Tue, 11 May 2021 10:09:01 +0200 (CEST) IronPort-SDR: cur8G3drFVxBoSMMyB/VhR0mdU6ujErdbCy/zmS4wMvbySLeNEexfd3qiwB1sxcHL5RCNcAID8 +4/cr5GVokIw== X-IronPort-AV: E=McAfee;i="6200,9189,9980"; a="186518996" X-IronPort-AV: E=Sophos;i="5.82,290,1613462400"; d="scan'208";a="186518996" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 01:08:59 -0700 IronPort-SDR: 8TnM0npS8oC7auC+FC0B69vsDNtOjSvdgsvG5QqDtk4b/tJDI2nJBr9vveswGFy4K4i1nfgC9W O54WtE/TdqXQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,290,1613462400"; d="scan'208";a="408694171" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga002.jf.intel.com with ESMTP; 11 May 2021 01:08:58 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 11 May 2021 01:08:58 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 11 May 2021 01:08:58 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.104) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 11 May 2021 01:08:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D0r8BUFTuhqv6Pi9EIP1eXhF8fLm5QjDF3Y/Xt+a0ookXHCEbKQQLOmSU+ePVqcBY3Q4a2RC6xPp0vbM9l9auDuMa4HkkTjVSSTG+cUJJTL3YgRxo6Kj8+4VmcStVnRSzdZYRdva87JDZaAo6UX4kSrtn3yITUVpsqb91npzIKJP3t17Pq4VvVovBw6lDa29cKVt7tSC6Ro81XlVluaAOKF34ikGcq0JS+rYgZqOtsr4VLajDPNQ0NgRVRIFpwCf4SYZIlMYOruLdaigWOnt8n4/dLqM/EI3kbpos/5Wh+pjgXODZ/XxsW0O6+VZ133U+ODlKq/ODkr2FPfBCbL4ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bOItLHBnNunXS0k7/Fv+Ew/gSr/zp1MtNESq3uR+C9I=; b=Y8AT3qahPfhMWUroTfh5ddlsKXUqmPUroKkDbJ5CdS+Ayuk46VH9Pw/lurD95f+vCtdV4eHhcvd7crcyjQDBClr7QrobiNR/P9NWydnKifyKis9ZQU6PM8FGnxArZXp80a+i6M1RIO9EDR+dXjn2KjLXWYdMRRKtnsfiWUSLzMSPXPFEtJJWCXMq43IbmtjeS0N8h11xEgwcadxVFSGqmJ9cYpfZwNMYoMptRCSKzYkipoNvogEjP3ydpz5SY67u1CGIwEkyOaIlW4V/ByvbVRMFbNOusCi5J5qIDbbsDrR07Wi9I74jPzU9574KCIBAgBPHTpuMDFJQGI5d6ARlgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bOItLHBnNunXS0k7/Fv+Ew/gSr/zp1MtNESq3uR+C9I=; b=f7aHhBfAqur0iqCzPgpwpmA6rVZO6lmLUmXxNrHWg6p20EIw2BCcdFm4hNfvqcRMfAVojr384iuABXvQ3aMp3rGuG40qqWK6AT9w6jUk1BZ/mwntj46/PsCRaVjLAp0rkw2gkuHmh4XPvrnFtlVXUGRlM6GeVIhuX8qCBl7H7Vk= Received: from SN6PR11MB2621.namprd11.prod.outlook.com (2603:10b6:805:59::15) by SA2PR11MB5113.namprd11.prod.outlook.com (2603:10b6:806:113::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25; Tue, 11 May 2021 08:08:56 +0000 Received: from SN6PR11MB2621.namprd11.prod.outlook.com ([fe80::50e2:3791:51f4:fc8b]) by SN6PR11MB2621.namprd11.prod.outlook.com ([fe80::50e2:3791:51f4:fc8b%5]) with mapi id 15.20.4108.031; Tue, 11 May 2021 08:08:55 +0000 From: "Rong, Leyi" To: "Zhang, AlvinX" , "Xing, Beilei" , "Zhang, Qi Z" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/i40e: fix offload flag checking in simple Tx datapath Thread-Index: AQHXRg7l7hXP/vM2xkugKeltfVe6sard6FsQ Date: Tue, 11 May 2021 08:08:55 +0000 Message-ID: References: <20210427085859.22376-1-alvinx.zhang@intel.com> <20210511023926.27296-1-alvinx.zhang@intel.com> In-Reply-To: <20210511023926.27296-1-alvinx.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.193] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: afb8cfa2-59a4-49f5-d0fa-08d9145405fb x-ms-traffictypediagnostic: SA2PR11MB5113: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4125; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Jpd/Gr87fRtJQOzANLw/wF4mRoOThPnq+zG8IfmlcZSShOBqKv3O1utahdQsfa3O/hLh3DpoDEyiy1guEIftK0YBm86HIiVcT1FMWWOkxU1fTScEmeP9IdMS5AFRC1VmEnNSIkj+Ifq/poGsyoSJPScADViyfbLBTO0ep1JGfQKAYwYKRBscT36Hil7JCcMRtK74a8n7T7lbk2VFeHMnZ0Amvd2t06zDgff3/udE7d+d/ScpbMiGzSwf/5lU8k5iJUT0nIc373xX76c2GGnjoHpQxM5G95TB8td0o8mrv8qahC3Z+sHKXM7wHKtY5bLRtLPrduqa/RQ0Koy796o3r/m5PkQ/R8NoaKGblqqokbhqOPtDwjOBvWXqA1d1feKe3ltzXUFq5FLbQMaL/e8hbWo2V4LOUcHySet15RUU9a2R8r03Lz+UceX4VNOKvkB/KP62PIHle2M8urU5o6HtzN5sHMEjaAoQ0hI83uU3daQ9K+mjYVyUvfooLbtwmmQrGEvquVfhVsMfzkXsC90ElpDhgPYCCEapj3z6fnRm/AU/X8YyntdZkCE5tHoU7JnnI0pMVYdZ5cSm5bpxvI6FEEic/i9OaXog1RrCBEz822g= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2621.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(396003)(346002)(136003)(39860400002)(376002)(6636002)(54906003)(186003)(478600001)(110136005)(5660300002)(122000001)(9686003)(6506007)(33656002)(55016002)(71200400001)(4326008)(38100700002)(8676002)(83380400001)(52536014)(450100002)(53546011)(2906002)(86362001)(66446008)(66946007)(64756008)(66476007)(66556008)(8936002)(26005)(76116006)(7696005)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Vte2L1djGukhjTiCVRzyn0lJQqYQCYuVBpq5H7JTEgd9X+uxlvuOfs6IN/5O?= =?us-ascii?Q?eJPd0yB3Vp6Kt45+XyTP1sOivrsYsifQdxCqtP3cvew0oCVhfsCU07qifub9?= =?us-ascii?Q?jFNAiahZyCDx5hVljw97bCVg/VL0qcGFiHINV4T/9wq0drRzfRHxvZOsbLTb?= =?us-ascii?Q?b6kipXQ3bIboFJwYntAJw+00zfPaaSNSON9/JnfcESqxiniiEGS2klQZtunf?= =?us-ascii?Q?u6tnMljn8Z6x6gDDsBE6onza/tX8dXLMc4ffzN+NMW1LqUth/Eru7pQTCTAh?= =?us-ascii?Q?cIv55EtJdMsV382+NAfTbA5H+eBO1IXP596cy/+btoE8NpOIMPNwReYbhIDh?= =?us-ascii?Q?LawzQrTj8qYo6m+hsuQ+hXnyGC6T+reVo8EXxUI26tHyqORnVZVeXtgReRSI?= =?us-ascii?Q?/EKIdO44SHAUUJXwdknUiZcKpVqDMKRTwKWuV8ZICuO+9CCuMdJPA/BwAg41?= =?us-ascii?Q?98AEuP80qpWl3+Lz0SfK6xKutZUKEou69hQNnapXjE5m4bsMG8RWkRI3SymI?= =?us-ascii?Q?nj44e658TFHuxJ61huidHekGcMYpAyzsCHdJw5Q6Zlwmoiq0v7lBRezKPhSA?= =?us-ascii?Q?I8DxNtRkcWhkrHmLlsKE47H1AC/zNC1o6cysPQZKsXt+qFMkcp52vmR+UlJ+?= =?us-ascii?Q?NxVTWKBRQR9Vh9wo36Cr/UcAh1vR/9+tchrvI9tQPZQ3GRg3OioeiJNC0lXq?= =?us-ascii?Q?04qoHY3DG0YlqoUsQma+dnR+aujPOPELhgbItCe2N4+LdW8YhFk2iaJfB7bi?= =?us-ascii?Q?qYXvmTaH5zEzOICbsJxPHfQpeAr5MmLot5WJXNS3W4iOCC2FXcShO0Vdiqx0?= =?us-ascii?Q?lPpkvQDqM0t0lq7ZuZYG43s8VsvB2KMVQBGhQYQmD9kDTulFI8h+Z1c/1I6M?= =?us-ascii?Q?lQa5g0DNmCfZtkZhhV1q6uD52iPsk+jsJWjxxbjyfQLjyYmtDrxHo6lgB1o+?= =?us-ascii?Q?mCnSpVbx6CPoyAWLq/sbz2ebdQSHT6yQE6EZV12wpEN8NHc5rPAUO1LqrlzG?= =?us-ascii?Q?+Rwa/dFZ7OWk3KwYtLPWb1XvrIeRm6JqFIzUxdh8ROttKp9s15dKvH+3nEsz?= =?us-ascii?Q?CRPBxKr2aYuDRPKhQXZPs8q5S4XacbMqqFpQuIdgoeK1aaMsKuIGwBMMiFvm?= =?us-ascii?Q?yJGUSx4y2P1eaF5uCpXAKNV0ldoEA33ytn753SuFy+iCL3QYc03hnKfC0D56?= =?us-ascii?Q?qM89vK3lwLC4BrprKPvdfS28gzFFlF4+WhCCGGs8aqck1xpFaZl4AS0bEoEQ?= =?us-ascii?Q?bkS/U8QwBttfLn4YO1z40PeK/Yrb3iZsX3DF9eHf7zlB4TEk0gvNWuvuPsdK?= =?us-ascii?Q?E0dx5OmDncruFeifd3Api4BP?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2621.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: afb8cfa2-59a4-49f5-d0fa-08d9145405fb X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2021 08:08:55.8334 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IR329T8KJjx/P8ZmBkMvCAMWSvKEYwu0b+bJbbKKQCIX/7+MiJTCOqiS/FNxoPox7foUBWW7/6dM7zOr89UKHg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5113 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH v2] net/i40e: fix offload flag checking in simple Tx datapath X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Zhang, AlvinX > Sent: Tuesday, May 11, 2021 10:39 AM > To: Xing, Beilei ; Rong, Leyi > Cc: dev@dpdk.org; Zhang, AlvinX ; stable@dpdk.org > Subject: [PATCH v2] net/i40e: fix offload flag checking in simple Tx data= path >=20 > Tx offload flags 'PKT_TX_IPV6, PKT_TX_IPV4, PKT_TX_OUTER_IPV6, > PKT_TX_OUTER_IPV4' are supported in simple datapath. >=20 > This patch removes these offload flags from packet checking in simple Tx > datapath and defines 2 macro I40E_TX_OFFLOAD_SIMPLE_SUP_MASK and > I40E_TX_OFFLOAD_SIMPLE_NOTSUP_MASK. >=20 > Fixes: 146ffa81d05e ("net/i40e: add Tx preparation for simple Tx datapath= ") > Cc: stable@dpdk.org >=20 > Signed-off-by: Alvin Zhang > --- > drivers/net/i40e/i40e_rxtx.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c = index > 02cf5e7..337916b 100644 > --- a/drivers/net/i40e/i40e_rxtx.c > +++ b/drivers/net/i40e/i40e_rxtx.c > @@ -72,6 +72,15 @@ > #define I40E_TX_OFFLOAD_NOTSUP_MASK \ > (PKT_TX_OFFLOAD_MASK ^ I40E_TX_OFFLOAD_MASK) >=20 > +#define I40E_TX_OFFLOAD_SIMPLE_SUP_MASK ( \ > + PKT_TX_IPV4 | \ > + PKT_TX_IPV6 | \ > + PKT_TX_OUTER_IPV4 | \ > + PKT_TX_OUTER_IPV6) > + > +#define I40E_TX_OFFLOAD_SIMPLE_NOTSUP_MASK \ > + (PKT_TX_OFFLOAD_MASK & > ~I40E_TX_OFFLOAD_SIMPLE_SUP_MASK) Hi Alvin, Better to use ^ oprand here, think about the situation when setting a flag = in I40E_TX_OFFLOAD_SIMPLE_SUP_MASK but not in the PKT_TX_OFFLOAD_MASK, the = result is going to be unexpected. > + > int > i40e_get_monitor_addr(void *rx_queue, struct rte_power_monitor_cond *pmc= ) > { @@ -1501,7 +1510,7 @@ > return i; > } >=20 > - if (ol_flags & PKT_TX_OFFLOAD_MASK) { > + if (ol_flags & I40E_TX_OFFLOAD_SIMPLE_NOTSUP_MASK) { > rte_errno =3D ENOTSUP; > return i; > } > -- > 1.8.3.1