From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA722A0548 for ; Tue, 27 Apr 2021 04:32:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B16D84003E; Tue, 27 Apr 2021 04:32:02 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 1BA074003E for ; Tue, 27 Apr 2021 04:31:58 +0200 (CEST) IronPort-SDR: RCMUrkWtxO9NpqZMGS2q1y47MYVeKd3XmYYAJXC22IFmNiXxL1kWsxyMMaTIz0sXoKC01agsrl Hypa+BIh08bg== X-IronPort-AV: E=McAfee;i="6200,9189,9966"; a="217140162" X-IronPort-AV: E=Sophos;i="5.82,252,1613462400"; d="scan'208";a="217140162" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2021 19:31:57 -0700 IronPort-SDR: KBXqK4jhuyh5YpTgY418/LHGs3IDLSd/mi+O3acGfaMx8rgvq6Msznw2g0aKnNKOqtPNXEsddi xHXb4U6ohPhg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,252,1613462400"; d="scan'208";a="457434684" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga002.fm.intel.com with ESMTP; 26 Apr 2021 19:31:57 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 26 Apr 2021 19:31:56 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 26 Apr 2021 19:31:56 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 26 Apr 2021 19:31:56 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Mon, 26 Apr 2021 19:31:55 -0700 Received: from SN6PR11MB2621.namprd11.prod.outlook.com (2603:10b6:805:59::15) by SN6PR11MB3421.namprd11.prod.outlook.com (2603:10b6:805:cd::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.23; Tue, 27 Apr 2021 02:31:50 +0000 Received: from SN6PR11MB2621.namprd11.prod.outlook.com ([fe80::50e2:3791:51f4:fc8b]) by SN6PR11MB2621.namprd11.prod.outlook.com ([fe80::50e2:3791:51f4:fc8b%5]) with mapi id 15.20.4065.027; Tue, 27 Apr 2021 02:31:50 +0000 From: "Rong, Leyi" To: "Zhang, AlvinX" , "Zhang, Qi Z" , "Yang, Qiming" CC: "dev@dpdk.org" , "Zhang, AlvinX" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [DPDK] net/ice: fix txq mbuf release mode Thread-Index: AQHXObUw+yYmhZ++hE+UHnS56HQknKrHpezA Date: Tue, 27 Apr 2021 02:31:50 +0000 Message-ID: References: <20210425092639.1428-1-alvinx.zhang@intel.com> In-Reply-To: <20210425092639.1428-1-alvinx.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.193] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 39637818-17d8-4aa4-28ff-08d909249cc1 x-ms-traffictypediagnostic: SN6PR11MB3421: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3631; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: a7iHd+Blu4yjF5v+cnSGYT67ZFq2Eq2M8KBUYzEfJiBYWC8MrJmOYHK2y8XIRtauK5ilhM849Y2dENJ8HZDaEJZaT7xrDCaJEPiPBjCgc7Q0kqt0GPYLtKtB2qgd0ftkl9ZvuWIVRiPSrl4TIWUOle0t4AamKuCc1v4QGyUtoQrzI6ywq2wY6aLgtuOnuG+g6Ph0BQ6kZUE1R8AXcoLwc/hocFIBRVtezTOTHcUGsvD2TV6skftLRVFY1W1k6ajshuGvL6Po/eNM6SCXeGvMjBrbJVbc4BiiC6PvKzwQm5eBaY+M/GUvRBC4Pimkh1pGG7fGww2qz01Em97dQWsVcv4/EFC0IPKsuyXqI43qYsg4LKi808sD3uNP7NTOL0N8vUkL+y0/zoay0bUMtpNRhN32I967vOwNb2kWBYY3il492G/i/NO24rBg8WDTz26MReKeUx7vX++eCnVRF7I8/cOuRw0G2vdVx1mmGS1on3wfhnUXUHCquOBCauvwS/b4yAvWmw7Br0LNavoG/VSRO4MvZBNEPiULKNGfCA7LRppQnuiefIIaJlEnETI3/BlhjDiT3w89IG6uJVSyo8vQdtLt6ywNn46po7k9WeV/QCk= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2621.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(39860400002)(396003)(376002)(136003)(366004)(66446008)(186003)(66946007)(71200400001)(316002)(38100700002)(26005)(83380400001)(64756008)(5660300002)(122000001)(110136005)(6506007)(66476007)(66556008)(53546011)(86362001)(7696005)(478600001)(9686003)(54906003)(55016002)(2906002)(6636002)(4326008)(33656002)(8936002)(8676002)(52536014)(450100002)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?/rQdewzvzDYe17SgDe5uUtMbAY8J65Hm+kNTq1GK96TY/XqyzqXSL89JxRWc?= =?us-ascii?Q?iQ2NKHAgNR9pn7Bew6TTCCRywzXUywO845LKZncLzX/5VuM5kc6XSY3qmuI0?= =?us-ascii?Q?GOaku1TvRCszVktF6W0ZgAYhBmwXjX+eMzOhviEyAOGuk6y0FtYI20dnGeam?= =?us-ascii?Q?ufAIPltDpNiCts4CGbwy2KkcAe+SxuCIcbteVP3WaqWqGAY/c8cmp9IcoU6z?= =?us-ascii?Q?009J9/pUG9f5cdNN8tgZ5WWSopmj8ZseXVACt1Jyh6xnTxWHsmscBcJ5jaBS?= =?us-ascii?Q?Kkkht2qRN+OhH+AeQANos50piKFGok5u9tLXWO55W2KPcUNan7Lep+tkE/c5?= =?us-ascii?Q?DS/Hzf2tmNn6lzzM6poJ48tU5M/xHtfReXGnkt9Gy0ZsXoVH4Qsh1ul9CPUx?= =?us-ascii?Q?ECnyLNgssu25mRSTVLlWU68rmXog872HPK7KJFlCBRE4Bzj3x3wANsYmpVDR?= =?us-ascii?Q?62W980b0spwrIBak0tJiLyqtZ208MBvlfZi7YKJLg+oSdUEFkMN4DB2J8LfD?= =?us-ascii?Q?7a7BOe+RnzLlEqtbWYoyRFUoQLdlXyWtfUA0HxxZMrDyOAdHNBLRcDnq1irE?= =?us-ascii?Q?KoB/CBReWeDHOVGAs6PqqwyAnZsUXPzUdPc30WeDL0Svp/ydXqb1qOFQoR9r?= =?us-ascii?Q?2jKuEN8fZ4c6otjjyXzYiusHbewiB+j0vya11Bv/+YIMM3wX8LHDBdjrDO5z?= =?us-ascii?Q?f8lomh0tcwaIK1qOhIVQFpRb5I+W0d7iLg1YSGUtFSSkp8NcZadSEORyGRc4?= =?us-ascii?Q?d1in5gkLZyFFLEteTFslGKZ6wdWhv7GeZbimRdltYehT77EP9WSYeHy/1H+5?= =?us-ascii?Q?gHCX+JDJm832bUWTZrUA6QNtwT4fudvegR9WPsvD9h4waEPqB6pXU51D0Lsl?= =?us-ascii?Q?4BUA6S/KchFaCN0um1P52Bna3z4zYDlvrIpivm2oYVQ7ohnzxWfYK02Mzl3X?= =?us-ascii?Q?j7nJrdymXaKR0mymvVa+Uwl5U31N6h8lJmGU9hiNMLB3C95TM3eMozWD8MT0?= =?us-ascii?Q?H5bTJfHoFat3QUjuVTt/fEgDqETXORB0315iiop7jNQ/UlW10SrXmS8otumH?= =?us-ascii?Q?i2wEknpV/MXW8vxVzPJQdgiHzF1lepgJqY4G/sjXkexG67MHZIx04nBmHqCV?= =?us-ascii?Q?17eQv13PWGvYOpBT8ks70O8ErySh8ZETw0XrAiyYdi9PYJGRY7yP6/hE2Oid?= =?us-ascii?Q?2wmh0tI03Aro8+4v/L+ilRWbHovWvsnFK0e9DQjWQTGzVuPgY5bRGfu1yY0M?= =?us-ascii?Q?hgN6zvXcmby4KHkgmXVk4iIaMwPBzboiJ3MTbV5vfiy5CfapOqSRaRpUp5Pm?= =?us-ascii?Q?70I6gpOeTGIlcxQSV68JnXyP?= arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h6cuLhFjL0hnoUr/ZDOJh4TKgCjnQkA7DlihwEx2sEuVS48e/UMZgN6j5Fnnj2hddTGHct27XP0MvRgaqBUAsg45yvAu4r+nePkUc0wXpfP8/pYDLrGk6zTGFjMK3ikaCN8kEUL4Sj49jm7XpwGmZKDwXOd/67fX3twA4b6vT6Kzk+46tEX4LVWbeXonsM9JUmobVPJCgSyU88f39dbhlvJzB37YqJBSX7LR0Cgj/RHUsKi4YJecVj+WGYF2v1VA87ioPtghg84fYTyVcdBpqCvTIHZONjeXK9tp0afRePZnXWLLLvvEUBW0C29n7SZZ7WIiY/Hf7b2E5M3/fetyyA== arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DoW8ZTf9aLj4gZhFNn/JPaJ0Purm8HOhib9bw5Cy3cA=; b=aZEVwjumzd8hzXMI4CZM8TkukqXEWAU9hNWUnkbV4JoUV9zPtcjt358PndobsRRAuZ/rY4EtpmWO1I2eVVZo1uuXoLEoRO/UVB8FE2wJT7165VzMrU7kBMTtggywGS8nlldxvtNhoV0NbcZjvj674tYm0eWvmzUCU/wX6q8l8s5AZtSab0cwqjSRILkxWJ/qzZk5ax1uLjoUfZoL0duqvgJrGnzzzMDpRBsgvAMQUZZDsD3BAu6gnxtUGBoaqSXlhKsIBr4VXr77KFpC+bfWXcokX9WjSlFL7rU/2w5kXZlGbpI06OnyOdr/s/0Tkri3hNTeNT8z1tT9KrJQ3jsFQQ== arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DoW8ZTf9aLj4gZhFNn/JPaJ0Purm8HOhib9bw5Cy3cA=; b=SKP556pYT99jPxAE5H9aTQtIubMRRbqt0LUnvK1oxXXTACcOUxdpmXLfpKOtUXx+8mzveVfuaLHnpjBq1ej+b0h62xJOmM8xGBLmx6u7F4BjVcSykTom3F5Ka0oNWfxk956MksMtl99WheUups79ls9EtLC1OV43eq/Wl/4tOCg= x-ms-exchange-crosstenant-authas: Internal x-ms-exchange-crosstenant-authsource: SN6PR11MB2621.namprd11.prod.outlook.com x-ms-exchange-crosstenant-network-message-id: 39637818-17d8-4aa4-28ff-08d909249cc1 x-ms-exchange-crosstenant-originalarrivaltime: 27 Apr 2021 02:31:50.2053 (UTC) x-ms-exchange-crosstenant-fromentityheader: Hosted x-ms-exchange-crosstenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d x-ms-exchange-crosstenant-mailboxtype: HOSTED x-ms-exchange-crosstenant-userprincipalname: P3zT5sQXaKgsMx8J24753UEunAd3UkM8ERlVlRmvUcyjgw92FLE9kLsEyTxnp3K8r5c+9It98O6TLAv8C37WKQ== x-ms-exchange-transport-crosstenantheadersstamped: SN6PR11MB3421 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [dpdk-dev] [DPDK] net/ice: fix txq mbuf release mode X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: dev On Behalf Of Alvin Zhang > Sent: Sunday, April 25, 2021 5:27 PM > To: Zhang, Qi Z ; Yang, Qiming > Cc: dev@dpdk.org; Zhang, AlvinX ; stable@dpdk.org > Subject: [dpdk-dev] [DPDK] net/ice: fix txq mbuf release mode > > In some cases, it seems that the txq mbuf vector release mode is enabled = first, > and then it is confirmed that the conditions for using the vector mode ar= e not > met. > > This patch puts the txq vector mode startup process after the condition > detection. > > Fixes: 28f9002ab67f ("net/ice: add Tx AVX512 offload path") > Cc: stable@dpdk.org > > Signed-off-by: Alvin Zhang > --- > drivers/net/ice/ice_rxtx.c | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c inde= x > 92fbbc1..49abcb2 100644 > --- a/drivers/net/ice/ice_rxtx.c > +++ b/drivers/net/ice/ice_rxtx.c > @@ -3303,13 +3303,6 @@ > if (tx_check_ret >=3D 0 && > rte_vect_get_max_simd_bitwidth() >=3D RTE_VECT_SIMD_128) > { > ad->tx_vec_allowed =3D true; > -for (i =3D 0; i < dev->data->nb_tx_queues; i++) { > -txq =3D dev->data->tx_queues[i]; > -if (txq && ice_txq_vec_setup(txq)) { > -ad->tx_vec_allowed =3D false; > -break; > -} > -} > > if (rte_vect_get_max_simd_bitwidth() >=3D > RTE_VECT_SIMD_512 && > rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) =3D=3D > 1 && @@ -3329,6 +3322,15 @@ > if (!use_avx512 && tx_check_ret =3D=3D > ICE_VECTOR_OFFLOAD_PATH) > ad->tx_vec_allowed =3D false; > > +if (ad->tx_vec_allowed) { > +for (i =3D 0; i < dev->data->nb_tx_queues; i++) { > +txq =3D dev->data->tx_queues[i]; > +if (txq && ice_txq_vec_setup(txq)) { > +ad->tx_vec_allowed =3D false; > +break; > +} > +} > +} > } else { > ad->tx_vec_allowed =3D false; > } > -- > 1.8.3.1 Acked-by: Leyi Rong