From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 744C2A0C3F for ; Mon, 10 May 2021 05:28:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 470684003E; Mon, 10 May 2021 05:28:02 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 609DF4003E for ; Mon, 10 May 2021 05:28:00 +0200 (CEST) IronPort-SDR: UbydULvG4XwaoB33gBHaZojhBTdOHAbVclKMOPTc0jftT8M0Eqt19CVbUpAAhbhVjvSq+gkhn6 PYtHnPDbtufg== X-IronPort-AV: E=McAfee;i="6200,9189,9979"; a="198779015" X-IronPort-AV: E=Sophos;i="5.82,286,1613462400"; d="scan'208";a="198779015" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2021 20:27:58 -0700 IronPort-SDR: Tsk+wdXIRPiIrsyPmhZgO84Umob63DhbFaK49PNjdrDwCtP+yIVkfPPN+Ztgvc/uo4WcGKjJ03 hJLFiDBuopYg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,286,1613462400"; d="scan'208";a="391772922" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga006.jf.intel.com with ESMTP; 09 May 2021 20:27:58 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Sun, 9 May 2021 20:27:58 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Sun, 9 May 2021 20:27:57 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Sun, 9 May 2021 20:27:57 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Sun, 9 May 2021 20:27:55 -0700 Received: from SN6PR11MB2621.namprd11.prod.outlook.com (2603:10b6:805:59::15) by SN6PR11MB3390.namprd11.prod.outlook.com (2603:10b6:805:c0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.26; Mon, 10 May 2021 03:27:52 +0000 Received: from SN6PR11MB2621.namprd11.prod.outlook.com ([fe80::50e2:3791:51f4:fc8b]) by SN6PR11MB2621.namprd11.prod.outlook.com ([fe80::50e2:3791:51f4:fc8b%5]) with mapi id 15.20.4108.031; Mon, 10 May 2021 03:27:52 +0000 From: "Rong, Leyi" To: "Zhang, AlvinX" , "Wu, Jingjing" , "Xing, Beilei" , "Zhang, Qi Z" CC: "dev@dpdk.org" , "Zhang, AlvinX" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/i40e: fix offload flag checking in simple Tx datapath Thread-Index: AQHXO0OnAcBMkTzYFkWFh7dj25lX5KrcIHVA Date: Mon, 10 May 2021 03:27:52 +0000 Message-ID: References: <20210427085859.22376-1-alvinx.zhang@intel.com> In-Reply-To: <20210427085859.22376-1-alvinx.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.209] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7bcadc34-fe12-45f5-1313-08d913639848 x-ms-traffictypediagnostic: SN6PR11MB3390: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: E5/uYLQ5mD9CCl0RQijEOEL2uARvHFChtKqFzcFY3Vj80e5xhRuq8JHfjQ45mT5557zmPnBiSMaf+tn/gWKkHqRysvNrC9a5VgadSQVRHqlB2z2LswKO9OEgV1GeKLG0cHUGpe40IBIksTpP6FuYfLNxxusulbck+lnwCWOKOs5zG1Si6jT8a+uVgnu9Fojtt8FbvuHd/A+de3WKs6sm5o4P6eau0x5k632Ip0zGR0Lg5NAyl3/ylFTgZ7r7CVknyq1nlhN7LmE4VazpJbE0GcJlAwSVkZrhjqotKR902xFIPFKlPQTA/Ct9lJ9RndtP75Vo3c80AmBqbZlJq8p2wgeLQCuRRLXHxFcHJpwPwid3fk+UgId2/3g2VNqfrTH1a5dagebkhgcWy4hmr0mqbSGlrT6legKiD/2/9Kffu4o0EphPINOrvEApsiebbqoaRmjRY0QShpA/2HSlmQBsCU5EK63aD6lsf4YppxSOvMjJ+dHM2g6tzknl2IviZ3i3mDxEBUllkbiBcg2SKniaVdMKBqJI/wrkYBxQqdF3TkgWuUgK+oUcvEVZdHgJ/KrlPTyrJS8+Y4/1zL0PeIqe8cnwHBG0id+PqmlLXkwir4I= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2621.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(396003)(376002)(346002)(366004)(136003)(39860400002)(8936002)(7696005)(478600001)(122000001)(8676002)(66556008)(71200400001)(66446008)(4326008)(9686003)(186003)(64756008)(316002)(38100700002)(5660300002)(53546011)(6506007)(66476007)(66946007)(2906002)(26005)(52536014)(83380400001)(33656002)(6636002)(110136005)(55016002)(450100002)(54906003)(76116006)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?1T2+hTwHrEfmeFlz4FvY8Q1rXH4ClvvdnrZ2uAq0oUyPplO9TWcqKqzidFr0?= =?us-ascii?Q?y4jhYt11MLsc2+vpd39XdMV125g4aQazhQ65MzR2jZSrBRX46XdyNsvzMOfZ?= =?us-ascii?Q?WSxjwcU6XP64Kao05pMoogKsz/b9FF+3T6PhQi46VCSXtlzDVLG5FNsX8RsZ?= =?us-ascii?Q?0bkSKtyGgviWFEDsFhd+13I2plo+fgUyEy3Sx8Mv/mR/0SDfWbywq/0xoBZX?= =?us-ascii?Q?DuGF5ASqMJu9kK9gifq8C12fcbe2xZ9y4LouUGEvq8uOUIhLH83/cFv8JbJO?= =?us-ascii?Q?e7wDvX1PKnpC/UoZDA6oBHbsgcB1tQatkUuaFuSGwgoTT0OfeOHvbmSwrmPZ?= =?us-ascii?Q?iytyc1oMXBK5jv/1afeqE8epcikWbp4Sy8Ran6VCXhlihomHtZ/xIRDEv8en?= =?us-ascii?Q?lsfLGwMgixQpOQiuYrZI5f92W8rVTfkEaALK+2ilDDccShRi1xE+4BTO5gnM?= =?us-ascii?Q?P85EB2b0XOZNKXQ4RdfEhacUvdXegjzBDrzaPpZbA1G0EoOZOqYDZxC7/pxn?= =?us-ascii?Q?lfpnjUEH8S/zgv4XC22eVZBdh1yQ39O7n0jjzgyCId/dyo6PZO1keMfdnV3z?= =?us-ascii?Q?65QWfIcGr38KRiQTZlWmp0Oy5bcGDuDl9ZCksHCHm33/zbROvVeLp+aeyzrM?= =?us-ascii?Q?kHPFAlPIqad7xNrNGIIi2JSSoSGaNL+xLzOWOaIHb7+AlaV3KFHU0XL90eXL?= =?us-ascii?Q?aqDpzcjsZCoz3/h1g0pCco1qyuo84xdQakkZAdjL/Md/lT4/dJyOm5wBOr9y?= =?us-ascii?Q?t43bBN5UNlSCHYQaN1AkcNGIIttEWZCMJKwsxBR80G/lyzC0/7tSFMg/dUo6?= =?us-ascii?Q?nyVGZgeG4Y4Ac0XhSAsycmPQFs8hvzqZmCJ/5fcdjh0dFl2HN8vvXnFuG/Jd?= =?us-ascii?Q?CVYsEhNwKWuKjp9RwiSWHM4X/XmLtwUfLxzb8pcAQLyfrx5uTYD2Aowtdms5?= =?us-ascii?Q?yL3a3UyB6rVnQ0vMkSDZWtJzwU8aZyC6SFi9UgXeVOxYMEld+Eai5YWlkUyB?= =?us-ascii?Q?hNtlXI6y9QHIAIqYonXdgybf4YlhOLoaI/1bajyWxrphPiKVate/Ohbj8ap+?= =?us-ascii?Q?Vq5i+BBPZ7Wor2DC63RvP1RO7qFOstXDjetzg24QcBqtLqnlyZa+gmbgfVgs?= =?us-ascii?Q?AoeVYHnxOX2+8qQQsorLLwAg/WAV9ZNZpO8owXxy+QsB613Pz5izPvs6PPOY?= =?us-ascii?Q?3A66qq3lBa3AfsDx1yPsUnkEmgEK8mPursDo/SattKm/OVufJy5aK6OQUZrC?= =?us-ascii?Q?UCRkNm0w/N0hadDGPogs76bjIH5aKiZJ0lZ2I1qnJSzu0pjUci950syHYMmK?= =?us-ascii?Q?cj3tq1Y7SGiTm8o7OwKsOfwc?= arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gIHtbyU/PdwrPagOWFzXXMZb9X62W9fvGHU0ya6RSkVUeTGrHAlTNNB/suc1Zahes+a70MJE/ckw3JXeGbYGYnDX1xWOxmLxOa2WCtRJ2nH8coV0VDCavNsDYVKq/dnNu0/h/dxbk2UCZPe58FpsYZViyuTTo4ceT4kOnmI328G4MQYOOzGbM+LwN83P8hBohqZ07VEgai7MsY8Q1LGj2M8ysqAeUi2n6B5IojXMXmXiITQvw54eEUx1pqiJmPAF3agmRBhgp0IFcVyhth0CFg9/5gX5yW9dBpDfJhZchOIAWDSsePIS1r5oawGhAO3Z8S3LCCpoA/RnHNuO+jXRLA== arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1AjwbgbA0NTPlj6UUvJTPT6TpHSZ3l+Z9XtzPhTzgyU=; b=Njl7DTRDH9mebvjCz5nd0kwUldeNJ/CogZ0A2USw2gO+zMGDvMeKiBbi7c2cYrqzcM+yKxrPFGKCsvZHqxi/ljZu+hsOZgiNhoZCm4kCQ4s9NVNGOiYbKXjeCFQysZ4kfaLs6XAADIqn1C9R8DoZQo8klf28YCBR2cR9hBrr0PP/OTfcUJms87eGO/kciQoaxmXyY5c7w6/aWLj6hd+8d6DXncKS6llCKUvVG4mv/M1EYUbkxzTeMx0hqGBORL7xWn2QULlEiX1cHBQqBlmgMpZCpvjds5o6Tzolt7LHRynt4tKl+U0Pb4V0MWIbO6DC7RSmEz5TOrl5IPkIjovRGg== arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1AjwbgbA0NTPlj6UUvJTPT6TpHSZ3l+Z9XtzPhTzgyU=; b=RWnIgnzOYPDlelqakFXkNHfm4PaIuxstJrgyZpE9b1PjJDLUo6HRIFV83X11PpBRZ4YsXdEjXft+MjNADyB829AR4GEuzaq8sP117y4OmjY8Q9R9lcAIoDVcEHKNI/mj9uBrIk3sRaKbmQB0uv5pwKwxDyevIeLyi+36pWtNPvc= x-ms-exchange-crosstenant-authas: Internal x-ms-exchange-crosstenant-authsource: SN6PR11MB2621.namprd11.prod.outlook.com x-ms-exchange-crosstenant-network-message-id: 7bcadc34-fe12-45f5-1313-08d913639848 x-ms-exchange-crosstenant-originalarrivaltime: 10 May 2021 03:27:52.5627 (UTC) x-ms-exchange-crosstenant-fromentityheader: Hosted x-ms-exchange-crosstenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d x-ms-exchange-crosstenant-mailboxtype: HOSTED x-ms-exchange-crosstenant-userprincipalname: SFV3E/OuJBECBlalhaioLsycpA3FVgbr1V3O8fzofkMu8dXIVXyXX+W2LtEebiv8Vb8I6wxhqjqrrN5Q0vH1RQ== x-ms-exchange-transport-crosstenantheadersstamped: SN6PR11MB3390 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/i40e: fix offload flag checking in simple Tx datapath X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: dev On Behalf Of Alvin Zhang > Sent: Tuesday, April 27, 2021 4:59 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Zhang, AlvinX ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/i40e: fix offload flag checking in simple= Tx > datapath > > For Tx packets, if no other offload flag except 'PKT_TX_OUTER_IPV6, > PKT_TX_OUTER_IPV4, PKT_TX_IPV6, PKT_TX_IPV4' is set, the hardware doesn't > need to do offloads for these packets. > > This patch removes those previously indicated flags from the offload flag > checking in simple Tx datapath. > > Fixes: 146ffa81d05e ("net/i40e: add Tx preparation for simple Tx datapath= ") > Cc: stable@dpdk.org > > Signed-off-by: Alvin Zhang > --- > drivers/net/i40e/i40e_rxtx.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c = index > 86a9eae..48d0582 100644 > --- a/drivers/net/i40e/i40e_rxtx.c > +++ b/drivers/net/i40e/i40e_rxtx.c > @@ -1501,7 +1501,9 @@ > return i; > } > > - if (ol_flags & PKT_TX_OFFLOAD_MASK) { > + if (ol_flags & PKT_TX_OFFLOAD_MASK & > + ~(PKT_TX_OUTER_IPV6 | PKT_TX_OUTER_IPV4 | > + PKT_TX_IPV6 | PKT_TX_IPV4)) { Hi Alvin, Could we define a new macro like I40E_SIMPLE_TX_OFFLOAD_NOTSUP_MASK as what= I40E_TX_OFFLOAD_NOTSUP_MASK did. That would have nice readability. Thanks! > rte_errno =3D ENOTSUP; > return i; > } > -- > 1.8.3.1