From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ABE2D42B2C for ; Wed, 17 May 2023 18:46:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A52E041611; Wed, 17 May 2023 18:46:19 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 3731B406B7; Wed, 17 May 2023 18:46:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684341977; x=1715877977; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=zpiMvtoiUQtSARr4tTEXfYu91pVV49PNzCCbt32HsCk=; b=IQDLE0pfbzRo9POdczrLk1ZnMXGnlhqNwhS/Gr29Y3mIQko0Jj6gqz8m yyG5o/c6wAu3Yor2xHTZnFna9x7gwDHmBr0tiEMO8L7w1zU1eQRZPjg5n wFWQuKmocz2MncNOJ4w3fdSAb6zcIoIxfXOzql2H6Fb1ZsJIc5/ugXRtT wk/Y7HWa5hrlddu0ZvuYWss71Z8oCHjI5IqFNzju2isk20/oB7evLslfJ BZ/gKozqxvCnnatD1jt0NIHwr2sJoLlCgoiEDwcb6oL26qcvRwoDFZYnA vkO2UlUKvJ1zyLF58EwVph8ZHJ1rKnFS9lDdgnzGJIMnuw/sN+CIxJ8l8 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10713"; a="350647965" X-IronPort-AV: E=Sophos;i="5.99,282,1677571200"; d="scan'208";a="350647965" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2023 09:46:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10713"; a="826026749" X-IronPort-AV: E=Sophos;i="5.99,282,1677571200"; d="scan'208";a="826026749" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga004.jf.intel.com with ESMTP; 17 May 2023 09:46:12 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 17 May 2023 09:46:12 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 17 May 2023 09:46:12 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 17 May 2023 09:46:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cKKQAOvTIp7F4Fuf888m3Sx59w7VhuDIRrkDCbOJxvogPgqiU4QjoVpRaH4TJGxze5hipP6MG/AKIodJeNozZjFVFEOw7lcs9WTryjAir7PZUgBsLYm8Dl4xTTb+IpvTS/3lyvAQA5A7GeJu7fkC27LxuVIa2PFt/48v0qDs0VsshJY4NNVpFr6A3a17HK1RAl0ATVqqFS59RAvb5ISU+0Qby6Nkpcj9QEZC0iw/C597ojq6xz7xhgwyDjF03fKnq8Vq+Qefr04+yqRJ/OKur/xInVXOKQq0Q+TDNDDiq6uHVGzue02HEEXUPZQB0a1vDGbAySVTiawjfzgq41IeJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rENbLK22GutIuBfs6ELf0qih0U0MKvFfmOQXiNvfljI=; b=jRWuF6cp34PoFWJK9qs9uMKbcR33OcWhUNiycgtAYGyL1tgbzr/TUKExrq+lbqU6jkqMdC867z0UcZByZaYyUnEv1EiaEiJJxwd79TtyGDtrQOSUV0ayyYDJEB8UBFlZH6bio/9qyFR0gXiylbybgjasW4i9sR4AwJ4XTbDCUQfF/kSaX9qFgoyaHzVTPcvHsMEWSHnhiAHEclwATY/tV9bCvn8QcmXSPq0jyDf89r6jMTGkxmhSeBhfmCgCQIkeAwaZEPDuZrL+TXh4sQwYesFKc0FqavGwyvlsmrzhaFr3SF4H7aCJnuoXWasdrlV3H6u2ahG+JeTeFJmPP5KQgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3408.namprd11.prod.outlook.com (2603:10b6:805:bc::22) by SA0PR11MB4734.namprd11.prod.outlook.com (2603:10b6:806:99::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.17; Wed, 17 May 2023 16:46:10 +0000 Received: from SN6PR11MB3408.namprd11.prod.outlook.com ([fe80::7bfe:acda:6bdb:84c2]) by SN6PR11MB3408.namprd11.prod.outlook.com ([fe80::7bfe:acda:6bdb:84c2%5]) with mapi id 15.20.6387.030; Wed, 17 May 2023 16:46:10 +0000 From: "Ji, Kai" To: "Power, Ciara" , "De Lara Guarch, Pablo" CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH] crypto/ipsec_mb: fix allocating mb_mgr in session Thread-Topic: [PATCH] crypto/ipsec_mb: fix allocating mb_mgr in session Thread-Index: AQHZiNI5ZbYcAyHIrk2n0Q8S3T7mqa9erHnQ Date: Wed, 17 May 2023 16:46:10 +0000 Message-ID: References: <20230517151339.1047237-1-ciara.power@intel.com> In-Reply-To: <20230517151339.1047237-1-ciara.power@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3408:EE_|SA0PR11MB4734:EE_ x-ms-office365-filtering-correlation-id: 99c6c946-472f-450a-8be1-08db56f6380b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HRxrN2yYziwqasUcZKqHjwwdz7KEK6ObtkbekR13VelAqalxv8ao6tBWGk+I3RQGhhMhlWHcFrg4NMFmJRoUbeQ6Itn5rQfDuhkdVKhY5qG/acmSS/MM79dBgikD9Zdr5N6m6cmmanpTgifnqVfm2AcQq99tXYzQW5PO0ukmsVUIfVfAD/yu3aPI4uSTokveiDBYmTZjBPRQhMlpR4gzS+1sqWfjsXXz0PokyG2sBPyPHP3EvNd0AL3iXgtVIp7gAgkQnXxV9HaBdOdvgCcakjM63YpNAVhmObi3rw53XAM75Sug5Br+/NxPlrOJ3GRLnCnixKg2U/vM/pCJMZkU6uRn9V8lXk0tWqQQxAll+EP9qC87HrlVmHpN8lP+1XG1kn4abwtGxx5PnqG6r0O4ehxDYwtAxF+KSX0+R/mxGtvzJU0n9AA9uywdt8ox8nor6w3i/wGp7bpDs1X+HeDT4LZqOLpOprJiwiFFUeFA3XQN8nKn5Mi8onAq/6pqV+GdGdXcahbEEAZ9l0ryw5Gn2bdnYvlKTke8HR73tpfdGsjxbmyIMbTkkMZou7BfS0xQxsrH1PmRCcp/iJqzg9qpz2AddC87Ke1fS8zN9eYuDHg9Wer8jiQ+pJN3T8S88K1z x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3408.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(346002)(366004)(136003)(39860400002)(396003)(451199021)(7696005)(478600001)(71200400001)(38100700002)(33656002)(82960400001)(55016003)(86362001)(38070700005)(83380400001)(186003)(26005)(6506007)(53546011)(9686003)(316002)(122000001)(52536014)(8936002)(2906002)(8676002)(41300700001)(5660300002)(450100002)(54906003)(110136005)(66476007)(64756008)(66446008)(4326008)(76116006)(6636002)(66946007)(66556008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TcQ2HgL4FbLRX46T8Z9Qosc3kmI1n+sFcVlNM02/KVt9Hz+94eQ1WDW7K1gf?= =?us-ascii?Q?jD/V/XbQG63PDJ4cSp+WRItao7/HLk737K+Q1P16z6IROUQ2LFVOrHEcd3Gr?= =?us-ascii?Q?lJBLT9+//god0/PBFlnPJXrRePfx9VyfjGzvY8jf7gCmnQ3qgqQOG/jr8Qf/?= =?us-ascii?Q?OCTXPNLnGs1kpi1kNGe00Zcw/lxIk4wMyjU3XRl6TaUIUoCwy7CbcpQU6o50?= =?us-ascii?Q?EZAYse4B7hGBYIvUPnA8qB+BpysgAL3xBOWscaOaRaGL/k0QMeA078FFALZ8?= =?us-ascii?Q?tQ3hbmHBZDRdg2d1B/1wIMCS+5We58EPZmlDzo/E7IMYMWSR0bPAATYWW1Ip?= =?us-ascii?Q?Bl3MSFVeNduI1icXosmNuRgUCxzOoUR2tfTD1y6QUzAcFM71/ynPckCphO+M?= =?us-ascii?Q?DxlG3iWv2yTJjNZga0iA4evJ1rmniBgUcTWZU+PSKyiu6CcMNQo9fDA33r2G?= =?us-ascii?Q?QAjZfW+q8XQZcmVDKQSzywtg611WS6iC6aPcTynw3A7WjumWW6eVUDJtgn5l?= =?us-ascii?Q?jVamUqdRd2ve7wkizY2jKm1L0tSLHvkW/238LjDlp39UbSVtpdgXHmX5e+29?= =?us-ascii?Q?Rt2Vo/vecoC5qOOkgP/tZgWbMV5B0G7dyb1s5SZ30TDKIK9D1RFXySpHZ7AR?= =?us-ascii?Q?rM8rz4VNjJVQhQrGMzUlGiogBAxDHI6VS2Oic/yk6Hu/KP0z1jVLx3Q+LiVF?= =?us-ascii?Q?jBwRPH+Xi7hwDR1qq3fOy7uUcyJ0zgh+IO42BNtYiz96oWjg1yEo323Dux9l?= =?us-ascii?Q?Hbv7uoiP9xCd/G6ZqQfFyiN1Y695KxYWJJJpv4hvwocD8RbkFWQbcYVBB9t6?= =?us-ascii?Q?6tJ8iaR/sfXETTHETDQE/xIPlGxHoXGI/VRKJNy/j9mqrN/VVIU7DhVh1y+P?= =?us-ascii?Q?Sc5ZFs6sWkI9qeMzupIdLD3tB6KaHwPQAJNIwwyViOtODiDxYKC4aTSPJmDg?= =?us-ascii?Q?RPjdqIrhO8ygRyjZfUIcN6z12FopuCGFWU2FuofTKncwvJCCLNmBHCry8iWs?= =?us-ascii?Q?9zKuLRPPrylGSuggtQv8ntljOZT6wLcNLvRPoP5kXi7NA21Xcie/AjEtqHei?= =?us-ascii?Q?BWgBSjlGRGACF2YiKvw0bmIavQG9IMMvgiWO0dn4SbaPGvSgQUN+IStqhqxB?= =?us-ascii?Q?VAShkUKf4XfLcYiR0Smlh7IyBtyb+rvX0/SQY5ha+yxMQDnw/jnvvHWsxsTr?= =?us-ascii?Q?v3Of+dN/Sna8iaG8wyEGgCuoqJLk7StqwRnkHT9QRoxLu3ds09s040cnt0X3?= =?us-ascii?Q?RxY1jY6K4mHyqSAbUf2qaP+7GqCuLQ4lpDA/1M8S1BncTHgGaU4Vejy6r3wG?= =?us-ascii?Q?7SG4ikc+B0s7w28Ss3tLlksxmgl0nV7z7h8hMZYIR4IQ08/UehTZSVv4PUix?= =?us-ascii?Q?9b7lWI8wmoNvPTfbBPKJ0x5PhBRRMWU+OvXbN0jdPiX84FXuxqFb4rMVQIzV?= =?us-ascii?Q?ayRPAkHIkQn5roxhah+Nd4SfUkljSCIo1crdFh8qdafwQhlKO0fXoDsQtOiU?= =?us-ascii?Q?KjrN939KezFjWNt4U4mIGXXQPOYIUidiQRWIYpPRINGWIavQszEuJcWb6LoU?= =?us-ascii?Q?ATfgsY7ozpOy44VJgCU=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3408.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 99c6c946-472f-450a-8be1-08db56f6380b X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2023 16:46:10.5128 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0qo2+hryjj5eRGlhnPlchUBJMDQ05T1nDns2tkhbPvjExCC4CHvkeeApEmO8ulx3avaE8+HQd8Gw8TT+XuwcMQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4734 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Acked-by: Kai Ji > -----Original Message----- > From: Power, Ciara > Sent: Wednesday, May 17, 2023 4:14 PM > To: Ji, Kai ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; Power, Ciara ; stable@dpdk.org > Subject: [PATCH] crypto/ipsec_mb: fix allocating mb_mgr in session >=20 > When configuring the session, use the queue pair mb_mgr that was already > allocated if possible. If this doesn't exist, then allocate a new mb_mgr. >=20 > This reduces unnecessary cycles creating an mb_mgr for every session > configured. >=20 > Fixes: c75542ae4200 ("crypto/ipsec_mb: introduce IPsec_mb framework") > Cc: stable@dpdk.org >=20 > Signed-off-by: Pablo de Lara > Signed-off-by: Ciara Power > --- > drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 17 +++++++++++++---- > 1 file changed, 13 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c > b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c > index 3e52f95674..f9ced8afc3 100644 > --- a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c > +++ b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c > @@ -434,15 +434,22 @@ ipsec_mb_sym_session_configure( > struct ipsec_mb_dev_private *internals =3D dev->data->dev_private; > struct ipsec_mb_internals *pmd_data =3D > &ipsec_mb_pmds[internals->pmd_type]; > - IMB_MGR *mb_mgr =3D alloc_init_mb_mgr(); > + struct ipsec_mb_qp *qp =3D dev->data->queue_pairs[0]; > + IMB_MGR *mb_mgr; > int ret =3D 0; >=20 > + if (qp !=3D NULL) > + mb_mgr =3D qp->mb_mgr; > + else > + mb_mgr =3D alloc_init_mb_mgr(); > + > if (!mb_mgr) > return -ENOMEM; >=20 > if (unlikely(sess =3D=3D NULL)) { > IPSEC_MB_LOG(ERR, "invalid session struct"); > - free_mb_mgr(mb_mgr); > + if (qp =3D=3D NULL) > + free_mb_mgr(mb_mgr); > return -EINVAL; > } >=20 > @@ -452,11 +459,13 @@ ipsec_mb_sym_session_configure( > IPSEC_MB_LOG(ERR, "failed configure session parameters"); >=20 > /* Return session to mempool */ > - free_mb_mgr(mb_mgr); > + if (qp =3D=3D NULL) > + free_mb_mgr(mb_mgr); > return ret; > } >=20 > - free_mb_mgr(mb_mgr); > + if (qp =3D=3D NULL) > + free_mb_mgr(mb_mgr); > return 0; > } >=20 > -- > 2.25.1