From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C848FA0540 for ; Thu, 10 Nov 2022 02:54:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BE96C410DE; Thu, 10 Nov 2022 02:54:46 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 7C8C8400D4; Thu, 10 Nov 2022 02:54:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668045283; x=1699581283; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Hdqhak9TTke5fyBCvc3gx+hhWvGPMjBDR5CMJgJQCTw=; b=ftCXk0AJclsYHUIkWsRIJbjWg//AlmeIzRMeEd/3assmbPrB1gPkE6FU IYXcCuP1W6zphsFIenuarDWC9iajdePiMC8X5K1129Mhj2Dv0z/drEb6o 7/K7dCroii0tvsupmHiugu+GvrGT0Z2g5KZDiasHi8uXtlnItpTO5S/P7 +NYD0uj0Tg40kPApqz/7GSuzZThbpO8wsnVBoM0k14UpeEu93eB0hg+Sk 2XPJaNnWZPCd48k1y6aBtxy3kk+h7MHfLOrj3LzIjgyBAyRu0fSWheMKB l3MJxnM5IUusj5ujeOqhLcVYkn+c8uNLad3DXz87uGSyRnK5EWe5KOhmg w==; X-IronPort-AV: E=McAfee;i="6500,9779,10526"; a="397476067" X-IronPort-AV: E=Sophos;i="5.96,152,1665471600"; d="scan'208";a="397476067" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2022 17:53:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10526"; a="779584657" X-IronPort-AV: E=Sophos;i="5.96,152,1665471600"; d="scan'208";a="779584657" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga001.fm.intel.com with ESMTP; 09 Nov 2022 17:53:52 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 9 Nov 2022 17:53:52 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 9 Nov 2022 17:53:52 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 9 Nov 2022 17:53:52 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 9 Nov 2022 17:53:52 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gQiEM4/wASgIX/GS6GLOHZCQslF0rlMnNI/BpTRUrRUbMdW94JSxptMXCYc5epzfMPEzvL44OUcHTov45ZnJ7LfnoVwp7KRCw7Y1+pu82hOy7lpJxSk1FI2oKW7dnoRgWYlKqdot5EU5OYi0wnTCEbqqjYqAQ1F6mYWeLbSBxU6eYKMGe58RzmZl0XF5yZAtsF5Ttmh5CPzzDGpEHVBUw5GyM/uSFw9/AMYHlTTA+H7ypRKsvBTxrnPFILlMk7ccNvHJLd7JBWPAuCs8P0Ro9B37H35EyEi2sfMrpwNJI9OKZTiTi4Hk0aifsRJY2khkmFjtZoSY9SoSbAQolQRKMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4q0xDeG6cN9iV8m8ACj/rxvUpCM4w4YV5coRus+4gmU=; b=n3CeTWGpYtPPdfr9mt0gheW6ORSFwPA9Nnm+p7HVlY0NKLkdeX7gnzBaRRdpJP3QRzOl2KPbIjnrp/PIkUPbBerQqRwYUqY3SSkEeSew548Vb27sthmr9q7Cn4b9ru4q4MSm5ElIUR5P+MK//Pq/vKU8JU5fI8YBClscpHLaSGSjkfjChP6nopwdr7RvV+973fqzvLYiTQAApT1+J9UdtSCXLGb5O7A6GtRHshiFuCwgaKeU+pXIYBL6JSIdK3YdT2X7s8RzRZPjBxrZBhATGNPfMML2s1X6jOOxaSbOF478AUg/FSJA35KR7L5W+SctVEKFCe9u2XgIuKkcAHMSgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by SJ1PR11MB6108.namprd11.prod.outlook.com (2603:10b6:a03:489::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Thu, 10 Nov 2022 01:53:50 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::3c6a:7a7c:129d:aecb]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::3c6a:7a7c:129d:aecb%4]) with mapi id 15.20.5791.026; Thu, 10 Nov 2022 01:53:50 +0000 From: "Xia, Chenbo" To: Taekyung Kim , "dev@dpdk.org" CC: "Pei, Andy" , "maxime.coquelin@redhat.com" , "stable@dpdk.org" , "Wang, Xiao W" Subject: RE: [PATCH v4] vdpa/ifc: fix update_datapath error handling Thread-Topic: [PATCH v4] vdpa/ifc: fix update_datapath error handling Thread-Index: AQHY81Anoib8wE30KEiP03AgkC1L1643Z1Og Date: Thu, 10 Nov 2022 01:53:50 +0000 Message-ID: References: <20221108085624.53989-1-kim.tae.kyung@navercorp.com> In-Reply-To: <20221108085624.53989-1-kim.tae.kyung@navercorp.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|SJ1PR11MB6108:EE_ x-ms-office365-filtering-correlation-id: f6d3fb81-fb52-4afc-c3f7-08dac2be69f0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fkL4er3erLUrKtGmpp53AHE3bKgcR7sYmW1peMKtGO0myce1PwqkQy3vje2gCvmTGmLxIaqjxu649Khm/paMjN16pt/u7rh90jlYilP3wH/u/ams/B+YVw+RxzT+WqnSzCl54eGDAJFHMzziGQvQVitEcd5LmrT61okq1PMWZJBcigAv3zpkS3BvVD1AVEv5UaRA5AWLeFr84LzSzidA30o9xX5/m3z0E61Vbj47ApAlDZX1K+9eK2QVMbTArnccUYg21dDZNKMAqi3wlSu/oR/TrELSFUeg7pF2N8dJ27VQ47MOB4iugAAaGSrHd2y0it4UNhGn+WTxW6KDCn9fHUd6cWacU4q1Q2sqMVXlYmjiP6xHJMwiyIOh0u15SnTYMxLLECo3u0TB+SDiNq8bTS6y3or7Lvg/2983YPF88VKeHguVNSYr/dHGJVWnjNOtLMKKtNLAzUV6ZuryZ3hBLCdQb7wNDrnUFy7qpZ3TZln9akE9eCc5Moi/wh5wcgIgLxCWCBaM3nm98EjrlMvm8JYDshswJ2gX49Iz4PeGdObH+7CZvLnTFF3SOkeEPfQeKP/Dnzf9YZ4juiTdbE15aliuy5Xu15zh/3gCf1FZrNo/NjLgL899JVX+4ISafi2E9bGv6C0JoX6QkREXTH+GdziZilWEs6NFs/7b2VksxJ2EX3AIqLdn/8DEgygim3nKMQ9F4V5uDu2NEK/CebOsmGF7nI/CMWYFvLHLU2cQudY2+ZUJdvMK7rUVAw+0uJ8xiiQJuz5hTeeEQbyTSHOUUr7wPueKEQ72Qo5z7yWcFYw= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(39860400002)(366004)(346002)(376002)(396003)(451199015)(83380400001)(15650500001)(2906002)(55016003)(64756008)(66946007)(33656002)(66446008)(8676002)(76116006)(4326008)(66556008)(41300700001)(66476007)(52536014)(86362001)(38070700005)(82960400001)(122000001)(54906003)(38100700002)(316002)(110136005)(9686003)(26005)(107886003)(5660300002)(8936002)(966005)(186003)(7696005)(6506007)(53546011)(71200400001)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6AWKp3YTLkto3LstAAZizP2QF8Tc8LksMnROtXyRmKkpKrdEqfjLHLZWljXs?= =?us-ascii?Q?7aqj38A1TSIXqxQYRQSj1d/KbnipJ62DFcLtALvrPdj6zDQPDi6KsjQd1C7t?= =?us-ascii?Q?NTdeS8lbjKeIYFONCpyBpr1f/m3HdL6lxhhMxPG4wC8kzUjd7RQXh1URx6Fk?= =?us-ascii?Q?5oG4O2UmztnNYe6t9MveH+ezXYeM+yxjIVD2OjHz0yJZ25BB5VkEYbQeAgpD?= =?us-ascii?Q?qxFAt3BGjkd8FOVv3wlMyStl/y/sI4daXC7rR5q1bsXbG3e9uDMsJGhm+rOT?= =?us-ascii?Q?Kw5ZY3VvAT2+cI8W3vcP9gputD5+Wh3kpa4SV99TcI24uPw9G7Kel1cgw6E7?= =?us-ascii?Q?YwAAhyqOCC92eeVWj/46kP9Wp46lPT5zx6rS/8ZwYSUWaeWi6QlZmwgg0fHI?= =?us-ascii?Q?hjykTdKG8r41DzB5VIWASI8gcJ5oEDnkTa2nBM1FkzRVKRSZwqJ5V0kgkcq6?= =?us-ascii?Q?L7NbfFa6fRMWIu0S62ET0DCUHkN54GN48vG6NDn62xeRSbI3YzV5pahn6kg5?= =?us-ascii?Q?1sO0HPjE+Q2QKdjvDK7xiF2uZ3TM4aN3PGduZaf/XJF8MoybViOSAexkl2HC?= =?us-ascii?Q?W5mF+f/vwROLKF+nF2o0vIrzTGhEvdTQehOtFISAYJ3YVyOJAZFP19KNivM8?= =?us-ascii?Q?ntDB/Taz1qdV1oJmxiyalzghdYBH2QxFDo3oCKYpeGLuTDhfBK9DF7wunRe3?= =?us-ascii?Q?ZPxBmCt8jIsFQ2g4WqIt/Z83IzDYA5P95+QPhwv6CfnY0d96zQ60AN1bSEMP?= =?us-ascii?Q?++drlGauDwtMTLhXLmvxMNK3xIP/Z54SJ7WcIb0R95dbizb5+74TmtmVB3hg?= =?us-ascii?Q?IVrxTTZ2RWdfycvbsGNOQZlqlp7CUAo701OfAyq9VyhXGqcIKXoWps4zgOux?= =?us-ascii?Q?kMDlEfuPQkZjYzKe5b1yNyjrZm5fxJ+F6kV68iFXvZZQGKnKzGivovBnh//Q?= =?us-ascii?Q?5QfUP0wlV9UNF6U+avLIym6fF6Lp6OFY/RbM2jS1P9vnuXyddCJN2JYTwWo5?= =?us-ascii?Q?kL6I0XGynX3flZKvkTskKCmKu3FmCa3hFayG1DB2tpcvDPcS9s1is2n6brkR?= =?us-ascii?Q?IFTJNU3ulqW0f6CqCmXmANghhJOyOg4qtyL6oP3WnYxM8ls4l6BsOAdpIXmF?= =?us-ascii?Q?qJAZmPVhEqOZbyx+Guu7jb/rd2Wjnk6lT2Rfok6Ovs4/fPS3fkGUxPyZL01w?= =?us-ascii?Q?zg8ytQHKDA0IEtR9yrgeqJahrpQwYEq8hbQ6U+FOwKp8KkurjravDR2//Pgs?= =?us-ascii?Q?pEwbHusflnnK/dQ95H0NbVistgBA/xPo/FSYy88UNiV1UsamklyacJc03/bt?= =?us-ascii?Q?a9YTU5u1Q31VjSj3zUbSSp2Du24sjPF22UOSFl5mvJ3rD+k07XbIm8/LJmao?= =?us-ascii?Q?dl1RC7ALlgdF7FmIPsdfgjNyDqkS5IkkVNUonC8J10R/CkAVUn4W6NZAy1Qj?= =?us-ascii?Q?C9Mp236tXcx79cCc3Bxv1HK1zs5PZN1O/vNkNpEb64anJod79LBNfT1QHjW9?= =?us-ascii?Q?KFawldrzMmRDHrPAH6E5tTmVWMV2h6ArrUcnDJBmWI8DvhCdv3m8iadRaTNA?= =?us-ascii?Q?HOLw9kzKVPWGG2wkGj2AvI1Tu91qaiBsxKLp4e2o?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6d3fb81-fb52-4afc-c3f7-08dac2be69f0 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2022 01:53:50.2995 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: y2Xl1q//aSi2aQF86OJEQHU9lCE3nhW6TtJ0yM+ZBmO2D4vwAbkK7BM/2CsfIZ1USS5LKUH4YdXYNoFsDhcpmA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6108 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi Kim, > -----Original Message----- > From: Taekyung Kim > Sent: Tuesday, November 8, 2022 4:56 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Pei, Andy ; > kim.tae.kyung@navercorp.com; maxime.coquelin@redhat.com; stable@dpdk.org; > Wang, Xiao W > Subject: [PATCH v4] vdpa/ifc: fix update_datapath error handling >=20 > Stop and return the error code when update_datapath fails. > update_datapath prepares resources for the vdpa device. > The driver should not perform any further actions > if update_datapath returns an error. >=20 > Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver") > Cc: stable@dpdk.org >=20 > Signed-off-by: Taekyung Kim > --- > v4: > * Add rte_vdpa_unregister_device in ifcvf_pci_probe >=20 > v3: > * Fix coding style >=20 > v2: > * Revert the prepared resources before returning an error > * Rebase to 22.11 rc2 > * Add fixes and cc for backport >=20 > --- > drivers/vdpa/ifc/ifcvf_vdpa.c | 27 +++++++++++++++++++++++---- > 1 file changed, 23 insertions(+), 4 deletions(-) I can't find your patch in patchwork: http://patchwork.dpdk.org/project/dpdk/list/?series=3D&submitter=3D2877&sta= te=3D*&q=3D&archive=3Dboth&delegate=3D so it's difficult to review and merge. Do you know why or is it possible that you send a new version to make it show on Patchwork today? Thanks, Chenbo