From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 092E442C67 for ; Fri, 9 Jun 2023 05:20:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED92041153; Fri, 9 Jun 2023 05:20:36 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 5731740A84; Fri, 9 Jun 2023 05:20:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686280833; x=1717816833; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=gx9IX23IErv3PNU7lhzXWs31BvT1YcttlIluv+dJDdA=; b=gByrBId3nh2sYrxwp7CZHbEXAy+XlZnTuf1Gs57Uc5i7Ld6EW7g6ZtOG iCNr+wH0kuK3LVl8cH3Aa3cFJVlTLcNr22B6Z6NLsJsfMZHkEpTwYK8iR 5k7qfNJDpxB4zqlpEgKKKosBteprXaKg2G5KYSxfpblPbp+qS6LV7OMfb cdE1JjCnnz7YuYDXVZelHldxA1fKl855HmND8ZxP04Gh2TrRVVVDHzQ36 Jl4WElPlAohVsOszkRGo+3WL9sSUdL3UMbVQdnZPlYWX4UR5kDP5KvTXo bmetYZoo0KMZWXFyvzf5HM396QCek5Cf5TEhA6uojqRuwxGbyFU4V/IMU g==; X-IronPort-AV: E=McAfee;i="6600,9927,10735"; a="342174804" X-IronPort-AV: E=Sophos;i="6.00,228,1681196400"; d="scan'208";a="342174804" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2023 20:20:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10735"; a="822888762" X-IronPort-AV: E=Sophos;i="6.00,228,1681196400"; d="scan'208";a="822888762" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga002.fm.intel.com with ESMTP; 08 Jun 2023 20:20:20 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 8 Jun 2023 20:20:20 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 8 Jun 2023 20:20:19 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 8 Jun 2023 20:20:19 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 8 Jun 2023 20:20:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M22B0OGYAg0j2n3FBVJJagXGsvCNKPH60rJQLG/Kt2i5JxguIV0UwBIYSvvYhYb3x5oP5VHJPcJ7mnIYiDpjcku5dHN0sCb0hsxdMkGWVuLRIJNR9PyU0dbvoO4vurZ8DqJG29RtHt5+fZ4y0WFsTB9nxqkSRpxTC528kUnJAGiXD8R5KL0oaOhTJeqdaPlKuq6oQm/1nQ5KgMNozkaJzUcEm2Q3ujOS+riHWwg/PcOZO1KlHVDh8znstXi9+8mlJfwv9HLdJlC63cOUS1nXzy/mrcWNKl4yeb0x8XGyLfildx5Bb1webXzVoGsHhAQJLGApJ7tnuGjep9sDT3UYZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Lc/x7VqZdzeKvYVeoMAzpThLrEexeei8ZXUSSNu6/NA=; b=Gv1u0MqSsDa69sUyoWsELaNO1qNK5p1LT0GfsB0Qpw7wO1Bf2gpj2RACQJZ209xAWjsvCd98Jter0I5234Uh6YBg3UHFcbzkVc79nq9EAMX5Ieh5f6jPyKRjL9gGhRF3b+8wiNHKN4uXFBFAfchXfZLjzrLmdBiPnv8iU7Fi93D5MO7Q0hm9dXA6jABYyNqo6rqAjkS1HPDdkVkhw9SCRVK2wmyWFpiMzPp6BwoncnPPzzsdTLTRt8RRRFXkKxcN+yBHoUesQNUS1ak7AHQMYLL2LRO85qtlpM1DtSv1IHDVWEX6QuxGMXppbGSi/qgtXrAXMgptxQKO9jV4W/SYDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB7139.namprd11.prod.outlook.com (2603:10b6:806:2a2::14) by SN7PR11MB6799.namprd11.prod.outlook.com (2603:10b6:806:261::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.36; Fri, 9 Jun 2023 03:20:19 +0000 Received: from SN7PR11MB7139.namprd11.prod.outlook.com ([fe80::fe73:c062:29dd:b549]) by SN7PR11MB7139.namprd11.prod.outlook.com ([fe80::fe73:c062:29dd:b549%3]) with mapi id 15.20.6477.016; Fri, 9 Jun 2023 03:20:19 +0000 From: "Ye, MingjinX" To: "Zhang, Qi Z" , "dev@dpdk.org" CC: "Yang, Qiming" , "Zhou, YidingX" , "stable@dpdk.org" , "Wu, Jingjing" , "Xing, Beilei" Subject: RE: [PATCH] net/iavf: fix abnormal disable HW interrupt Thread-Topic: [PATCH] net/iavf: fix abnormal disable HW interrupt Thread-Index: AQHZmdLpXVSV3KCGFkqH2yXWBnylh6+BtS8AgAABRbA= Date: Fri, 9 Jun 2023 03:20:18 +0000 Message-ID: References: <20230608062305.99819-1-mingjinx.ye@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB7139:EE_|SN7PR11MB6799:EE_ x-ms-office365-filtering-correlation-id: 33de620c-879b-443a-eab7-08db689873c1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YkdfoFmNdzoI/X/skIM0CKsLKxU9/dt3W4lswVJlZUyvSjXldI7w1SVLFwwb5viqKHjczcGl+DtIWIyJqNXinGCFsJGqNkd7marmHR7xob0yiGxme2rLpboOH1bTPlrashxr0qPmPQB5xLxGaOiqqarbdkrrQiPgsnuFL6MlqPUICNpLzdTN929sa8vYV9dI2Q+i7nJT4m7bsexGhm8BHkgZ+RBWetwPmdYx7Tufn/OYuduENdxpB+CjadmZ70HJ0+93o32WcJI8IXKsJ24xQHEbqZxvdCV/xSr2Y59GEm1sMUafjEbMj72bKSTaNZCNk9uhnHnZPa+zr4i1zRyL/IFPmA6SIONWAiBuahiWSfvWNweQ1K7uamHToXEXzkxiW6BWd5wxcRaGIbOaJ4co8g8a/VQNDH20LZx1031G+7Tjpy9doNFU64GbSaQlkbEmI3935sw81rkfwSPzFQWniucBuqm7DLM2B141tOpndEU8zZj/Y1OGv8rQQlimHKiggOKpIiovlNHKCnsAoo4yEsEqHgQrmaWinULK0XO/UOquKS2jV8gG45mfmI5ppnqfjkC/t0IdtJK7zXzsBSkCAT0hNWsJfron4meITEFKn2opWnU7Mopc/0XtbUiAt09d x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB7139.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(136003)(376002)(346002)(39860400002)(396003)(366004)(451199021)(66946007)(450100002)(5660300002)(8936002)(8676002)(52536014)(4326008)(64756008)(66476007)(66446008)(66556008)(54906003)(76116006)(110136005)(71200400001)(478600001)(41300700001)(316002)(7696005)(38100700002)(55016003)(122000001)(9686003)(6506007)(53546011)(107886003)(186003)(38070700005)(82960400001)(83380400001)(86362001)(2906002)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?TGNwc3lreEJVV3FSbU16WVlLRmV2QnBXUlMrSDFJK0pMRHg5Rm1zeTVo?= =?iso-2022-jp?B?ZHZINThBT1h5Y0xEK3RMSEpsSTl6bCt0T0h2TEhOWjVEUlBCY3NUYXpt?= =?iso-2022-jp?B?VVczazZaM1lJSU00VlVwUHlzNlVuZk1LTVhtayt5SEp3QW9SWWFJanVD?= =?iso-2022-jp?B?blkwNmd5amJsWk5yTnFHTkNac3dCaUFlOEUrdTZxYWduTzB6WWZTQ3VF?= =?iso-2022-jp?B?disreVlPNTF5c1ZhVFFJanBTTmxCYVU4ck9wcTYxbHYxY1Y0a3ZkZlBV?= =?iso-2022-jp?B?QmNpWndudktFeWRrbHRYdi81akVwbU9obVlhL1Zhd3FiOWlOSGJJVzBp?= =?iso-2022-jp?B?OUdwREh4ZDFZUWZUZnhMM3d3UHRBNXB3YWpRQTlvb3doa2RKMXFqQUtz?= =?iso-2022-jp?B?a2hjclBkZFNvQmtPZXJkZGROSjRjZjlCWndkR2k4Z2VhcktXTy9uR3lX?= =?iso-2022-jp?B?eXkrZmVQNlZuWXdVT3FuYTZmNmt2QTFOT3R2NHVKQXFRS0RsVW10NmZE?= =?iso-2022-jp?B?YW9WTFcrMFZxRnR0ZnprVkk5UDlWNVhwcUphUUNCdGdpQmVJQjVVSnNB?= =?iso-2022-jp?B?RStNUy9TanZ1eWtoMlA3WFoxaXM5eEgvaCtkaVdVRER5eFdSSEdIZ2hr?= =?iso-2022-jp?B?dlYxdEJxRFVNRFpvclg3WlVLL3VVRWZRWXlXQnFpV3RqZHhuT3c2WUE1?= =?iso-2022-jp?B?M1BpMktBNlpIcDVmNE5mNTFueGRkOWtZVzQ1OTZPOU9NRi83UVN2VFNW?= =?iso-2022-jp?B?R2JucGVhbnlFREdJT3lxZXRKTE1PRmZ3S2lTU1hKMG8yRnRTeUQ0bE9B?= =?iso-2022-jp?B?SVFBUDlEa3FML2xkQTJHQ0R4aVR1STNGN2NjWGRmb05BOFU0anMreDk2?= =?iso-2022-jp?B?ZVpZdDRvYk5Ba3Jsb1V3MGt0dm1ZL1pwOWQ3dU9qREFEZkRLcHFTMUNF?= =?iso-2022-jp?B?ais0OU03Rm56MUdER01ndm5QRll6bW5paWRGMXZZWFRtVElzTXRlUmMw?= =?iso-2022-jp?B?ZTI0dTNETFFnbkFwSTkwNlRYU0Z3RW94cE4zaUJ6c3pVQi8zdHN5WEpz?= =?iso-2022-jp?B?T0lqT0F3bUJHMk5ZWjRsa1dQOGI3cFdKNU9JTFRHMVdpeTRYbDB1UTBs?= =?iso-2022-jp?B?QlRIRmFZbTZkS0xxUGlhOW9hQ2M3MHRCNVZtR1pBSmNsdmp6M2htSnpy?= =?iso-2022-jp?B?MkJrSjhaemhxQ3FUTG5mWWEwTXdFVi95Wk14QWZueVNOUXZOMnIxdVcx?= =?iso-2022-jp?B?WE9yWkdXaGc4M0ZRR096VXJNUUREbUh2UEJwV2kwcmlkMm9KQ2VkQVdm?= =?iso-2022-jp?B?aGZHTjgvQU8ySjhhUlRZS3hGMlFSS1BZeGpicmtoWTVqM1ZPY1R0K1Iz?= =?iso-2022-jp?B?dkpPcEVtZTJPR3hPQi9LbzhDSXlpM3J2WlNJR0JiYnBjcUFhUmh6aUt2?= =?iso-2022-jp?B?SDVZNWJWUW5BQUhBQVh1V1FGcjdYa0taLzNCeUZvdUpWZUIxcWJtdzds?= =?iso-2022-jp?B?VjUxRDlFYlNLQVpOd3R6Y2Ewb0lQQ3U0aTlkeFcyRFpzd1B2RkhXckc5?= =?iso-2022-jp?B?T2FXZkJTY3JGeTMyKzRtWmJhbjVLVHJhK1pVdEExVVdQejhWZXRNdElq?= =?iso-2022-jp?B?ZjVhSVI0dmZDSE95RlZuc3JGM3Urak0xNDc1cXhicWdZbEYwTjhCdVhO?= =?iso-2022-jp?B?T3V5c3F2U1dhN1ErYXVPcW82WW9oa1NySlBGei9jZ01yZkVTTTdNZTY3?= =?iso-2022-jp?B?Q21PR2RnYVg2enprSWFVbnZQSjVWNzRPVEgrVEcyK1ozaVphMWx5SGR5?= =?iso-2022-jp?B?UjhER0NtS1htYmRmc3JJMHV3ZWUrUGh6SEJUM1g3NXdyeVo1MGxtU21K?= =?iso-2022-jp?B?NFNpcDRPSUNVcHNYTXRWZXpUWXQxcm9hNTFSM3pxSVBOeEpyUzNvMi9w?= =?iso-2022-jp?B?NDNmdndZUlh4dmxSOFhhSlkwdWJKZVh0VGg0YlUwWjJjOVB5R2FKUDg4?= =?iso-2022-jp?B?QVBvS3B6bkVONllmaTV2b1BRbWtOemhZMlMxVjUzbW1QYWl4SGNEQndS?= =?iso-2022-jp?B?d2hJQ2VjZ1M1akVkelJoYzc5VGhRUjhKc2MvODkzUzk0VXJCczFxUjZ2?= =?iso-2022-jp?B?TmFuVUtCeWRnQUh1Y25VaDBldUZrcWg4dStzMEZraHE0aWxzcW1MRnBw?= =?iso-2022-jp?B?dGVBOEwwUUtsOW5GbFk1eDZlVjBKcm5Cc1BwSGZ6TEVBR3FqbUE2SXlD?= =?iso-2022-jp?B?TEtTQT09?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7139.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33de620c-879b-443a-eab7-08db689873c1 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jun 2023 03:20:18.9429 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fir4ej91R09B4CxmF+mYssWTagBmHnblSTm8klTNd+h0fegn5f3j+8lQZ/yi4N1GFhVt8p/pq+WC8GP6kTzfIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6799 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Zhang, Qi Z > Sent: 2023=1B$BG/=1B(B6=1B$B7n=1B(B9=1B$BF|=1B(B 9:48 > To: Ye, MingjinX ; dev@dpdk.org > Cc: Yang, Qiming ; Zhou, YidingX > ; Ye, MingjinX ; > stable@dpdk.org; Wu, Jingjing ; Xing, Beilei > > Subject: RE: [PATCH] net/iavf: fix abnormal disable HW interrupt >=20 >=20 >=20 > > -----Original Message----- > > From: Mingjin Ye > > Sent: Thursday, June 8, 2023 2:23 PM > > To: dev@dpdk.org > > Cc: Yang, Qiming ; Zhou, YidingX > > ; Ye, MingjinX ; > > stable@dpdk.org; Wu, Jingjing ; Xing, Beilei > > > > Subject: [PATCH] net/iavf: fix abnormal disable HW interrupt > > > > For command VIRTCHNL_OP_REQUEST_QUEUES, polling access to the > admin > > queue has the issue of access overruns after disabling interrupt. That > > results in FW disabling HW interrupt for protection purposes. > > > > The updates/changes in this patch: > > 1. Remove the polling admin queue processing and use the generic > > interrupt processing instead. > > 2. Release redundant queue resource before stopping processing > > interrupt events. > > > > Fixes: 22b123a36d07 ("net/avf: initialize PMD") > > Fixes: ef807926e148 ("net/iavf: support requesting additional queues > > from > > PF") > > Fixes: 84108425054a ("net/iavf: support asynchronous virtual channel > > message") > > Cc: stable@dpdk.org > > > > Signed-off-by: Mingjin Ye > > --- > > drivers/net/iavf/iavf_ethdev.c | 25 +++++++++--------- > > drivers/net/iavf/iavf_vchnl.c | 48 +++++++--------------------------- > > 2 files changed, 23 insertions(+), 50 deletions(-) > > > > diff --git a/drivers/net/iavf/iavf_ethdev.c > > b/drivers/net/iavf/iavf_ethdev.c index e6cf897293..ba5c88a1ec 100644 > > --- a/drivers/net/iavf/iavf_ethdev.c > > +++ b/drivers/net/iavf/iavf_ethdev.c > > @@ -2756,6 +2756,19 @@ iavf_dev_close(struct rte_eth_dev *dev) > > } > > > > ret =3D iavf_dev_stop(dev); > > + > > + /* > > + * Release redundant queue resource when close the dev > > + * so that other vfs can re-use the queues. > > + */ > > + if (vf->lv_enabled) { > > + ret =3D iavf_request_queues(dev, > > IAVF_MAX_NUM_QUEUES_DFLT); > > + if (ret) > > + PMD_DRV_LOG(ERR, "Reset the num of queues > > failed"); > > + > > + vf->max_rss_qregion =3D IAVF_MAX_NUM_QUEUES_DFLT; > > + } > > + > > adapter->closed =3D true; > > > > /* free iAVF security device context all related resources */ @@ - > > 2772,18 +2785,6 @@ iavf_dev_close(struct rte_eth_dev *dev) > > if (vf->promisc_unicast_enabled || vf->promisc_multicast_enabled) > > iavf_config_promisc(adapter, false, false); > > > > - /* > > - * Release redundant queue resource when close the dev > > - * so that other vfs can re-use the queues. > > - */ > > - if (vf->lv_enabled) { > > - ret =3D iavf_request_queues(dev, > > IAVF_MAX_NUM_QUEUES_DFLT); > > - if (ret) > > - PMD_DRV_LOG(ERR, "Reset the num of queues > > failed"); > > - > > - vf->max_rss_qregion =3D IAVF_MAX_NUM_QUEUES_DFLT; > > - } > > - > > iavf_shutdown_adminq(hw); > > if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_WB_ON_ITR) > { > > /* disable uio intr before callback unregister */ diff --git > > a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c index > > 8cc5377bcf..579c0d0d70 100644 > > --- a/drivers/net/iavf/iavf_vchnl.c > > +++ b/drivers/net/iavf/iavf_vchnl.c > > @@ -323,6 +323,7 @@ iavf_execute_vf_cmd(struct iavf_adapter *adapter, > > struct iavf_cmd_info *args, > > > > switch (args->ops) { > > case VIRTCHNL_OP_RESET_VF: > > + case VIRTCHNL_OP_REQUEST_QUEUES: > > /*no need to wait for response */ > > _clear_cmd(vf); > > break; >=20 > Have you tested the "large VF" case ( > 16 queue) with this patch. > I assume event VIRTCHNL_EVENT_RESET_IMPENDING need to be handled > here then to trigger a device reset. > But I didn't see related part in your patch. The processing related to the "big VF" is moved before "adapter->closed =3D= true;" to make sure it can be handled correctly by the interrupt function.