From: Akhil Goyal <akhil.goyal@nxp.com>
To: "asomalap@amd.com" <asomalap@amd.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v1 4/6] crypto/ccp: updating ccp crypto capabilities ops
Date: Tue, 15 Oct 2019 11:06:12 +0000 [thread overview]
Message-ID: <VE1PR04MB6639298321B379F0DF53E30CE6930@VE1PR04MB6639.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20191015070144.93172-1-asomalap@amd.com>
Title: crypto/ccp: fix capabilities for digest size
>
> From: Amaranath Somalapuram <asomalap@amd.com>
>
> crypto capabilities ops for ccp initilzed incorrectly.
> changing the correct values for the capabilities ops
You are changing digest size only in this patch.
You can rephrase this as:
CCP can support varied digest sizes ranging from 1 to some max value
But the current code support only fixed max values.
This patch updates the minimum digest sizes to 1.
Also a Fixes line is missing
> Cc: stable@dpdk.org
>
> Signed-off-by: Amaranath Somalapuram <asomalap@amd.com>
> ---
> drivers/crypto/ccp/ccp_pmd_ops.c | 44 ++++++++++++++++----------------
> 1 file changed, 22 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/crypto/ccp/ccp_pmd_ops.c
> b/drivers/crypto/ccp/ccp_pmd_ops.c
> index d5041f0ec..768378033 100644
> --- a/drivers/crypto/ccp/ccp_pmd_ops.c
> +++ b/drivers/crypto/ccp/ccp_pmd_ops.c
> @@ -47,7 +47,7 @@
> .increment = 1 \
> }, \
> .digest_size = { \
> - .min = 20, \
> + .min = 1, \
> .max = 20, \
> .increment = 0 \
> }, \
> @@ -68,9 +68,9 @@
> .increment = 0 \
> }, \
> .digest_size = { \
> - .min = 28, \
> + .min = 1, \
> .max = 28, \
> - .increment = 0 \
> + .increment = 1 \
> }, \
> .aad_size = { 0 } \
> }, } \
> @@ -89,9 +89,9 @@
> .increment = 1 \
> }, \
> .digest_size = { \
> - .min = 28, \
> + .min = 1, \
> .max = 28, \
> - .increment = 0 \
> + .increment = 1 \
> }, \
> .aad_size = { 0 } \
> }, } \
> @@ -110,9 +110,9 @@
> .increment = 0 \
> }, \
> .digest_size = { \
> - .min = 28, \
> + .min = 1, \
> .max = 28, \
> - .increment = 0 \
> + .increment = 1 \
> }, \
> .aad_size = { 0 } \
> }, } \
> @@ -131,9 +131,9 @@
> .increment = 1 \
> }, \
> .digest_size = { \
> - .min = 28, \
> + .min = 1, \
> .max = 28, \
> - .increment = 0 \
> + .increment = 1 \
> }, \
> .aad_size = { 0 } \
> }, } \
> @@ -173,9 +173,9 @@
> .increment = 1 \
> }, \
> .digest_size = { \
> - .min = 32, \
> + .min = 1, \
> .max = 32, \
> - .increment = 0 \
> + .increment = 1 \
> }, \
> .aad_size = { 0 } \
> }, } \
> @@ -215,9 +215,9 @@
> .increment = 1 \
> }, \
> .digest_size = { \
> - .min = 32, \
> + .min = 1, \
> .max = 32, \
> - .increment = 0 \
> + .increment = 1 \
> }, \
> .aad_size = { 0 } \
> }, } \
> @@ -257,9 +257,9 @@
> .increment = 1 \
> }, \
> .digest_size = { \
> - .min = 48, \
> + .min = 1, \
> .max = 48, \
> - .increment = 0 \
> + .increment = 1 \
> }, \
> .aad_size = { 0 } \
> }, } \
> @@ -299,9 +299,9 @@
> .increment = 1 \
> }, \
> .digest_size = { \
> - .min = 48, \
> + .min = 1, \
> .max = 48, \
> - .increment = 0 \
> + .increment = 1 \
> }, \
> .aad_size = { 0 } \
> }, } \
> @@ -341,9 +341,9 @@
> .increment = 1 \
> }, \
> .digest_size = { \
> - .min = 64, \
> + .min = 1, \
> .max = 64, \
> - .increment = 0 \
> + .increment = 1 \
> }, \
> .aad_size = { 0 } \
> }, } \
> @@ -383,9 +383,9 @@
> .increment = 1 \
> }, \
> .digest_size = { \
> - .min = 64, \
> + .min = 1, \
> .max = 64, \
> - .increment = 0 \
> + .increment = 1 \
> }, \
> .aad_size = { 0 } \
> }, } \
> @@ -536,7 +536,7 @@
> .increment = 1 \
> }, \
> .digest_size = { \
> - .min = 16, \
> + .min = 1, \
> .max = 16, \
> .increment = 0 \
> }, \
> --
> 2.17.1
prev parent reply other threads:[~2019-10-15 11:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 7:02 [dpdk-stable] " asomalap
2019-10-15 11:06 ` Akhil Goyal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR04MB6639298321B379F0DF53E30CE6930@VE1PR04MB6639.eurprd04.prod.outlook.com \
--to=akhil.goyal@nxp.com \
--cc=asomalap@amd.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).