From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2C03A0613 for ; Fri, 27 Sep 2019 16:34:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BE8C71BEFB; Fri, 27 Sep 2019 16:34:51 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10044.outbound.protection.outlook.com [40.107.1.44]) by dpdk.org (Postfix) with ESMTP id B79421BEF1; Fri, 27 Sep 2019 16:34:47 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O/gqlu6kDbHJwVz5/cb4cY+FVbMFVdtvp+lxTv+oZhSYaULbzRBrdWkZ4xNYwWA5XIBfaNL6wsVxaTEVsYZKDeLXA/DREMpICum3GIM1K+w4vL/wU3zSWNcenqeVznQie6oxsqdaHQ5xJQgAMuQKgg1Ba/WRddsZchb+l+isC6r12t7Oy1Jt6YHNOnlooJi6iRFHB53zUz6y23w67Mdq/2btXZdDHxzlrW2AjyG/VomCQw/c7jWITnPlSpJypkmvH6VJtQKAJuQxIpkN8vsfXw/lHF9HnFRiWlVPZzr95KPw3XqhdXB7pcOlWXV9uNP5JAymYDOIuyLP3kIm6QZ5hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GWJtHevCBk0GedkRkQXEPUp2gNNlYSXUI+EcdMVZqYk=; b=dN3uS6fDjYIcZBe08miAonREFtoPT4dNeZpMv279lfl4x0QwTihIQysM931sTrocyjZZPBwWFrzV+RPvCaVcW4JRRewuWwTkkCaUGFSGzN3lAJ0pHhfJXEPjhFOMJ4wwpSTsyNEgFe6+v3rbQo2e0HuXtU8YyQZeMrZ4u5g30qzWowy7i97+jIwzk0N8hdsB8QD6fzNA3WhkJ82/OUtna4KdSjRP1JAqJGwGVl+6vq3qRWmrEf2d9+SIXDsILODLvdmb3ANNlNL+ozsPmKL72fauqfPtHfBYMfs13hwROJ1EcS525eHyeSjs54Q5SzqX9B/i/ThlsVKMmqqun9LOJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GWJtHevCBk0GedkRkQXEPUp2gNNlYSXUI+EcdMVZqYk=; b=MumOoPrNoejmHgP7IeaLYpaD95w69I/0AfSvmP14AUTXfauX2ztD2D8pciYOowZCy19L9J7wkj/T5wRkPpwzngrYv5eQ03lrrXAy86loKG8FSSjVpdUn/ZAY59B4yyqI3bdwm4tlqTQIAO0qdKkDFZ+OcD8m9ijKfnnUQRhY6Do= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (10.255.118.11) by VE1PR04MB6719.eurprd04.prod.outlook.com (20.179.235.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2284.18; Fri, 27 Sep 2019 14:34:46 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::c045:5df2:ba1f:c3ee]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::c045:5df2:ba1f:c3ee%5]) with mapi id 15.20.2305.017; Fri, 27 Sep 2019 14:34:46 +0000 From: Akhil Goyal To: "Ananyev, Konstantin" , "Smoczynski, MarcinX" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] examples/ipsec-secgw: fix over MTU packet crash Thread-Index: AQHVcsabjR6sdbwAX0+JsO7UEB34V6c6sJYAgATrFAA= Date: Fri, 27 Sep 2019 14:34:46 +0000 Message-ID: References: <20190924105508.19068-1-marcinx.smoczynski@intel.com> <2601191342CEEE43887BDE71AB97725801919699C7@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB97725801919699C7@irsmsx105.ger.corp.intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: de4ceff0-04be-45d2-9532-08d74357d85a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600167)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR04MB6719; x-ms-traffictypediagnostic: VE1PR04MB6719: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2399; x-forefront-prvs: 0173C6D4D5 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(366004)(346002)(396003)(136003)(39860400002)(189003)(199004)(76116006)(229853002)(4326008)(305945005)(6436002)(316002)(54906003)(66476007)(66556008)(66946007)(11346002)(256004)(4744005)(5660300002)(446003)(66446008)(64756008)(476003)(9686003)(52536014)(6246003)(110136005)(486006)(55016002)(6506007)(26005)(25786009)(478600001)(74316002)(6116002)(44832011)(2906002)(3846002)(7736002)(99286004)(7696005)(71190400001)(71200400001)(86362001)(81156014)(102836004)(14454004)(186003)(8676002)(81166006)(33656002)(66066001)(8936002)(76176011); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6719; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: HDG+FWOHXJUwDUaGoBNPeOsetjsZO+/1BjTJb/oiikI8CNf75+5L7iYxpSG1IXUsqHwBkLRBGaFyh2OSDwaCYOaF7aWHmBErJAApiJskdnUnz/SLs74dlQTbMMCMLqjJpb1MiOGu2VTCBqINK8rs5E8rMsSn39i5XyZHDYDYY8OXXekQG8BoMEkTFPQrR0ZG2ZqdcOy61NdFkbdme+nVQ5QwtEArL2X7o9m/d1uJaQz0x5YNUZJ0my1PKWCNOnKgq2jPOU2J8nbhaWLaWRv6TDbeo6EDrk2LFmEztXUXX7aLy8wQ6Xgh8C79hEiuh7Alr1YfoaU9sYdKdXkcT+u/f8l/P2AJqQgTUQCmrSz+iG+w763JIS+Ki84x4INv8HGZajJ7f3qO507m+IKy2nfoc9CCb9AxIEa8ctt5L6nHBSg= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: de4ceff0-04be-45d2-9532-08d74357d85a X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2019 14:34:46.3697 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wjk9WqZ5lJhhwDHks+RqjhngKRcstVRdOBhuwfFqN2hjQp22h3XyzDs6LeKDowcXn2DpG9yBAmfABO+frZuxbQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6719 Subject: Re: [dpdk-stable] [PATCH] examples/ipsec-secgw: fix over MTU packet crash X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > > > > When sending an encrypted packet which size after encapsulation exceeds > > MTU, ipsec-secgw application tries to fragment it. If --reassemble > > option has not been set it results with a segmantation fault, because > > fragmentation buckets have not been initialized. > > > > Fix crashing by adding extra check: if --ressemble option has not been > > set and packet exceeds MTU after encapsulation - drop it. > > > > Fixes: b01d1cd213 ("examples/ipsec-secgw: support fragmentation and > reassembly") > > Cc: stable@dpdk.org > > > > Signed-off-by: Marcin Smoczynski > Acked-by: Konstantin Ananyev Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.