From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 11BAEA0096 for ; Tue, 7 May 2019 13:03:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7E38B37AF; Tue, 7 May 2019 13:03:45 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150088.outbound.protection.outlook.com [40.107.15.88]) by dpdk.org (Postfix) with ESMTP id 76F4028FD; Tue, 7 May 2019 13:03:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HNZ56MNoxbqmaDUOofMglJlw6YR1lcYTp1POVaKNOhA=; b=ISTEoNCE6Cd6MQTnSrGApM9CYC59S4/dW+XWwcg0NscZB4htM7ONCxchey6g6/uZEpOhi0oT9M2Vp1jdP53XLOmWmagYZ94+TcDdEm/nP+ToIvPtVq3ZrLNqCskM2k9S/nlP9XgtQWdRTF2t1daFFXPCU8vEwPcXQYxhjVKz0oU= Received: from VE1PR08MB5149.eurprd08.prod.outlook.com (20.179.30.152) by VE1PR08MB4736.eurprd08.prod.outlook.com (10.255.112.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.12; Tue, 7 May 2019 11:03:37 +0000 Received: from VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::f5e3:39bc:e7d9:dfea]) by VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::f5e3:39bc:e7d9:dfea%5]) with mapi id 15.20.1856.012; Tue, 7 May 2019 11:03:37 +0000 From: Honnappa Nagarahalli To: "jerinj@marvell.com" , "yskoh@mellanox.com" CC: "thomas@monjalon.net" , "dev@dpdk.org" , "bruce.richardson@intel.com" , Pavan Nikhilesh Bhagavatula , Shahaf Shuler , "Gavin Hu (Arm Technology China)" , "stable@dpdk.org" , Luca Boccassi , nd , nd Thread-Topic: [dpdk-stable] [PATCH v2] build: disable armv8 crypto extension Thread-Index: AQHVAauzmkiFG4Tv5EaKa0BQLwiRC6ZZe7hggAAUOdCAAB4ugIAE+PUAgACrGgCAADC3wA== Date: Tue, 7 May 2019 11:03:37 +0000 Message-ID: References: <20190502015806.41497-1-yskoh@mellanox.com> <20190503122813.8938-1-yskoh@mellanox.com> <20190503175034.GD2510@mtidpdk.mti.labs.mlnx> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 420ef86f-a1d8-451d-762b-08d6d2dba7bc x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:VE1PR08MB4736; x-ms-traffictypediagnostic: VE1PR08MB4736: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr nodisclaimer: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0030839EEE x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(376002)(39860400002)(396003)(366004)(346002)(189003)(199004)(446003)(54906003)(68736007)(110136005)(2906002)(486006)(11346002)(3846002)(8936002)(81166006)(8676002)(7736002)(305945005)(74316002)(53936002)(6246003)(4326008)(25786009)(86362001)(478600001)(229853002)(5660300002)(66066001)(476003)(76116006)(7696005)(99286004)(6116002)(316002)(102836004)(76176011)(81156014)(53546011)(6506007)(256004)(55016002)(71200400001)(71190400001)(14454004)(9686003)(6436002)(72206003)(52536014)(33656002)(2501003)(66446008)(186003)(26005)(66476007)(66556008)(64756008)(73956011)(66946007); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR08MB4736; H:VE1PR08MB5149.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: DCIw7tsB2357/0xMSjxuKOFYVGGkNBUEoGhQJTNSF0miRuRRWEfpPe5O9XWBRxTXHK3XFOj8a+tbhOkHRVqifDyPMdDXXVpwcCz/vXl2CgOlUVWQFvQb7N33mY5rXz3QI4jm7ljuCCKj4uEZY2IbxjjFaDwbHLER9A9owCQSwz7yT3qYEbaKqyyensouUwPRpBzeDS4ImYuarkhxEiPD5idn0KhqjFgXnguXRC72YRsYjYtucRNx7mhYBWruwbdg0KNdWJpfak65kblPZSLFrQR7uDEtnC3ccuuBk7Iu+wa2dU37J6u18xE7RS5H3HYiR4p7z7gyMIc+AhMAyTa2ngi9Y16dXvMx9L7E0/Gs4R3m5z9NOHUCGxjyd5AH7JA8P50JOxFvLLBXToAOnWAN81ZBDJig0BItDU3+qB15C+A= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 420ef86f-a1d8-451d-762b-08d6d2dba7bc X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2019 11:03:37.1359 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4736 Subject: Re: [dpdk-stable] [PATCH v2] build: disable armv8 crypto extension X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > > Subject: [EXT] Re: [dpdk-stable] [PATCH v2] build: disable armv8 > > crypto extension > > > > > On May 3, 2019, at 10:50 AM, Yongseok Koh > > wrote: > > > > > >> I think this change might have an impact on the existing users. > > >> Does this change need to be documented somewhere (at least in the > > >> release > > notes)? > > > > > > Practically, there would be no impact. Even if user's app makes use > > > of crypto instructions, the build config of the app should have the f= lag. > > > > On IRC, I could see you concerned about the case where user app > > derives build flags from DPDK like apps under the examples directory. > > Yes, that's a valid concern. >=20 > Is there any DPDK example application would depend on the armv8 crypto > flags? IMO, None of the applications are directly using armv8 crypto It is not about DPDK's example application. We have control over that. > instruction. Even such as comes for any external DPDK app which is not in > dpdk.org tree then it can be added in APP makefile. > IMO, app writes should be aware of the need for using +crypto if he/she > using the crypto instruction. Agree. But, it might be that the app writer might have depended on the +cry= pto coming from DPDK build system, in which case, she/he needs to know the = change through release notes? I do not think it needs to be documented anywhere else. >=20 > > > > Thomas/Jerin, where could be the best spot to document it? Just > > release note? > > I think release note would be fine. >=20