patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH v2] crypto/kasumi: fix gcc 10 fno-common error
       [not found] <20200505125442.18048-1-ktraynor@redhat.com>
@ 2020-05-06  9:45 ` Kevin Traynor
  2020-05-09 22:01   ` [dpdk-stable] [dpdk-dev] " Akhil Goyal
  0 siblings, 1 reply; 2+ messages in thread
From: Kevin Traynor @ 2020-05-06  9:45 UTC (permalink / raw)
  To: dev, pablo.de.lara.guarch; +Cc: david.marchand, Kevin Traynor, stable

gcc 10 defaults to fno-common and it reports:

crypto_kasumi_rte_kasumi_pmd_ops.c.o:(.data.rel+0x0):
multiple definition of `rte_kasumi_pmd_ops';
crypto_kasumi_rte_kasumi_pmd.c.o:(.bss+0x8): first defined here

Fix by making rte_kasumi_pmd_ops extern in the header file.

Fixes: 2773c86d061a ("crypto/kasumi: add driver for KASUMI library")
Cc: stable@dpdk.org

Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

---
v2: add tags and ack
---
 drivers/crypto/kasumi/kasumi_pmd_private.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/kasumi/kasumi_pmd_private.h b/drivers/crypto/kasumi/kasumi_pmd_private.h
index b7f1c428b..abedcd616 100644
--- a/drivers/crypto/kasumi/kasumi_pmd_private.h
+++ b/drivers/crypto/kasumi/kasumi_pmd_private.h
@@ -77,5 +77,5 @@ kasumi_set_session_parameters(MB_MGR *mgr, struct kasumi_session *sess,
 
 /** device specific operations function pointer structure */
-struct rte_cryptodev_ops *rte_kasumi_pmd_ops;
+extern struct rte_cryptodev_ops *rte_kasumi_pmd_ops;
 
 #endif /* _KASUMI_PMD_PRIVATE_H_ */
-- 
2.21.3


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] crypto/kasumi: fix gcc 10 fno-common error
  2020-05-06  9:45 ` [dpdk-stable] [PATCH v2] crypto/kasumi: fix gcc 10 fno-common error Kevin Traynor
@ 2020-05-09 22:01   ` Akhil Goyal
  0 siblings, 0 replies; 2+ messages in thread
From: Akhil Goyal @ 2020-05-09 22:01 UTC (permalink / raw)
  To: Kevin Traynor, dev, pablo.de.lara.guarch; +Cc: david.marchand, stable

> gcc 10 defaults to fno-common and it reports:
> 
> crypto_kasumi_rte_kasumi_pmd_ops.c.o:(.data.rel+0x0):
> multiple definition of `rte_kasumi_pmd_ops';
> crypto_kasumi_rte_kasumi_pmd.c.o:(.bss+0x8): first defined here
> 
> Fix by making rte_kasumi_pmd_ops extern in the header file.
> 
> Fixes: 2773c86d061a ("crypto/kasumi: add driver for KASUMI library")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> 
Applied to dpdk-next-crypto

Thanks.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-09 22:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20200505125442.18048-1-ktraynor@redhat.com>
2020-05-06  9:45 ` [dpdk-stable] [PATCH v2] crypto/kasumi: fix gcc 10 fno-common error Kevin Traynor
2020-05-09 22:01   ` [dpdk-stable] [dpdk-dev] " Akhil Goyal

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git