From: Akhil Goyal <akhil.goyal@nxp.com>
To: Anoob Joseph <anoobj@marvell.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "declan.doherty@intel.com" <declan.doherty@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v2] security: fix crash at accessing non-implemented ops
Date: Thu, 23 Apr 2020 16:14:19 +0000 [thread overview]
Message-ID: <VI1PR04MB3168EAF44C806D670D995070E6D30@VI1PR04MB3168.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <MN2PR18MB28773439B71C687D4D966EB2DFD30@MN2PR18MB2877.namprd18.prod.outlook.com>
Hi Anoob,
>
> Hi Akhil,
>
> I have my concerns over unwanted checks in the datapath. Something that
> crypto enqueue/dequeue APIs are not doing is being enforced on other APIs. As
> Konstantin had suggested, PMDs (IXGBE here) could define a function which
> returns -ENOTSUP and it would have been win-win for everyone.
>
> Anyway, I don't have any objections to this.
>
Your concerns are valid and those can be handled separately.
We will apply this patch.
next prev parent reply other threads:[~2020-04-23 16:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200422235158.24497-1-konstantin.ananyev@intel.com>
2020-04-23 15:10 ` Konstantin Ananyev
2020-04-23 15:51 ` Akhil Goyal
2020-04-23 16:08 ` Anoob Joseph
2020-04-23 16:14 ` Akhil Goyal [this message]
2020-04-23 16:29 ` [dpdk-stable] [dpdk-dev] " Lukasz Wojciechowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB3168EAF44C806D670D995070E6D30@VI1PR04MB3168.eurprd04.prod.outlook.com \
--to=akhil.goyal@nxp.com \
--cc=anoobj@marvell.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).