From: Sachin Saxena <sachin.saxena@nxp.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v1] net/dpaa2: fixes issue of accidentally resetting rx offloads flags
Date: Mon, 11 Nov 2019 16:05:46 +0000 [thread overview]
Message-ID: <VI1PR04MB484502520F4F103A6B554642E3740@VI1PR04MB4845.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <2597413.12N5DsGnAP@xps>
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Monday, November 11, 2019 9:27 PM
> To: Sachin Saxena <sachin.saxena@nxp.com>
> Cc: dev@dpdk.org; ferruh.yigit@intel.com; stable@dpdk.org
> Subject: Re: [PATCH v1] net/dpaa2: fixes issue of accidentally resetting rx
> offloads flags
>
> 11/11/2019 16:36, Sachin Saxena:
> > The JUMBO frame handling in dpaa2_dev_mtu_set api was not correct.
> > When frame_size is greater than RTE_ETHER_MAX_LEN, the intention is to
> > add JUMBO flag in rx offload while it was resetting all other flags
> > other than JUMBO as AND operator was used instead of OR.
>
> Hi,
> About the title of this patch:
> - "fixes" should be "fix" (infinitive verb)
> - "issue" is not needed after "fix"
> - we don't care whether it is "accidentally resetting"
> You should just tell what is fixed and what is the case:
> fix Rx offload flags on jumbo MTU set
>
[Sachin Saxena] Thanks for information. I got your point.
next prev parent reply other threads:[~2019-11-11 16:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 15:36 Sachin Saxena
2019-11-11 15:57 ` Thomas Monjalon
2019-11-11 16:05 ` Sachin Saxena [this message]
2019-11-11 16:08 ` [dpdk-stable] [PATCH v2] net/dpaa2: fix Rx offload flags on jumbo MTU set Sachin Saxena
2019-11-11 16:33 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB484502520F4F103A6B554642E3740@VI1PR04MB4845.eurprd04.prod.outlook.com \
--to=sachin.saxena@nxp.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).