From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07506A0353 for ; Sat, 9 May 2020 19:44:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DFE521D5CF; Sat, 9 May 2020 19:44:14 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150058.outbound.protection.outlook.com [40.107.15.58]) by dpdk.org (Postfix) with ESMTP id 6BA971D483; Sat, 9 May 2020 19:44:11 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VgDiNsrUTQBGU2aDniHPRAitOut2JYZV5Cw+LVKtrARgzjKfXICjW6T8Qk3O8nMR0b2Svrdxc6s588NUBr0139zPfvCc9Mn9gvqc7eRcTe5Zbg9ZJuORoytjhEfPBC++Hh2qMbbwlVQInNV4e0vKlRXHO+EhGu4xNI/t54Ee7MknkkOUB67S6kMlDHWyCIhkHHfSyQaSSAYXRFVbSqdF9YxtF4GTYyPC75LmU6tLRfFKEWw3ndWh4Oy3tr1iN0dh7GyfRUK97XEkloTP8HwazldYrj9i+b8nE0JLLoTa8fuIyapXDyzsY9iJdBndmTtUHX4iq9ieGRYp3BHEv9uP4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ObKLvA+3FurKdsCU2hjEDkoSNJj+evT7bXJso0YgYs8=; b=YkhjjILEscYjk7cYnKoIEiH6QQSJlNZX4qAmFo5s2SkLS+yucoLcJcA4ESYneurIgEGb/Ps/IfoWptrJ1oB7DooEg9q2mimdS2WPWm/G/t6HzNrHovJe5Q6f3xjKfEzB/NmBeus6t2C5NNwCwEwM9GSmO0QzXWglMKkelZAx+UR+Pf0ZPuYy2aXtB8w9gIZQXL/qbH/ci0saPyW9L5+NZkz8KQlprEEKXNdiTDXWCKuchQ3qw0MFoEEgH4/kaqeHo4zhY8HmoPUSgzh8VBmEra4VSto69/aoRD82dYMjHCYuS9iTN3wJ/X5fpOx4kwm+zAVypvgFmHdZhcVTkp9Gkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ObKLvA+3FurKdsCU2hjEDkoSNJj+evT7bXJso0YgYs8=; b=srzFVfiJroOoQhiUTAqY8DZ6K0FXMktOKDHuBETosOBu+VPX2U7cNl0A1dSpyQveA2cBbKFu4nk9q1WHThNeyCtkqWZX7MgRwT/CtVCdoxise3dRXRl3iVKw/+g/Zy53pmQPuWAfQfgFyVLAKZJbjORCZ9nFyS+uVsQqTUaUnVI= Received: from VI1PR04MB6960.eurprd04.prod.outlook.com (2603:10a6:803:12d::10) by VI1PR04MB5245.eurprd04.prod.outlook.com (2603:10a6:803:5a::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.29; Sat, 9 May 2020 17:44:09 +0000 Received: from VI1PR04MB6960.eurprd04.prod.outlook.com ([fe80::dd6:d975:588f:1c1c]) by VI1PR04MB6960.eurprd04.prod.outlook.com ([fe80::dd6:d975:588f:1c1c%3]) with mapi id 15.20.2979.033; Sat, 9 May 2020 17:44:09 +0000 From: Gagandeep Singh To: wangyunjian , "dev@dpdk.org" , Akhil Goyal CC: Hemant Agrawal , "jerry.lilijun@huawei.com" , "xudingke@huawei.com" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] crypto/caam_jr: fix wrong check of fd Thread-Index: AQHWG8rI44mHCdfRd0u9BduxVJOHeaigGinA Date: Sat, 9 May 2020 17:44:09 +0000 Message-ID: References: <1587906052-1548-1-git-send-email-wangyunjian@huawei.com> In-Reply-To: <1587906052-1548-1-git-send-email-wangyunjian@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [106.211.90.32] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 7b00b4b7-2e22-4813-9908-08d7f44093e3 x-ms-traffictypediagnostic: VI1PR04MB5245:|VI1PR04MB5245: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3631; x-forefront-prvs: 03982FDC1D x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YjkCLzz102OGVMd5Ea6M+ZNPFN+bYkKbW+aDCeFqMrHGYjqSrTqxfE3vxi80OvE57WFXaOzXq9Jkdb39Zy8YWqGdA+ib82R0YmG0QTMX3RW7kuBIby+F6ljlMSV7AuktlDuUy+Iz9TCFfI3GgDpiZdyg+5ATyM8nJpOlkuLX2pIH+gr/0WRIB5LNqjtFY90EoNCAQ1O4IAztobICAk9rP5q/dqp2y9SKo9YUqrCvKk8kb3Gd7eJfZ11hv7WyF9upDRTJOOnAoSi7MKqe3o8Vu9/ygS+ed4Dt/3kplCk96SjUfO7TPJwQ0bCC2qszg65TA63X7nqZJD1wdvKvv0JvLaLj6lqZVmwtN+tNqZm/yeNgYQPUKI99QybyjYjw5MiSZL4ECzWsH+pFXM2HsZQUzbBdTJ5A/6V6xfnXpuqcrd1o2kDVUGaQyGfoiFLp9GADJ4G/mqqFEyGaw/Y7CdkcRd4za8XhS26lGINCe/w9Xzi7nQaGH6+hw9SdFIvjWo8JYz1uFyTotuIkZeQlwOqCPw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB6960.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(376002)(136003)(39860400002)(396003)(366004)(33430700001)(76116006)(33440700001)(9686003)(64756008)(316002)(71200400001)(55236004)(66476007)(66446008)(4326008)(66556008)(86362001)(66946007)(55016002)(6636002)(8676002)(5660300002)(110136005)(54906003)(52536014)(7696005)(2906002)(53546011)(6506007)(8936002)(33656002)(26005)(478600001)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: rzwXoUVezF34LCEKtykKW51m0v7cRgEKs1fFZUnsOv66I4x5dC+T7Godujzs9HI7xD1erVzOoKfNHB8jACzumP88Mvl2xn5rBTW7oHvTffmD+Dn4A2Bq5Mczcda7b4wW5xCrs2qFyO/7PpVxSK0Muyjkpqvf13aKP36b/tEAPl6wo6USwKe6umig5sxZ+HtJ2pijP3tZQCooLJg1GxREF655LTzPqixktcdDkgo/tm+N1QKGXEMdDKcF0Ag9u/QQtxYt+H0TEKcC4wTA9rEFqJyxi0m3p6KJh6JqUmvYCGT3qALzCmjW4C20m+GrW5qYUkibPoCoEVtfDZqJ3cJcvmroeazfYZoZyPqr293GXJBvDeiZB7YUOOdZf94MkkpkMjXMAlJ8SZh8XY37m7HTirVGQ9mF+mrFbM5RkuKU49G+81AocQMtoVutKWYz6OOVOoYnQQ+DD5HVW/RL/sEy+nrnP41ZurDEX5MsEvXZGqw= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b00b4b7-2e22-4813-9908-08d7f44093e3 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2020 17:44:09.2017 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: le+eE+VgTyI4l0L96glmxj+G6gJ4KQqgeWZTmC4Zc3q0q12iMkQjWMaUVwImJ8ss X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5245 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] crypto/caam_jr: fix wrong check of fd X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: wangyunjian > Sent: Sunday, April 26, 2020 6:31 PM > To: dev@dpdk.org > Cc: Gagandeep Singh ; Hemant Agrawal > ; jerry.lilijun@huawei.com; > xudingke@huawei.com; Yunjian Wang ; > stable@dpdk.org > Subject: [dpdk-dev] [PATCH] crypto/caam_jr: fix wrong check of fd >=20 > From: Yunjian Wang >=20 > Zero is a valid fd. It will fail to check the fd if the fd is zero. >=20 > Fixes: e7a45f3cc245 ("crypto/caam_jr: add UIO specific operations") > Cc: stable@dpdk.org >=20 > Signed-off-by: Yunjian Wang > --- > drivers/crypto/caam_jr/caam_jr_uio.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/crypto/caam_jr/caam_jr_uio.c > b/drivers/crypto/caam_jr/caam_jr_uio.c > index b1bb44ca4..658de5460 100644 > --- a/drivers/crypto/caam_jr/caam_jr_uio.c > +++ b/drivers/crypto/caam_jr/caam_jr_uio.c > @@ -145,7 +145,7 @@ file_read_first_line(const char root[], const char > subdir[], > "%s/%s/%s", root, subdir, filename); >=20 > fd =3D open(absolute_file_name, O_RDONLY); > - SEC_ASSERT(fd > 0, fd, "Error opening file %s", > + SEC_ASSERT(fd >=3D 0, fd, "Error opening file %s", > absolute_file_name); >=20 > /* read UIO device name from first line in file */ > @@ -389,7 +389,7 @@ uio_job_ring *config_job_ring(void) >=20 > /* Open device file */ > job_ring->uio_fd =3D open(uio_device_file_name, O_RDWR); > - SEC_ASSERT(job_ring->uio_fd > 0, NULL, > + SEC_ASSERT(job_ring->uio_fd >=3D 0, NULL, > "Failed to open UIO device file for job ring %d", > job_ring->jr_id); >=20 > @@ -488,7 +488,7 @@ sec_cleanup(void) > /* I need to close the fd after shutdown UIO commands need to > be > * sent using the fd > */ > - if (job_ring->uio_fd !=3D 0) { > + if (job_ring->uio_fd >=3D 0) { > CAAM_JR_INFO( > "Closed device file for job ring %d , fd =3D %d", > job_ring->jr_id, job_ring->uio_fd); > -- > 2.19.1 >=20 Reviewed-by: Gagandeep Singh