From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F596A0A0A for ; Mon, 24 May 2021 12:28:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 14F9F41117; Mon, 24 May 2021 12:28:42 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70042.outbound.protection.outlook.com [40.107.7.42]) by mails.dpdk.org (Postfix) with ESMTP id DB8704003C; Mon, 24 May 2021 12:28:38 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=egkcMksQLF/23WXHoAg6r5B2pkpHKRpUMALijQMYlYPCKJXjWBOEbP+njYKMfvCsqTZa1YpR66Hs/w2imiIeXxx0gOCrky7yAex8n8GMhS7DxrD73v9OAzX1G1epKDy9H2nR2gUqaM1cMr/05tppt8rHQHFSOTyzqntLbJ2mIXMAhT7d0EWDc8Bmy3Nhs/c9ueqI8kErPHQB1ZaGwMPnI7u/8R3Z1OfvT4atz8ywI4IvcTO1NnZQVezSXy93TdTmAyAFzsufZ+RsgBRl9WFEL9N9Pb9wU1/C6a6XvledNVMcy0grj65H1HEU+kr4wE2I4DWt1cyS5r8JQqwOmSq1AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q2bhQ20oF1HxZp6eWoXDd2d1JV9Ku51nwwNNYgcCbpY=; b=SPw7zpAGWQV3FrnE4d0DkuWvCd0f8a4RBm2N8MBPPaiPOoDX0O1F5gtGx3LnKyvNsCi8cBerVGw5C3XXMnIqMFtqHKNl2kSVYwGo2XkQ9Rs2D8mm7mZUnjsvJ1FzDgy5g+UWvxOs7MpYdrK8kgCKNQ5Jla2kPb9HNCU4ro3777gO6U/8dmSgAIhdAHem0qF453ZfgOerbMmfgigMqAVY7noyKXB+hqxjyGRSUPHHtJXU9X7fscue5PQSi87L3HAxaYCcgQ+e5u4EJlPXrtnghP1GIwebSNKH2uFgBrIvFEhWhilTv/Z+O7n7DIeyaPIA1ZU7CGOY1wwji4jUPOOWhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q2bhQ20oF1HxZp6eWoXDd2d1JV9Ku51nwwNNYgcCbpY=; b=cWhQp1a5PZgp9IkdXG5ymTYaYIREoLol0cskr4VK/IUbFR1td25+yVP0TjhAgwVTp808B/SevJzTQ54W4rM88ocoWuHN5qosdBybUNcAm6xdvf5mvaFw778SRnuL8KrfvZljiZTDaY8/ov1uqscT0vVXAnLd5zUnKJsT0iMyPw4= Received: from VI1PR04MB6960.eurprd04.prod.outlook.com (2603:10a6:803:12d::10) by VI1PR0402MB3904.eurprd04.prod.outlook.com (2603:10a6:803:17::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.26; Mon, 24 May 2021 10:28:37 +0000 Received: from VI1PR04MB6960.eurprd04.prod.outlook.com ([fe80::3502:3562:a059:fe51]) by VI1PR04MB6960.eurprd04.prod.outlook.com ([fe80::3502:3562:a059:fe51%4]) with mapi id 15.20.4150.027; Mon, 24 May 2021 10:28:37 +0000 From: Gagandeep Singh To: Thierry Herbelot , "dev@dpdk.org" CC: Thomas Monjalon , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/pfe: no need to check dev to be NULL Pointer Thread-Index: AQHXUIB+HFBAxB4roEC+U7Z22B1GzqrybeDQ Date: Mon, 24 May 2021 10:28:37 +0000 Message-ID: References: <20210524085917.16254-1-thierry.herbelot@6wind.com> <20210524093754.21046-1-thierry.herbelot@6wind.com> In-Reply-To: <20210524093754.21046-1-thierry.herbelot@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [157.39.42.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7deaada3-a9cf-4f50-e84f-08d91e9eb100 x-ms-traffictypediagnostic: VI1PR0402MB3904: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Xdm5Zh9QW1UI7l0l7B80vAoySVpi8WWsko99lwSXpF/jFkoataD9Us5nX4ntBq+yBlXX2gDDOfFGV/pUtN6rfRmHcY7SAuban9NraQsXYpoACBD1YumloC2ZFCO8xk/Taf95D60auHOeJfrDpF8uCWeOgBBNlh2lE81f0w6c08JiXTQkpf6ns841AObNQSM4+5esZw25t3p0UkTDfD4Ua6kN6kALtSLo269TRD4bjb7ROPm4SIOhSNJuVERd42OwDF3dVuG9teyfTqEQlkLcUOJwgB4MCwBXQGyYkT+0cSZTHIjWCzIqhlCbjTpN6LtI3syJw4Ie7KLB4aouvYM8ZjGzpBpELqLGsMkMzGzqWWebQefbGow42hYzLEhbRJ1eBpo+cMU+vpdtyc2PfvdEOgOXT//Up3UF9K75IXVUA+D2RePIuLoE/Y0SlukO24sd/FLR/+tR24RIfMfjkO4M8suJV31+rUTn4Gxz5HLpIw/PAh6hFBBjtKmbGJ6pGs7Y9kkvqClt4M93zGGgH/3GaSz/hKRRxWIeCog19wCJc7NW82shars1+zg17DUs3k7gbW3xpaGzz8ydI4R3T3r1zA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB6960.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39860400002)(376002)(396003)(366004)(136003)(64756008)(53546011)(66946007)(7696005)(33656002)(76116006)(316002)(478600001)(66556008)(6506007)(5660300002)(122000001)(9686003)(71200400001)(38100700002)(55016002)(54906003)(26005)(66476007)(110136005)(86362001)(2906002)(52536014)(8936002)(66446008)(83380400001)(186003)(8676002)(4326008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?F+SkKzIVXsDjaXIZss+mlEr/vTahPX+sqCFo6pmYTrq5d+yaDp27Mu426XiZ?= =?us-ascii?Q?vW6pQhmW7MsXJgo/rk6NPXYseVYxtuPFuZ4yj7rY79lBTL9WQfk59lUISopu?= =?us-ascii?Q?swGYb1MXU+EQhXPYU6cTflQGLbFDGqTp5hELPBOu4U3A1BoWyBk/rHX+FFuz?= =?us-ascii?Q?3qlo3FrFkRREfHEs3Hb6yN60BqSSzbtI6Z4kqZSWYV+MowKlRHTMsU6MR3U1?= =?us-ascii?Q?ejMBdwBGW99YDM9om1mHW+DA6Mxw9xwmIJN5+qlWs+D/hZhOZWu/V9E8zd6S?= =?us-ascii?Q?aZhRuour/N4ocyvCFk7iKGnplGfTX0xXEqfzGaMepeJahp+kt7Hv4o45wOgp?= =?us-ascii?Q?6cIt9IaCOD6lge0zsfa+Xx0A1USixbfSn4lrV+1S2lsdN0mXeUEmReaKguvt?= =?us-ascii?Q?OxJTGIwBtD4XLVBbxw850ZFUZpDmVpf/rddpRHalR832GJuoIxggCxfOKSyc?= =?us-ascii?Q?3iGJHK0ksaSVmEn9hxnaLcHb69bIkeSUBQW/xvma8Ak0V1tu7xVYcNqIJp3k?= =?us-ascii?Q?SqTUAi9tyceLCV+9O/AHf6QvIpivPVgkWK1nRS2yU3TwzmadGG21HJgZgO5k?= =?us-ascii?Q?amZQ9wqpUk1t0ciLxKkemVn/z0ablEbnjgm73enystXMfOsPfdpm4dcgQyBX?= =?us-ascii?Q?aIwFfiQrN2Ya76TWeqXH36ic7zRMSnr8fxTfv+gqxOf/uqb4ArNlOjUTA0Pj?= =?us-ascii?Q?HjrJaNoHqFAEzya0lOKOROJ7wC9VD13DNmreDdmGtRP8Z7KGXN4qBcoABcb5?= =?us-ascii?Q?zoZRxMzrMMtGmtX0PVMWFJgc1U53nARe8GxDyY2zGsYNkRE1o3isCRqVGTrk?= =?us-ascii?Q?drXVpoAMTuSem03TTHi2oSauxweKElaxATB4JzaggoOoBY0Vh0oSWCIaYOJY?= =?us-ascii?Q?spXxQI4RX7fFKvxCQginXigfs9C8NV9hs8mzuis9K4TRGeeS36SXZxH8C33g?= =?us-ascii?Q?CTxX/JlTYmHcCq6czUHizVSYWS4CDZTlYrIye9LrNCCq2/9T/HLu4b93JqVP?= =?us-ascii?Q?J2tfrPgG9Sd76puxXBiE0hedqSE53AtHtDB0BMfwReD45Wqz8l3iARYE9NKM?= =?us-ascii?Q?f0jThLUyrePsOkFx/PI+nJ+6WnHhRMQk12EzgENxUycmzcXXgfUASumLc5Cr?= =?us-ascii?Q?o7lWptTtrnaU8CdwZQ5PPoWUIGfw/sYNO7wYICyejxsCuIpTrq+hI3KTO7a4?= =?us-ascii?Q?mlgY20/KuDipV+hzCInKFCxEPwtbSD9quTeOcpPvU6klTYkGFTqNn8SSktSr?= =?us-ascii?Q?r4mlHj606rOASf+hx3xpGYcly+3jdmxxD8zdK9NU8vI0zZdCjX92C7WkzguE?= =?us-ascii?Q?sPc=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB6960.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7deaada3-a9cf-4f50-e84f-08d91e9eb100 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2021 10:28:37.2032 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HjdIYd5r74Fe+bG5AfbRTXoT1GGs5mh9BapW0/pNbYVEaBWQxJmcJMYFD9jc12oI X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3904 Subject: Re: [dpdk-stable] [PATCH v2] net/pfe: no need to check dev to be NULL Pointer X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Thierry Herbelot > Sent: Monday, May 24, 2021 3:08 PM > To: dev@dpdk.org > Cc: Thierry Herbelot ; Thomas Monjalon > ; stable@dpdk.org; Gagandeep Singh > > Subject: [PATCH v2] net/pfe: no need to check dev to be NULL Pointer >=20 > librte_ethdev library is already doing some checks on dev before calling > the link update. >=20 > Fixes: acd4818ea2a45 ("net/pfe: add link status update") > Cc: stable@dpdk.org > Cc: Gagandeep Singh >=20 > Signed-off-by: Thierry Herbelot > -- > V2: rework after noting dev cannot be NULL > --- Acked-by: Gagandeep Singh > drivers/net/pfe/pfe_ethdev.c | 5 ----- > 1 file changed, 5 deletions(-) >=20 > diff --git a/drivers/net/pfe/pfe_ethdev.c b/drivers/net/pfe/pfe_ethdev.c > index 3135466713fb..feec4d10a26e 100644 > --- a/drivers/net/pfe/pfe_ethdev.c > +++ b/drivers/net/pfe/pfe_ethdev.c > @@ -582,11 +582,6 @@ pfe_eth_link_update(struct rte_eth_dev *dev, int > wait_to_complete __rte_unused) > struct rte_eth_link link, old; > unsigned int lstatus =3D 1; >=20 > - if (dev =3D=3D NULL) { > - PFE_PMD_ERR("Invalid device in link_update.\n"); > - return 0; > - } > - > memset(&old, 0, sizeof(old)); > memset(&link, 0, sizeof(struct rte_eth_link)); >=20 > -- > 2.29.2