From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24B57A0547 for ; Mon, 24 May 2021 11:25:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 11DF44003C; Mon, 24 May 2021 11:25:32 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10051.outbound.protection.outlook.com [40.107.1.51]) by mails.dpdk.org (Postfix) with ESMTP id 012C04003C; Mon, 24 May 2021 11:25:30 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dPDvNaaoYsgxgTSu7EKxpka79+GZe1UalPTrJX2kwMqm2RqBtIGkc9UO49rG9R0GFlmyRdCWo+pols9w/MwFLUgGjZlDbxy5ryqmBuGbxlJWY2N4q5IFopTQKuc0LlV4YJxVNBFgCminVr6/WQTzmXPRmvQLlGRJ1/fcng1WKNGfL//pJQK4tKIbdn2mfy+VSTMXxizhmQmBJWTiuITCjccwlABuWZ316NjpeLTdPIPe4W3j/Uz+dhzGezqRInVfRFm52985STu2myWooCvKy2vHIywd4jDS1slDH2/yGgNhJxl0IXFe1DS/EUY2jFfwdITtq/ORDoVeYiqcZ4nQ9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZMew9Rwfgav3Myx2lmkQZl/eB0S5TCCmwMsqjSWnWY8=; b=JLuGps5Eer+FI+VR+E1YFtYxfplqYY6cdi+BuSxNb+g4n0Qu/pmZBk9sgxX71MsX6IoVrmPW9lO8Aj+7fNtsJznTlTKU4tQKP9N1gw9LSBZrTGUH8BjBVsw5qxjJaRPfBKXvyrVRnC6lfeoiBh8Mz0a3icqqy9R+KlqnoUqW0cOaVqn8VLK2YX+6ZlJHUyFHUPlzELHfJ0XHajr56rE0dylHmdGeLub84U9RBflmLwPk7EFN/6VML0W6H+s5WXGkBTaOADoCXVsSyVMv7tDbAv6DNEjPls3keqO9PxyoruBW7MjsDFZZ1hlDycaTJ8Raxh5RF2WZkeupeHUVe7RPvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZMew9Rwfgav3Myx2lmkQZl/eB0S5TCCmwMsqjSWnWY8=; b=MMyP6FT+AfqxfuM4Dh9SUu5aa/oaVeVylNnFHhAsCh/lVJGYslAF77QFg+UbSse0sfCfVW4+qQuoTP/f8XSM7+YR3MqJZuZnERtuy+ll9x6Zjzbtk1tkdrl6vv+wUia5Ayz2ODKWyGmS+S38bZsiZcj5/aACURv4eV0tAsSNaVE= Received: from VI1PR04MB6960.eurprd04.prod.outlook.com (2603:10a6:803:12d::10) by VI1PR0402MB3614.eurprd04.prod.outlook.com (2603:10a6:803:b::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.27; Mon, 24 May 2021 09:25:28 +0000 Received: from VI1PR04MB6960.eurprd04.prod.outlook.com ([fe80::3502:3562:a059:fe51]) by VI1PR04MB6960.eurprd04.prod.outlook.com ([fe80::3502:3562:a059:fe51%4]) with mapi id 15.20.4150.027; Mon, 24 May 2021 09:25:28 +0000 From: Gagandeep Singh To: Thierry Herbelot , "dev@dpdk.org" CC: Thomas Monjalon , "stable@dpdk.org" Thread-Topic: [PATCH] net/pfe: do not use a possibly NULL Pointer Thread-Index: AQHXUHsWQyetDh8M5kmabFImQWI1zaryWxKQ Date: Mon, 24 May 2021 09:25:28 +0000 Message-ID: References: <20210524085917.16254-1-thierry.herbelot@6wind.com> In-Reply-To: <20210524085917.16254-1-thierry.herbelot@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [157.39.42.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f0be389e-14be-4298-a4f1-08d91e95de81 x-ms-traffictypediagnostic: VI1PR0402MB3614: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1360; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Quvtz8tOiyPcfywrbArBL/QTHsfCKjcOUxbCQq2sv9HtvvzmQAizwLYevbCGyM3yQPaCziTdjhTJClN5mCbnD4X6uVBj14M563Loc85mJ3XKU856uh6Obhhl8+Ct6mpHe6nPcYUe4dRbkcfa+QyEnYke/mAHZxdfsf7Tr7Ym8doEpz5enmoZnU41xxJUmDl7o2Ps5Qo9DMlIGImbX2i60N+Pg1Dw5K77FjPoREuRhldfDY+QkhtgP5o4J4kJ2tTK7T2FZKpqBGbDbcpIugFRWXnjvxHdN3L5iGJKqDoXLikOPGP9b4EdTrzO28g0fyh/xAC6buAmFUrS35FIC+OxPCp+ljtnTbYyUGXpnFQAgpt4+qnMs3aXCO/aslSBjxypKX8ellzWZRzBM+qEN77Jl2L1Yel/ALSz6MbVEy0sOOTdzBGrjo0b/Xod8zPQ7Syarssg6KFt+lW1ERwk0fqkQmyAW8Hy9YZdCUTEZDTQBqs5TnZEbpWz7So9BF34FjmFgnJzKfBlGqmwFaSLEpcmvfipFziQsdLL5+p1vmHDzDOSDyBvFipj1Cg1ZHKtM2Qq3Dj0zhLGfv4wiDfrYUT6ouXXgdJeY/9JRs0SQ/Kdfus= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB6960.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(396003)(39860400002)(366004)(136003)(83380400001)(7696005)(53546011)(76116006)(8676002)(110136005)(6506007)(64756008)(66446008)(66556008)(52536014)(66946007)(4326008)(55016002)(186003)(8936002)(66476007)(26005)(478600001)(122000001)(5660300002)(38100700002)(71200400001)(33656002)(86362001)(54906003)(316002)(9686003)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?3WN6HpRXC3YnoQI/0WmdHb9G+LjPDPbpOPAFZ1K7EpdjUMG8xq/0Ig+HuaK0?= =?us-ascii?Q?AEK5rmJIlvUyP0++ftKcgvOnSF9LLZYd/kjp393MaP/qVxfZnbuSmZoapR0X?= =?us-ascii?Q?TfvzksDABd5nf1zWn2GlFmNni6+mSVsd4uhpGLlB/z+oDL1s6cT8anOlzxpu?= =?us-ascii?Q?JB75DeheT6BYqdNnEiiZwp6pUgE7Bw7J022f23QSSYaQy7YhJrDzl/dGHZ1A?= =?us-ascii?Q?1FU3QWIMv+Twpy6iPX/glLJGDxnuWpvP45GkvN2NtgXoatgRDCg6IFdNLvjh?= =?us-ascii?Q?YoYc6kUosqlYfkDv26lCLXtEgtcnG5fQ8h8uBEDWzvVpGv3SpsQMHoHsvvu8?= =?us-ascii?Q?lT3IrdFg7XakxA5AZStYljUYf62c36VvBgyM85/xG2PIbXCY6Bul2day0pGE?= =?us-ascii?Q?SX6G6pvqrnIKNggkJF0NZCKRnoepakG/zLmPLvrf3x3SY1aSH52T7HtTlTYs?= =?us-ascii?Q?27gwBoVnS8zWs6FemmXX4KbCn3Gj5E/OPSRhqFOdQ8I71uOuRG5enXoMQRkq?= =?us-ascii?Q?GBTzgXba/Gc6gCRiA73eFNxev5P5xaeLoss8OKW1MpPwp640yHNkCK7Oa7GF?= =?us-ascii?Q?61hjQXbM8tqxZfsrn0Dk9/cNn1eN07c0b0ANSC99XJanBk9jChQ7UHP2jxTV?= =?us-ascii?Q?pcWaWr3O2a+7c2+2S5yngCNW9YNHl2LTZunsTHjtsk3RFAiu39U25IPuZW9Y?= =?us-ascii?Q?7xtia8RQJvCrbEHjY0dPeETJyADblElp9HLRUbXWpSEzi11u0irQp21yXgmV?= =?us-ascii?Q?RDx7MVAEeR3j7KrquSelwrtTidbuhx6tUEdz9MhAjXs9XjJs3Qe16pRk73MT?= =?us-ascii?Q?fLkcR6mRdK+jTB/zEkW/8hVZtJnotVykeeR3fG99XFloe6zbPXBis6IFqIne?= =?us-ascii?Q?1HEdD4xhhRqNx5QruGOxLAIVRJP3EAfnZpWIokWbPA+ZTjonjs0hITl8vXaQ?= =?us-ascii?Q?/a+S0X3zxob/OUQI838nEuc6/G99fzd1+2EiSOVWtTvnr4vPLS5R6bOMkdwM?= =?us-ascii?Q?J4ufHXyEjkKQ+OHrkYJwczWyzYNduVhlfBjLXlHTuHn0BvOefIBTdiXP1q3f?= =?us-ascii?Q?MDbD2xc2ZcjiJnQCqwrjuQA50aThOB/aIMHF7+hkV5L0d/bKfjK3bD9U8/mr?= =?us-ascii?Q?E/WQ33wfcRWE2zFKV6laon8nFXBmow6Z+E9a3hmfnrsCvV83MebpzFhQJV0W?= =?us-ascii?Q?EK9WjXijU2zdW6hlJW5ezkE3ZjK5n9Idm4z+K3ogGHJxzgHsTgCUE2ImKIDJ?= =?us-ascii?Q?NwbtQmb7oVvH6OYWZywVL0qsuDhBzLHYiDgtk15emqbJokK7AcabnxR4E1Ob?= =?us-ascii?Q?kqc=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB6960.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0be389e-14be-4298-a4f1-08d91e95de81 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2021 09:25:28.1096 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gYFkvxgxT+RfTgJo115zWRkoEB8SL4sR42dJR4LEhDSATOVFhTx0L7sY8B3gO+kf X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3614 Subject: Re: [dpdk-stable] [PATCH] net/pfe: do not use a possibly NULL Pointer X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Thierry Herbelot > Sent: Monday, May 24, 2021 2:29 PM > To: dev@dpdk.org > Cc: Thierry Herbelot ; Thomas Monjalon > ; stable@dpdk.org; Gagandeep Singh > > Subject: [PATCH] net/pfe: do not use a possibly NULL Pointer >=20 > Use dev only after it was checked not to be NULL. >=20 > Fixes: acd4818ea2a45 ("net/pfe: add link status update") > Cc: stable@dpdk.org > Cc: Gagandeep Singh >=20 > Signed-off-by: Thierry Herbelot > --- > drivers/net/pfe/pfe_ethdev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/pfe/pfe_ethdev.c b/drivers/net/pfe/pfe_ethdev.c > index 3135466713fb..09048e57d973 100644 > --- a/drivers/net/pfe/pfe_ethdev.c > +++ b/drivers/net/pfe/pfe_ethdev.c > @@ -578,7 +578,7 @@ static int > pfe_eth_link_update(struct rte_eth_dev *dev, int wait_to_complete > __rte_unused) > { > int ret, ioctl_cmd =3D 0; > - struct pfe_eth_priv_s *priv =3D dev->data->dev_private; > + struct pfe_eth_priv_s *priv; > struct rte_eth_link link, old; > unsigned int lstatus =3D 1; >=20 > @@ -586,6 +586,7 @@ pfe_eth_link_update(struct rte_eth_dev *dev, int > wait_to_complete __rte_unused) > PFE_PMD_ERR("Invalid device in link_update.\n"); > return 0; > } > + priv =3D dev->data->dev_private; "dev" will never be NULL here because librte_ethdev library is already doin= g some checks on dev before calling the link update. So please remove the i= f check. >=20 > memset(&old, 0, sizeof(old)); > memset(&link, 0, sizeof(struct rte_eth_link)); > -- > 2.29.2