From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A00E2A00BE for ; Fri, 12 Jun 2020 22:00:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 72FBB1BF8C; Fri, 12 Jun 2020 22:00:02 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2057.outbound.protection.outlook.com [40.107.22.57]) by dpdk.org (Postfix) with ESMTP id 46A771BF74; Fri, 12 Jun 2020 21:59:59 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AkzqY2+YrOmcpq+rZmVK5QdgvGPFKTaxPGGV3hHNPUfujILQ3I9mtmXxVK8YE8gFdcjS59blK9VE15lqe63PHW/LbWkTx9eZQX5ZT9yP6d7womQD3QBd2R4nAY3DeIKUmLBc8TnChU32q6bkRE0SQcBQi0grblhRDJqthH+T+rHZU9wrw/X3Dqd1aDCkpdhOqKN9+txU/Zxx/CKCr1Y80A1FpnT1+4W9ZUTJ3suVyx+j4hj2YWy/J+C4yn2xdMaCf9W99X/z37EbAAP/zGhdMPMtqMg5T8o0LbRYX2yg9I0xfoqbb9Cb/NqatRbwWL+uG99rdYeDj5V6r4we5J7uyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0KYApQ7CSrbSBs6Swf9FaXO5o0EQxNBMIMIHA7rFGZo=; b=UKBSgJ4SihbBDz3+DGh0RTmxPoUm7uZGcf76r34l5gq/x1TQ/Ka8MnBY7tCwGoF91kFcbsSY+kPN61GzZrIGem0nO1rbl1p97g+xcEKE7NfYUE/3W85k4/dPbNqLQwPvDeNEisPgUKM2lv0X/5W5qsfAEvoyH0dxiQdtgOjdymYOoZS7g4jYg+ilH9T3Im7bG9vE0Rgib4LwOjF/u8Soek+TV4zM8aFbpqSZRDg3z6BRs7q2kyHvZPr466LMEEi4vAsq3BMa1o9Aon6TLtzjT93tzBlUTAtl2zwqC6DBc0qV0bNeKHRlLzTNZLpawZn2jKlskcZ9IFimOax0T4nlfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0KYApQ7CSrbSBs6Swf9FaXO5o0EQxNBMIMIHA7rFGZo=; b=IgYfBUOM3ytCy+JkktE4juSrh5OaBNJ1H93boT5Sm543PuExteCxVatlXpV0T2gHPlw3yjUdt8UNub5QQkl29uY6+ayBba7gEt4c3Dvs+kAO+xM+UtjnfoiyKOiHu4iZLUvziWrsRmzy+KI8EXmwdkTpwAMJd38T+CrTEzFisJE= Received: from VI1PR05MB3278.eurprd05.prod.outlook.com (2603:10a6:802:1f::28) by VI1PR05MB5534.eurprd05.prod.outlook.com (2603:10a6:803:9c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.22; Fri, 12 Jun 2020 19:59:56 +0000 Received: from VI1PR05MB3278.eurprd05.prod.outlook.com ([fe80::dc31:eda3:1f30:48ce]) by VI1PR05MB3278.eurprd05.prod.outlook.com ([fe80::dc31:eda3:1f30:48ce%6]) with mapi id 15.20.3088.021; Fri, 12 Jun 2020 19:59:56 +0000 From: Slava Ovsiienko To: Alexander Kozyrev , "dev@dpdk.org" CC: "stable@dpdk.org" , Raslan Darawsheh Thread-Topic: [PATCH] net/mlx5: do not select legacy MPW implicitly Thread-Index: AQHWQBe/Vhjn8s45yEij7r5eBHKcXKjVZ8bg Date: Fri, 12 Jun 2020 19:59:55 +0000 Message-ID: References: <1591897320-15192-1-git-send-email-akozyrev@mellanox.com> In-Reply-To: <1591897320-15192-1-git-send-email-akozyrev@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 83daa038-5ffb-4bfe-a783-08d80f0b2deb x-ms-traffictypediagnostic: VI1PR05MB5534: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 0432A04947 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BaVDGeM5OU4idvxeZ35qF1yW2QzheRmQuzQzshMC8JCpNrtXNyQ657Y48pf2xYFv8u2z0NmJW9Wr5kXjqxv4ZWpbMIRHIp8L/V//QmulZ6i//GxC7+2xUkG66PWnDtLq4vetbLNQzHhHcqeHNcL8vU3dXdPksg4NeMuPCDRcvmLEDADx+9YEM+9H5yjGD1KFkjVdo1+OHz+HM2xXw3XaFUs45cpsthPkGYoJtqabI9CEw9HsVTfgbpL4AKBE//pE041JPp+Fftbeht5Rp4O2s0NAw6jjbuGrKbLyY+CBwBNDO5I+l/tbohJLpi3w1nBr x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR05MB3278.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(136003)(346002)(366004)(396003)(376002)(8676002)(478600001)(7696005)(186003)(8936002)(33656002)(66946007)(66446008)(76116006)(110136005)(66556008)(9686003)(71200400001)(52536014)(5660300002)(83380400001)(26005)(450100002)(53546011)(55016002)(316002)(54906003)(107886003)(64756008)(4326008)(66476007)(86362001)(2906002)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: +5nrrf+P5WfmXaXOpQsj2BNXn3TipZ5FDz37/1ANt/h9F5q+b9oI7+EjKCLsY2Mp9x7ANNYTJI+08FlDcJSoftFp9N9COoA64w/ujznKBy9F8CmZ5vhNWwVDkfH/WVSCvlls7xcq5RxmTfk825BlMuYhrXPtNefhUX1RnQ5LW2vhTUGi/l0Gja6NwoJaiHN5TfCNSP1glT1H//go4lL5qPlej33qem32qZpo8o7ARH6473y9FBZAuQ3aWbcXj7QH8RVrCYfJdnPcxYz7AJnapNqtzPe7msH12lf9KEPqXWxXZ+X/ZgXzQIGrUIhTn7b+KPauHfLt3O+eXLduSXuizVP2K2CSS6/KOUR/0X/UNcyFYeM/WESp8NGxT218OtFGM1aGEkqD6cVutWShROjVCWH2NzRGa6BaA7EpWRFqDU8BE/SscXvo3vBmrNqwC7ysOntbA2hVSkI4DBc/P9QL1uccPA+3YAyVqksWga1z41Q= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 83daa038-5ffb-4bfe-a783-08d80f0b2deb X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2020 19:59:56.0101 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0jIiFIXhKagRTRLBMcNam9S9DKjWdMqaTYj2Sq/HH20AYcWgtcexqYIZBN/4j9jyRJ4ZrypZ/4MFb662b2QLxz3NILPdOdZpkKKSdzXTiaQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB5534 Subject: Re: [dpdk-stable] [PATCH] net/mlx5: do not select legacy MPW implicitly X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Alexander Kozyrev > Sent: Thursday, June 11, 2020 20:42 > To: dev@dpdk.org > Cc: stable@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko > Subject: [PATCH] net/mlx5: do not select legacy MPW implicitly >=20 > The Legacy MPW (multi-packet write) should not be engaged implicitly. > We should exclude this function form a Tx burst routine selection process > unless it is requested specifically by setting the txq_mpw_en devarg. > Exclude this function from the selection process the same way it is done = for > the Enhanced MPW in the mlx5_select_tx_function() routine. >=20 > Fixes: eb8121ab9dac ("net/mlx5: introduce Tx burst routine template") > Cc: stable@dpdk.org >=20 > Signed-off-by: Alexander Kozyrev Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_rxtx.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c > index 6a17a9a..df58af5 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.c > +++ b/drivers/net/mlx5/mlx5_rxtx.c > @@ -5542,6 +5542,9 @@ enum mlx5_txcmp_code { > /* Does not meet requested offloads at all. */ > continue; > } > + if ((olx ^ tmp) & MLX5_TXOFF_CONFIG_MPW) > + /* Do not enable legacy MPW if not configured. */ > + continue; > if ((olx ^ tmp) & MLX5_TXOFF_CONFIG_EMPW) > /* Do not enable eMPW if not configured. */ > continue; > -- > 1.8.3.1