patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Raslan Darawsheh <rasland@mellanox.com>
To: Slava Ovsiienko <viacheslavo@mellanox.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@mellanox.com>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] common/mlx5: fix physical port name pattern recognition
Date: Thu, 9 Jul 2020 12:01:38 +0000
Message-ID: <VI1PR05MB671842F940B4BC3A327D4E41C2640@VI1PR05MB6718.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1594241536-5300-1-git-send-email-viacheslavo@mellanox.com>

Hi,

> -----Original Message-----
> From: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> Sent: Wednesday, July 8, 2020 11:52 PM
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@mellanox.com>; Raslan Darawsheh
> <rasland@mellanox.com>; stable@dpdk.org
> Subject: [PATCH] common/mlx5: fix physical port name pattern recognition
> 
> This patch makes the Infiniband device physical port name
> recognition more strict. Currently mlx5 PMD might recognize
> the names like "pf0sf0" erroneously as "pf0" and the wrong
> device type (host PF representor) is reported.
> 
> The names like "pf0sf0" belong to PCI subfunctions which
> is currently not supported by mlx5 PMD and this false
> recognition must be eliminated.
> 
> Fixes: 420bbdae89f2 ("net/mlx5: fix host physical function representor
> naming")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
>  drivers/common/mlx5/linux/mlx5_common_os.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/common/mlx5/linux/mlx5_common_os.c
> b/drivers/common/mlx5/linux/mlx5_common_os.c
> index e74aa89..7bb3ba6 100644
> --- a/drivers/common/mlx5/linux/mlx5_common_os.c
> +++ b/drivers/common/mlx5/linux/mlx5_common_os.c
> @@ -89,7 +89,7 @@
>  mlx5_translate_port_name(const char *port_name_in,
>  			 struct mlx5_switch_info *port_info_out)
>  {
> -	char pf_c1, pf_c2, vf_c1, vf_c2;
> +	char pf_c1, pf_c2, vf_c1, vf_c2, eol;
>  	char *end;
>  	int sc_items;
> 
> @@ -97,9 +97,9 @@
>  	 * Check for port-name as a string of the form pf0vf0
>  	 * (support kernel ver >= 5.0 or OFED ver >= 4.6).
>  	 */
> -	sc_items = sscanf(port_name_in, "%c%c%d%c%c%d",
> +	sc_items = sscanf(port_name_in, "%c%c%d%c%c%d%c",
>  			  &pf_c1, &pf_c2, &port_info_out->pf_num,
> -			  &vf_c1, &vf_c2, &port_info_out->port_name);
> +			  &vf_c1, &vf_c2, &port_info_out->port_name,
> &eol);
>  	if (sc_items == 6 &&
>  	    pf_c1 == 'p' && pf_c2 == 'f' &&
>  	    vf_c1 == 'v' && vf_c2 == 'f') {
> @@ -110,8 +110,8 @@
>  	 * Check for port-name as a string of the form p0
>  	 * (support kernel ver >= 5.0, or OFED ver >= 4.6).
>  	 */
> -	sc_items = sscanf(port_name_in, "%c%d",
> -			  &pf_c1, &port_info_out->port_name);
> +	sc_items = sscanf(port_name_in, "%c%d%c",
> +			  &pf_c1, &port_info_out->port_name, &eol);
>  	if (sc_items == 2 && pf_c1 == 'p') {
>  		port_info_out->name_type =
> MLX5_PHYS_PORT_NAME_TYPE_UPLINK;
>  		return;
> @@ -120,8 +120,8 @@
>  	 * Check for port-name as a string of the form pf0
>  	 * (support kernel ver >= 5.7 for HPF representor on BF).
>  	 */
> -	sc_items = sscanf(port_name_in, "%c%c%d",
> -			  &pf_c1, &pf_c2, &port_info_out->pf_num);
> +	sc_items = sscanf(port_name_in, "%c%c%d%c",
> +			  &pf_c1, &pf_c2, &port_info_out->pf_num, &eol);
>  	if (sc_items == 3 && pf_c1 == 'p' && pf_c2 == 'f') {
>  		port_info_out->port_name = -1;
>  		port_info_out->name_type =
> MLX5_PHYS_PORT_NAME_TYPE_PFHPF;
> --
> 1.8.3.1


Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

      reply	other threads:[~2020-07-09 12:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-08 20:52 Viacheslav Ovsiienko
2020-07-09 12:01 ` Raslan Darawsheh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR05MB671842F940B4BC3A327D4E41C2640@VI1PR05MB6718.eurprd05.prod.outlook.com \
    --to=rasland@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=matan@mellanox.com \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git