From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC865A0528 for ; Thu, 9 Jul 2020 14:01:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 739C41E86E; Thu, 9 Jul 2020 14:01:43 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150079.outbound.protection.outlook.com [40.107.15.79]) by dpdk.org (Postfix) with ESMTP id D233D1E537; Thu, 9 Jul 2020 14:01:38 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=emG30wQi6n/lbLSLL3Z/LN6dF0dcvQtYdvGvzV8bD+s95Y5Kvmg9k7MqZAWLcd8+nRfDmbPbKT62VGX+B+qWqKpOgBobEsk0R/o31QRaRfK3+XdtUxfkjeFMnPRZctZsLGREhWOhp+HNKHcDyqHbILpkfI1YcwHt7QFrHe0UCvFDr0x+m4PAOgkbwQZQtTqRikqSQVB69KeWTBJyC7bVSCCoGFk8SOsnnzmHpxAmEzR+1ZcKe7cFotQjlsTkKIsBoC4NklPRx7HmbZkFgyCogTt+JonkvIFphy1e03L1nKZkhQ1moHyKutru/2XUy8wXBX7uXH2PnuppC8cjDo+ZUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z6eBDNf+YuUjBI7EljECgaz8s5Zx+hUYTWcbWpUMpGU=; b=hrSaWJ2S5K8Ck6WJCN2ap1odunjycpXOcf/80lczifmBbNIo6PM/ShDG/x1YSYBRciLt7CAQQgkRK2vszTGkXtY5V3wcf/ouBMYLY0+6SkLfMXmLf5RPPZpgqsMRsOBR1+BjSDHftGdIsF+2UoxvQKD5loYWve5ip4IGHxqB+fYgudx10MBaT1P7DU6cWH35oeRvTnAGpAiTF9WGeBiSSHYySlBKRS+9da9kBbqGWiMxsmZ2hEJ8Pyqoo96AzyJM4f/vwFQy5WLrGb8yEnQ0CEITjeWBh4Oh5WO/RZXm8RSwnvPPAAIeUuJX0n06LD1KkVHEit/g/B9GO/CAS/Fmgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z6eBDNf+YuUjBI7EljECgaz8s5Zx+hUYTWcbWpUMpGU=; b=jCzKGkBOlXPoUnlkZ7s5Ny2lOE4XGDzxXR+44sP3ewrrqJWCxPMQ2cHSIpHQJmPv+TO5waZNLKP183vYWEQiWEX5zrBKYRnmcjaBwVB56lQU0NDZNwzO6ia4yUT4uXeUOdA0aWuktxhCwfK88bWuOm9TsbiaB0F8tZ6E4WY5hFk= Received: from VI1PR05MB6718.eurprd05.prod.outlook.com (2603:10a6:800:13b::9) by VI1PR05MB5053.eurprd05.prod.outlook.com (2603:10a6:803:5b::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.20; Thu, 9 Jul 2020 12:01:38 +0000 Received: from VI1PR05MB6718.eurprd05.prod.outlook.com ([fe80::bc68:25c4:b452:f24d]) by VI1PR05MB6718.eurprd05.prod.outlook.com ([fe80::bc68:25c4:b452:f24d%9]) with mapi id 15.20.3174.022; Thu, 9 Jul 2020 12:01:38 +0000 From: Raslan Darawsheh To: Slava Ovsiienko , "dev@dpdk.org" CC: Matan Azrad , "stable@dpdk.org" Thread-Topic: [PATCH] common/mlx5: fix physical port name pattern recognition Thread-Index: AQHWVWmtKx2qDkHUqUyNyCS/9tPqKKj/JdCw Date: Thu, 9 Jul 2020 12:01:38 +0000 Message-ID: References: <1594241536-5300-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: <1594241536-5300-1-git-send-email-viacheslavo@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [84.242.49.134] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 8106cccb-44a1-46d7-e3eb-08d823ffd5ab x-ms-traffictypediagnostic: VI1PR05MB5053: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: R+KmZypdqBwrT9gZdjs6OFB7m/Aph2s5mCVpl6rd4Ud3j6K7Obb+Apr9BvVsc6mnHQfU1A+6Vd3pDFsmq8gWHyLazIRMdkLGvEz+UdcT/ZyrufbDjPUvt/Dk7N3lN7DiuEd/bZMiQuH6FGSC3t1SfBBCxLJ2iWs5XavVonAzNwcowvFZhaAIBs1PmYFtsrOBS5ywQX6UAv6RjWqo4q0x05AgqeYsQVth6C0im2snTdAByIGZrRCFfz/7b21yZFYS8PYwUxOOJfnHg1TGt4cHNtpOLYFDwmPNi7S4+6pyXei67kxD3Idup0lnFah62+PS1Jrel2sXztA8WBDuOPrNPQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR05MB6718.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(136003)(396003)(39860400002)(376002)(366004)(71200400001)(52536014)(55016002)(9686003)(83380400001)(316002)(478600001)(450100002)(7696005)(86362001)(6506007)(53546011)(26005)(4326008)(33656002)(54906003)(2906002)(66946007)(76116006)(66476007)(66446008)(64756008)(66556008)(110136005)(5660300002)(8936002)(8676002)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: D2Atp1YsmvpfEwNyozgHLhKX8aJqctB+Qoj4fPMTrVfaTxV7RqTELm3lBlzl0blqEs/+bji82x+DAipzDExY0h0szjemVbpD0lIrFbkFjLvb7o8A12GPRwFMBTXObnv/d730VFUwSnvwQqwfifNv6JcDpGUkHR7C3aW2Z7F2PFoCitvj0n6QP4C99w06vV8I0y3zOilMoBKecEH16uqesW2JJQXb2mI7Mz4y3w27dhFHqpyRgxLya9NXHhoown/oiZw678B09Mi8qtxSYA0qBxcislldE4AsJehCCkn1xJd9JEhe1GYnm52RzZvlkbp1yuWKx2OEGSAU7V3Gw3F4sgIOWWCRIxH49RXvfS5xA5SegzeHH9XxadLXTLhcJos3uxPb6yo/FwEy2ZTT2aIUxPNjv23BMg7l+QBTzuNdr0deLcKR4ePYxfGTnIOjy6LU8YBFYAVE/IUfYdRBswshWXC28Yky+nLqjaY0OEkl4cc= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR05MB6718.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8106cccb-44a1-46d7-e3eb-08d823ffd5ab X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jul 2020 12:01:38.0185 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ywHSV6PtJXxEDmGOqB20PChtirICr/Xyo6dGuqUieGK2qbN2U4w4l1Dw3Q0Gpr8RMElG4JOyDoRcfzFmokeheA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB5053 Subject: Re: [dpdk-stable] [PATCH] common/mlx5: fix physical port name pattern recognition X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: Viacheslav Ovsiienko > Sent: Wednesday, July 8, 2020 11:52 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; stable@dpdk.org > Subject: [PATCH] common/mlx5: fix physical port name pattern recognition >=20 > This patch makes the Infiniband device physical port name > recognition more strict. Currently mlx5 PMD might recognize > the names like "pf0sf0" erroneously as "pf0" and the wrong > device type (host PF representor) is reported. >=20 > The names like "pf0sf0" belong to PCI subfunctions which > is currently not supported by mlx5 PMD and this false > recognition must be eliminated. >=20 > Fixes: 420bbdae89f2 ("net/mlx5: fix host physical function representor > naming") > Cc: stable@dpdk.org >=20 > Signed-off-by: Viacheslav Ovsiienko > --- > drivers/common/mlx5/linux/mlx5_common_os.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) >=20 > diff --git a/drivers/common/mlx5/linux/mlx5_common_os.c > b/drivers/common/mlx5/linux/mlx5_common_os.c > index e74aa89..7bb3ba6 100644 > --- a/drivers/common/mlx5/linux/mlx5_common_os.c > +++ b/drivers/common/mlx5/linux/mlx5_common_os.c > @@ -89,7 +89,7 @@ > mlx5_translate_port_name(const char *port_name_in, > struct mlx5_switch_info *port_info_out) > { > - char pf_c1, pf_c2, vf_c1, vf_c2; > + char pf_c1, pf_c2, vf_c1, vf_c2, eol; > char *end; > int sc_items; >=20 > @@ -97,9 +97,9 @@ > * Check for port-name as a string of the form pf0vf0 > * (support kernel ver >=3D 5.0 or OFED ver >=3D 4.6). > */ > - sc_items =3D sscanf(port_name_in, "%c%c%d%c%c%d", > + sc_items =3D sscanf(port_name_in, "%c%c%d%c%c%d%c", > &pf_c1, &pf_c2, &port_info_out->pf_num, > - &vf_c1, &vf_c2, &port_info_out->port_name); > + &vf_c1, &vf_c2, &port_info_out->port_name, > &eol); > if (sc_items =3D=3D 6 && > pf_c1 =3D=3D 'p' && pf_c2 =3D=3D 'f' && > vf_c1 =3D=3D 'v' && vf_c2 =3D=3D 'f') { > @@ -110,8 +110,8 @@ > * Check for port-name as a string of the form p0 > * (support kernel ver >=3D 5.0, or OFED ver >=3D 4.6). > */ > - sc_items =3D sscanf(port_name_in, "%c%d", > - &pf_c1, &port_info_out->port_name); > + sc_items =3D sscanf(port_name_in, "%c%d%c", > + &pf_c1, &port_info_out->port_name, &eol); > if (sc_items =3D=3D 2 && pf_c1 =3D=3D 'p') { > port_info_out->name_type =3D > MLX5_PHYS_PORT_NAME_TYPE_UPLINK; > return; > @@ -120,8 +120,8 @@ > * Check for port-name as a string of the form pf0 > * (support kernel ver >=3D 5.7 for HPF representor on BF). > */ > - sc_items =3D sscanf(port_name_in, "%c%c%d", > - &pf_c1, &pf_c2, &port_info_out->pf_num); > + sc_items =3D sscanf(port_name_in, "%c%c%d%c", > + &pf_c1, &pf_c2, &port_info_out->pf_num, &eol); > if (sc_items =3D=3D 3 && pf_c1 =3D=3D 'p' && pf_c2 =3D=3D 'f') { > port_info_out->port_name =3D -1; > port_info_out->name_type =3D > MLX5_PHYS_PORT_NAME_TYPE_PFHPF; > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh