From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE2E6A00BE for ; Wed, 29 Apr 2020 12:36:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9AC7A1D9C1; Wed, 29 Apr 2020 12:36:19 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20058.outbound.protection.outlook.com [40.107.2.58]) by dpdk.org (Postfix) with ESMTP id F10C11D9C1; Wed, 29 Apr 2020 12:36:17 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jlv+hAgBl+JMiLzNgP1COHQsi2UqfUeIavKBahT4omOAqOWxsRCkGbInCkurt8hIRZy0xbI/vJq9Nc+IXFtp5WjQV6py3paVpH9s9aQV9VqOmzPwMmktgtDr5fPQ3c/m8nNfJsO8N4NeSRqbZIRZhzxcIzLC6jr04jbtCPzbWecj1YeBvUV2GFVafl5mo4E7KxKJ1epz6dfI/4P0b/wu8dRG1SdLFM3hhUZSAV+oXVGfQJ86AflWBGZzmM7Iv3yMMeYH7uhioqSQsAIalHAd3XB7Y+0/0rW6ibblsEpb7G6HVqCbkG5Tj0lUjoXeGYFaEm/6RfMEo41wayyvfLIM8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hx4a/9JLQqc4JU0EaqnTOnFghPH520G0CcUGMB/x+40=; b=FLqeEAW5O8EPPeygHmULXFrAyhzIm1JJVB5iCpLaxVEY6GrfhAWdL7tXzEhCerYKowrwR8DI6WnNlE/lM8p81dxKIoYN4L0TdV+0PtHbXFQY4rd98zt3dRbmY1namCgeqfSlPbufzit400Zo8Xg8NESfod21y3s+gc0QyZQwSLPRSRMazLCyiPEG/xIWlYLafhjeiIMlEwWfqFk+c/aNbUIuC+Ow905J/7L3Lm9Y/hy0Hg/YCoGA04LRUZ98cmONYGyRskR1STXSeWFg7sL4IhjEUnot02nm+IRos35Q7rvpuH4vbBvA+m5QkpxUyCrT+7oKVfAHIYrGiL82uriZ/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hx4a/9JLQqc4JU0EaqnTOnFghPH520G0CcUGMB/x+40=; b=SBObVv/vVL0wPZNYoP0ccovB3melARvqgdpI8HHga//pnFbNameEjBqtQCvNjJtkYENBlDRLt4S3mkubihTtHVZTKuhd07ZmYGojYSbkiBGzsip5AHXbkxi0XARaSn78uVl39M9QxokcpE8GyH4JRU0R5wPpjtf4yYQng15faIY= Received: from VI1PR05MB6718.eurprd05.prod.outlook.com (2603:10a6:800:13b::9) by VI1PR05MB5101.eurprd05.prod.outlook.com (2603:10a6:803:5d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Wed, 29 Apr 2020 10:36:16 +0000 Received: from VI1PR05MB6718.eurprd05.prod.outlook.com ([fe80::6d6a:e905:6b4b:addd]) by VI1PR05MB6718.eurprd05.prod.outlook.com ([fe80::6d6a:e905:6b4b:addd%6]) with mapi id 15.20.2937.023; Wed, 29 Apr 2020 10:36:16 +0000 From: Raslan Darawsheh To: Asaf Penso , "dev@dpdk.org" CC: Slava Ovsiienko , Dekel Peled , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix location of assert function Thread-Index: AQHWFBKiaWP5rBzQm06t6oQptjD9baiP+4ug Date: Wed, 29 Apr 2020 10:36:16 +0000 Message-ID: References: <1587057309-2947-1-git-send-email-asafp@mellanox.com> In-Reply-To: <1587057309-2947-1-git-send-email-asafp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [188.161.230.216] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: bae5f722-ea2a-4214-a8c1-08d7ec292592 x-ms-traffictypediagnostic: VI1PR05MB5101:|VI1PR05MB5101: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-forefront-prvs: 03883BD916 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR05MB6718.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(39850400004)(366004)(346002)(376002)(136003)(8936002)(8676002)(71200400001)(86362001)(52536014)(66946007)(26005)(2906002)(76116006)(5660300002)(64756008)(66446008)(66556008)(450100002)(33656002)(66476007)(53546011)(186003)(4326008)(55016002)(478600001)(316002)(7696005)(6506007)(9686003)(110136005)(54906003); DIR:OUT; SFP:1101; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ChVTdGlHFWKedM3E1vDJTEkgP78hLkYZWNHgQXKphgDORbtGhxdVqlsr1ObiaO+HSho1l5XQzNN/Iby90UPkUWIeM/M9yWmn776uk05u/vpyWAvg5Wow+HHIxKRpQRv610MBSRe+a5mT13AFivvMHvvJLy90TfnLEMB7IBjOoNObmHDCXcoqIaeucpafeAyqYSnfAGPMf1fHxnK9VYxzxUCE5LtcbjK/oOawGdz76k1+BsOAe5U9ke2J6H+7ntoHTtSZYfGNbDFeBXd6hgvGRG03iuwkRPBCxZPsyuVxsFzzSM1jWFJKAkqX/PNTCnae6raYh5pKfnrPzHs7peyI8jI2QuGKFa5xK0XGL0u9xGguVykbNv8s+bU/09XmSs+qHKMKlyzcI0aAzsKvXv/MFdFbaeV859BStSNdeeNNPqtCOLJx6doqwQenwmCgundu x-ms-exchange-antispam-messagedata: sIQoq4dlSoTYq9I6IX3RW42uIGGOPB+smbPlnqSiWKx7XWVx6oVm1CxcIohGmuKpsZRPYsTys89IgEQ0yIBeOmi0ewAURKFk+PTf5wp7qbjR4egClWzcJlZ+XxZeOvzwQM2v4xz5ihvc6fxHeNg+4JUcPo//6Pe4K3YFRjYPVYSFFzaP6NNGmsVOzYfN3yMa9OpBb9vofObDLmiWaaNWAXi0WyDGbrdHU5i5UthZhgxgyh0Mf/n8bOe8wBNIjuV1JVhjy/598Hqnr/oHAZufJuKAK5C0pcelJzASk4w+AxSpbILva/KU7JHQ+V+iRpBrmRRVxRJ7tCz//hUU8SHYKiqm4mfkRGhjiZzUSiGq4RCDoIrRRvASQaSf3+WOapYNMELbRQ3qDAokrsOT88yeiik0jHYeOrlDGBkyWqVAC2SHT1bw43NCdQUs8QQxmvi1J+/fwxwF/OahN3ZjxN9utZhru8usMToIqTQnXQg74TtULpgux9k+AGzQcGsPfQqj8WYQ+YzyC2fd1O1vS47ku9GzaPu41jtKwq2Sy6svVv2Wueg6S2x3Ja6TE8wCJSFepoAgIOs1X9oxhK2yBmgrY1qEZu7SMIHvbaaLppbPo5UsCmNWVeDlNJlGilw/R5CrKVHezFl4OWnMQxp1nbeYqKAB70HQneThj5M8IUvWroFBpnHyBYVW1qUa0M+X8nKxUmE5u1siuz2kckI0Rit/CCoVUiGdnjzdGWL3vqpBMxQB3Cx4NWD1ud6WLTRFR0Vxm48575re9mlOBshb9O0V0EDsm5Gk9f8AB3cvPT9ywqowLw7NNODCmEyxxweDZRxp Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: bae5f722-ea2a-4214-a8c1-08d7ec292592 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2020 10:36:16.3531 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0EQIXAifOXoV3jxBrCDPaQ/tTXc7aChTV77gqODcXtGgRRZkpp7y78zKDBHulu7pcuEJv0bKAK357PKgjjwuLw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB5101 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/mlx5: fix location of assert function X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: dev On Behalf Of Asaf Penso > Sent: Thursday, April 16, 2020 8:15 PM > To: dev@dpdk.org > Cc: Slava Ovsiienko ; Dekel Peled > ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix location of assert function >=20 > The asserts makes sure that 'i' doesn't exceed the exepcted value. > This to prevent an out of bound access to dbr_bitmap. >=20 > The current location of the assert protects the assignment of > dbr_bitmap, but not the access to it. >=20 > Moved the assert to the correct place, to protect both cases. > Also, used an existing define for the assert. >=20 > Fixes: 21cae858 ("net/mlx5: allocate door-bells via DevX") > Cc: stable@dpdk.org >=20 > Signed-off-by: Asaf Penso > Reviewed-by: Dekel Peled > Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c > index f8b134c..df12a3b 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -1989,8 +1989,8 @@ struct mlx5_flow_id_pool * > i++) > ; /* Empty. */ > /* Find the first clear bit. */ > + MLX5_ASSERT(i < MLX5_DBR_BITMAP_SIZE); > j =3D rte_bsf64(~page->dbr_bitmap[i]); > - MLX5_ASSERT(i < (MLX5_DBR_PER_PAGE / 64)); > page->dbr_bitmap[i] |=3D (1 << j); > page->dbr_count++; > *dbr_page =3D page; > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh