From: Ruifeng Wang <Ruifeng.Wang@arm.com>
To: "Ferruh Yigit" <ferruh.yigit@intel.com>,
"Jan Viktorin" <viktorin@rehivetech.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"Bruce Richardson" <bruce.richardson@intel.com>,
"Juraj Linkeš" <juraj.linkes@pantheon.tech>,
"Honnappa Nagarahalli" <Honnappa.Nagarahalli@arm.com>,
"Vimal Chungath" <vcchunga@amazon.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"stable@dpdk.org" <stable@dpdk.org>,
Thierry Herbelot <thierry.herbelot@6wind.com>, nd <nd@arm.com>
Subject: Re: [dpdk-stable] [PATCH] config/arm: fix typo in meson config
Date: Tue, 2 Feb 2021 02:19:23 +0000 [thread overview]
Message-ID: <VI1PR0802MB2351917DE5B728A6F06A78B69EB59@VI1PR0802MB2351.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20210201224150.2718693-1-ferruh.yigit@intel.com>
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Tuesday, February 2, 2021 6:42 AM
> To: Jan Viktorin <viktorin@rehivetech.com>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>; jerinj@marvell.com; Bruce Richardson
> <bruce.richardson@intel.com>; Juraj Linkeš <juraj.linkes@pantheon.tech>;
> Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>; Vimal Chungath
> <vcchunga@amazon.com>
> Cc: Ferruh Yigit <ferruh.yigit@intel.com>; dev@dpdk.org;
> thomas@monjalon.net; stable@dpdk.org; Thierry Herbelot
> <thierry.herbelot@6wind.com>
> Subject: [PATCH] config/arm: fix typo in meson config
>
> s/implementor/implementer
>
> Fixes: 3d01d65ba0d3 ("config: add aarch64 clang for Ubuntu 18.04")
> Fixes: c51401832147 ("config/arm: add Graviton2")
'implementor' -> 'implementer' change was made in 7870ae8994c6.
It seems 7870ae8994c6 missed Graviton2 config file which was added earlier.
With the fix tag update,
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Cc: stable@dpdk.org
>
> Reported-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Cc: Ruifeng Wang <ruifeng.wang@arm.com>
> Cc: vcchunga@amazon.com
> ---
> config/arm/arm64_armv8_linux_clang_ubuntu1804 | 4 ++--
> config/arm/arm64_graviton2_linux_gcc | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/config/arm/arm64_armv8_linux_clang_ubuntu1804
> b/config/arm/arm64_armv8_linux_clang_ubuntu1804
> index aa5ee0132065..ae3fb30c5da8 100644
> --- a/config/arm/arm64_armv8_linux_clang_ubuntu1804
> +++ b/config/arm/arm64_armv8_linux_clang_ubuntu1804
> @@ -14,7 +14,7 @@ cpu = 'armv8-a'
> endian = 'little'
>
> [properties]
> -implementor_id = 'generic'
> -implementor_pn = 'default'
> +implementer_id = 'generic'
> +implementer_pn = 'default'
> c_args = ['-target', 'aarch64-linux-gnu', '--sysroot', '/usr/aarch64-linux-gnu']
> c_link_args = ['-target', 'aarch64-linux-gnu', '-fuse-ld=lld', '--gcc-
> toolchain=/usr'] diff --git a/config/arm/arm64_graviton2_linux_gcc
> b/config/arm/arm64_graviton2_linux_gcc
> index cfe2397975fc..123f14eed29e 100644
> --- a/config/arm/arm64_graviton2_linux_gcc
> +++ b/config/arm/arm64_graviton2_linux_gcc
> @@ -13,8 +13,8 @@ cpu = 'armv8-a'
> endian = 'little'
>
> [properties]
> -implementor_id = '0x41'
> -implementor_pn = '0xd0c'
> +implementer_id = '0x41'
> +implementer_pn = '0xd0c'
> max_lcores = 64
> max_numa_nodes = 1
> numa = false
> --
> 2.29.2
next prev parent reply other threads:[~2021-02-02 2:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7a4b591b-5e32-a3f8-a8ff-59a636217814@6wind.com>
2021-02-01 22:41 ` Ferruh Yigit
2021-02-01 23:22 ` Honnappa Nagarahalli
2021-02-02 2:19 ` Ruifeng Wang [this message]
2021-02-02 8:08 ` Ferruh Yigit
2021-02-02 7:12 ` Juraj Linkeš
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0802MB2351917DE5B728A6F06A78B69EB59@VI1PR0802MB2351.eurprd08.prod.outlook.com \
--to=ruifeng.wang@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=juraj.linkes@pantheon.tech \
--cc=nd@arm.com \
--cc=stable@dpdk.org \
--cc=thierry.herbelot@6wind.com \
--cc=thomas@monjalon.net \
--cc=vcchunga@amazon.com \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).