From: Ruifeng Wang <Ruifeng.Wang@arm.com>
To: David Marchand <david.marchand@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Olivier Matz <olivier.matz@6wind.com>,
Phil Yang <Phil.Yang@arm.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
"thomas@monjalon.net" <thomas@monjalon.net>, nd <nd@arm.com>
Subject: Re: [dpdk-stable] [PATCH] mbuf: remove unneeded EAL header include
Date: Mon, 1 Feb 2021 07:51:11 +0000 [thread overview]
Message-ID: <VI1PR0802MB2351E03079659EE3BB30D0FC9EB69@VI1PR0802MB2351.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20210129203307.25123-1-david.marchand@redhat.com>
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Saturday, January 30, 2021 4:33 AM
> To: dev@dpdk.org
> Cc: konstantin.ananyev@intel.com; bruce.richardson@intel.com;
> stable@dpdk.org; Olivier Matz <olivier.matz@6wind.com>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>; Phil Yang <Phil.Yang@arm.com>; Andrew
> Rybchenko <arybchenko@solarflare.com>; thomas@monjalon.net
> Subject: [PATCH] mbuf: remove unneeded EAL header include
>
> There is no need for the direct inclusion of the generic/ header [1] now that
> we don't use the rte_atomic API anymore.
>
> 1: https://git.dpdk.org/dpdk/commit/?id=3eb860b08eb7
>
> Fixes: e41d27a68df6 ("mbuf: remove atomic reference counters")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> lib/librte_mbuf/rte_mbuf_core.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/librte_mbuf/rte_mbuf_core.h
> b/lib/librte_mbuf/rte_mbuf_core.h index a85cabdd18..9d1609336a 100644
> --- a/lib/librte_mbuf/rte_mbuf_core.h
> +++ b/lib/librte_mbuf/rte_mbuf_core.h
> @@ -20,7 +20,6 @@
>
> #include <rte_compat.h>
> #include <rte_byteorder.h>
> -#include <generic/rte_atomic.h>
>
> #ifdef __cplusplus
> extern "C" {
> --
> 2.23.0
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
next prev parent reply other threads:[~2021-02-01 7:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 20:33 David Marchand
2021-02-01 7:51 ` Ruifeng Wang [this message]
2021-02-04 10:05 ` [dpdk-stable] [PATCH v2 1/2] mbuf: remove unneeded atomic " David Marchand
2021-02-04 13:35 ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0802MB2351E03079659EE3BB30D0FC9EB69@VI1PR0802MB2351.eurprd08.prod.outlook.com \
--to=ruifeng.wang@arm.com \
--cc=Phil.Yang@arm.com \
--cc=arybchenko@solarflare.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=nd@arm.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).