patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] build: mention -march in pkg-config description
@ 2019-01-10 17:28 Luca Boccassi
  2019-01-11  3:58 ` [dpdk-stable] [dpdk-dev] " Gavin Hu (Arm Technology China)
  0 siblings, 1 reply; 4+ messages in thread
From: Luca Boccassi @ 2019-01-10 17:28 UTC (permalink / raw)
  To: dev; +Cc: bruce.richardson, christian.ehrhardt, Luca Boccassi, stable

Applications need to at least match DPDK's -march option to build
successfully due to some static inline functions in the public headers.

This might cause problems, especially in distributions, so add a note
in the pkg-config description.

Fixes: a25a650be5f0 ("build: add infrastructure for meson and ninja builds")
Cc: stable@dpdk.org

Signed-off-by: Luca Boccassi <bluca@debian.org>
---
At the moment there are no adversely affected applications in Debian and
Ubuntu (collectd builds a separate shared object, and OVS/virtio-forwareder
are stand-alone DPDK-specific binaries), but we thought that having an
explicit notice would be good.

 meson.build | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meson.build b/meson.build
index f87dc235f..35126106a 100644
--- a/meson.build
+++ b/meson.build
@@ -83,7 +83,9 @@ pkg.generate(name: meson.project_name(),
 	libraries: dpdk_libraries,
 	libraries_private: dpdk_drivers + dpdk_static_libraries +
 			['-Wl,-Bdynamic'] + dpdk_extra_ldflags,
-	description: 'The Data Plane Development Kit (DPDK)',
+	description: '''The Data Plane Development Kit (DPDK).
+Note that CFLAGS might contain an -march flag higher than typical baseline.
+This is required for a number of static inline functions in the public headers.''',
 	subdirs: [get_option('include_subdir_arch'), '.'],
 	extra_cflags: ['-include', 'rte_config.h'] + machine_args
 )
-- 
2.20.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-01-28  0:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-10 17:28 [dpdk-stable] [PATCH] build: mention -march in pkg-config description Luca Boccassi
2019-01-11  3:58 ` [dpdk-stable] [dpdk-dev] " Gavin Hu (Arm Technology China)
2019-01-11  9:57   ` Bruce Richardson
2019-01-28  0:50     ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).