From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 3156DA059F
for <public@inbox.dpdk.org>; Sat, 11 Apr 2020 04:51:07 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 1D4251D158;
Sat, 11 Apr 2020 04:51:07 +0200 (CEST)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
(mail-eopbgr10084.outbound.protection.outlook.com [40.107.1.84])
by dpdk.org (Postfix) with ESMTP id 3809A1C2F2;
Sat, 11 Apr 2020 04:51:03 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
s=selector2-armh-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=gtH8DTjgqUIk2EuxO1Rl2FaCarDSSyGLhYdHsjcJjUQ=;
b=KmEfpL7RGcCubqJCKIta3owpi5C9iGcMFVScIDP4B5kc+okaYeTGT+IFS5rwsBhB6vVjfxRA202+0XwyL18c0ZXbeOF2FQtpjU12ninR4HGr1W/lktSNVhlbgvT/2DFvlBQRhRfK0IA0aXORPOdOCGE86JkV23T+CWT5iN3vySA=
Received: from DB8PR06CA0061.eurprd06.prod.outlook.com (2603:10a6:10:120::35)
by AM6PR08MB2981.eurprd08.prod.outlook.com (2603:10a6:209:44::22)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.24; Sat, 11 Apr
2020 02:51:00 +0000
Received: from DB5EUR03FT035.eop-EUR03.prod.protection.outlook.com
(2603:10a6:10:120:cafe::4f) by DB8PR06CA0061.outlook.office365.com
(2603:10a6:10:120::35) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15 via Frontend
Transport; Sat, 11 Apr 2020 02:51:00 +0000
Authentication-Results: spf=pass (sender IP is 63.35.35.123)
smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified)
header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none
header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
63.35.35.123 as permitted sender) receiver=protection.outlook.com;
client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
DB5EUR03FT035.mail.protection.outlook.com (10.152.20.65) with
Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.2900.15 via Frontend Transport; Sat, 11 Apr 2020 02:51:00 +0000
Received: ("Tessian outbound 4b84da486446:v50");
Sat, 11 Apr 2020 02:51:00 +0000
X-CR-MTA-TID: 64aa7808
Received: from 77a0b67ccaf9.1
by 64aa7808-outbound-1.mta.getcheckrecipient.com id
DFBC3BA6-9F6E-4483-9431-F6F31819F33E.1;
Sat, 11 Apr 2020 02:50:55 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 77a0b67ccaf9.1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
Sat, 11 Apr 2020 02:50:55 +0000
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=CbezTEZfT/C8auETE1N3CUPHJ0I5ryVnoPKm+scmDRvPpEMNrytYk2CxxKYvc72P+6SOzVUktvspYs2875tWN7WyVZzCvxp0uBq8RlsuoH2AMLhlZmhvK3WO3HiZ3Gpj3HyVKcl85kYJFLQsFyT1lFa4a2VfgQkpBDd7n6YUNWQnZdqGgtc99Z+K4e3ucbFzzWKEKiB89TayDfbSNBh8k1giCOfvcFMHd5Og18LXFjyj7ImK1oE43IQstO/0a5V47AMeOQwJqBa3QWXTFGVlZIi04h7z0oGSoz9Wl/s0bX0zPwjnlAHx3FKy2RTIKOVy+4SKi2Ww+an6NrFBE2RpHA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=gtH8DTjgqUIk2EuxO1Rl2FaCarDSSyGLhYdHsjcJjUQ=;
b=UCf3YZiOswcsyjL63eJPtE/aAROhEL+SENHVHzFcHzvCSisS1a4mLawCSvaey7o5qARg+Y0PUtHDBgjVzgZOLFp2k9/dvsak8CvnefRz/jABJEblpk+EJRDbfqL8hjWgteaENl79eWYCoVPQFGILKRY2UxDYLCddNdUZa9zcx6AAIeQdAfQSWHZGBAIO3f4znDuI6t6kxbnOBn0lXRGLPMaCzI+zeFmW1t0RmJrF7p9/BTqNJH2OzsUIVbmHWWNMi6q58Pp+1DORkCsHSpa7F/6P8pMmFOOiLJkMZL+XT/XgYQkpzb1ObG8X+h0aENvbe2rWhTyQ4AqSrBddSPyL6w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
s=selector2-armh-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=gtH8DTjgqUIk2EuxO1Rl2FaCarDSSyGLhYdHsjcJjUQ=;
b=KmEfpL7RGcCubqJCKIta3owpi5C9iGcMFVScIDP4B5kc+okaYeTGT+IFS5rwsBhB6vVjfxRA202+0XwyL18c0ZXbeOF2FQtpjU12ninR4HGr1W/lktSNVhlbgvT/2DFvlBQRhRfK0IA0aXORPOdOCGE86JkV23T+CWT5iN3vySA=
Received: from VI1PR08MB5376.eurprd08.prod.outlook.com (2603:10a6:803:13e::15)
by VI1PR08MB3760.eurprd08.prod.outlook.com (2603:10a6:803:c1::27)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.24; Sat, 11 Apr
2020 02:50:45 +0000
Received: from VI1PR08MB5376.eurprd08.prod.outlook.com
([fe80::a0e2:2a9f:be7b:4b15]) by VI1PR08MB5376.eurprd08.prod.outlook.com
([fe80::a0e2:2a9f:be7b:4b15%3]) with mapi id 15.20.2900.015; Sat, 11 Apr 2020
02:50:44 +0000
From: Gavin Hu <Gavin.Hu@arm.com>
To: "thomas@monjalon.net" <thomas@monjalon.net>
CC: David Marchand <david.marchand@redhat.com>, Kevin Traynor
<ktraynor@redhat.com>, Bruce Richardson <bruce.richardson@intel.com>,
=?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>, Ferruh Yigit
<ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>,
"jerinj@marvell.com" <jerinj@marvell.com>, Honnappa Nagarahalli
<Honnappa.Nagarahalli@arm.com>, Ruifeng Wang <Ruifeng.Wang@arm.com>, Phil
Yang <Phil.Yang@arm.com>, Joyce Kong <Joyce.Kong@arm.com>, "stable@dpdk.org"
<stable@dpdk.org>, Olivier MATZ <olivier.matz@6wind.com>, Konstantin Ananyev
<konstantin.ananyev@intel.com>, Andrew Rybchenko <arybchenko@solarflare.com>,
nd <nd@arm.com>, "mdr@ashroe.eu" <mdr@ashroe.eu>, nd <nd@arm.com>
Thread-Topic: [dpdk-stable] [dpdk-dev] [PATCH v2] mbuf: replace zero-length
marker with unnamed union
Thread-Index: AQHV9fBz71Suucrna027AAjtXZtDbqhAAhPAgAAeKgCAACHPgIACxQ9ggAAMaNCAADvtgIAC9jiwgCfON4CAAVzWkIAAFlyAgADCpvCAAIOQAIACnk1g
Date: Sat, 11 Apr 2020 02:50:44 +0000
Message-ID: <VI1PR08MB5376638F9E617391E6B9C0CA8FDF0@VI1PR08MB5376.eurprd08.prod.outlook.com>
References: <20200303162728.93744-1-gavin.hu@arm.com>
<CAJFAV8yL2GvEJtTXOLk6o0eXHi4CpZmqCoRsfN2WcDe_ju1C8A@mail.gmail.com>
<VI1PR08MB537664AD062975D1382B516D8FC10@VI1PR08MB5376.eurprd08.prod.outlook.com>
<2539459.X9hSmTKtgW@thomas>
In-Reply-To: <2539459.X9hSmTKtgW@thomas>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: d4c98c9c-3e20-43b3-87ef-707a8c1fc8f0.0
x-checkrecipientchecked: true
Authentication-Results-Original: spf=none (sender IP is )
smtp.mailfrom=Gavin.Hu@arm.com;
x-originating-ip: [221.239.170.106]
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 24154b19-7f1e-43e6-866c-08d7ddc32af3
x-ms-traffictypediagnostic: VI1PR08MB3760:|VI1PR08MB3760:|AM6PR08MB2981:
x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS: <AM6PR08MB29817ECDD054F3F2D885DA368FDF0@AM6PR08MB2981.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
x-forefront-prvs: 03706074BC
X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en;
SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB5376.eurprd08.prod.outlook.com;
PTR:; CAT:NONE; SFTY:;
SFS:(10009020)(4636009)(396003)(136003)(366004)(376002)(346002)(39860400002)(7696005)(316002)(55016002)(54906003)(86362001)(4326008)(8936002)(81156014)(8676002)(2906002)(53546011)(71200400001)(33656002)(6506007)(66946007)(6916009)(66556008)(66446008)(64756008)(186003)(52536014)(478600001)(76116006)(966005)(66476007)(26005)(5660300002)(66574012)(7416002)(9686003);
DIR:OUT; SFP:1101;
received-spf: None (protection.outlook.com: arm.com does not designate
permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original: 1xKP2sVJFT9qEs2XFKOrbJMOR/sZKbg9WGvSkghOJuZ/JwWAoIlwPhYAqywBP24lijf0cfRePpwghpHfNI35Vu5V08TwWizyG7tYwr6HL115TGC62ruyQWsn1tRyCyP9MHmqrTS4ja7at7QR4+0dCcoyId9TjtLPhR/dPqb6IP9yQ9MniOYlK40jHvhYvqmjkjWwBfREkcu0OB6799CquARRHOJW2ay24hA7zUQmt5TmkLEmHGzldQpLd86JXUyVkSdCu6BO8N5e1+VE0ypwFTXMjCJK6rrNsAx/ZVajXZxXKO/shxkjXZ0F6zdCUnIKneBy0E3sti3dhlTlm2vpKMlPnPLkW3x75TojYLNIteWUZjG3tDrhJosw+gNNE3z+ipPj9Ekdgbix1GrlDodAv6OB3H/yPybDdaJItpGWshLjjjpZk7T7T4m720dEnfhipTOfUGObfIjXwZqTQvmi0w99oxXqxSrlkfK1JUH35GPPNpdVoR/5zyiYxdvro4EpsMh1HWyYlTd2uOjTPxyOVA==
x-ms-exchange-antispam-messagedata: W93lgHhGNHlpMTruVhh/oxfL4g4+CLRqDXumz9MLIaxKdIPNmEnBAGp1hxPZNgdlgboge11JUCJgLLJETkx3DSnLpePzAeDllojkPIGjNNqXyoQue2aZ1WNZoe+rfcB1x4rYf69Hl7RLo1ANn+1emw==
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3760
Original-Authentication-Results: spf=none (sender IP is )
smtp.mailfrom=Gavin.Hu@arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT035.eop-EUR03.prod.protection.outlook.com
X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:;
IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com;
PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:;
SFS:(10009020)(4636009)(396003)(376002)(39860400002)(346002)(136003)(46966005)(966005)(81156014)(336012)(55016002)(9686003)(356005)(6506007)(8676002)(450100002)(478600001)(26005)(86362001)(66574012)(8936002)(4326008)(316002)(33656002)(26826003)(53546011)(81166007)(186003)(6862004)(7696005)(82740400003)(47076004)(54906003)(52536014)(70206006)(2906002)(5660300002)(70586007);
DIR:OUT; SFP:1101;
X-MS-Office365-Filtering-Correlation-Id-Prvs: 863653f3-be51-4a3c-8cec-08d7ddc321a1
X-Forefront-PRVS: 03706074BC
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 2UNlW1wIPeYN2FPXLzXMi0F0w2pKV7L9Yt98Nw+/USR5elFy6Gh/5M9jMqNL/FsYlQTScl5U/j6CcONVg8HDB0X+KorhFCv05DojluHfPmIacSGM1zgbFQ/WprnzyMN0sFB2QuVQDc9wXD0DcHNtGgGeOYucrtGP9eXib5x8bRM2XhSvTH39GU8NuElcOzFMWLciCrga7vMoE23bKeBYbdd+zGjc7ANDlccwSPkkyv8cEgsMbPtCz+YWUSXVpYEjCqxwiREW4o1MicXfonUtQikLIpnUCUBB+5oOsGPUS/Nz8TEPRGkZQQYXqVddiKEJ1UsonUsnOfwv09E3MJrxSBbBzZ/S+xKnQJppOzhNo5/n2wsopfsyX6yZq268mit07hv1L8cKUkMDgGc8dS8/BXl5GiJ/kAMqbWyIxZRKZpR071cVVxl4sJVYvtbBedbPqhix1hPzyE7Ll8rjbgoXJLxowG6f72r9XJQEisHnWvyCn731/PAgEqEV0HGotYrGpAZgeQQEqRtxBmr3+GobkjY1wN0AvDqwX0nAhmzREr79sKhl6Wei/zFc0ovuzDc4r+t1y4mSA1kEDDxqu/fw9Q==
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2020 02:51:00.5098 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 24154b19-7f1e-43e6-866c-08d7ddc32af3
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123];
Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB2981
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] mbuf: replace zero-length
marker with unnamed union
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Thursday, April 9, 2020 6:50 PM
> To: Gavin Hu <Gavin.Hu@arm.com>
> Cc: David Marchand <david.marchand@redhat.com>; Kevin Traynor
> <ktraynor@redhat.com>; Bruce Richardson <bruce.richardson@intel.com>;
> Morten Br=F8rup <mb@smartsharesystems.com>; Ferruh Yigit
> <ferruh.yigit@intel.com>; dev@dpdk.org; nd <nd@arm.com>;
> jerinj@marvell.com; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>; Phil Yang <Phil.Yang@arm.com>; Joyce Kong
> <Joyce.Kong@arm.com>; stable@dpdk.org; Olivier MATZ
> <olivier.matz@6wind.com>; Konstantin Ananyev
> <konstantin.ananyev@intel.com>; Andrew Rybchenko
> <arybchenko@solarflare.com>; nd <nd@arm.com>; mdr@ashroe.eu
> Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] mbuf: replace zero-lengt=
h
> marker with unnamed union
>=20
> 09/04/2020 11:48, Gavin Hu:
> > From: David Marchand <david.marchand@redhat.com>
> > > On Wed, Apr 8, 2020 at 5:05 PM Gavin Hu <Gavin.Hu@arm.com> wrote:
> > > > From: Kevin Traynor <ktraynor@redhat.com>
> > > > > Hi Gavin, I lost track if v2 is still a candidate for merge. fwiw=
, it
> > > > > compiles without giving the zero-length-bounds warning on my
> system.
> > > > >
> > > > > Kevin.
> > > >
> > > > Yes, this path alone is a candidate for merge.
> > >
> > > This patch is not mergeable, it would trigger failures in the ABI che=
cks.
> >
> > Isn't it a false failure? If yes, is it ignorable?
> >
> > > You can see in patchwork that the robot reported a warning in Travis.
> > > http://mails.dpdk.org/archives/test-report/2020-March/119919.html
> > > https://travis-ci.com/github/ovsrobot/dpdk/jobs/295652710#L4476
> > >
> > >
> > > I opened a bz to libabigail.
> > > https://sourceware.org/bugzilla/show_bug.cgi?id=3D25661
> > >
> > >
> > > Either a different solution is found, or your patch will have to deal
> > > with this issue (libabigail fix won't be ready soon afaik) and waive
> > > this.
> >
> > Maybe we come back to 'disable the warning', before the libabigail fix
> ready? or alternatively ignore this ABI false failure, if it is.
> > I do not have ideas of what otherwise the options are.
>=20
> Gavin,
> I did not check this case.
> But in general, we do not skip checks, except some checkpatch ones.
> The policy with ABI checks is "NEVER SKIP".
> We prefer postponing patches, waiting for someone to fix tooling.
Ok, I am fine with this.=20
> There is a lack of motivation currently for general concerns.
> We need to avoid being "write-only" contributors.
> So two things need to be done:
> 1/ improve tooling where it needs
> 2/ review patches from others
> I published a review list recently:
> http://mails.dpdk.org/archives/announce/2020-April/000315.html
Thanks!
>=20