From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ABB7CA2EEB for ; Wed, 11 Sep 2019 05:21:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 837441E9C2; Wed, 11 Sep 2019 05:21:56 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150040.outbound.protection.outlook.com [40.107.15.40]) by dpdk.org (Postfix) with ESMTP id 0E4701C031; Wed, 11 Sep 2019 05:21:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kJ7j+UwEF0S/7Wioqf77pobZ54z+2NUhE49ZaUsC4W0=; b=HaIgQZoqDRllVpMp0M27ndrLyD2RWQUzDyHcIzrDeWZnTjmlDqafny9Cao6cDTDZGjuNbKmyQDr/iJt25PQn0txexQJ91oSwMr/BO0q+elLvmVjBNKuBkbW6Wo+BX3/dqdbHBzG5Wljh5AzTjxEMexPzsPJ2U21ESmzaSMVGY3I= Received: from VI1PR08CA0118.eurprd08.prod.outlook.com (2603:10a6:800:d4::20) by VI1PR0801MB1872.eurprd08.prod.outlook.com (2603:10a6:800:86::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.14; Wed, 11 Sep 2019 03:21:50 +0000 Received: from AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::205) by VI1PR08CA0118.outlook.office365.com (2603:10a6:800:d4::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.15 via Frontend Transport; Wed, 11 Sep 2019 03:21:50 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=none action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT007.mail.protection.outlook.com (10.152.16.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.14 via Frontend Transport; Wed, 11 Sep 2019 03:21:48 +0000 Received: ("Tessian outbound b18964f7fb75:v29"); Wed, 11 Sep 2019 03:21:45 +0000 X-CR-MTA-TID: 64aa7808 Received: from fa91210e4171.1 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.0.53]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id C148F5B6-4A8E-4FF2-A278-003520EC2310.1; Wed, 11 Sep 2019 03:21:40 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01lp2053.outbound.protection.outlook.com [104.47.0.53]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fa91210e4171.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 Sep 2019 03:21:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ua3TWsA2nCdQ+IzcmniMCep+aYr9AFuulq40xFcpU1axnRYsIF9Icapqtfkw8SclAwNRFE6ZlS0pKS9WGvB3QZfCAm6dpRgsk0Z4z4QiSU8CDRC1t5OMuR7OnZrclYehHkqmMF4QGum06S5LHgOZGJE/ITn9eY4gqAtcsqTRj6S+afxFvpCXXR91z5oTN+8GvrB+H3Cva6YkuJ69q7CUJ3cVAXtiHaHjcEAmOA7xW9bJudddHw8BzRj6LfjGaU0tuW3ZKBQa6yo5dNVnmg6SZtAIiNIy7Ap7zm02vDuNZMTNxIZO6OWehG+5or44BxuZVUEGj/QmQKfBHoqE5ECQvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kJ7j+UwEF0S/7Wioqf77pobZ54z+2NUhE49ZaUsC4W0=; b=XaYRqR2VJOaPf0++VYVjhoqjUsaXyY/4lwEQpoDrGk9drZfmWewacPTkZ4Ll19V0deHQbGGCh1XR5jcKxlaU1ectjb0b6UZ4sUcJgBf6yo9owkHbL94/+cbtrLsZZyLvGWkQlmwAhZvh9UxfjzzY6ArEsSq0CGXoSL0ccukrErPIuCWSyUvd6KmmkmfbCrolRu8hh7K3Kid8uOcdeCNhfyb+fMV6LCzDOy0wli9oDK6BJpFGZzkwfX6EKClfroFRUg71KJqG55U/t7bWKh+pCvEVK9NEPkjjGxKocgyQzx4GbFAPTmN8vmr5PyZyzTbPU0ovkjLgPK/vpF8HLRYq2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kJ7j+UwEF0S/7Wioqf77pobZ54z+2NUhE49ZaUsC4W0=; b=HaIgQZoqDRllVpMp0M27ndrLyD2RWQUzDyHcIzrDeWZnTjmlDqafny9Cao6cDTDZGjuNbKmyQDr/iJt25PQn0txexQJ91oSwMr/BO0q+elLvmVjBNKuBkbW6Wo+BX3/dqdbHBzG5Wljh5AzTjxEMexPzsPJ2U21ESmzaSMVGY3I= Received: from VI1PR08MB5376.eurprd08.prod.outlook.com (52.133.244.200) by VI1PR08MB3487.eurprd08.prod.outlook.com (20.177.59.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.15; Wed, 11 Sep 2019 03:21:37 +0000 Received: from VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::c09a:49d3:eab2:f707]) by VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::c09a:49d3:eab2:f707%3]) with mapi id 15.20.2241.018; Wed, 11 Sep 2019 03:21:37 +0000 From: "Gavin Hu (Arm Technology China)" To: Xiao Zhang , "dev@dpdk.org" CC: "wenzhuo.lu@intel.com" , "stable@dpdk.org" , Honnappa Nagarahalli , Steve Capper , "Phil Yang (Arm Technology China)" , "Joyce Kong (Arm Technology China)" , nd Thread-Topic: [dpdk-dev] net/e1000: correct mb function Thread-Index: AQHVZ7RrhX2m0POWkECd1HDFr0OQJaclz9WA Date: Wed, 11 Sep 2019 03:21:37 +0000 Message-ID: References: <1568137278-10066-1-git-send-email-xiao.zhang@intel.com> In-Reply-To: <1568137278-10066-1-git-send-email-xiao.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 1a0494dd-36c7-4cfb-936b-eb604e2e96b3.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 3bcae4e4-1b2e-4031-5f17-08d736672e8e X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam-Untrusted: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VI1PR08MB3487; X-MS-TrafficTypeDiagnostic: VI1PR08MB3487:|VI1PR08MB3487:|VI1PR0801MB1872: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:276;OLM:276; x-forefront-prvs: 0157DEB61B X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(366004)(376002)(136003)(346002)(396003)(13464003)(199004)(189003)(55236004)(76176011)(55016002)(305945005)(2501003)(256004)(316002)(66556008)(14444005)(66946007)(186003)(7696005)(64756008)(26005)(66476007)(9686003)(54906003)(446003)(476003)(6246003)(86362001)(76116006)(81166006)(66446008)(33656002)(2906002)(229853002)(6436002)(6506007)(71190400001)(71200400001)(99286004)(53936002)(110136005)(52536014)(486006)(74316002)(7736002)(3846002)(11346002)(5660300002)(4326008)(14454004)(25786009)(478600001)(8936002)(66066001)(81156014)(6116002)(8676002)(102836004)(53546011); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB3487; H:VI1PR08MB5376.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: rZMIBcwsGc5HvcqUYAbcD9ikAAmQfO8laPHJbuy2Ms/WObDIgmoakWOEbHhRidUhhGUvbU0uHole0P2GpHHjIMf3SZPdgbqIim6sOdDkm5bOxOSHSGlXf/1BegLcvpOARTr2juZTwUzQfkJi/xq2rlKo10/iuuID1HHOBYowotq9ixNIB3+lAfULuDdM6WwHaZEcQ8R6QSRF0IrczaPkBDkCp8gZblTcNZdiHhZQqgazhRCc3o8giY8KOTaYeIMj0r1Muf8BswQm3LLuGQUQ3b4awYdHvkViALmJRYIbqcpaN1UTjCexZ0kAFbGea2j4gDhnSn0x/oPlNssBbSIGr4vTANqE6o+OkZD+HaGRwL5JigSg4kQIhhgE6v38YAHzknYfod3CN33lZN7uQR+JHHvp7BgYzKw9DJyJUziMP0E= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3487 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(396003)(346002)(376002)(136003)(39860400002)(189003)(199004)(13464003)(3846002)(126002)(486006)(476003)(25786009)(86362001)(186003)(6246003)(70586007)(70206006)(2501003)(99286004)(76176011)(7696005)(46406003)(356004)(14444005)(50466002)(5660300002)(76130400001)(52536014)(26005)(229853002)(97756001)(9686003)(74316002)(478600001)(55016002)(47776003)(66066001)(450100002)(8676002)(81156014)(81166006)(8746002)(102836004)(33656002)(8936002)(305945005)(7736002)(2906002)(22756006)(446003)(54906003)(63350400001)(11346002)(110136005)(36906005)(26826003)(23726003)(4326008)(336012)(53546011)(6116002)(316002)(6506007)(14454004); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0801MB1872; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:TempError; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; MX:1; A:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 97c84471-ebd2-44cb-b039-08d7366727e1 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(710020)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VI1PR0801MB1872; NoDisclaimer: True X-Forefront-PRVS: 0157DEB61B X-Microsoft-Antispam-Message-Info: puz76LMaOOu7nHTmlauuFJ50IHbqDscE/guhUEV6+rJoIOZUbCJcDWW9RtyQtmRSSF+FYUsm+ZZnWG9tzZm7CCEx3MFuTpkiN9Zr5HKfv6J6BhiQxXiThikYyHq+TZ3W8MBQplHg9eunNPz3+LGampJA6tg4hA1NV7eipIApv+YCp2y/5Ebj0v0Rx1eWkiR5HVjwGtZVw1oErWqpqLZq73Kb9nIIv/cHQ0Z/XRniIxTjkD3AfwiWuCG781piux3H0nf3UcvLNWth9ESuCeWu651qQARcN+WNI4wUT6lK6kmnKCvroR4zQV+YTBz9NzWinwN2ClFIsY2gzmh/qiviDnuEcXqr7ALTd78R1fqZUmY8AzTFfxacCFh/GcjBkgnCc4NrO2RiTL/PRo5QG+xgLjEvN/vPEGx1nfWKd8rZ62U= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2019 03:21:48.5697 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3bcae4e4-1b2e-4031-5f17-08d736672e8e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1872 Subject: Re: [dpdk-stable] [dpdk-dev] net/e1000: correct mb function X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: dev On Behalf Of Xiao Zhang > Sent: Wednesday, September 11, 2019 1:41 AM > To: dev@dpdk.org > Cc: wenzhuo.lu@intel.com; Xiao Zhang ; > stable@dpdk.org > Subject: [dpdk-dev] net/e1000: correct mb function >=20 > Use rte_cio_wmb instead of rte_wmb when writing TX descriptor since it's > CIO memory. > Replace rte_io_wmb and E1000_PCI_REG_WRITE_RELAXED with > E1000_PCI_REG_WRITE since it has rte_io_wmb inside, which will be more > clear. >=20 > Fixes: 1fc9701238ed ("net/e1000: fix i219 hang on reset/close") > Cc: stable@dpdk.org >=20 > Signed-off-by: Xiao Zhang > --- > drivers/net/e1000/em_rxtx.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/e1000/em_rxtx.c b/drivers/net/e1000/em_rxtx.c > index 5925e49..49c5371 100644 > --- a/drivers/net/e1000/em_rxtx.c > +++ b/drivers/net/e1000/em_rxtx.c > @@ -2049,13 +2049,12 @@ e1000_flush_tx_ring(struct rte_eth_dev *dev) > tx_desc->lower.data =3D rte_cpu_to_le_32(txd_lower | size); > tx_desc->upper.data =3D 0; >=20 > - rte_wmb(); > + rte_cio_wmb(); > txq->tx_tail++; > if (txq->tx_tail =3D=3D txq->nb_tx_desc) > txq->tx_tail =3D 0; > - rte_io_wmb(); > tdt_reg_addr =3D E1000_PCI_REG_ADDR(hw, E1000_TDT(i)); > - E1000_PCI_REG_WRITE_RELAXED(tdt_reg_addr, txq->tx_tail); > + E1000_PCI_REG_WRITE(tdt_reg_addr, txq->tx_tail); > usec_delay(250); > } > } Reviewed-by: Gavin Hu =20 > -- > 2.7.4