From: "Niklas Söderlund" <niklas.soderlund@corigine.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>
Cc: Chaoyong He <chaoyong.he@corigine.com>,
oss-drivers@corigine.com, Peng Zhang <peng.zhang@corigine.com>,
stable@dpdk.org, dev@dpdk.org
Subject: Re: [PATCH v2] net/nfp: using the correct PCI name to look for the firmware
Date: Wed, 14 Dec 2022 11:45:47 +0100 [thread overview]
Message-ID: <Y5mpW6uR9VET+lWP@oden.dyn.berto.se> (raw)
In-Reply-To: <b26681ef-ec6e-3e5d-fab9-a6da01bf8cd3@amd.com>
Hi Ferruh,
On 2022-12-08 18:06:56 +0000, Ferruh Yigit wrote:
> On 12/8/2022 3:31 AM, Chaoyong He wrote:
> > From: Peng Zhang <peng.zhang@corigine.com>
> >
> > In the description of nfp document, DPDK PMD supports that the PF
> > looks for a firmware file by the PCI name.
> >
> > After this commit, it will looks for the PCI name format such as
> > pci-0000:04:00.0.nffw rather than pci-04:00.0.nffw, which will
> > keep consistent with what is written in the nfp.rst.
> >
> > Fixes: 896c265ef954 ("net/nfp: use new CPP interface")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Peng Zhang <peng.zhang@corigine.com>
> > Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> > Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
> > ---
> >
> > v2:
> > * add fixline.
> >
>
> Updated commit log a little while merging, please check.
Thanks for improving the commit message, looks good!
>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
>
> Applied to dpdk-next-net/main, thanks.
>
--
Kind Regards,
Niklas Söderlund
prev parent reply other threads:[~2022-12-14 10:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221128023705.32671-1-chaoyong.he@corigine.com>
2022-12-08 3:31 ` Chaoyong He
2022-12-08 18:06 ` Ferruh Yigit
2022-12-14 10:45 ` Niklas Söderlund [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5mpW6uR9VET+lWP@oden.dyn.berto.se \
--to=niklas.soderlund@corigine.com \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=oss-drivers@corigine.com \
--cc=peng.zhang@corigine.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).