From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CDF41A054F for ; Fri, 5 Mar 2021 16:50:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BDACD22A3E5; Fri, 5 Mar 2021 16:50:54 +0100 (CET) Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by mails.dpdk.org (Postfix) with ESMTP id 41D4622A33E; Fri, 5 Mar 2021 16:50:52 +0100 (CET) Received: by mail-pg1-f175.google.com with SMTP id l2so1650253pgb.1; Fri, 05 Mar 2021 07:50:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=O1l6qtU+AcopGh9jlkcpCoUjtIac9vseSPA0yHihucY=; b=ck5g02mnAsAGSCoGjWmdNy2ptmNWtCchYNgZ7xCLJo35Pn74Uspew69ULAa8N984AO VqaWActTB3nnwom6kF0rARxxLaS9rriBLGAJ3y9wvSAP996KyBvk+J8OYE9WWdtszNRy iPnxNbVFk51RnECloKZA0zcb/i2cfSYbtthK99s0/KuWchc/Tl1Yo2nqs1K9wgpEZ8DP iYzMO4iiiTWN3UD1MMLyM9zt+iHvnihNF7kI6ZgPav86l4qYPygYPTOJNbJBc4unSDr7 FbKCGx2QakfKL9E/BzPIHpw/sagQBq4gO7TRj84f26+nUgODnbXVR0wQlqsEXvIbnKya iPtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=O1l6qtU+AcopGh9jlkcpCoUjtIac9vseSPA0yHihucY=; b=tBOdEOFtomCBZWReEdWZTrO7/3uD/7J5+WrpQCjlm0srWQh9OPeo4pAe1ANGrrPafM UMkR5w6+rzuZFWbP4vxsA5CfrA6mXOd7S1Slb+t/wDSSlG/CxPU6t39Ed8UvYkKxvNEr CsBYbySPCwRu0l/6BIXtd+VVFqWIQKYGoyc+GCTulaIxKyNKEHiytD1i6QdGXc7tv/D1 AXGnvy7EaP0yOg4BxIKTtrb66eFAP6sEFhxMn0gyLI+5tjCJl2DyYmKwI+k5I9E9Zr4C qOub1nArgkGhnoSsA7BFTDGaoWKIIn+oQts4EBaQinTfmLb1+KTGKxIx1zgHyhKR15Sz Ni0A== X-Gm-Message-State: AOAM532G14u1eYs6h8Bf6ig4yQaTU5eaRez/aFe/JocGtEMigJO01KtL oyMPuGqPYXtn9bdjD+h+mo0= X-Google-Smtp-Source: ABdhPJx/DpcZjFGHZgBDTQD5O8DCWjpoUy2skrgKVK7Y1gsmVkaphBWcZUSW5siJENUUiPIAlyRsWw== X-Received: by 2002:a63:225f:: with SMTP id t31mr1324926pgm.371.1614959451380; Fri, 05 Mar 2021 07:50:51 -0800 (PST) Received: from gmail.com ([1.6.215.26]) by smtp.gmail.com with ESMTPSA id d2sm2714806pjx.42.2021.03.05.07.50.49 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Mar 2021 07:50:50 -0800 (PST) Date: Fri, 5 Mar 2021 21:20:16 +0530 From: Nithin Dabilpuram To: "Burakov, Anatoly" Cc: David Marchand , David Christensen , Jerin Jacob Kollanukkaran , dev , dpdk stable Message-ID: References: <20201012081106.10610-1-ndabilpuram@marvell.com> <20210115073243.7025-1-ndabilpuram@marvell.com> <20210115073243.7025-2-ndabilpuram@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v8 1/3] vfio: revert changes for map contiguous areas in one go X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Fri, Mar 05, 2021 at 01:54:34PM +0000, Burakov, Anatoly wrote: > On 05-Mar-21 7:50 AM, David Marchand wrote: > > On Fri, Jan 15, 2021 at 8:33 AM Nithin Dabilpuram > > wrote: > > > > > > In order to save DMA entries limited by kernel both for externel > > > memory and hugepage memory, an attempt was made to map physically > > > contiguous memory in one go. This cannot be done as VFIO IOMMU type1 > > > does not support partially unmapping a previously mapped memory > > > region while Heap can request for multi page mapping and > > > partial unmapping. > > > Hence for going back to old method of mapping/unmapping at > > > memseg granularity, this commit reverts > > > commit d1c7c0cdf7ba ("vfio: map contiguous areas in one go") > > > > > > Also add documentation on what module parameter needs to be used > > > to increase the per-container dma map limit for VFIO. > > > > > > Fixes: d1c7c0cdf7ba ("vfio: map contiguous areas in one go") > > > Cc: anatoly.burakov@intel.com > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Nithin Dabilpuram > > > Acked-by: Anatoly Burakov > > > Acked-by: David Christensen > > > > There is a regression reported in bz: https://bugs.dpdk.org/show_bug.cgi?id=649 > > > > I assigned it to Anatoly for now. > > Nithin, can you have a loo too? > > > > Thanks. > > > > > > I've responded on the bug tracker as well, but to repeat it here: this is > not a regression, this is intended behavior. We cannot do anything about > this. To add, for test case to pass, either limits have to be increased, or use "--mp-alloc=xmemhuge" instead of "--mp-alloc=xmem" which is forcing system page size or reduce total mbuf count to reduce page count. > > -- > Thanks, > Anatoly