From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 2F316A0548
for <public@inbox.dpdk.org>; Mon, 22 Mar 2021 09:27:41 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 19EE0140DB2;
Mon, 22 Mar 2021 09:27:41 +0100 (CET)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [63.128.21.124])
by mails.dpdk.org (Postfix) with ESMTP id 8D33540040
for <stable@dpdk.org>; Mon, 22 Mar 2021 09:27:38 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1616401657;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
in-reply-to:in-reply-to:references:references;
bh=hQMi6+YxF6etfKXKFG3NVoV4wr6E82t/ijfSDivLooo=;
b=Z6FlfKMVXl1HF6y2Ye7h8Epll+nNsEmNqcdetcfrQXSJbP9nFlNZYEVLWhmVuEw67vTtXh
WbkAt7Sq6JEhDJaHEUoSCNvCSODp7f4nIWnBcysN6nIyshlW0zOACvsspEjwrdeF9k/vEb
C9aEh1Lan/+3qa6kleEMWp/Woj+Y0aU=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
[209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-452-Zho1BilnP6OAPPhncGjiYQ-1; Mon, 22 Mar 2021 04:27:36 -0400
X-MC-Unique: Zho1BilnP6OAPPhncGjiYQ-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com
[10.5.11.22])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D6BB987A842;
Mon, 22 Mar 2021 08:27:33 +0000 (UTC)
Received: from localhost (ovpn-112-82.ams2.redhat.com [10.36.112.82])
by smtp.corp.redhat.com (Postfix) with ESMTPS id EB99510013C1;
Mon, 22 Mar 2021 08:27:26 +0000 (UTC)
Date: Mon, 22 Mar 2021 09:27:25 +0100
From: Jens Freimann <jfreimann@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, david.marchand@redhat.com, stable@dpdk.org,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Xiaoyun Li <xiaoyun.li@intel.com>, Ori Kam <orika@nvidia.com>,
Bing Zhao <bingz@nvidia.com>,
Bernard Iremonger <bernard.iremonger@intel.com>,
Kevin Traynor <ktraynor@redhat.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Maciej Czekaj <maciej.czekaj@caviumnetworks.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>
Message-ID: <YFhU7YhDgEz5ZdiH@fedora>
References: <20210309233116.1934666-1-thomas@monjalon.net>
<20210321223116.1340974-1-thomas@monjalon.net>
<20210321223116.1340974-12-thomas@monjalon.net>
MIME-Version: 1.0
In-Reply-To: <20210321223116.1340974-12-thomas@monjalon.net>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
Authentication-Results: relay.mimecast.com;
auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jfreimann@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v4 11/11] app/testpmd: fix
usage text
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
On Sun, Mar 21, 2021 at 11:31:15PM +0100, Thomas Monjalon wrote:
>The options help text was including an incomplete and redundant
>summary of the options before explaining each. The summary is dropped.
>
>The details of the option --hairpin-mode had an extra space,
>breaking the alignment with the next line.
>
>There were some mismatches between options in the usage text
> sed -rn 's/.*\(" *--([a-z-]*)[=: ].*/\1/p' app/test-pmd/parameters.c
>and the options declared in lgopts array
> sed -rn 's/.*\{.*"(.*)",.*,.*,.*},.*/\1/p' app/test-pmd/parameters.c
>The misses were:
> --no-numa
> --enable-scatter
> --tx-ip
> --tx-udp
> --noisy-lkup-num-reads-writes
>The option --ports was not implemented.
>
>Fixes: 01817b10d27c ("app/testpmd: change hairpin queues setup")
>Fixes: 3c156061b938 ("app/testpmd: add noisy neighbour forwarding mode")
>Fixes: bf5b2126bf44 ("app/testpmd: add ability to set Tx IP and UDP parameters")
>Fixes: 0499793854f5 ("app/testpmd: add scatter enabling option")
>Fixes: 999b2ee0fe45 ("app/testpmd: enable NUMA support by default")
>Fixes: af75078fece3 ("first public release")
>Cc: stable@dpdk.org
>
>Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>---
> app/test-pmd/parameters.c | 35 ++++++++---------------------------
> 1 file changed, 8 insertions(+), 27 deletions(-)
>
Thank you Thomas!
Reviewed-by: Jens Freimann <jfreimann@redhat.com>
regards,
Jens