From: Liang Ma <liangma@liangbit.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Konstantin Ananyev <konstantin.ananyev@intel.com>,
dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] acl: fix build with GCC 6.3
Date: Fri, 21 May 2021 16:21:31 +0100 [thread overview]
Message-ID: <YKfP+3MnwZt+efM0@C02F33EJML85> (raw)
In-Reply-To: <5942248.XgMt1RgFVE@thomas>
On Fri, May 21, 2021 at 05:10:41PM +0200, Thomas Monjalon wrote:
> 21/05/2021 16:42, Konstantin Ananyev:
> > --buildtype=debug with gcc 6.3 produces the following error:
> >
> > ../lib/librte_acl/acl_run_avx512_common.h: In function
> > ‘resolve_match_idx_avx512x16’:
> > ../lib/librte_acl/acl_run_avx512x16.h:33:18: error:
> > the last argument must be an 8-bit immediate
> > ^
> > ../lib/librte_acl/acl_run_avx512_common.h:373:9: note:
> > in expansion of macro ‘_M_I_’
> > return _M_I_(slli_epi32)(mi, match_log);
> > ^~~~~
> >
> > Seems like gcc-6.3 complains about the following construct:
> >
> > static const uint32_t match_log = 5;
> > ...
> > _mm512_slli_epi32(mi, match_log);
> >
> > It can't substitute constant variable 'match_log' with its actual value.
> > The fix replaces constant variable with its immediate value.
> >
> > Bugzilla ID: 717
> > Fixes: b64c2295f7fc ("acl: add 256-bit AVX512 classify method")
> > Fixes: 45da22e42ec3 ("acl: add 512-bit AVX512 classify method")
> > Cc: stable@dpdk.org
> >
> > Reported-by: Liang Ma <liangma@liangbit.com>
> > Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
>
> How much critical is it?
> It looks safer to wait for 21.08 cycle?
+1. gcc8.30 is OK. It's a bit late now.
>
>
next prev parent reply other threads:[~2021-05-21 15:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 14:42 [dpdk-stable] " Konstantin Ananyev
2021-05-21 14:55 ` Liang Ma
2021-05-21 15:10 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2021-05-21 15:16 ` Ananyev, Konstantin
2021-05-21 15:21 ` Liang Ma [this message]
2021-06-17 6:57 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKfP+3MnwZt+efM0@C02F33EJML85 \
--to=liangma@liangbit.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).