From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Jan Viktorin <viktorin@rehivetech.com>,
Ruifeng Wang <ruifeng.wang@arm.com>,
Jerin Jacob <jerinj@marvell.com>, dev <dev@dpdk.org>,
Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>,
dpdk stable <stable@dpdk.org>,
kosar@rehivetech.com, Phil Yang <phil.yang@arm.com>,
Joyce Kong <joyce.kong@arm.com>
Subject: Re: [dpdk-stable] [PATCH v5] eal: arm: fix out of tree build
Date: Fri, 11 Jun 2021 10:59:42 +0100 [thread overview]
Message-ID: <YMM0DnqP/bN9+5jl@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8ynCtzh9fJnKQhojYJBp5Jn+0iwysZEcY+ROwt2=h_ZDQ@mail.gmail.com>
On Fri, Jun 11, 2021 at 11:54:25AM +0200, David Marchand wrote:
> Hello Bruce,
>
> On Wed, Jun 9, 2021 at 12:18 PM Michael Pfeiffer
> <michael.pfeiffer@tu-ilmenau.de> wrote:
> >
> > Including various headers may fail for ARM builds with 'Platform must
> > be built with RTE_FORCE_INTRINSICS' if rte_config.h is not included
> > before. Move the error message after the includes to ensure rte_config.h
> > is always included.
> >
> > Fixes: de966ccdcd7f ("eal/arm: add byte order operations for ARM")
> > Fixes: 17d5fa0fa90d ("eal/arm: add atomic operations for ARMv7")
> > Fixes: d708f01b7102 ("eal/arm: add atomic operations for ARMv8")
> > Fixes: 2173f3333b61 ("mcslock: add MCS queued lock implementation")
> > Fixes: 7860c3965483 ("eal/arm: add spinlock operations for ARM")
> > Fixes: ca49b92079df ("ticketlock: enable generic ticketlock on all arch")
> > Cc: stable@dpdk.org
> > Cc: kosar@rehivetech.com
> > Cc: phil.yang@arm.com
> > Cc: joyce.kong@arm.com
> >
> > Signed-off-by: Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>
>
> The header check currently compiles all headers with an implicit
> "-include rte_config.h".
> I suppose this is because it comes from the project level meson configuration.
>
> Would there be a way to detect the issue fixed by this patch?
>
I'm not convinced that there is an issue here. For DPDK compiles
rte_config.h must always be included first, which is why it's included in
the cflags reported by pkg-config. If we do want to move away from having
rte_config as an omnipresent first include, we need to update many DPDK
headers to explicitly include it.
/Bruce
next prev parent reply other threads:[~2021-06-11 9:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CALBAE1N_XJqwA1ypCZ6bMq1edGjLefGc41SM4yUwyDoufWgcSw@mail.gmail.com>
2021-06-07 6:53 ` [dpdk-stable] [PATCH v3] " Michael Pfeiffer
2021-06-08 9:56 ` Ruifeng Wang
2021-06-08 10:29 ` [dpdk-stable] [PATCH v4] " Michael Pfeiffer
2021-06-09 7:27 ` Ruifeng Wang
2021-06-09 10:17 ` [dpdk-stable] [PATCH v5] " Michael Pfeiffer
2021-06-09 10:22 ` Ruifeng Wang
2021-06-09 11:43 ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
2021-06-11 9:54 ` [dpdk-stable] " David Marchand
2021-06-11 9:59 ` Bruce Richardson [this message]
2021-06-11 10:27 ` Michael Pfeiffer
2021-06-11 10:44 ` Ruifeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMM0DnqP/bN9+5jl@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=joyce.kong@arm.com \
--cc=kosar@rehivetech.com \
--cc=michael.pfeiffer@tu-ilmenau.de \
--cc=phil.yang@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=stable@dpdk.org \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).