From: Olivier Matz <olivier.matz@6wind.com> To: Mohsin Kazmi <mohsin.kazmi14@gmail.com> Cc: dev@dpdk.org, ray.kinsella@intel.com, stable@dpdk.org, Tomasz Kulasek <tomaszx.kulasek@intel.com>, Konstantin Ananyev <konstantin.ananyev@intel.com>, Thomas Monjalon <thomas.monjalon@6wind.com> Subject: Re: [dpdk-stable] [PATCH v2] net: prepare the outer ipv4 hdr for checksum Date: Wed, 30 Jun 2021 16:09:53 +0200 Message-ID: <YNx7MVHMcSzA2ziD@platinum> (raw) In-Reply-To: <20210630110404.21209-1-mohsin.kazmi14@gmail.com> Hi Mohsin, Hope you are fine! Please see my comments below. On Wed, Jun 30, 2021 at 01:04:04PM +0200, Mohsin Kazmi wrote: > Re: [PATCH v2] net: prepare the outer ipv4 hdr for checksum I suggest to highlight that it this is the Intel-specific tx-prepare function in the commit title. What about: net: fix Intel-specific Tx preparation for outer checksums > Preparation the headers for the hardware offload > misses the outer ipv4 checksum offload. > It results in bad checksum computed by hardware NIC. > > This patch fixes the issue by setting the outer ipv4 > checksum field to 0. > > Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation") > Cc: stable@dpdk.org > > Signed-off-by: Mohsin Kazmi <mohsin.kazmi14@gmail.com> > Acked-by: Qi Zhang <qi.z.zhang@intel.com> > --- > > v2: > * Update the commit message with Fixes. > --- > lib/net/rte_net.h | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/lib/net/rte_net.h b/lib/net/rte_net.h > index 434435ffa2..e47365099e 100644 > --- a/lib/net/rte_net.h > +++ b/lib/net/rte_net.h > @@ -128,8 +128,18 @@ rte_net_intel_cksum_flags_prepare(struct rte_mbuf *m, uint64_t ol_flags) > if (!(ol_flags & (PKT_TX_IP_CKSUM | PKT_TX_L4_MASK | PKT_TX_TCP_SEG))) > return 0; I think this test should be updated too with PKT_TX_OUTER_IP_CKSUM. > > - if (ol_flags & (PKT_TX_OUTER_IPV4 | PKT_TX_OUTER_IPV6)) > + if (ol_flags & (PKT_TX_OUTER_IPV4 | PKT_TX_OUTER_IPV6)) { > inner_l3_offset += m->outer_l2_len + m->outer_l3_len; > + /* > + * prepare outer ipv4 header checksum by setting it to 0, > + * in order to be computed by hardware NICs. > + */ > + if (ol_flags & PKT_TX_OUTER_IP_CKSUM) { > + ipv4_hdr = rte_pktmbuf_mtod_offset(m, > + struct rte_ipv4_hdr *, m->outer_l2_len); > + ipv4_hdr->hdr_checksum = 0; > + } > + } What about outer L4 checksum? Does it requires the same than inner? > > /* > * Check if headers are fragmented. > -- > 2.17.1 >
next prev parent reply other threads:[~2021-06-30 14:09 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-30 11:04 Mohsin Kazmi 2021-06-30 14:09 ` Olivier Matz [this message] 2021-07-07 9:14 ` Mohsin Kazmi 2021-07-22 19:53 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon 2021-08-03 12:29 ` Mohsin Kazmi 2021-07-07 9:40 ` [dpdk-stable] [PATCH v3] net: fix Intel-specific Prepare " Mohsin Kazmi 2021-07-22 19:56 ` Thomas Monjalon 2021-07-27 12:52 ` Olivier Matz 2021-07-28 15:46 ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko 2021-07-30 11:11 ` Olivier Matz 2021-07-31 12:49 ` Andrew Rybchenko 2021-08-03 12:49 ` Mohsin Kazmi 2021-08-27 13:44 ` Mohsin Kazmi 2021-09-07 10:49 ` [dpdk-stable] [PATCH v4] net: fix Intel-specific Prepare the outer IPv4 " Mohsin Kazmi 2021-09-15 10:39 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit 2021-09-15 11:04 ` Ferruh Yigit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YNx7MVHMcSzA2ziD@platinum \ --to=olivier.matz@6wind.com \ --cc=dev@dpdk.org \ --cc=konstantin.ananyev@intel.com \ --cc=mohsin.kazmi14@gmail.com \ --cc=ray.kinsella@intel.com \ --cc=stable@dpdk.org \ --cc=thomas.monjalon@6wind.com \ --cc=tomaszx.kulasek@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \ stable@dpdk.org public-inbox-index stable Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/public-inbox.git