From: Olivier Matz <olivier.matz@6wind.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Mohsin Kazmi <mohsin.kazmi14@gmail.com>,
dev@dpdk.org, stable@dpdk.org, david.marchand@redhat.com,
maxime.coquelin@redhat.com, andrew.rybchenko@oktetlabs.ru,
ferruh.yigit@intel.com
Subject: Re: [dpdk-stable] [PATCH v3] net: fix Intel-specific Prepare the outer ipv4 hdr for checksum
Date: Tue, 27 Jul 2021 14:52:58 +0200
Message-ID: <YQABqs5okRV4V5tZ@platinum> (raw)
In-Reply-To: <7265315.64hUE0sMR9@thomas>
On Thu, Jul 22, 2021 at 09:56:25PM +0200, Thomas Monjalon wrote:
> +Cc more people for reviews.
>
> 07/07/2021 11:40, Mohsin Kazmi:
> > Preparation the headers for the hardware offload
"of" is missing after Preparation?
> > misses the outer ipv4 checksum offload.
> > It results in bad checksum computed by hardware NIC.
> >
> > This patch fixes the issue by setting the outer ipv4
> > checksum field to 0.
>
> nit: please write "IPv4" here and below.
>
> > Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Mohsin Kazmi <mohsin.kazmi14@gmail.com>
> > Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
next prev parent reply other threads:[~2021-07-27 12:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 11:04 [dpdk-stable] [PATCH v2] net: prepare " Mohsin Kazmi
2021-06-30 14:09 ` Olivier Matz
2021-07-07 9:14 ` Mohsin Kazmi
2021-07-22 19:53 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2021-08-03 12:29 ` Mohsin Kazmi
2021-07-07 9:40 ` [dpdk-stable] [PATCH v3] net: fix Intel-specific Prepare " Mohsin Kazmi
2021-07-22 19:56 ` Thomas Monjalon
2021-07-27 12:52 ` Olivier Matz [this message]
2021-07-28 15:46 ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
2021-07-30 11:11 ` Olivier Matz
2021-07-31 12:49 ` Andrew Rybchenko
2021-08-03 12:49 ` Mohsin Kazmi
2021-08-27 13:44 ` Mohsin Kazmi
2021-09-07 10:49 ` [dpdk-stable] [PATCH v4] net: fix Intel-specific Prepare the outer IPv4 " Mohsin Kazmi
2021-09-15 10:39 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
2021-09-15 11:04 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQABqs5okRV4V5tZ@platinum \
--to=olivier.matz@6wind.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=mohsin.kazmi14@gmail.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
patches for DPDK stable branches
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
stable@dpdk.org
public-inbox-index stable
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://inbox.dpdk.org/inbox.dpdk.stable
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git