From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E2640460D3 for ; Tue, 21 Jan 2025 10:05:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D72C542D76; Tue, 21 Jan 2025 10:05:48 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by mails.dpdk.org (Postfix) with ESMTP id 1C53B4066E; Tue, 21 Jan 2025 10:05:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737450345; x=1768986345; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=mcdDB5lkG+CYE1k5B0nQScjNqeFuOWvF/uxbCi7KBnE=; b=iQ6rOgOZ31LGf/xZYHHGP8g4S3PeeTF1xo7Xxa1ZQ2D0ElijxfVVB1lx AT0EpRS0sATXQZEx/ZD+rzFMSJGIPBxQCetmDbCBziL6YQFsPQKKA83Ws KpUnXr3XKEiDuOO397+h/0L870IxCd6ughAhkkLSBmnyivx4R5njeWpdM Z6VmmEelzk3i90bNfYYp38zL0m6nPcZ+C9skQ4HmHjOeZplX3UDTZfHjT C9Mv0HZ4aaosDMr0CIX8+/j+1AIUWx7o1OBga+9bRak9SuASM8LO7Rzup /uH4fD5hJNUCWrbA0UOFFu4oH/7xvfRbri2aH+CXtF3LaXjw9ro0/5pJ+ Q==; X-CSE-ConnectionGUID: 4twRz6cjSP+wEMeOeHY3QA== X-CSE-MsgGUID: r1cgtpVDQU2xiqKO9XmSAQ== X-IronPort-AV: E=McAfee;i="6700,10204,11321"; a="48845731" X-IronPort-AV: E=Sophos;i="6.13,221,1732608000"; d="scan'208";a="48845731" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2025 01:05:44 -0800 X-CSE-ConnectionGUID: hbMhk5aYRCmbfGLz8dkcpA== X-CSE-MsgGUID: gn/a+QCXTU2rwkOtKwY77g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="106577318" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa010.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 21 Jan 2025 01:05:45 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Tue, 21 Jan 2025 01:05:43 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Tue, 21 Jan 2025 01:05:43 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.173) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Tue, 21 Jan 2025 01:05:43 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Cml/n5HRGYKbFGY1ZTdq6GpK8ePLPCv8B6BAIEtIJ/5p13E4NUNLVBe73n/HEaqx9ZxB0m4aeSUgtib5CsNrU6tpEDt3n6Aetu/6eJudLVlrbSjnK2K4ZtI1fPb+Z+lLCH6Kz8KZ17OPHZLdp+g7TbW/SBjmXYGoNM43KRMkj//PKB01EKUcVxBpnizkye7J5RdMwNZNdBPueag7AupbFWxey3VvTKIuryVWz39/6XIi4LqzOWElKAJvfBBFmZxagbVhKxia8d4xxUeDikTpLH9TJF3fJI+JOpYEKp6Yd0k50iCLtJECMD7mtkpHXwStBExxMOh7E2K+III9yjM9TQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lhXNEZ/XvP9zrX4Ece+vm4KX5DbMKoMbhNzxrB8R2Ys=; b=pHeqKGPDGgnzLHUjnPs4ZvGJESqZEzxAcYhijSbdnuYB2yLf80YJAyS0IIFVXAatExKGYLMDw7t7aLHjcLxsDN4ZOz/VHe+Nbcvg4mn7EZFsB+M0DzPJgB1G0yK5deLoqXIj1SQvj9B3Ir1hafGrLWjEpjkGIXiWyHh/9owpYVoGNWHtwNpb++t/75cGFV333UC00NEF4Zv3MBlazkYwHeRKr5eeImLxma0Qlwgw3lqbtTZZB4gnK6ewU8KMou1u5WJ+6mUn99h6hrkYy6kDApkLm47JGuh6xg2uoSYuVPqJTnStPDJ417E3r8jq7i4Nbo99E2I8tA9VSGHAIqEmTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by LV8PR11MB8558.namprd11.prod.outlook.com (2603:10b6:408:1ed::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.21; Tue, 21 Jan 2025 09:05:41 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%5]) with mapi id 15.20.8356.020; Tue, 21 Jan 2025 09:05:40 +0000 Date: Tue, 21 Jan 2025 09:05:34 +0000 From: Bruce Richardson To: Zhichao Zeng , Jaroslaw Ilgiewicz CC: , , Zhichao Zeng , Ian Stokes , Anatoly Burakov Subject: Re: [PATCH v2] net/i40e/base: fix the debug print format Message-ID: References: <20250114100010.207536-1-zhichaox.zeng@intel.com> <20250115074417.396909-1-jaroslaw.ilgiewicz@intel.com> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250115074417.396909-1-jaroslaw.ilgiewicz@intel.com> X-ClientProxiedBy: ZR2P278CA0028.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:46::8) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|LV8PR11MB8558:EE_ X-MS-Office365-Filtering-Correlation-Id: 04e1ab54-57d0-4c99-e943-08dd39fac73c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?iso-8859-1?Q?to7Y4HhTvNmy0QepjhV/E1zgphYxffn3XraK2qJ4RgO8s14mY9v2ayqo3C?= =?iso-8859-1?Q?eJ5+15KDcVSw47nmo5j207jlRMrPQ6Uqy0FBbZZ2w3I+hP+zKdegkGfmkB?= =?iso-8859-1?Q?BU1RGbrXJf3UF/v12a11QjMu/fTxaAz2+bow5RGl+1Sl8yqOxDIzxNtQJ+?= =?iso-8859-1?Q?b1oJ53wrZBAQzTOSVDdwfRIpex3fsqUvfVHkfFo4Jr+WHP1Ds9oEcosGxl?= =?iso-8859-1?Q?ktD0wo9KOVvb4uZ+9q7iDwutbU/6maNBHkC7w11WnLfrPXNqUaqh9VdCYM?= =?iso-8859-1?Q?qUHJ9J6G963eZ015TmVPOiENCdE1ShupZ2WtOwpgEJuhYXB1tJUbimg00a?= =?iso-8859-1?Q?2jaFKRQjA8HUqaZDIzHM69rIrD7w3SuvLFv8AmYLm7vSaQDET33JJjGSlF?= =?iso-8859-1?Q?CFTcQUo1gVstN7SuhZLZMND+Nv93XffRcRD3TmBLtjKCB0RTvruDVQx62T?= =?iso-8859-1?Q?jmc2yP2BBM/2I4o2rCRCrMRZbpjWGlG7x0uVnDe0BHSI2bzAQR7q9vdjFE?= =?iso-8859-1?Q?i3+tIXsPj84BabLxXkYDkzZ+m6D65yHvARRo7lkFYnhtlHOf0S8+YLGoDx?= =?iso-8859-1?Q?4VpZ6uNidzb3P769KRefTAK16EBVxwFWGSaRfvOlCXvi9OjYKkWpsTDlul?= =?iso-8859-1?Q?ME3tXlvD9J3btY8wWeueLURr9TlgCecjpeF46gn1eCjypPPbiqhivOV/tn?= =?iso-8859-1?Q?o6MWNyYqo/wg/xTZNaLwca7aadZOzAh7aUi62bJiguZWOWSRnWTp9/FvL1?= =?iso-8859-1?Q?asg+QwjCATPtG1p/XdnRZkdcbgNkSdb2TLMrG0Wb+HsIs8VU3NR4ekPhay?= =?iso-8859-1?Q?uY39ctpYsS6ghqJdpl7xn8tbvMYL69EDYhoqM6WgBOXVCORN+59MPMTNZk?= =?iso-8859-1?Q?AQXtt6MuaO5K2+xwugqfcWk51TYp8Tfpc1qmN+CTJA+4XQgyXhgNXDqLtd?= =?iso-8859-1?Q?FI/c6d3WERNgtXcL91xiAFezVDItByuMQaKgjg4rqWsoZO4vqzFHOzgBG7?= =?iso-8859-1?Q?Bb6vTBdCbbPAuZo6EPI0mfly3YIIlijGLcrby4nlm0kugRVbAExQ5aPR9B?= =?iso-8859-1?Q?q0lfV3PF0/87tECFcR8pxwW6lHvNMuv7L0L/YFhOes/8/Y24b0Qk5H6gME?= =?iso-8859-1?Q?DRz+h1YjWks0O5in8fnjLNjm08cpGh7V/BXQtjXGaGSMBk2w/q5ic7PwBm?= =?iso-8859-1?Q?JOTLdl4QtW4LKyE7Y4qAXIaOiiHnvoQasAUcx0PYUGR1sbRHjVdEld0gxC?= =?iso-8859-1?Q?xrLrQkFl3QiKNB4rKMfMexUwUZWNj+1aOihLPj3koy35hwyH+A48eXvhFV?= =?iso-8859-1?Q?GEE6d8FI8/yMsghdKZl2NYPd4iLEzANrElB5h1sG7CFraRFSU3Y+bvZiYk?= =?iso-8859-1?Q?y9EHnhxEEjqMX6wadvf3oyd/IIKCIHzUVYjVm1Y1z+HW3lZCTK1QBQFvpa?= =?iso-8859-1?Q?vPvLY4z8e+Vvx5S0?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?cR+uZdYN5SPHRykpPAPUHfHxqDMokYtTRpDyChGF2G9IBr047s0gRTf9LN?= =?iso-8859-1?Q?RtYeBM9W8/XUaiWeV/aTRgIq7b0vwtqZNWxF687+nk0b8mDSiu0N9yvT+T?= =?iso-8859-1?Q?8TG7zyhHn6HORdZAwVvfQE7cHCsX6/gx11oyDgz58C3kRYjkMOctXnCzik?= =?iso-8859-1?Q?joCk4QLiQ3R3iA7+xPkICKR22RHGC+X1xWdmYD5+E6dFChTdaNoMSjjumW?= =?iso-8859-1?Q?Wdp2lelkDnK3B9Jtw8mCg7GG9pm2JqSu0FNZ9VBU/iInB7EaDqHFoj0TFb?= =?iso-8859-1?Q?OqssvvNrYDdbhjU5gIqTkYJ/39ir+12jt1mj/GJSmCs7KS9SBDXK2A/z2g?= =?iso-8859-1?Q?ltDvdZVLeeoT+T6U0W2dU8UiWbJmcSvOPh8Vc4DnQd8n8rVRkDQcnwYyO7?= =?iso-8859-1?Q?ajapNgkdc0hRgnJcUHsCBCaXD3GBLuJP+S0DUhkPgdT7Wfo2iHrZ2Y9+rx?= =?iso-8859-1?Q?MYpaSc+nP+JWJz1OtV6RE0pLddP7JGZae/MUHP4Q+WMBFwhTNp5isZiBrg?= =?iso-8859-1?Q?/LCoM5hptCWZHGCM9BGhs2QFl0hdiKK0Zq1bRJmfZPTZ4tPG9UK7Ci/9u8?= =?iso-8859-1?Q?Z+BS2SkTGN2NBu3aEprTc8Q8YCocNdMdv3QLIn7Dv8dJZsN1AqrHDGkNmW?= =?iso-8859-1?Q?o+8794eAMtzNtpte2ZyKpTrZ6Ol2fPR4Tuk3vR22NXP4q0CsmvD6ixgED+?= =?iso-8859-1?Q?WiLVdSKkhqn8nbxNttxWuMX2ZiYJfMHkh/T6kT20cPv9yC+MiXXvzCxgel?= =?iso-8859-1?Q?jf1GL3R7xIoaUzXWBeNQVqBwzHk+Hvdgszowyvx10ViASOhJiUNFrF1gG4?= =?iso-8859-1?Q?KEWNqwmJ8XEy0RX5GoKA8dU8fNDoR5ADFIzYiM9AbENdBm/Fiz9KNEyngW?= =?iso-8859-1?Q?nMVIfZqAAUCF1ML7iGs+YCBh9yA3B9yUHcWgNYDDZRAX+CqVi3EcudP2qq?= =?iso-8859-1?Q?1wiLFtIb51fKOL6THOcIaq7ONurKxEe0ao/XL0c6ft4PVZJQGP/bFwM9HF?= =?iso-8859-1?Q?Ct6pGL7nvVJml+MaQoDWW7Cr/QDYV2RLeFb0dnn7yBgvf9A6VosdVsq/+o?= =?iso-8859-1?Q?NXogbvziYpMFA0XxGUcc3p9FayIxCtLJe6AxzjfhPugFtXHwC3SLAPA36j?= =?iso-8859-1?Q?xgNLSQzG5VFX5Xsjy5o5UkmDrfdalKiZJTLzKt8s3zNyiUChuBXiwqd23w?= =?iso-8859-1?Q?+b58HGL4WkVd/v/iaiGxD/KWNmEPtNQDNx1JV9JVWDOK4sMZY43OSTS08X?= =?iso-8859-1?Q?9ZeZdO3afjICKOcZ8Z30L98Smnvvzwsa2QxWgGQCt7hgL1w9x+KX1CgsMh?= =?iso-8859-1?Q?RDmCB6nVwhTasa5M0oYfyTGMVm/a3PQic+X0rC8gVyEeQepRB5JP70FMgy?= =?iso-8859-1?Q?DY8sic2bp8SWFLzJ4UahM+suww7rT5VVPCeIQhav2CRZIxVa4V81KHun5O?= =?iso-8859-1?Q?OagUI46nNfiGNETMwonXmIhiJ36cN2cMoATdBRh2lC/X2P7fQHoGwlGmVq?= =?iso-8859-1?Q?k7/jf18lTNRyLSVYPhDpqxaohEaabG2DEVT7LncFnHvL6aInpjshIxSDgS?= =?iso-8859-1?Q?L8mCK11uTohv+ZhI8SamtBo/l1g3MTXbf7CuYwBVs7S8qBrtgfyL2d6Ygv?= =?iso-8859-1?Q?JMkl3sF7GwZZe6LVvlhZvoCRtTTAYyUNG0XNJ8eLH/cjPvbjTgyKL1xA?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 04e1ab54-57d0-4c99-e943-08dd39fac73c X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jan 2025 09:05:40.6248 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ew0/JSc/iOwTOlOQqJyUQUV3hT4k+CUinIegFlClh1pS8zJ1Y/A3C3GW7NSZWZ9sRcFFQdLs/eBOH3KSrROe504/VZmXnvXNyy6R849kWMg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8558 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, Jan 15, 2025 at 03:44:17PM +0800, Jaroslaw Ilgiewicz wrote: > This patch modifies format specifier in debug prints to match to the > change of time variables from 64 bit to 32 bit. > > Fixes: d980a401b137 ("net/i40e/base: add NVM acquire with custom timeout") > Cc: stable@dpdk.org > > Signed-off-by: Zhichao Zeng > Signed-off-by: Jaroslaw Ilgiewicz > --- > drivers/net/i40e/base/README | 2 +- > drivers/net/i40e/base/i40e_nvm.c | 10 ++++------ > 2 files changed, 5 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/i40e/base/README b/drivers/net/i40e/base/README > index c5305ffae0..188633dde3 100644 > --- a/drivers/net/i40e/base/README > +++ b/drivers/net/i40e/base/README > @@ -6,7 +6,7 @@ Intel® I40E driver > ================== > > This directory contains source code of i40e base driver generated on > -2024-08-30 released by the team which develops > +2025-01-15 released by the team which develops > basic drivers for any i40e NIC. The directory of base/ contains the > original source package. > This driver is valid for the product(s) listed below > diff --git a/drivers/net/i40e/base/i40e_nvm.c b/drivers/net/i40e/base/i40e_nvm.c > index 3e16a0d997..890c1dfc8a 100644 > --- a/drivers/net/i40e/base/i40e_nvm.c > +++ b/drivers/net/i40e/base/i40e_nvm.c > @@ -145,9 +145,8 @@ enum i40e_status_code i40e_acquire_nvm_ex(struct i40e_hw *hw, > > if (ret_code) > i40e_debug(hw, I40E_DEBUG_NVM, > - "NVM acquire type %d failed time_left=%llu ret=%d aq_err=%d\n", > - access, (unsigned long long)time_left, ret_code, > - hw->aq.asq_last_status); > + "NVM acquire type %d failed time_left=%" PRIu32 " ret=%d aq_err=%d\n", > + access, time_left, ret_code, hw->aq.asq_last_status); > Since this is not actually fixing a bug, but just aligning the DPDK code with the internal base code, I think we can defer this patch. Let's look at it again, if it's worth aligning these simple fmt strings, when we next have a base code update with some more significant changes in it. Thanks, /Bruce