From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B988B4550B for ; Thu, 27 Jun 2024 12:57:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AFBB940DDE; Thu, 27 Jun 2024 12:57:49 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by mails.dpdk.org (Postfix) with ESMTP id 6762A40B8F; Thu, 27 Jun 2024 12:51:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719485472; x=1751021472; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=V8fQgJDYHNOUTd/OW5NERhvL0LDSEIb1o9fS5wkoMxo=; b=kINeRxB8g8lSBocU9hexvhjKhitISwvgKz+416BtMDiHsfVpU4VW1fkz tROF9x6QyhtrWTsgsuUa18CKSV2+L0i4Fbzw2r29n5MjtDn+S6egvyub5 LacLJsFGKQzWDrJHhHGgcM5i5VL4oYcgIZsJJVWT7y+6cIdu8FyEn6lQA aRVx+CEFSV53WKzNMQ1dqLR+wylrDu/yga6uPkjbraosV8EJbEy5127Y+ bgxWRx12vhKz7emx+BEgtzu3IBr05z6DoSSpax5hmaNJXMpcfmImSQ1fd PAmGXj6m+OygLh86OJUTzXwIJPMzBYVu9VJuZLoNaTDFyMCTNQS05iCef w==; X-CSE-ConnectionGUID: gfhfMEv0SMqMIJx16SoOqA== X-CSE-MsgGUID: fI/TOfMYSu+ZS1gAHl78pg== X-IronPort-AV: E=McAfee;i="6700,10204,11115"; a="12278743" X-IronPort-AV: E=Sophos;i="6.08,269,1712646000"; d="scan'208";a="12278743" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2024 03:51:10 -0700 X-CSE-ConnectionGUID: fqrPqIEgROOUgFoV6Cwnfw== X-CSE-MsgGUID: MeDibm4lRMKVKA8QqrKdZg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,269,1712646000"; d="scan'208";a="45088177" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 27 Jun 2024 03:51:11 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 27 Jun 2024 03:51:09 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 27 Jun 2024 03:51:09 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 27 Jun 2024 03:51:09 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.171) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 27 Jun 2024 03:51:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gjl9O30d90kssmBvxuK0cNgavzsbJqLjkLyv50CRyaeXSMt0Ej7gX+2p0azDOIPX3LDBrxs9vvG/ViTIAWx3iLsMzkspG70xFKP2rP7HplIQQeqn1DESLYdBHG06UzyY0N0FiiDM+EbM7rDzNMFi2QofR30FkRIl6+uPIK7+AGXvuMt+Tvmdb7onvFLdJ9sH+E6f6VVS4c6pk9VFfPkH9yJ/Bkng0lAUBht9lIkgCxjveEyOVfTujJfj5V4/sMwwyOK5flpUfgOWsIsFuIMcPRpAOCSDH8GDp0USgR917R3Go4+jZ1uoNT5krufldhwoGKYUcKM5ISv1c+JTWagdFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rskki9I62OMtjB3sKmFw972m85QY1zwMWDrzuloh+Gg=; b=B91nB6MNzbOcg/ww1XxolFvI8eirivZFkP3rhmeAI+/uBncBMBQkl/wlZfVR9+N4GO9a4LnRLwW9xFHgikso0QumIdmZMSJfQT08hF2daOVeOFBp3f1aCemAww34stivizPmQXCKhd+enjmusn6jWHBEutUwlI1UxVVnGT/EgwoF4Ll11lTOVIxnsCMVbpYypSQCbrltEJCOVJdbfSxkV8iNtCXzmidAMmlcHXwVzcpETNQ8TTPW9SKGNJnAid4Kg/xEwvnUZ5fclY+KOlEyAaa6VwFTGZRpM1hql2boc646zrBEjZi+25URDaflaTbnnWk+Q0P62JzrFtakZchzgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH7PR11MB5820.namprd11.prod.outlook.com (2603:10b6:510:133::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.30; Thu, 27 Jun 2024 10:51:02 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7719.022; Thu, 27 Jun 2024 10:51:02 +0000 Date: Thu, 27 Jun 2024 11:50:56 +0100 From: Bruce Richardson To: Mingjin Ye CC: , , Dmitry Kozlyuk Subject: Re: [PATCH] buildtools: fix invalid symbols Message-ID: References: <20240627101144.665413-1-mingjinx.ye@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240627101144.665413-1-mingjinx.ye@intel.com> X-ClientProxiedBy: DUZPR01CA0280.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b9::26) To CY8PR11MB7290.namprd11.prod.outlook.com (2603:10b6:930:9a::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH7PR11MB5820:EE_ X-MS-Office365-Filtering-Correlation-Id: 27d31964-4061-42ad-7681-08dc96970904 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Nrlif+LiVBY/9m1/EubYiflH8rEWuV+LZz87BaPJBLFDayepD5hbE2D/e/Kt?= =?us-ascii?Q?AP/fucPdifQw/hARh1glFgfqbTLPIdot+BdMtde50XddYgUgs2jqbMOlWCai?= =?us-ascii?Q?HCDoTDaH+c4GbagDK1JWh5lqQg37pqlHYCZmJ/+3R1ZmOhnPAeUgKOxpuCgn?= =?us-ascii?Q?eYhMpFsvH54ALFRec805DAnZVx2gs0A6mLwc4LblOpn9gqkdI9fJwBMVq6hn?= =?us-ascii?Q?mOVxDCwiyls4vlDB1riv/EnPyXdXeXKz0RFU2UHWA+9JHLhoQEVhz4eAhXt8?= =?us-ascii?Q?MJy/bg2lnuEBLHMJnz89X2pRXKjx94QPLhjN2DwP5Gu71+lPe2A2tJFPFiQ0?= =?us-ascii?Q?QReF5EMNh8OOP4pYePKbFNO1RhLuthEiihoT9Hrk+KKFfUVfasqxjlKgF62M?= =?us-ascii?Q?OmzG4WcO2xH1U+a1YJwiIBx3LpVI+j50tw2aBzEssfpgmq73y/uqGvxCHst1?= =?us-ascii?Q?cAPWBu151yuQc9tkqO4SiUnRUi2mymFQ+ug4y/JsNn/yWxlMEc8mZjfcOU/w?= =?us-ascii?Q?ZsN4OXREffxbIaxKrJP00tUiavOFZnJPEWTVIG86jLxmIjL6w4aUwehOrMtM?= =?us-ascii?Q?ielVjm61Rk31ERcMaLdlbS9GIM3OgA95ns1/zRJwOtYajNBfQlTWMd7/cv+L?= =?us-ascii?Q?a5QRVLNiXFIkJX0LGqp4yWW+EThj9Ejo6kAhVt+Ar/VaeK/vIZ1mbOchdIAO?= =?us-ascii?Q?+vPwKC14fD6k3lBqxmOxN5wf0ODqgvfIb5GTHQogJ+qhtWbfpr/IWq/gakrP?= =?us-ascii?Q?I98kawrUoo9mueu2o0WoZmVH9l1AOoLq7jyctkxY3sydXcr+si29COJ2icju?= =?us-ascii?Q?Bh69tbTVKtxPes0Zbp1VRPqY/k2iKlPdhYpW+eqQe/+1NzYaQVW3+ClUHgq/?= =?us-ascii?Q?GkEhPU/97MmjrBZpnhrirxi7LbAFaWFuJASTyrIHHQIjlZCSWvcgo01LENIa?= =?us-ascii?Q?VP98FYlcYeLFW/az05HjBh/r0xpgD4Bi++un4EN46ori+myge2htc2N9CWTO?= =?us-ascii?Q?BZrZ1vaPRgCuruUUcTy+uyXB+ZY0v4ViyHUEc5Khw7RenUOOsw+9l6N7WkGP?= =?us-ascii?Q?q8p9K9ArkFACmb+IRbXX9B/k415vF5hx7TBm61CsQYq+HyIVR98uYJIikS1k?= =?us-ascii?Q?VC9PM9YGw9KIeSQyQ0uvVvXHeGMuchn+9bWvUXZDVPYjJBLkjfB2KrH8fX+y?= =?us-ascii?Q?VmDSl/LfM3uZy9Nv6uoX7PuuQBn+n6oDPAQ71ccGbhb90rXQh0iHc1BCRVQd?= =?us-ascii?Q?cqChyymJbh82jLeoLs4poJaSe4jd89BK46MSMuxtR6lKcrI3N1MpTInc6jb+?= =?us-ascii?Q?psyAGBgT3iSZp+T4+X++cJLkDVwwrzYYE9ixN+KCA517ww=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6vz47ZBkhMWWrq9ROqVnFHg9j9nSLaQZ6KoJ0v4ssuOv7OHCycWM5lIYTxgZ?= =?us-ascii?Q?pVCRlcsxpiGA2wCHhQlN9OwLaL3h2RCGCMWtzvs5yk41MMdMImepsLrStn8M?= =?us-ascii?Q?COnyXvOQ3OdA6+yTpOK0nRRgBhyUq71pBTmwTzE9hcgPFHDtCeIKIk7JxkYR?= =?us-ascii?Q?8yuJLO1XHlrDbfgrBD9KtfP2DZyurXXBAac00T9RGeX3rUsMn3FdIwUovALu?= =?us-ascii?Q?9xWxgSmQqm0HBAy64KwEB+9+swy7eISXiYdCbuImmGFqmtneR5f60QmOQri0?= =?us-ascii?Q?TUmvCH8vePuohAt7QO4IO/vnIBDsv3f+MwXf6vwpmU1sYMxPLgQXEoSZ6ee8?= =?us-ascii?Q?M37P3V4BeC9rydUsA0sFpx1EumJHpXp+6OwOdoTzAgcxObf9M7ewkG/QpQTt?= =?us-ascii?Q?tZEPZcduxqMF7e+BjpZoK9D/npswVrPD+i2Y1JinTUrDtQdPQAxVdc5m5v/e?= =?us-ascii?Q?3jxuhzT20B0UjphYy7YotZvgHd5CgSHkUAl8agB68rzX1UTQFcAY/V8r5FzP?= =?us-ascii?Q?PaAQLqmdA00RYt+m0y8yISgW79qHq6CGw3zCSEHCRLo6hG+HpkJqvfQoXE0j?= =?us-ascii?Q?yQx4VRwKGKSRtfM6n+tscQcz5im6KCIahPJ0zKwn6JsZJl+mkDk4jZOi1LpW?= =?us-ascii?Q?ND51ms2EdsQg/AoQaPHQskoze7DFtNs1kwwiWmXxOSGvZ2uNm3BZ4yBoBJtO?= =?us-ascii?Q?wRpETTHMUYbsyJ3nPY/KoEXxXdORcZyyhF/tXAsBJMgrNzl7gUH+z/2sFsUe?= =?us-ascii?Q?KZBUSj2sWhvvJ3T/DdLYSrMgPeviTTRKd8lToCXOxAoecVN3fVZ753FfPhT9?= =?us-ascii?Q?I0RVgIHSo+oz5q2iwKvVdjC0VnuB3vSugffuyJRG9qHpXUrrtj5zfkvj00pv?= =?us-ascii?Q?Z4aclWm36w0WWSSYGBaCTT8FlJDFVC09uZusg+KvzO3Dv4LNNXjCIpZccSKS?= =?us-ascii?Q?OE4uaoP4Hts+KNxh7a/6uvn7FfEMz64yyehZ1aNo6nH0uEjOtwXnbyPlgPtZ?= =?us-ascii?Q?i7/Ntd+gHe4IN16slnJb8mgmJMH8D22NYiKATir2Oh2vQTxH+63qSxnd88qn?= =?us-ascii?Q?QNQgX+WaSCOKcPvTx4u/i78M2+hLiaB66Nh37fq7JNEbRbeODHw7sd0RPFnZ?= =?us-ascii?Q?cwsrkYepzvC9hVjtENuAvS+CoaegCUzMclFIZ/KGmezbZOXUPf+arYdrwDON?= =?us-ascii?Q?oViT+QT1YvysqNXr11lz/OU4AocxPOuv5EuG98I3FcA7fdlUZtK15AKXy9wS?= =?us-ascii?Q?TZMcqdytR1222Khh93uQFiG7B7VPgOuBBoTm7T/MxRvhPQAy+GLXF6d56LBJ?= =?us-ascii?Q?0Iv8B6MJaZYLYS4bYws+Aq5O6tlPrCYNiyQkZHW68bXh/usQZpgoBC+qxzxl?= =?us-ascii?Q?WEMhu/NMkQhsgl7jxWJ54q+1R2XUmzttGu+iCbtdgGmWudzOVB1jIWMFf1Gm?= =?us-ascii?Q?ZDUO+y2kNmTvW7e7aYPLvxgCyi0uhKJGMsMq5FJQDn9dzrsg79+Zqbqumiq6?= =?us-ascii?Q?B6VFgKZU5DCY2OX4NLYl5EW9bfKlvLreAV0HDiuqjk/NFm904t5cneilCIZ2?= =?us-ascii?Q?hWgI7Nsq51hxNa5807SQcFrbj/OXCq4ajSCyn528sgL6XRuw4LrsU1gEXVeH?= =?us-ascii?Q?HQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 27d31964-4061-42ad-7681-08dc96970904 X-MS-Exchange-CrossTenant-AuthSource: CY8PR11MB7290.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2024 10:51:02.1920 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UdxsL8kMFdJNNMly8OYRSACRYMgzf+3V+cHLbNhGybsCsclrRk5xiwn76nY7wDzMKBK8nfFR5PiX+5JmIZu/JkE+DeQ48iVB1Bbib3djPR8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5820 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Thu, Jun 27, 2024 at 10:11:44AM +0000, Mingjin Ye wrote: > ELF files generated by higher version compilers wrap multiple > symbols prefixed with "this_pmd_name". > > This patch fixes the issue by filtering invalid symbols. > > Bugzilla ID: 1466 > Fixes: 6c4bf8f42432 ("buildtools: add Python pmdinfogen") > Cc: stable@dpdk.org > > Signed-off-by: Mingjin Ye > --- > buildtools/pmdinfogen.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/buildtools/pmdinfogen.py b/buildtools/pmdinfogen.py > index 2a44f17bda..6ea97caec7 100755 > --- a/buildtools/pmdinfogen.py > +++ b/buildtools/pmdinfogen.py > @@ -200,7 +200,8 @@ def dump(self, file): > def load_drivers(image): > drivers = [] > for symbol in image.find_by_prefix("this_pmd_name"): > - drivers.append(Driver.load(image, symbol)) > + if len(symbol.string_value) != 0: > + drivers.append(Driver.load(image, symbol)) One small suggestion. Empty strings evaluate to boolean false, so the condition can just be simplified to: if symbol.string_value: drivers.append(....) /Bruce