From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB79E45848 for ; Thu, 22 Aug 2024 18:25:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC0DC42EE3; Thu, 22 Aug 2024 18:25:19 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mails.dpdk.org (Postfix) with ESMTP id D37EA42E52; Thu, 22 Aug 2024 18:25:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724343919; x=1755879919; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=k/udIlEsM3Hfee6Ggml5KHtNFf1k4O2wa+DUMKA9B1A=; b=HGLX7RXT72iEpmgsNd3dnIbpmgIBpuUjXZ4jCDTpqJgkF0QoNsbyTNQ6 +kPhNhhJULQVH0XaayoTByqBirx+i4fIJGXtehEjftXqP/JsuF2LhQGPJ Uy5CpmpHzeQ27XhNm94Cflk9Yq4F7oKCKAa+ym21Mjo6HY1lGGKnEeBRD eodwHNJxwtG0IJ5I5jKAJs24YlpTa6M622coOcoYPKge8odrFlTmkK90N G9u0RsSCVEu0fZ9pdYtrUJWcdiuZeY9MSOixqpoohWW8V4K81SuHyy3GC fVmm7gDwsssX/eD5Ih8uIQicNIpzAXGj62hQmSGB0ELtDq8WsjvdyfnJ1 w==; X-CSE-ConnectionGUID: 4oA27twSQMqvEjxy1kYtZg== X-CSE-MsgGUID: 2VVkMzXWRz+QjT0Tgs8bZw== X-IronPort-AV: E=McAfee;i="6700,10204,11172"; a="40239469" X-IronPort-AV: E=Sophos;i="6.10,167,1719903600"; d="scan'208";a="40239469" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2024 09:25:17 -0700 X-CSE-ConnectionGUID: bZULpxX5Qc2MA6xI0E8+oQ== X-CSE-MsgGUID: n9iWpk+BTKiWvSZ42rU/Rw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,167,1719903600"; d="scan'208";a="84683645" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Aug 2024 09:25:16 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 22 Aug 2024 09:25:16 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 22 Aug 2024 09:25:16 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.45) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 22 Aug 2024 09:25:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ol2a0hwbypodPfXNthk0qGAFlGJjTykxE7UeCgBwR9f6H7l5W3HH7qXyTrhYmbKjQI4HuBRvG9s2uKCaCrrZrv/Q98yF2fED1re/goMegVECdP925joCHfOu6xXw+Hd/1Lpft4m6Squ4kDpXi7bfqJh7d+EGslISH+kCet5+jFiHDPhHqrGQf1N3aFAfV5wIDoL3e0zMF6YrLneaPjTDmGCS28KPSoD4R2nl89Xacxr8TDtxNwqEYEJlRDBqXQcbWAMxIr7MAdREvRO9aXejzSwv+ko9f7wLNtffMKxD3g+h2pCS5PI0C1Wv7uV/gdxvbPYRy004hkbggcE/8s47pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+ez+9hRxaKub3Xtvm6vDqzIBCgBvsB2BMIW4ah+reFU=; b=dD7bDT1DtcSXBPHwaUdgwBy+yziVMGhGSUN2CSJTuA5blhBcIf/8xZ9zGvix9xKULgPR+iV6pNebeFOjOl0MYBV8DLdHRrRz7c4f8LdRw7ddrheqFlVPCWv/O/LdO1B9VXD2E0tpF9rlcHRVWjVZE3Naf3GsMo0+nW0MQ8flJIA3euOu93ML4z61a+nXELJPioOOMc7/rLXGggdWJHlFDSIbM5yv0YyDFjWCOExkyZIj47IUFSggZ0/uobb8dGwXFd3dOlPZGSntihri4IKlV7WvpBYHcHB2C29ypm9zylZY55UcB8yAVIs5UHNPyOlYHokYPxSkYJ7Whtauiozm9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH7PR11MB7605.namprd11.prod.outlook.com (2603:10b6:510:277::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.19; Thu, 22 Aug 2024 16:25:14 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%2]) with mapi id 15.20.7897.014; Thu, 22 Aug 2024 16:25:13 +0000 Date: Thu, 22 Aug 2024 17:25:09 +0100 From: Bruce Richardson To: Praveen Shetty CC: , Subject: Re: [PATCH v1] net/cpfl: fix invalid action types Message-ID: References: <20240730114540.1048785-1-praveen.shetty@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240730114540.1048785-1-praveen.shetty@intel.com> X-ClientProxiedBy: DB8PR04CA0004.eurprd04.prod.outlook.com (2603:10a6:10:110::14) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH7PR11MB7605:EE_ X-MS-Office365-Filtering-Correlation-Id: c1847cb7-880e-40ad-f402-08dcc2c7002b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?0c9owFnZEtVyLvbnSfvFhmCYb4NWv3MbDgGrh+ZXEn6Xh5EkV4YT3pXU3WfK?= =?us-ascii?Q?Gu/qMt84wXMbB+MIb0NYqUIu0FCKF4VDHjKLSovqBjVK4BWNa8IDlnPOYRDq?= =?us-ascii?Q?I/AJwF3ry58SXEX6kQds67SC9dT3j6MtsgZG4tFUZEaxODOqNATUUDyaAazT?= =?us-ascii?Q?AZ7DDp19N9iIaVqBIf9Nsz7d1NsVnmdSM//IxO+qvhdpMxv752flf7jSpfPh?= =?us-ascii?Q?8jot6AYRYWaXyCkbUGjMd+F/Ptuw3CFy7dxI24GWXksi6/ZGq4nqwIcGjgB3?= =?us-ascii?Q?cY5yLIUC5ZMruELHN3H7FVEzafXbqPgcV+yYAUF6f7b6KrNCfMnCLySIgw64?= =?us-ascii?Q?wvhD8FPs1Jph0sLyUSDLVj1OP6TUcanWqAFoEKCEdh5O0awsbZy23jaXV4OD?= =?us-ascii?Q?9gcPXHlY3P422L7SDE6M5bwjYbj8cbyf/1ni+5IwZc1iYsH3J+UrtolvdL5Z?= =?us-ascii?Q?UKJ8e9xcn2Gxj3b3PZEFf3S/JgKwpcTGUXVHqd3xWL2m7GrOE4c6gvDK/4UH?= =?us-ascii?Q?d8pSwEMCRuikz+nYVkaih4CbmMWPiLUMPVYxj6e7t5/nAO3dZ1i9+dvw1FOe?= =?us-ascii?Q?Q2ln1Mx+P2D7zuC149g6D4GECW7lMmLeFnmLCDt1zIGDCq1EAmV4tPSrmyxN?= =?us-ascii?Q?w+osMX3c4D98XwTf8PS/OnBC0+lw5sdxVUSXeW/059Rhs/t57UjDifKbdwt9?= =?us-ascii?Q?yYsk+xfdoYVw+SYDip13jBejbK2NgXeWBWPp/N1tthjGec5auDYxcGXZDMvN?= =?us-ascii?Q?wWjDUeGyrape7mErOQahdh3l1z+iN34n6AGOZQ1HMypUlUaaSakcXyVXcCsX?= =?us-ascii?Q?rJr0svdjoUrSnUFVGHes8XWEjxW4jPPOSGybXlHpJxfroYL4yrZmr99ZKfUG?= =?us-ascii?Q?eO7Oavz8xg5zuh5oarX6hDLHz0j79CaqS75Q61PWwkhQSDYeucIHdr+PqcnH?= =?us-ascii?Q?Beb5JbXJiq51kT0izOOic1gKjuSCZg7pRna1pTmZOp86OwmwQkrBMIG4EQhi?= =?us-ascii?Q?U8j/IKyLsd+J4XqdT6CfVCas/Pm0Y6aXS9sMI9/LgJJoKnS9QlZRA+JhB9kP?= =?us-ascii?Q?jB2AM5o4Ir8a1levj+TxXsD1asZSxpkWLENbGcsotN45f1BheTiezZCwwI3Q?= =?us-ascii?Q?hBDhwvN8ngKWPGTUeyj9xXVJJhOFUiFSYpH9fo3TTb4RsyRDKI+yUOQCAWnL?= =?us-ascii?Q?lSuysUffc2zGyBA+kbkU3wdL4mXSetvRbHzgJxYwkd/sFf6Nc6/loONFouXH?= =?us-ascii?Q?Sbon3J4yl2nkaJuVyGkq1p7enKmUx0e/o9qp23mlteSojscsDTCnElY6pXRh?= =?us-ascii?Q?z36QuWZ/yMsEYKh84K9Y/263VQDmST6b+fiptuJdr5cmJw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3OtIOrf7AL6kjmHYajvbeNWi4vdTZzXdWM6k3LyrmprSKk49lSxaFsFYR/qs?= =?us-ascii?Q?CDuK2hf9qbx6/dzpFcbKGpeOshSibb1TlFk9/FpACPdcJepnOiCnk+ip3MVU?= =?us-ascii?Q?AYNjJKT/jxaTVddKxlnDHljvK1olI9UZrT0M7ZksFpjrmTQi/2yrIzctkG1X?= =?us-ascii?Q?WT8MKJx2lHe0cMiumQeikFf1ebtafU8fCwQ5U03T9nJsSDJrkP+YoiRJI/V+?= =?us-ascii?Q?/23OSjG6KmXUNG6YvZ8R+CARur+aEO7wx+gK0GVIbONJcTU9hktzJjbQQMp8?= =?us-ascii?Q?G0Nwdz8fuAlKZj9tB5MR5sIRmS934jd6mR9nckfoRkqv2QMVqwuWHQlmw6Pc?= =?us-ascii?Q?Xjqy+wwprjykdLYi4L1vtVri74I1BYbgSk9l0JSwXVaGFEW11hPIVV+n+cXO?= =?us-ascii?Q?WlhguN9gO0Bznkkn8myXRX15kxNruOlTQCc1aT8umHLauEIrOHwFJo8CKlyX?= =?us-ascii?Q?ZFB7fU9TKzW4WRJ0LeWZzcY/I4QeUU3ASNIJTTv7t8G0WX/ZszuHs2HAxda4?= =?us-ascii?Q?S12euwW8MKNpWD7urSGwDIMWwseCtPrIvlOG8Tl5ko6pHbp1cIuksX8WrA7d?= =?us-ascii?Q?5nnw8JiG2yxncpf1CntXOCqtpyW8SrVVuo9CjjncrJ3nCHPFyw5XoEOKhmw4?= =?us-ascii?Q?n4iLHeTHKuUn4SEfCJD+hcX27VpDNNfaU9OJkdjhz1IuAKQj5phRmeqIu6q8?= =?us-ascii?Q?Hp+FYbMpFFmEL5LXHgDMAYgBNX0pQYrHwWJk8moi+8OR8R83f59Mk+uN3LWH?= =?us-ascii?Q?sQW7b5SoK3VSRaQJPRvD9N5dMqwA4LHpwmxkH3nYE8XbYtcm2C1bsXqiRlms?= =?us-ascii?Q?E8YjOtwJpk/PLA0y1FgRXpXfHZ2MGPprTHct/VMN88Z7HRS59rzbdvmsojFR?= =?us-ascii?Q?nRhC45qWAQj0N1fG0biMtip7/ncuFl5FHSSrEWoQJm/152tuErZDen5aMq22?= =?us-ascii?Q?i+1Eqafek2TMMEfo7jl1F03WUaVrca2mHRbACtZNZgkH2Y5XEUWDLyfWmQQK?= =?us-ascii?Q?DZ/HgTxCKjW+9+Lfhuui0FqbEaoZYlFAIWslnqxJw/16Li5cukzU4KXOZxpb?= =?us-ascii?Q?DVz0ZL9S23Ys+4mgdjU2JJQ6GLIHBwZMjGc7YyNpb3I1EenNiPsDom9UKVPP?= =?us-ascii?Q?qveQRWf01ahCwaaPqwLu6UtWP+uXhqWodUYCbQaw+DGPZ5P8TM3KyS7anyX/?= =?us-ascii?Q?s/U737MThThBAparTE5p4BMd+86zz3kAC+Cn7Ga+/dJos3Z7fxoYcUgi4epo?= =?us-ascii?Q?VxjOts/+6Zu7hdDaynrUrRFozvK6sItvihUDMTrbeRqeJAieaVY47knk+BpS?= =?us-ascii?Q?teibEv8uBms4jkRPKJqD1Ep4ruZoq/5mojjfTjhoObq7f7OnH8uEIJb98nhK?= =?us-ascii?Q?RdGVUhU3RtCSMdAa5/xJIvDycq1eYRqKWSggAl8berxVHuB30WE7w6LwGIFH?= =?us-ascii?Q?ipO/Unz96aFGGI3BuKI2qEjw/PjKp66mWHB4ePfjem8IhZ9wGWOoO1iDmpx7?= =?us-ascii?Q?P6gLxUzV3sH1oUcUdTE8G3Cr/XibRdnxVZ7ByOtpxvJEDfmHS44UzU7ldk4s?= =?us-ascii?Q?pfs6EjdrQml+QkpkYMkv0bVj/YIuT1bacKeD1C8TildG6rB49mmqZGZ0dmue?= =?us-ascii?Q?jA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: c1847cb7-880e-40ad-f402-08dcc2c7002b X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2024 16:25:13.8930 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LrM3l2ZZBbouw45Z6rsv8Z8dIdMMCD2luDvUwEvtotf3PZqsJqca2uxd86RNJxbqppRjphBOKbeWaQGHJW99A2OllzdJSJXfybuQeMYTFW8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7605 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Tue, Jul 30, 2024 at 11:45:40AM +0000, Praveen Shetty wrote: > In case of CPFL PMD, port_representor action is used for > the local vport and represented_port action is used for > the remote port(remote port in this case is either the idpf > pf or the vf port that is being represeted by the cpfl pmd). > Any mismatch in either of the cases PMD will throw > an error. > > Fixes: 441e777b85f1 ("net/cpfl: support represented port action") > Cc: stable@dpdk.org > > Signed-off-by: Praveen Shetty Acked-by: Bruce Richardson Applied to dpdk-next-net-intel with minor indent fixup. > --- > drivers/net/cpfl/cpfl_flow_engine_fxp.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/net/cpfl/cpfl_flow_engine_fxp.c b/drivers/net/cpfl/cpfl_flow_engine_fxp.c > index b9e825ef57..e760acd722 100644 > --- a/drivers/net/cpfl/cpfl_flow_engine_fxp.c > +++ b/drivers/net/cpfl/cpfl_flow_engine_fxp.c > @@ -292,6 +292,17 @@ cpfl_fxp_parse_action(struct cpfl_itf *itf, > > is_vsi = (action_type == RTE_FLOW_ACTION_TYPE_PORT_REPRESENTOR || > dst_itf->type == CPFL_ITF_TYPE_REPRESENTOR); > + /* Added checks to throw an error for the invalid action types. */ > + if (action_type == RTE_FLOW_ACTION_TYPE_PORT_REPRESENTOR && > + dst_itf->type == CPFL_ITF_TYPE_REPRESENTOR) { > + PMD_DRV_LOG(ERR, "Cannot use port_representor action for the represented_port"); > + goto err; > + } > + if (action_type == RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT && > + dst_itf->type == CPFL_ITF_TYPE_VPORT) { > + PMD_DRV_LOG(ERR, "Cannot use represented_port action for the local vport"); > + goto err; > + } > if (is_vsi) > dev_id = cpfl_get_vsi_id(dst_itf); > else > -- > 2.34.1 >