From: Bruce Richardson <bruce.richardson@intel.com>
To: Soumyadeep Hore <soumyadeep.hore@intel.com>
Cc: <aman.deep.singh@intel.com>, <dev@dpdk.org>,
<shaiq.wani@intel.com>, <stable@dpdk.org>
Subject: Re: [PATCH v4] net/ice: fix incorrect reading of PHY timestamp
Date: Fri, 25 Oct 2024 10:02:07 +0100 [thread overview]
Message-ID: <Zxtejz6ctLDq5wlH@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20241025075025.682290-1-soumyadeep.hore@intel.com>
On Fri, Oct 25, 2024 at 07:50:25AM +0000, Soumyadeep Hore wrote:
> In ICE PMD, previously the ready bitmap checking before reading
> PHY timestamp was not present. This caused incorrect Tx
> timestamping.
>
> The ready bitmap checking is enabled and PHY timestamp is read once
> the ready bitmap gives positive value.
>
> Fixes: 881169950d80 ("net/ice/base: implement initial PTP support for E830")
> Cc: stable@dpdk.org
>
> Signed-off-by: Soumyadeep Hore <soumyadeep.hore@intel.com>
> ---
> drivers/net/ice/ice_ethdev.c | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
Hi Soumyadeep,
see review I made on the previous version. Also, when sending new revisions
- especially if there hasn't been previous on-list review, please include
below the cutline a summary of what has changed from previous version.
Thanks,
/Bruce
next prev parent reply other threads:[~2024-10-25 9:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 13:00 [PATCH v1] " Soumyadeep Hore
2024-10-25 5:14 ` [PATCH v2] " Soumyadeep Hore
2024-10-25 7:32 ` [PATCH v3] " Soumyadeep Hore
2024-10-25 8:55 ` Bruce Richardson
2024-10-25 7:50 ` [PATCH v4] " Soumyadeep Hore
2024-10-25 9:02 ` Bruce Richardson [this message]
2024-11-04 10:31 [PATCH v3] " Soumyadeep Hore
2024-11-05 10:14 ` [PATCH v4] " Soumyadeep Hore
2024-11-05 11:33 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zxtejz6ctLDq5wlH@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=shaiq.wani@intel.com \
--cc=soumyadeep.hore@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).