From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7967945C0C for ; Tue, 29 Oct 2024 18:10:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6FD4E42EFC; Tue, 29 Oct 2024 18:10:07 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by mails.dpdk.org (Postfix) with ESMTP id 11C2842EDE; Tue, 29 Oct 2024 18:10:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1730221804; x=1761757804; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=9xkvCfhy0hpnV6kRY9O1k81adI0knEaGHitANQSyFHk=; b=e/rZ0HELVF11WcIl+vg16wLLe9tcA6xL73dSepva7Yu0I0K8HpALxO3b L0V/9zTvoX2NEhYuagnvOllH49+S/15pxRwfWS2T5U5OYLbm0dayZJTBn IrrHBF2yzWbAt9aMcFFnWlRsjJbEO+zHNO90ZOmW1iP5D6UIaSi/OklUs BKvruPxkjobK+tRcTQt38+y5WfRNxC4wlZEuloM0WHvcV0BrYIB01Cc+Y 0u0BMZ7gfo+mRe+49s7LWcYy5+nPHSHGYJAnvkZt4sNOu3aaWtsoYpM61 UGR7lBnwT1SddgxNxI+FMy/en2usi1q/dZe8a8O3W6gKA/yOJplgtCkkK Q==; X-CSE-ConnectionGUID: vYRc0PYhQ5W6DQ7+MAURJA== X-CSE-MsgGUID: RSiG4t1MTTOw7NyBXjJ00g== X-IronPort-AV: E=McAfee;i="6700,10204,11240"; a="40495135" X-IronPort-AV: E=Sophos;i="6.11,241,1725346800"; d="scan'208";a="40495135" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2024 10:10:03 -0700 X-CSE-ConnectionGUID: X8nqbsyPQFm/pgZXe3uzwg== X-CSE-MsgGUID: 4QDcrnwFSem3eI4u8HtMsw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,241,1725346800"; d="scan'208";a="86638658" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 29 Oct 2024 10:10:03 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 29 Oct 2024 10:10:02 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 29 Oct 2024 10:10:02 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.47) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 29 Oct 2024 10:10:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=o0yo1c2ZR3G/CzejmOBpO3c9DJ8/GagvmYUj33+HiHnRPBdZaxxOh3oqaFJwN50Rm30gx04CR/nbjph51U45in+5fMcwHksI+8Q4qLiaH2EGp4UWQFtlUbtRBE59J9B3cjladMG8Y5iSClkIDwOdsuFq5s9x8E+l9ifGvioFKTPCCtvF4EUb8iHbgfCFjY4Mpy2D3iRY96eSD4hOIi8LlEMc3ioUoZoVfjPh137iNV6es0wKDw01nY7/2AKS2azpniV0vKhHcbA9U9AgBPfLQ3LC1hNI37ocqsX+z2a136a+CY4orugmquuVXhx3Ty2bvRkdWAuaGfciX6jFca++KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8zB471bTc4finkJhiIE50BfycKcupNxKdaj0psNcSvc=; b=if0oRHgpUU6PnIzRE8z9EapK+U0p7RVQQnYcbfwrd1qP0LHS4jvjVEtQ+4oxIxJlWt9L5vliQz77DpKG2V/hLKx3cxmniSWOtMQXsAKRPwnrg2mNCNhGb3aXnbzuQld7WXrQet1fgIB9cjkQj7kAWoQSN8+NdVHWj4IlsMcf+5uYD6V1Of2/J+NS8VsHP55t7m/hkIcoeFPw1mhU3CHeNNs9lZ/3hgiLWgA/HFf5PxBEL/M59Q6vitH9jVAkY/t2tZIczSljsIfijqRlpuB0b1i9AdPB5ax+Oqkr/4tP5Nw4MKDtr+gzwuMkeWhi+hlHMl12Jdfit8PTCBFFzs0ZMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MW4PR11MB7149.namprd11.prod.outlook.com (2603:10b6:303:221::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.25; Tue, 29 Oct 2024 17:09:59 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Tue, 29 Oct 2024 17:09:59 +0000 Date: Tue, 29 Oct 2024 17:09:53 +0000 From: Bruce Richardson To: "Singh, Aman Deep" CC: Soumyadeep Hore , , , Subject: Re: [PATCH v1] net/ice: fix incorrect reading of PHY timestamp Message-ID: References: <20241025102625.801994-1-soumyadeep.hore@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DUZP191CA0006.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:4f9::16) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MW4PR11MB7149:EE_ X-MS-Office365-Filtering-Correlation-Id: 16f619a4-1201-4e6c-35d2-08dcf83c8482 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?nuDP88WjBz6xomhVQLf5i3aD1PyFE4em2JLLOoi86+Re/1AYZD8a0l3gV5T+?= =?us-ascii?Q?+mQBKeSYAg2/j9wkTCoTXo1pvWUpI9FeQzoo7ltX4Do0AORrayIu91TJuXRy?= =?us-ascii?Q?7zUMcFztKm3l7sDrcxIAZuXboqZ0qf5fkPf0fdjb3UupzDEspiFC9VellhDy?= =?us-ascii?Q?ZFeIbBvHGpWxAoLck5N20hPGjX01D3w6rhngKmVuqxy3dOSDKMTsBfvGP5mH?= =?us-ascii?Q?Zl8eAv658ApjuZjFrxqj5O2y2qm4yIh7ebJ++vd0RTvmWKVWKC2bQ/+lriHE?= =?us-ascii?Q?Y+2/vVMhPsu1F2auA5cZrB/vyJVFSwbKycf4jQHiIbDR47kOcKXhg3t6mkYx?= =?us-ascii?Q?fOpDtZN6juPopTYyqzVWzbeg0eKlb78JI8x6O/eMwQ7kOwVj9rxOqPpht+R5?= =?us-ascii?Q?raiGnHfhN1ROUZeVW7Q8TC4YzjPi6+8eco/nHknGpQZhVg2+XW4iFV0ssI3w?= =?us-ascii?Q?4nGasX1c/NJ2MDV7RVzmPDSninqS3c1cW7hN3oGRR9LVxVprYk0bBalyoila?= =?us-ascii?Q?Fn+dSZUkml+9WiwDgTeLus14LvFI/BU2EXYyDg/CdKLBwTqv1sd7jknFTAHe?= =?us-ascii?Q?2yvNDZd/4/VshL8cyUA0+78MRHOAJmDkjdt4ieqN2W3WLHhm/9+bsCPC43Mt?= =?us-ascii?Q?EY5HrPEUImxn4xis7E5n/SD2Gxu7LjJ8h8cPXyqelhFMe6fjYEgiz+QeQA76?= =?us-ascii?Q?S4xVq7jw7qR3E1ExXuJM/IlZF+rZeSTqsXnzfA7QlKtkQZWniXZ+WDB8UiUx?= =?us-ascii?Q?Mj5bobIGMJ6+C8feN9nrwGF4VQd9cwx6Zr5ugbKFmXgNa63ZG1tw7J7YG89E?= =?us-ascii?Q?ZW7FdTAXyjQIunBoYMfueOTT1l/PrEjzqbnjY1cNy3aJYMWg9QUelH5d/k4r?= =?us-ascii?Q?kulz5LNsCPjrvJUkmhlqc7dUg5FXt4bAHhIKeO33C623ofbtCp7I3NU2qCjZ?= =?us-ascii?Q?ESACSGYkrOrIGlGWgG1Gr2hqAVaAbojZFllE7Hwy4etr+P9AsIzVWmdm3TUR?= =?us-ascii?Q?NSNU2EcmivAqxU4xD8JWdTy2CHLclQRWAjK80X+O1R90J+uO8MzjRBh9dyMI?= =?us-ascii?Q?QEOgHfatvaQWBYqjrbYSVuVL3ghPxG+d32jIBt3BvcjLqXGuN8JZSfl+C57c?= =?us-ascii?Q?F5G8szOt/9ugHAhjEm5itTFkJk73ofymyYLgJywMYxG0mh9SMAoVEPgqMFIn?= =?us-ascii?Q?WmNST/uthgXhUnaH4YsT6TizgR8rglLiTVrYYtpKsdWidCASpP52qvjfRJN7?= =?us-ascii?Q?sufZV23m9lhAp8qQTMv9?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yjaM6TzmilCOhpgKD9Bc1fJ7FcNTLocc95r/JiMQxRUlCmMOzL/RLbmB106J?= =?us-ascii?Q?zwRwyUDW7lR8U0PnluiviHy89GAbfB3VEXQe1/FAJ4LWJP4F7kvofk6xrksb?= =?us-ascii?Q?+N1fbk/iLbJ7IXffMTteDalXHv2cgWboGJsA/pSDYy8r274I3EGPMROm5K+Q?= =?us-ascii?Q?z3LdpdRWcjIGf57wqVrnC6prZofxXqasmdNKy0OBHA8rjtjmb88morwvlXej?= =?us-ascii?Q?oWOHR17fk5LO0TiCfIt+EAmKJfFtjJqeRwDMXRqYDIBnM1FdFNx4LPTT2ElA?= =?us-ascii?Q?GGfNlIErcoprFJnvxIp66XivbbgCKVdWMUY9sJSEhw0UuPaY1vg3Xw7EFwA/?= =?us-ascii?Q?eZX2jBqgx0h351nTspZmFaucbFdeFWPlCmlrLoE1rWUo6AYEz6kSc0z+sc77?= =?us-ascii?Q?7cIuiFE56sm3+FP7OsWwBKQjNt4nxmXg5JOhgw1FZYulDlsp3XJqzO6lnwYr?= =?us-ascii?Q?5V3vNXHjsNlvl6fyLxST6ptj6VSkTZlJx819XAtZP0Urx0otGADKUGwp78Id?= =?us-ascii?Q?QErwPoT6NTPaGz8arqp9IJLAEQiMFucTjDyU8QrN0/1KB93tw7swzCYLCa5h?= =?us-ascii?Q?1RUj7mJromc3D7ZGhAOhwwnooS8KXv28v5TpEImoWTVsf/1DLMHPsoEf45Ee?= =?us-ascii?Q?t0HwXUX4UiuDWxjGE0x3Jy6gTye3rgh5p337YHi19krUPpgTveG2YSkfD3bF?= =?us-ascii?Q?pAvfTI+Iz/N0njHHuWDgFgjgkYOLZzLUlB2Bl81OKtt8Tnr7iNqOTPP8Krj6?= =?us-ascii?Q?StIHC4lX2m9NOFTGMTACE8pzTyusulSAl60FBZ78ZthHRiCOSAccftjjx1Z2?= =?us-ascii?Q?i1ckaEkiMHGGIiDhX4xgn425n+wOc6glbo86dJJj6zR4zpnkPS66RrLzZmiI?= =?us-ascii?Q?+urI+T1/61tL41hBZM3qa/y2aAjz7q+SvaLt44GkAmesYclzUj0KOxWFYCcw?= =?us-ascii?Q?ew+pxeJYeAupIoA1OfifwaS/pLEA5RIoq5rtUi5tPSaTYxHr4O21YszOpahm?= =?us-ascii?Q?t10lpRbFJDBWb4K24DIFef5zBUHiiWCdyfqKpAr/i6F1sPV6E5vA6SJwSkoi?= =?us-ascii?Q?GBpfszRaJPqiBbXkbtx8JN6YfoU4KxCbwtCho9S2dHzSYncyrpSx6efjpn16?= =?us-ascii?Q?Y+X/xfZeB8SzU6gHRnWnaby9eCCwfpVvOdO7Ry8/tmRz2tIE6nUZ33ikTkAo?= =?us-ascii?Q?XHWlQkswX7H39zSwfl4IOPqnBin6NC6mbiA8VijKyz4iclL9eUMTsoB/cS12?= =?us-ascii?Q?lMqZ5IIkJ2UHYA0p0WUvwItV0J7fZa3yXnq0YKJvbK4PjE4U4Hg23KGCeGSq?= =?us-ascii?Q?rBgURVNLjgjtgn+D3dkj0MgBrk2nByUtCaFg1CpvxQCXFXZ3S5+W7AQg5bKm?= =?us-ascii?Q?ZesBQw8TYKdwplS65QIgG9tv94FmJG5qEDx8qPUzH46+jq2XdtPPPq3b5egK?= =?us-ascii?Q?pjny36fSbJFQ3cKlSBB3C18tLOumy72soF9f/tFBVdsgS855BEghC7Yin8p4?= =?us-ascii?Q?fJudNgo0ce4LpXRdATjRu7y2wPwHpn2lKcDz9gjQDTdW8iFfXl0O8XeC+DQ7?= =?us-ascii?Q?b7volwHwldbFrl70vdlpgHF1qXw7wSAnJZ6FzI4xf2GQtKhKXk3XOpdLDxLJ?= =?us-ascii?Q?jQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 16f619a4-1201-4e6c-35d2-08dcf83c8482 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2024 17:09:59.0107 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wJMZUQbWeQPxIYewTY47W1H7Mq48nmaEXll7sbUiyWsqCd9j+qHwByD6idee8yonXB8jkju1OvyXm8FY1LucImW4N2xylQccmC6pBFDmZH8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB7149 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Tue, Oct 29, 2024 at 04:07:45PM +0530, Singh, Aman Deep wrote: > On 25-10-2024 15:56, Soumyadeep Hore wrote: > > In ICE PMD, previously the ready bitmap checking before reading > PHY timestamp was not present. This caused incorrect Tx > timestamping. > > The ready bitmap checking is enabled and PHY timestamp is read once > the ready bitmap gives positive value. > > Fixes: 881169950d80 ("net/ice/base: implement initial PTP support for E830") > Cc: [1]stable@dpdk.org > > Signed-off-by: Soumyadeep Hore [2] > > Acked-by: Aman Singh [3] > Is this a v5 of this patch, or a resubmission of v1? There are 3 different v1's of this patch, plus a v2, v3 and v4 listed in patchwork, see [1]. I had feedback on v3 of this patch, which I believe is still relevant to this version. Please keep all revisions of a patch in the one thread and with increasing version number, saves us reviewers getting confused! :-) Also, with each new version, please include a summary below the cutline of what has changed from previous, so we know what to look out for when reviewing. /Bruce [1] https://patches.dpdk.org/project/dpdk/list/?series=&submitter=&state=*&q=fix+incorrect+reading+of+PHY&archive=&delegate=