patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Ali Alnubani <alialnu@nvidia.com>, "stable@dpdk.org" <stable@dpdk.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Abhishek Marathe <Abhishek.Marathe@microsoft.com>,
	Hemant Agrawal <hemant.agrawal@nxp.com>,
	Ian Stokes <ian.stokes@intel.com>,
	Jerin Jacob <jerinj@marvell.com>,
	John McNamara <john.mcnamara@intel.com>,
	Ju-Hyoung Lee <juhlee@microsoft.com>,
	Luca Boccassi <bluca@debian.org>, Pei Zhang <pezhang@redhat.com>,
	Raslan Darawsheh <rasland@nvidia.com>,
	"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
	"yanghliu@redhat.com" <yanghliu@redhat.com>
Subject: Re: 21.11.8 patches review and test
Date: Wed, 11 Sep 2024 13:19:45 +0100	[thread overview]
Message-ID: <a24e24b5-6988-4f9c-9617-f495206f26a1@redhat.com> (raw)
In-Reply-To: <PH7PR12MB917306EB7BFF8DC83FCFF3FEDA9A2@PH7PR12MB9173.namprd12.prod.outlook.com>

On 10/09/2024 20:12, Ali Alnubani wrote:
>> -----Original Message-----
>> From: Kevin Traynor <ktraynor@redhat.com>
>> Sent: Friday, September 6, 2024 12:53 PM
>> To: Ali Alnubani <alialnu@nvidia.com>; stable@dpdk.org
>> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
>> David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal
>> <hemant.agrawal@nxp.com>; Ian Stokes <ian.stokes@intel.com>; Jerin Jacob
>> <jerinj@marvell.com>; John McNamara <john.mcnamara@intel.com>; Ju-
>> Hyoung Lee <juhlee@microsoft.com>; Luca Boccassi <bluca@debian.org>; Pei
>> Zhang <pezhang@redhat.com>; Raslan Darawsheh <rasland@nvidia.com>; NBU-
>> Contact-Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>;
>> yanghliu@redhat.com
>> Subject: Re: 21.11.8 patches review and test
>>
>> On 05/09/2024 15:02, Kevin Traynor wrote:
>>> On 05/09/2024 14:29, Ali Alnubani wrote:
>>>>> -----Original Message-----
>>>>> From: Kevin Traynor <ktraynor@redhat.com>
>>>>> Sent: Thursday, September 5, 2024 3:38 PM
>>>>> To: stable@dpdk.org
>>>>> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
>> Ali
>>>>> Alnubani <alialnu@nvidia.com>; David Christensen
>> <drc@linux.vnet.ibm.com>;
>>>>> Hemant Agrawal <hemant.agrawal@nxp.com>; Ian Stokes
>>>>> <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; John McNamara
>>>>> <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>;
>> Kevin
>>>>> Traynor <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei
>> Zhang
>>>>> <pezhang@redhat.com>; Raslan Darawsheh <rasland@nvidia.com>; NBU-
>>>>> Contact-Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>;
>>>>> yanghliu@redhat.com
>>>>> Subject: 21.11.8 patches review and test
>>>>>
>>>>> Hi all,
>>>>>
>>>>> Here is a list of patches targeted for stable release 21.11.8.
>>>>>
>>>>> The planned date for the final release is 18th September.
>>>>>
>>>>> Please help with testing and validation of your use cases and report
>>>>> any issues/results with reply-all to this mail. For the final release
>>>>> the fixes and reported validations will be added to the release notes.
>>>>>
>>>>> A release candidate tarball can be found at:
>>>>>
>>>>>     https://dpdk.org/browse/dpdk-stable/tag/?id=v21.11.8-rc1
>>>>>
>>>>> These patches are located at branch 21.11 of dpdk-stable repo:
>>>>>     https://dpdk.org/browse/dpdk-stable/
>>>>>
>>>>> Thanks.
>>>>>
>>>>> Kevin
>>>>>
>>>>> ---
>>>>
>>>> Hi Kevin,
>>>>
>>>> I see this build failure in Debian 12 and Fedora 40:
>>>>
>>>> $ meson --werror --buildtype=debugoptimized build && ninja -C build
>>>> [..]
>>>> drivers/net/softnic/rte_eth_softnic_meter.c:916:25: error: 's' may be used
>> uninitialized [-Werror=maybe-uninitialized]
>>>>
>>>> Will update with the rest of our functional testing later during the next couple
>> of weeks.
>>>>
>>>> Regards,
>>>> Ali
>>>
>>> ok, thanks. I will check it out.
>> Hi Ali,
>>
>> It looks like a false positive, as the stats [0] are initialised in
>> mtr_stats_convert() before they are used. The code is unchanged since
>> the last release so probably it's compiler/distro change for this release.
>>
>> I've built with this meson command using latest gcc and clang on a F40
>> and not seeing this issue [1].
>>
>> Are you using same compiler versions ? Any other details needed to
>> reproduce ?
>>
>> thanks,
>> Kevin.
>>
>> [0]
>> https://git.dpdk.org/dpdk-
>> stable/tree/drivers/net/softnic/rte_eth_softnic_meter.c?h=21.11#n906
>>
>> [1]
>> $ clang --version
>> clang version 18.1.6 (Fedora 18.1.6-3.fc40)
>> $ gcc --version
>> gcc (GCC) 14.2.1 20240801 (Red Hat 14.2.1-1)
>>
>> commit 680818068d31764357075cde440232ce5ab8b786 (HEAD -> 21.11, tag:
>> v21.11.8-rc1, origin/21.11)
>> Author: Kevin Traynor <ktraynor@redhat.com>
>> Date:   Thu Sep 5 10:34:16 2024 +0100
>>
>>     version: 21.11.8-rc1
>>
>> e.g.
>> $ meson --werror --buildtype=debugoptimized build-gcc
>> ...
>> $ ninja -C build-gcc
>> ninja: Entering directory `build-gcc'
>> [3071/3071] Linking target app/test/dpdk-test
>>
>>
>>
>>> Kevin.
> 
> Hi Kevin, apologies for the late response,
> 
> The build failure doesn't reproduce for me on some environments either.
> I tried to compare the log of 2 builds (one that reproduced, and one that didn't), and the only difference I saw was related to AVX512 support.
> 
> Build passed on an AMD EPYC 7713 system (3rd Gen EPYC, no AVX512 support):
> [..]
> Fetching value of define "__AVX512BW__" : (undefined)
> Fetching value of define "__AVX512CD__" : (undefined)
> Fetching value of define "__AVX512DQ__" : (undefined)
> Fetching value of define "__AVX512F__" : (undefined)
> Fetching value of define "__AVX512VL__" : (undefined)
> [..]
> 
> Build failed on an AMD EPYC 9654P system (4th Gen EPYC, has AVX512 support):
> [..]
> Fetching value of define "__AVX512BW__" : 1
> Fetching value of define "__AVX512CD__" : 1
> Fetching value of define "__AVX512DQ__" : 1
> Fetching value of define "__AVX512F__" : 1
> Fetching value of define "__AVX512VL__" : 1
> [..]
> 
> The build failure doesn't reproduce for me on 22.11 and newer versions.
> 

Yes, that function is not present in later versions. I don't have easy
access to an AVX512 enabled system but it should be a simple fix.

Would you be able to try with the below ?

--- a/drivers/net/softnic/rte_eth_softnic_meter.c
+++ b/drivers/net/softnic/rte_eth_softnic_meter.c
@@ -904,5 +904,5 @@ pmd_mtr_stats_read(struct rte_eth_dev *dev,
        /* Stats format conversion. */
        if (stats || stats_mask) {
-               struct rte_mtr_stats s;
+               struct rte_mtr_stats s = {0};
                uint64_t s_mask = 0;




> Regards,
> Ali


  reply	other threads:[~2024-09-11 12:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-05 12:38 Kevin Traynor
2024-09-05 13:29 ` Ali Alnubani
2024-09-05 14:02   ` Kevin Traynor
2024-09-06  9:53     ` Kevin Traynor
2024-09-10 19:12       ` Ali Alnubani
2024-09-11 12:19         ` Kevin Traynor [this message]
2024-09-11 13:10           ` Ali Alnubani
2024-09-17 16:13             ` Kevin Traynor
2024-09-17 16:21               ` Ali Alnubani
2024-09-17 16:43                 ` Kevin Traynor
2024-09-13  8:46 ` Yanghang Liu
2024-09-13 10:03 ` Xu, HailinX
2024-09-18  7:50 ` Ali Alnubani
2024-09-18 10:33   ` Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a24e24b5-6988-4f9c-9617-f495206f26a1@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=Abhishek.Marathe@microsoft.com \
    --cc=alialnu@nvidia.com \
    --cc=bluca@debian.org \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=ian.stokes@intel.com \
    --cc=jerinj@marvell.com \
    --cc=john.mcnamara@intel.com \
    --cc=juhlee@microsoft.com \
    --cc=pezhang@redhat.com \
    --cc=rasland@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    --cc=yanghliu@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).