From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C405CA0547 for ; Tue, 9 Feb 2021 11:43:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 93B1F40147; Tue, 9 Feb 2021 11:43:00 +0100 (CET) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mails.dpdk.org (Postfix) with ESMTP id 8AE5840147 for ; Tue, 9 Feb 2021 11:42:59 +0100 (CET) Received: by mail-wr1-f50.google.com with SMTP id z6so20946231wrq.10 for ; Tue, 09 Feb 2021 02:42:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=/kxkP/MJlzbqiWpDXWSRxgIrhcFyfMRZSwMNIdR1KQE=; b=a1gVswFno+azcnsXPmPaU9n55qoDP8EwGCDlnZvxG0DYVAHk74iB1FrdLu2R3YIdfw QbdZOn9DQ8FRFOSwidPrkMB8G/Oe4PPs8O+wAOgB7zoq9MOj61U3JVWJH8u6OzWBcz8o 9PH1NiBsFgB/az8uh/+ER123C16oVU31iEbm0KdHkuPaEumfzPzzhv3kASTY1lVuqK6z G3VGigdcVKyUppRKBytPVO+wz0PGYjvQOuJEYwL0DH0ZXHfmic5yhr6cEVRsN1GytIOW JOQlMt1cvZCzn9joXfr69taM48rV9PU6Iwm6x1pmV84vR6Solk+RgWRm8ho5hNvtd6bJ hwyA== X-Gm-Message-State: AOAM532RcTcQT4t3x90UUlViTIvhgUF6gQdwwQIR4IBv/q1kaeVfLsx6 opsKbUHiiNAl8+2cqevN+Fk= X-Google-Smtp-Source: ABdhPJxCcPm9l1V43MCMc5uFw659LKOJr5MaMKF2w+ZCGDmHTzeBYAfVQWMB9b2JI3cp1gl7n4CyVQ== X-Received: by 2002:adf:e490:: with SMTP id i16mr12245621wrm.87.1612867379214; Tue, 09 Feb 2021 02:42:59 -0800 (PST) Received: from localhost ([2a01:4b00:f419:6f00:7a8e:ed70:5c52:ea3]) by smtp.gmail.com with ESMTPSA id c11sm33968794wrs.28.2021.02.09.02.42.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Feb 2021 02:42:58 -0800 (PST) Message-ID: From: Luca Boccassi To: Alexander Kozyrev Cc: Viacheslav Ovsiienko , dpdk stable Date: Tue, 09 Feb 2021 10:42:58 +0000 In-Reply-To: <20210209103529.466775-8-luca.boccassi@gmail.com> References: <20210205111920.1272063-1-luca.boccassi@gmail.com> <20210209103529.466775-1-luca.boccassi@gmail.com> <20210209103529.466775-8-luca.boccassi@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.2 MIME-Version: 1.0 Subject: Re: [dpdk-stable] patch 'net/mlx5: check FW miniCQE format capabilities' has been queued to stable release 20.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Tue, 2021-02-09 at 10:35 +0000, luca.boccassi@gmail.com wrote: > Hi, >=20 > FYI, your patch has been queued to stable release 20.11.1 >=20 > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. > It will be pushed if I get no objections before 02/11/21. So please > shout if anyone has objections. >=20 > Also note that after the patch there's a diff of the upstream commit vs t= he > patch applied to the branch. This will indicate if there was any rebasing > needed to apply to the stable branch. If there were code changes for reba= sing > (ie: not only metadata diffs), please double check that the rebase was > correctly done. >=20 > Queued patches are on a temporary branch at: > https://github.com/bluca/dpdk-stable >=20 > This queued commit can be viewed at: > https://github.com/bluca/dpdk-stable/commit/de75752e7e707382086c7d0e88b49= 46b6e9ca7bf >=20 > Thanks. >=20 > Luca Boccassi >=20 > --- > From de75752e7e707382086c7d0e88b4946b6e9ca7bf Mon Sep 17 00:00:00 2001 > From: Alexander Kozyrev > Date: Tue, 2 Feb 2021 02:07:37 +0000 > Subject: [PATCH] net/mlx5: check FW miniCQE format capabilities >=20 > [ upstream commit 3d3f4e6d1aaaec77016a8b406371f1b491ae9044 ] >=20 > miniCQE formats for Flow Tag and L3/L4 Header compression are only > supported by Mellanox FW starting version 16.29.392. There is no > point to allow user to enable these formats if FW cannot provide them. > Check FW capabilities and deny user requests if the selected miniCQE > format is not supported by an underlying NIC. >=20 > Fixes: 54c2d46b160f ("net/mlx5: support flow tag and packet header miniCQ= Es") >=20 > Signed-off-by: Alexander Kozyrev > Acked-by: Viacheslav Ovsiienko > --- > drivers/common/mlx5/mlx5_devx_cmds.c | 5 +++++ > drivers/common/mlx5/mlx5_devx_cmds.h | 3 +++ > drivers/common/mlx5/mlx5_prm.h | 5 ++++- > drivers/net/mlx5/linux/mlx5_os.c | 32 ++++++++++++++++++---------- > 4 files changed, 33 insertions(+), 12 deletions(-) >=20 > diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/m= lx5_devx_cmds.c > index a0277b7cc0..eafee65f22 100644 > --- a/drivers/common/mlx5/mlx5_devx_cmds.c > +++ b/drivers/common/mlx5/mlx5_devx_cmds.c > @@ -720,6 +720,11 @@ mlx5_devx_cmd_query_hca_attr(void *ctx, > attr->flow_hit_aso =3D !!(MLX5_GET64(cmd_hca_cap, hcattr, > general_obj_types) & > MLX5_GENERAL_OBJ_TYPES_CAP_FLOW_HIT_ASO); > + attr->cqe_compression =3D MLX5_GET(cmd_hca_cap, hcattr, cqe_compression= ); > + attr->mini_cqe_resp_flow_tag =3D MLX5_GET(cmd_hca_cap, hcattr, > + mini_cqe_resp_flow_tag); > + attr->mini_cqe_resp_l3_l4_tag =3D MLX5_GET(cmd_hca_cap, hcattr, > + mini_cqe_resp_l3_l4_tag); > if (attr->qos.sup) { > MLX5_SET(query_hca_cap_in, in, op_mod, > MLX5_GET_HCA_CAP_OP_MOD_QOS_CAP | > diff --git a/drivers/common/mlx5/mlx5_devx_cmds.h b/drivers/common/mlx5/m= lx5_devx_cmds.h > index bddeabf0ea..78202eba9d 100644 > --- a/drivers/common/mlx5/mlx5_devx_cmds.h > +++ b/drivers/common/mlx5/mlx5_devx_cmds.h > @@ -115,6 +115,9 @@ struct mlx5_hca_attr { > uint32_t regex:1; > uint32_t regexp_num_of_engines; > uint32_t log_max_ft_sampler_num:8; > + uint32_t cqe_compression:1; > + uint32_t mini_cqe_resp_flow_tag:1; > + uint32_t mini_cqe_resp_l3_l4_tag:1; > struct mlx5_hca_qos_attr qos; > struct mlx5_hca_vdpa_attr vdpa; > }; > diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_pr= m.h > index 6f5e5dc5f6..00b425ac85 100644 > --- a/drivers/common/mlx5/mlx5_prm.h > +++ b/drivers/common/mlx5/mlx5_prm.h > @@ -1364,7 +1364,10 @@ struct mlx5_ifc_cmd_hca_cap_bits { > u8 num_of_uars_per_page[0x20]; > u8 flex_parser_protocols[0x20]; > u8 reserved_at_560[0x20]; > - u8 reserved_at_580[0x3c]; > + u8 reserved_at_580[0x39]; > + u8 mini_cqe_resp_l3_l4_tag[0x1]; > + u8 mini_cqe_resp_flow_tag[0x1]; > + u8 enhanced_cqe_compression[0x1]; > u8 mini_cqe_resp_stride_index[0x1]; > u8 cqe_128_always[0x1]; > u8 cqe_compression_128[0x1]; Please triple-check this one, as I counted manually to adjust the padding. --=20 Kind regards, Luca Boccassi