From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 70F9B1B440; Thu, 29 Nov 2018 15:21:56 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Nov 2018 06:21:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,294,1539673200"; d="scan'208";a="290003296" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by fmsmga006.fm.intel.com with ESMTP; 29 Nov 2018 06:21:54 -0800 Received: from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com [10.237.217.45]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id wATELslp023239; Thu, 29 Nov 2018 14:21:54 GMT Received: from sivswdev01.ir.intel.com (localhost [127.0.0.1]) by sivswdev01.ir.intel.com with ESMTP id wATELsY6012592; Thu, 29 Nov 2018 14:21:54 GMT Received: (from aburakov@localhost) by sivswdev01.ir.intel.com with LOCAL id wATELsQE012588; Thu, 29 Nov 2018 14:21:54 GMT From: Anatoly Burakov To: dev@dpdk.org Cc: stable@dpdk.org Date: Thu, 29 Nov 2018 14:21:54 +0000 Message-Id: X-Mailer: git-send-email 1.7.0.7 Subject: [dpdk-stable] [PATCH] malloc: fix duplicate mem event notification X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 14:21:57 -0000 We already trigger a mem event notification inside the walk function, no need to do it twice. Fixes: f32c7c9de961 ("malloc: enable event callbacks for external memory") Cc: stable@dpdk.org Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/rte_malloc.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/lib/librte_eal/common/rte_malloc.c b/lib/librte_eal/common/rte_malloc.c index 0da5ad5e8..750a83c2c 100644 --- a/lib/librte_eal/common/rte_malloc.c +++ b/lib/librte_eal/common/rte_malloc.c @@ -518,10 +518,6 @@ sync_memory(const char *heap_name, void *va_addr, size_t len, bool attach) rte_errno = -wa.result; ret = -1; } else { - /* notify all subscribers that a new memory area was added */ - if (attach) - eal_memalloc_mem_event_notify(RTE_MEM_EVENT_ALLOC, - va_addr, len); ret = 0; } unlock: -- 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 5AD2D1B4ED; Thu, 29 Nov 2018 16:18:33 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Nov 2018 07:18:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,295,1539673200"; d="scan'208";a="278826573" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by orsmga005.jf.intel.com with ESMTP; 29 Nov 2018 07:18:31 -0800 Received: from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com [10.237.217.45]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id wATFIUVR005476; Thu, 29 Nov 2018 15:18:30 GMT Received: from sivswdev01.ir.intel.com (localhost [127.0.0.1]) by sivswdev01.ir.intel.com with ESMTP id wATFIULR017725; Thu, 29 Nov 2018 15:18:30 GMT Received: (from aburakov@localhost) by sivswdev01.ir.intel.com with LOCAL id wATFIUNQ017716; Thu, 29 Nov 2018 15:18:30 GMT From: Anatoly Burakov To: dev@dpdk.org Cc: stable@dpdk.org Date: Thu, 29 Nov 2018 15:18:30 +0000 Message-Id: X-Mailer: git-send-email 1.7.0.7 Subject: [dpdk-stable] [PATCH] malloc: fix duplicate mem event notification X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 15:18:34 -0000 Content-Type: text/plain; charset="UTF-8" Message-ID: <20181129151830.UlAe5VUePk_XSeySUz9hdf1eaaNSCaJ5TruhPK7ADBE@z> We already trigger a mem event notification inside the walk function, no need to do it twice. Fixes: f32c7c9de961 ("malloc: enable event callbacks for external memory") Cc: stable@dpdk.org Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/rte_malloc.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/lib/librte_eal/common/rte_malloc.c b/lib/librte_eal/common/rte_malloc.c index 0da5ad5e8..750a83c2c 100644 --- a/lib/librte_eal/common/rte_malloc.c +++ b/lib/librte_eal/common/rte_malloc.c @@ -518,10 +518,6 @@ sync_memory(const char *heap_name, void *va_addr, size_t len, bool attach) rte_errno = -wa.result; ret = -1; } else { - /* notify all subscribers that a new memory area was added */ - if (attach) - eal_memalloc_mem_event_notify(RTE_MEM_EVENT_ALLOC, - va_addr, len); ret = 0; } unlock: -- 2.17.1